From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ramalingam C <ramalingam.c@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/execlists: Tweak virtual unsubmission
Date: Mon, 14 Oct 2019 10:45:19 +0100 [thread overview]
Message-ID: <157104631897.18859.10661106190188014271@skylake-alporthouse-com> (raw)
In-Reply-To: <20191014092817.GA26556@intel.com>
Quoting Ramalingam C (2019-10-14 10:28:18)
> On 2019-10-13 at 21:30:12 +0100, Chris Wilson wrote:
> > Since commit e2144503bf3b ("drm/i915: Prevent bonded requests from
> > overtaking each other on preemption") we have restricted requests to run
> > on their chosen engine across preemption events. We can take this
> > restriction into account to know that we will want to resubmit those
> > requests onto the same physical engine, and so can shortcircuit the
> > virtual engine selection process and keep the request on the same
> > engine during unwind.
> >
> > References: e2144503bf3b ("drm/i915: Prevent bonded requests from overtaking each other on preemption")
> Chris,
>
> Based on what i understood here, change looks good to me.
>
> If it helps, please use
> Reviewed-by: Ramlingam C <ramalingam.c@intel.com>
Welcome!
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-10-14 9:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-13 20:30 [PATCH] drm/i915/execlists: Tweak virtual unsubmission Chris Wilson
2019-10-13 20:37 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-10-14 9:28 ` [PATCH] " Ramalingam C
2019-10-14 9:45 ` Chris Wilson [this message]
2019-10-14 9:34 ` Tvrtko Ursulin
2019-10-14 9:41 ` Chris Wilson
2019-10-14 9:50 ` Tvrtko Ursulin
2019-10-14 9:59 ` Chris Wilson
2019-10-14 13:15 ` Tvrtko Ursulin
2019-10-14 9:42 ` Chris Wilson
2019-10-14 16:14 ` ✗ Fi.CI.BUILD: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157104631897.18859.10661106190188014271@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ramalingam.c@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.