From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12CF0CA9EA0 for ; Fri, 18 Oct 2019 15:13:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B27AD21897 for ; Fri, 18 Oct 2019 15:13:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="V6wzyZSR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B27AD21897 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6260A8E0005; Fri, 18 Oct 2019 11:13:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D5268E0003; Fri, 18 Oct 2019 11:13:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C38C8E0005; Fri, 18 Oct 2019 11:13:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1E0328E0003 for ; Fri, 18 Oct 2019 11:13:11 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id B7E9E824C740 for ; Fri, 18 Oct 2019 15:13:10 +0000 (UTC) X-FDA: 76057248540.13.food93_55ddc3557c24a X-HE-Tag: food93_55ddc3557c24a X-Filterd-Recvd-Size: 15642 Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Fri, 18 Oct 2019 15:13:09 +0000 (UTC) Received: by mail-qt1-f194.google.com with SMTP id m15so9631165qtq.2 for ; Fri, 18 Oct 2019 08:13:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=HwagLGb5Xe7VSz4Zd3RM9CL5ljL9GJBDyZ6DOBY06nk=; b=V6wzyZSRsh2mYpAlvg1HUWQpR5//slNEE972+ReaEo2iveSrNWkpe60izjjdhZunkT akn5iKqIAUEbb1SzQ+aozYIuMJAGUHTo7kRG/fZJ3yAkJ1Hjrr+lxrcq7eVksEb34v3G bMiV6EFtGlyR6upqCKgcYPjxJnm9mMIYvExIw+ze/VBM0D8PYmu2N8bNA3V3eFrCJ44X wk4e59WPJOW8pTMXOAFvvvTU9x28tU2xkv0E+se3Dvkzq9lCDOF81kFnjEHdF/6YKNO7 1S+wDONX/v55dZW1HeFw4MxpkNe84JO6xHi1Xs5YDyb+WKQ4iHz/6nxgdr2+dFmmCYF9 2ncg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=HwagLGb5Xe7VSz4Zd3RM9CL5ljL9GJBDyZ6DOBY06nk=; b=j190wcrEKmXqdBHZDGHNBhZZyCcF4zIyMC5J/iFYTTFfATDm0cBBl2ybBJ0tzzxGjL 4a93yBk2njvm7yIB37hzGOuhhHxW8jlPIzt9uzbvClFPGAvY2NznRnFijyKML6HiTPEd KLuwgM1d0D0+H3/M2P9RsDdERPkikKAOG0tp3LyECal4zHbOhJqZa+bJz0qX3rPdZR/K 6XmhgDLFa/Kcv2xHgGn2+RLoZRGPx402wmG828DNqcS+V2TduVviyHbN+eAONYC31z0R GQdR/wMrxzuVxcEK35OcfQLYgN4/JJpu7netlEgfjnnAGi9n0GxdL7T5uxOP+Zi0NSIF KjcA== X-Gm-Message-State: APjAAAV/lxhuyqWkg6tS+zCJBr6Vw4LunGWHgia9aTDhmJpe61Mqgnnu OnqB7+Gi6jck+ZbXKRoKMuFArQ== X-Google-Smtp-Source: APXvYqwPwdvgK7TDZIEYKj+896QJ8S/eM3fZRzyOBhCMGXgc9QoOhMDUqbYU7OF5O/tTzEQwetBeeA== X-Received: by 2002:a0c:eda9:: with SMTP id h9mr10254128qvr.125.1571411589161; Fri, 18 Oct 2019 08:13:09 -0700 (PDT) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id w2sm4171058qtc.59.2019.10.18.08.13.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Oct 2019 08:13:08 -0700 (PDT) Message-ID: <1571411587.5937.80.camel@lca.pw> Subject: Re: [PATCH RFC v1 18/26] kmsan: mm: call KMSAN hooks from SLUB code From: Qian Cai To: Alexander Potapenko Cc: Andrew Morton , Vegard Nossum , Dmitry Vyukov , Linux Memory Management List Date: Fri, 18 Oct 2019 11:13:07 -0400 In-Reply-To: References: <20191018094304.37056-1-glider@google.com> <20191018094304.37056-19-glider@google.com> <1571404943.5937.71.camel@lca.pw> <1571406117.5937.73.camel@lca.pw> <1571409732.5937.76.camel@lca.pw> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 2019-10-18 at 16:54 +0200, Alexander Potapenko wrote: > On Fri, Oct 18, 2019 at 4:42 PM Qian Cai wrote: > > > > On Fri, 2019-10-18 at 15:55 +0200, Alexander Potapenko wrote: > > > On Fri, Oct 18, 2019 at 3:42 PM Qian Cai wrote: > > > > > > > > On Fri, 2019-10-18 at 15:33 +0200, Alexander Potapenko wrote: > > > > > On Fri, Oct 18, 2019 at 3:22 PM Qian Cai wrote: > > > > > > > > > > > > On Fri, 2019-10-18 at 11:42 +0200, glider@google.com wrote: > > > > > > > In order to report uninitialized memory coming from heap allocations > > > > > > > KMSAN has to poison them unless they're created with __GFP_ZERO. > > > > > > > > > > > > > > It's handy that we need KMSAN hooks in the places where > > > > > > > init_on_alloc/init_on_free initialization is performed. > > > > > > > > > > > > Well, there is SLUB debug which has red zoning and poisoning checks. What's > > > > > > value of this patch? > > > > > > > > > > Sorry, are you talking about the whole patchset or just this patch? > > > > > > > > Just this patch. > > > > > > > > > Note that SLUB debug is unable to detect uninitialized values with > > > > > bit-to-bit precision, neither have I heard of anyone using it for > > > > > detecting uses of uninitialized memory in the kernel at all. > > > > > The purpose of SLUB debug is to detect corruptions of freed memory. > > > > > > > > The point is if developers have SLUB debug enabled, all the free objects will be > > > > poisoned, so what's the point of checking uninitialized memory there? > > > > > > You are right, SLUB debug has to be handled separately. If I'm > > > understanding correctly, right now KMSAN poisons freed memory before > > > SLUB debug wipes it, therefore the memory will count as initialized. > > > On the other hand, newly allocated memory is still marked as > > > uninitialized, so a lot of bugs still remain detectable. > > > > Yes, but newly allocated slub objects will be poisoned as well. > > As far as I can tell, KMSAN hook marking newly allocated objects as > uninitialized is called after slub poisoning. > Therefore these allocations will be treated by KMSAN as uninitialized. > > > TBH, I haven't tested KMSAN with SLUB debug good enough. Note that > > > it's anyway a separate build that requires Clang, so right now it > > > doesn't make much sense to combine KMSAN and SLUB debug together. > > > > Can't you just build a debug kernel with SLUB debug enabled but dropping this > > patch? If there is an uninitialized memory here leading to data corruption, SLUB > > debug should be detected as well as this patch. If not, it needs to understand > > why. > > Sorry, there might be some misunderstanding here. > KMSAN keeps the state of heap objects separately by keeping exactly > the same amount of initialized/uninitialized bits for every > allocation. > A call to kmsan_slab_alloc()/kmsan_slab_free() will mark an allocation > as uninitialized for KMSAN. Not doing so will result in false reports. > A call to memset(object, POISON_FREE, object_size) performed by SLAB > debug will actually mark this allocation as initialized from KMSAN > point of view, because we're memsetting a range with initialized data. > Note that use of uninitialized data doesn't necessarily lead to > immediate data corruption, so there might be nothing to detect for > SLUB debug. Well, SLUB debug would mark any access of uninitialized memory as data corruption with the help of poisoning and red zoning. It is true that KMSAN might be doing a bit more than SLUB debug here, but the question is if it is worth the maintenance burden? Do you have any existing bugs to show that KMSAN would find by this patch but SLUB debug can't? > > > > > > > > > > > > > > > > Signed-off-by: Alexander Potapenko > > > > > > > To: Alexander Potapenko > > > > > > > Cc: Andrew Morton > > > > > > > Cc: Vegard Nossum > > > > > > > Cc: Dmitry Vyukov > > > > > > > Cc: linux-mm@kvack.org > > > > > > > --- > > > > > > > > > > > > > > Change-Id: I51103b7981d3aabed747d0c85cbdc85568665871 > > > > > > > --- > > > > > > > mm/slub.c | 37 +++++++++++++++++++++++++++++++------ > > > > > > > 1 file changed, 31 insertions(+), 6 deletions(-) > > > > > > > > > > > > > > diff --git a/mm/slub.c b/mm/slub.c > > > > > > > index 3d63ae320d31..3d6d4c63446e 100644 > > > > > > > --- a/mm/slub.c > > > > > > > +++ b/mm/slub.c > > > > > > > @@ -21,6 +21,8 @@ > > > > > > > #include > > > > > > > #include > > > > > > > #include > > > > > > > +#include > > > > > > > +#include /* KMSAN_INIT_VALUE */ > > > > > > > #include > > > > > > > #include > > > > > > > #include > > > > > > > @@ -285,17 +287,27 @@ static void prefetch_freepointer(const struct kmem_cache *s, void *object) > > > > > > > prefetch(object + s->offset); > > > > > > > } > > > > > > > > > > > > > > +/* > > > > > > > + * When running under KMSAN, get_freepointer_safe() may return an uninitialized > > > > > > > + * pointer value in the case the current thread loses the race for the next > > > > > > > + * memory chunk in the freelist. In that case this_cpu_cmpxchg_double() in > > > > > > > + * slab_alloc_node() will fail, so the uninitialized value won't be used, but > > > > > > > + * KMSAN will still check all arguments of cmpxchg because of imperfect > > > > > > > + * handling of inline assembly. > > > > > > > + * To work around this problem, use KMSAN_INIT_VALUE() to force initialize the > > > > > > > + * return value of get_freepointer_safe(). > > > > > > > + */ > > > > > > > static inline void *get_freepointer_safe(struct kmem_cache *s, void *object) > > > > > > > { > > > > > > > unsigned long freepointer_addr; > > > > > > > void *p; > > > > > > > > > > > > > > if (!debug_pagealloc_enabled()) > > > > > > > - return get_freepointer(s, object); > > > > > > > + return KMSAN_INIT_VALUE(get_freepointer(s, object)); > > > > > > > > > > > > > > freepointer_addr = (unsigned long)object + s->offset; > > > > > > > probe_kernel_read(&p, (void **)freepointer_addr, sizeof(p)); > > > > > > > - return freelist_ptr(s, p, freepointer_addr); > > > > > > > + return KMSAN_INIT_VALUE(freelist_ptr(s, p, freepointer_addr)); > > > > > > > } > > > > > > > > > > > > > > static inline void set_freepointer(struct kmem_cache *s, void *object, void *fp) > > > > > > > @@ -1390,6 +1402,7 @@ static inline void *kmalloc_large_node_hook(void *ptr, size_t size, gfp_t flags) > > > > > > > ptr = kasan_kmalloc_large(ptr, size, flags); > > > > > > > /* As ptr might get tagged, call kmemleak hook after KASAN. */ > > > > > > > kmemleak_alloc(ptr, size, 1, flags); > > > > > > > + kmsan_kmalloc_large(ptr, size, flags); > > > > > > > return ptr; > > > > > > > } > > > > > > > > > > > > > > @@ -1397,6 +1410,7 @@ static __always_inline void kfree_hook(void *x) > > > > > > > { > > > > > > > kmemleak_free(x); > > > > > > > kasan_kfree_large(x, _RET_IP_); > > > > > > > + kmsan_kfree_large(x); > > > > > > > } > > > > > > > > > > > > > > static __always_inline bool slab_free_hook(struct kmem_cache *s, void *x) > > > > > > > @@ -1453,6 +1467,12 @@ static inline bool slab_free_freelist_hook(struct kmem_cache *s, > > > > > > > } while (object != old_tail); > > > > > > > } > > > > > > > > > > > > > > + do { > > > > > > > + object = next; > > > > > > > + next = get_freepointer(s, object); > > > > > > > + kmsan_slab_free(s, object); > > > > > > > + } while (object != old_tail); > > > > > > > + > > > > > > > /* > > > > > > > * Compiler cannot detect this function can be removed if slab_free_hook() > > > > > > > * evaluates to nothing. Thus, catch all relevant config debug options here. > > > > > > > @@ -2769,6 +2789,7 @@ static __always_inline void *slab_alloc_node(struct kmem_cache *s, > > > > > > > if (unlikely(slab_want_init_on_alloc(gfpflags, s)) && object) > > > > > > > memset(object, 0, s->object_size); > > > > > > > > > > > > > > + kmsan_slab_alloc(s, object, gfpflags); > > > > > > > slab_post_alloc_hook(s, gfpflags, 1, &object); > > > > > > > > > > > > > > return object; > > > > > > > @@ -2797,6 +2818,7 @@ void *kmem_cache_alloc_trace(struct kmem_cache *s, gfp_t gfpflags, size_t size) > > > > > > > void *ret = slab_alloc(s, gfpflags, _RET_IP_); > > > > > > > trace_kmalloc(_RET_IP_, ret, size, s->size, gfpflags); > > > > > > > ret = kasan_kmalloc(s, ret, size, gfpflags); > > > > > > > + > > > > > > > return ret; > > > > > > > } > > > > > > > EXPORT_SYMBOL(kmem_cache_alloc_trace); > > > > > > > @@ -2809,7 +2831,6 @@ void *kmem_cache_alloc_node(struct kmem_cache *s, gfp_t gfpflags, int node) > > > > > > > > > > > > > > trace_kmem_cache_alloc_node(_RET_IP_, ret, > > > > > > > s->object_size, s->size, gfpflags, node); > > > > > > > - > > > > > > > return ret; > > > > > > > } > > > > > > > EXPORT_SYMBOL(kmem_cache_alloc_node); > > > > > > > @@ -2825,6 +2846,7 @@ void *kmem_cache_alloc_node_trace(struct kmem_cache *s, > > > > > > > size, s->size, gfpflags, node); > > > > > > > > > > > > > > ret = kasan_kmalloc(s, ret, size, gfpflags); > > > > > > > + > > > > > > > return ret; > > > > > > > } > > > > > > > EXPORT_SYMBOL(kmem_cache_alloc_node_trace); > > > > > > > @@ -3150,7 +3172,7 @@ int kmem_cache_alloc_bulk(struct kmem_cache *s, gfp_t flags, size_t size, > > > > > > > void **p) > > > > > > > { > > > > > > > struct kmem_cache_cpu *c; > > > > > > > - int i; > > > > > > > + int i, j; > > > > > > > > > > > > > > /* memcg and kmem_cache debug support */ > > > > > > > s = slab_pre_alloc_hook(s, flags); > > > > > > > @@ -3188,11 +3210,11 @@ int kmem_cache_alloc_bulk(struct kmem_cache *s, gfp_t flags, size_t size, > > > > > > > > > > > > > > /* Clear memory outside IRQ disabled fastpath loop */ > > > > > > > if (unlikely(slab_want_init_on_alloc(flags, s))) { > > > > > > > - int j; > > > > > > > - > > > > > > > for (j = 0; j < i; j++) > > > > > > > memset(p[j], 0, s->object_size); > > > > > > > } > > > > > > > + for (j = 0; j < i; j++) > > > > > > > + kmsan_slab_alloc(s, p[j], flags); > > > > > > > > > > > > > > /* memcg and kmem_cache debug support */ > > > > > > > slab_post_alloc_hook(s, flags, size, p); > > > > > > > @@ -3793,6 +3815,7 @@ static int __init setup_slub_min_objects(char *str) > > > > > > > > > > > > > > __setup("slub_min_objects=", setup_slub_min_objects); > > > > > > > > > > > > > > +__no_sanitize_memory > > > > > > > void *__kmalloc(size_t size, gfp_t flags) > > > > > > > { > > > > > > > struct kmem_cache *s; > > > > > > > @@ -5698,6 +5721,7 @@ static char *create_unique_id(struct kmem_cache *s) > > > > > > > p += sprintf(p, "%07u", s->size); > > > > > > > > > > > > > > BUG_ON(p > name + ID_STR_LENGTH - 1); > > > > > > > + kmsan_unpoison_shadow(name, p - name); > > > > > > > return name; > > > > > > > } > > > > > > > > > > > > > > @@ -5847,6 +5871,7 @@ static int sysfs_slab_alias(struct kmem_cache *s, const char *name) > > > > > > > al->name = name; > > > > > > > al->next = alias_list; > > > > > > > alias_list = al; > > > > > > > + kmsan_unpoison_shadow(al, sizeof(struct saved_alias)); > > > > > > > return 0; > > > > > > > } > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >