From: Chris Wilson <chris@chris-wilson.co.uk>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/selftests: Move uncore fw selftests to operate on intel_gt
Date: Tue, 22 Oct 2019 14:54:12 +0100 [thread overview]
Message-ID: <157175245213.8049.4480871379034831120@skylake-alporthouse-com> (raw)
In-Reply-To: <0b58a54a-f484-7459-1e63-ce711f49837c@linux.intel.com>
Quoting Tvrtko Ursulin (2019-10-22 14:44:31)
>
> On 22/10/2019 14:10, Chris Wilson wrote:
> > Forcewake is the speciality of the GT, so it is natural to run the
> > intel_uncore_forcewake tests over the GT. So pass intel_gt as the
> > parameter to our selftests.
>
> I had the same urge yesterday but then ended unsure how the display/gt
> uncore split may affect this on the logical level. So I'll leave the
> decision to Daniele, he should know better what plans are there.
>
> On the particular patch only comment is that I would consider one or two
> i915 locals for better readability.
You don't have the itch for a GT_INFO() yet?
I'll keep piling them up then ;)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-10-22 13:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 13:10 [PATCH] drm/i915/selftests: Move uncore fw selftests to operate on intel_gt Chris Wilson
2019-10-22 13:44 ` Tvrtko Ursulin
2019-10-22 13:54 ` Chris Wilson [this message]
2019-10-22 15:25 ` Chris Wilson
2019-10-22 18:49 ` Daniele Ceraolo Spurio
2019-10-22 20:26 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-10-23 11:08 ` ✓ Fi.CI.IGT: " Patchwork
2019-10-23 11:08 ` [Intel-gfx] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157175245213.8049.4480871379034831120@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.