From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7AA7CA9EB9 for ; Wed, 23 Oct 2019 20:17:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8F7552064A for ; Wed, 23 Oct 2019 20:17:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KUg1t7Ae" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405668AbfJWURd (ORCPT ); Wed, 23 Oct 2019 16:17:33 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:49670 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732361AbfJWURc (ORCPT ); Wed, 23 Oct 2019 16:17:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571861851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XsR5JVvlz2axvxZwMdTJ7DzX9ow3E3JJWkMAMhNB57M=; b=KUg1t7AentdkJD0/6grYk76NSispahMY2UqFTjQBiuZZAbNZfpaoevNwjFpvDnZqXK5vlA Lgf7DCElYeHcHAiY2kOzUVNhdiY93Cv8Rv0YsPXiDJsTHGKMbivTRvLLF32EMxazKYgL81 i7WXK0cNoilFdFruThFNPeYZuWjzpvQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-223-N0f243VWNhW2UxMcsze37g-1; Wed, 23 Oct 2019 16:17:28 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5148F80183D; Wed, 23 Oct 2019 20:17:26 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-121-40.rdu2.redhat.com [10.10.121.40]) by smtp.corp.redhat.com (Postfix) with ESMTP id 92112194B6; Wed, 23 Oct 2019 20:17:23 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 Subject: [RFC PATCH 02/10] Remove the nr_exclusive argument from __wake_up_sync_key() [ver #2] From: David Howells To: torvalds@linux-foundation.org Cc: dhowells@redhat.com, Rasmus Villemoes , Greg Kroah-Hartman , Peter Zijlstra , nicolas.dichtel@6wind.com, raven@themaw.net, Christian Brauner , dhowells@redhat.com, keyrings@vger.kernel.org, linux-usb@vger.kernel.org, linux-block@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 23 Oct 2019 21:17:22 +0100 Message-ID: <157186184284.3995.13755220637594977072.stgit@warthog.procyon.org.uk> In-Reply-To: <157186182463.3995.13922458878706311997.stgit@warthog.procyon.org.uk> References: <157186182463.3995.13922458878706311997.stgit@warthog.procyon.org.uk> User-Agent: StGit/unknown-version MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: N0f243VWNhW2UxMcsze37g-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Remove the nr_exclusive argument from __wake_up_sync_key() and derived functions as everything seems to set it to 1. Note also that if it wasn't set to 1, it would clear WF_SYNC anyway. Signed-off-by: David Howells --- include/linux/wait.h | 8 ++++---- kernel/exit.c | 2 +- kernel/sched/wait.c | 14 ++++---------- 3 files changed, 9 insertions(+), 15 deletions(-) diff --git a/include/linux/wait.h b/include/linux/wait.h index 3eb7cae8206c..bb7676d396cd 100644 --- a/include/linux/wait.h +++ b/include/linux/wait.h @@ -201,9 +201,9 @@ void __wake_up(struct wait_queue_head *wq_head, unsigne= d int mode, int nr, void void __wake_up_locked_key(struct wait_queue_head *wq_head, unsigned int mo= de, void *key); void __wake_up_locked_key_bookmark(struct wait_queue_head *wq_head, =09=09unsigned int mode, void *key, wait_queue_entry_t *bookmark); -void __wake_up_sync_key(struct wait_queue_head *wq_head, unsigned int mode= , int nr, void *key); +void __wake_up_sync_key(struct wait_queue_head *wq_head, unsigned int mode= , void *key); void __wake_up_locked(struct wait_queue_head *wq_head, unsigned int mode, = int nr); -void __wake_up_sync(struct wait_queue_head *wq_head, unsigned int mode, in= t nr); +void __wake_up_sync(struct wait_queue_head *wq_head, unsigned int mode); =20 #define wake_up(x)=09=09=09__wake_up(x, TASK_NORMAL, 1, NULL) #define wake_up_nr(x, nr)=09=09__wake_up(x, TASK_NORMAL, nr, NULL) @@ -214,7 +214,7 @@ void __wake_up_sync(struct wait_queue_head *wq_head, un= signed int mode, int nr); #define wake_up_interruptible(x)=09__wake_up(x, TASK_INTERRUPTIBLE, 1, NUL= L) #define wake_up_interruptible_nr(x, nr)=09__wake_up(x, TASK_INTERRUPTIBLE,= nr, NULL) #define wake_up_interruptible_all(x)=09__wake_up(x, TASK_INTERRUPTIBLE, 0,= NULL) -#define wake_up_interruptible_sync(x)=09__wake_up_sync((x), TASK_INTERRUPT= IBLE, 1) +#define wake_up_interruptible_sync(x)=09__wake_up_sync((x), TASK_INTERRUPT= IBLE) =20 /* * Wakeup macros to be used to report events to the targets. @@ -228,7 +228,7 @@ void __wake_up_sync(struct wait_queue_head *wq_head, un= signed int mode, int nr); #define wake_up_interruptible_poll(x, m)=09=09=09=09=09\ =09__wake_up(x, TASK_INTERRUPTIBLE, 1, poll_to_key(m)) #define wake_up_interruptible_sync_poll(x, m)=09=09=09=09=09\ -=09__wake_up_sync_key((x), TASK_INTERRUPTIBLE, 1, poll_to_key(m)) +=09__wake_up_sync_key((x), TASK_INTERRUPTIBLE, poll_to_key(m)) =20 #define ___wait_cond_timeout(condition)=09=09=09=09=09=09\ ({=09=09=09=09=09=09=09=09=09=09\ diff --git a/kernel/exit.c b/kernel/exit.c index a46a50d67002..a1ff25ef050e 100644 --- a/kernel/exit.c +++ b/kernel/exit.c @@ -1435,7 +1435,7 @@ static int child_wait_callback(wait_queue_entry_t *wa= it, unsigned mode, void __wake_up_parent(struct task_struct *p, struct task_struct *parent) { =09__wake_up_sync_key(&parent->signal->wait_chldexit, -=09=09=09=09TASK_INTERRUPTIBLE, 1, p); +=09=09=09 TASK_INTERRUPTIBLE, p); } =20 static long do_wait(struct wait_opts *wo) diff --git a/kernel/sched/wait.c b/kernel/sched/wait.c index c1e566a114ca..b4b52361dab7 100644 --- a/kernel/sched/wait.c +++ b/kernel/sched/wait.c @@ -169,7 +169,6 @@ EXPORT_SYMBOL_GPL(__wake_up_locked_key_bookmark); * __wake_up_sync_key - wake up threads blocked on a waitqueue. * @wq_head: the waitqueue * @mode: which threads - * @nr_exclusive: how many wake-one or wake-many threads to wake up * @key: opaque value to be passed to wakeup targets * * The sync wakeup differs that the waker knows that it will schedule @@ -183,26 +182,21 @@ EXPORT_SYMBOL_GPL(__wake_up_locked_key_bookmark); * accessing the task state. */ void __wake_up_sync_key(struct wait_queue_head *wq_head, unsigned int mode= , -=09=09=09int nr_exclusive, void *key) +=09=09=09void *key) { -=09int wake_flags =3D 1; /* XXX WF_SYNC */ - =09if (unlikely(!wq_head)) =09=09return; =20 -=09if (unlikely(nr_exclusive !=3D 1)) -=09=09wake_flags =3D 0; - -=09__wake_up_common_lock(wq_head, mode, nr_exclusive, wake_flags, key); +=09__wake_up_common_lock(wq_head, mode, 1, WF_SYNC, key); } EXPORT_SYMBOL_GPL(__wake_up_sync_key); =20 /* * __wake_up_sync - see __wake_up_sync_key() */ -void __wake_up_sync(struct wait_queue_head *wq_head, unsigned int mode, in= t nr_exclusive) +void __wake_up_sync(struct wait_queue_head *wq_head, unsigned int mode) { -=09__wake_up_sync_key(wq_head, mode, nr_exclusive, NULL); +=09__wake_up_sync_key(wq_head, mode, NULL); } EXPORT_SYMBOL_GPL(__wake_up_sync);=09/* For internal use only */ =20 From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Date: Wed, 23 Oct 2019 20:17:22 +0000 Subject: [RFC PATCH 02/10] Remove the nr_exclusive argument from __wake_up_sync_key() [ver #2] Message-Id: <157186184284.3995.13755220637594977072.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <157186182463.3995.13922458878706311997.stgit@warthog.procyon.org.uk> In-Reply-To: <157186182463.3995.13922458878706311997.stgit@warthog.procyon.org.uk> To: torvalds@linux-foundation.org Cc: dhowells@redhat.com, Rasmus Villemoes , Greg Kroah-Hartman , Peter Zijlstra , nicolas.dichtel@6wind.com, raven@themaw.net, Christian Brauner dhowells@redhat.com, keyrings@vger.kernel.org, linux-usb@vger.kernel.org, linux-block@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org@vger.kernel.org, linux-kernel@vger.kernel.org Remove the nr_exclusive argument from __wake_up_sync_key() and derived functions as everything seems to set it to 1. Note also that if it wasn't set to 1, it would clear WF_SYNC anyway. Signed-off-by: David Howells --- include/linux/wait.h | 8 ++++---- kernel/exit.c | 2 +- kernel/sched/wait.c | 14 ++++---------- 3 files changed, 9 insertions(+), 15 deletions(-) diff --git a/include/linux/wait.h b/include/linux/wait.h index 3eb7cae8206c..bb7676d396cd 100644 --- a/include/linux/wait.h +++ b/include/linux/wait.h @@ -201,9 +201,9 @@ void __wake_up(struct wait_queue_head *wq_head, unsigned int mode, int nr, void void __wake_up_locked_key(struct wait_queue_head *wq_head, unsigned int mode, void *key); void __wake_up_locked_key_bookmark(struct wait_queue_head *wq_head, unsigned int mode, void *key, wait_queue_entry_t *bookmark); -void __wake_up_sync_key(struct wait_queue_head *wq_head, unsigned int mode, int nr, void *key); +void __wake_up_sync_key(struct wait_queue_head *wq_head, unsigned int mode, void *key); void __wake_up_locked(struct wait_queue_head *wq_head, unsigned int mode, int nr); -void __wake_up_sync(struct wait_queue_head *wq_head, unsigned int mode, int nr); +void __wake_up_sync(struct wait_queue_head *wq_head, unsigned int mode); #define wake_up(x) __wake_up(x, TASK_NORMAL, 1, NULL) #define wake_up_nr(x, nr) __wake_up(x, TASK_NORMAL, nr, NULL) @@ -214,7 +214,7 @@ void __wake_up_sync(struct wait_queue_head *wq_head, unsigned int mode, int nr); #define wake_up_interruptible(x) __wake_up(x, TASK_INTERRUPTIBLE, 1, NULL) #define wake_up_interruptible_nr(x, nr) __wake_up(x, TASK_INTERRUPTIBLE, nr, NULL) #define wake_up_interruptible_all(x) __wake_up(x, TASK_INTERRUPTIBLE, 0, NULL) -#define wake_up_interruptible_sync(x) __wake_up_sync((x), TASK_INTERRUPTIBLE, 1) +#define wake_up_interruptible_sync(x) __wake_up_sync((x), TASK_INTERRUPTIBLE) /* * Wakeup macros to be used to report events to the targets. @@ -228,7 +228,7 @@ void __wake_up_sync(struct wait_queue_head *wq_head, unsigned int mode, int nr); #define wake_up_interruptible_poll(x, m) \ __wake_up(x, TASK_INTERRUPTIBLE, 1, poll_to_key(m)) #define wake_up_interruptible_sync_poll(x, m) \ - __wake_up_sync_key((x), TASK_INTERRUPTIBLE, 1, poll_to_key(m)) + __wake_up_sync_key((x), TASK_INTERRUPTIBLE, poll_to_key(m)) #define ___wait_cond_timeout(condition) \ ({ \ diff --git a/kernel/exit.c b/kernel/exit.c index a46a50d67002..a1ff25ef050e 100644 --- a/kernel/exit.c +++ b/kernel/exit.c @@ -1435,7 +1435,7 @@ static int child_wait_callback(wait_queue_entry_t *wait, unsigned mode, void __wake_up_parent(struct task_struct *p, struct task_struct *parent) { __wake_up_sync_key(&parent->signal->wait_chldexit, - TASK_INTERRUPTIBLE, 1, p); + TASK_INTERRUPTIBLE, p); } static long do_wait(struct wait_opts *wo) diff --git a/kernel/sched/wait.c b/kernel/sched/wait.c index c1e566a114ca..b4b52361dab7 100644 --- a/kernel/sched/wait.c +++ b/kernel/sched/wait.c @@ -169,7 +169,6 @@ EXPORT_SYMBOL_GPL(__wake_up_locked_key_bookmark); * __wake_up_sync_key - wake up threads blocked on a waitqueue. * @wq_head: the waitqueue * @mode: which threads - * @nr_exclusive: how many wake-one or wake-many threads to wake up * @key: opaque value to be passed to wakeup targets * * The sync wakeup differs that the waker knows that it will schedule @@ -183,26 +182,21 @@ EXPORT_SYMBOL_GPL(__wake_up_locked_key_bookmark); * accessing the task state. */ void __wake_up_sync_key(struct wait_queue_head *wq_head, unsigned int mode, - int nr_exclusive, void *key) + void *key) { - int wake_flags = 1; /* XXX WF_SYNC */ - if (unlikely(!wq_head)) return; - if (unlikely(nr_exclusive != 1)) - wake_flags = 0; - - __wake_up_common_lock(wq_head, mode, nr_exclusive, wake_flags, key); + __wake_up_common_lock(wq_head, mode, 1, WF_SYNC, key); } EXPORT_SYMBOL_GPL(__wake_up_sync_key); /* * __wake_up_sync - see __wake_up_sync_key() */ -void __wake_up_sync(struct wait_queue_head *wq_head, unsigned int mode, int nr_exclusive) +void __wake_up_sync(struct wait_queue_head *wq_head, unsigned int mode) { - __wake_up_sync_key(wq_head, mode, nr_exclusive, NULL); + __wake_up_sync_key(wq_head, mode, NULL); } EXPORT_SYMBOL_GPL(__wake_up_sync); /* For internal use only */ From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: [RFC PATCH 02/10] Remove the nr_exclusive argument from __wake_up_sync_key() [ver #2] Date: Wed, 23 Oct 2019 21:17:22 +0100 Message-ID: <157186184284.3995.13755220637594977072.stgit@warthog.procyon.org.uk> References: <157186182463.3995.13922458878706311997.stgit@warthog.procyon.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <157186182463.3995.13922458878706311997.stgit@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: torvalds@linux-foundation.org Cc: dhowells@redhat.com, Rasmus Villemoes , Greg Kroah-Hartman , Peter Zijlstra , nicolas.dichtel@6wind.com, raven@themaw.net, Christian Brauner dhowells@redhat.com, keyrings@vger.kernel.org, linux-usb@vger.kernel.org, linux-block@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.orglinux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-api@vger.kernel.org Remove the nr_exclusive argument from __wake_up_sync_key() and derived functions as everything seems to set it to 1. Note also that if it wasn't set to 1, it would clear WF_SYNC anyway. Signed-off-by: David Howells --- include/linux/wait.h | 8 ++++---- kernel/exit.c | 2 +- kernel/sched/wait.c | 14 ++++---------- 3 files changed, 9 insertions(+), 15 deletions(-) diff --git a/include/linux/wait.h b/include/linux/wait.h index 3eb7cae8206c..bb7676d396cd 100644 --- a/include/linux/wait.h +++ b/include/linux/wait.h @@ -201,9 +201,9 @@ void __wake_up(struct wait_queue_head *wq_head, unsigne= d int mode, int nr, void void __wake_up_locked_key(struct wait_queue_head *wq_head, unsigned int mo= de, void *key); void __wake_up_locked_key_bookmark(struct wait_queue_head *wq_head, =09=09unsigned int mode, void *key, wait_queue_entry_t *bookmark); -void __wake_up_sync_key(struct wait_queue_head *wq_head, unsigned int mode= , int nr, void *key); +void __wake_up_sync_key(struct wait_queue_head *wq_head, unsigned int mode= , void *key); void __wake_up_locked(struct wait_queue_head *wq_head, unsigned int mode, = int nr); -void __wake_up_sync(struct wait_queue_head *wq_head, unsigned int mode, in= t nr); +void __wake_up_sync(struct wait_queue_head *wq_head, unsigned int mode); =20 #define wake_up(x)=09=09=09__wake_up(x, TASK_NORMAL, 1, NULL) #define wake_up_nr(x, nr)=09=09__wake_up(x, TASK_NORMAL, nr, NULL) @@ -214,7 +214,7 @@ void __wake_up_sync(struct wait_queue_head *wq_head, un= signed int mode, int nr); #define wake_up_interruptible(x)=09__wake_up(x, TASK_INTERRUPTIBLE, 1, NUL= L) #define wake_up_interruptible_nr(x, nr)=09__wake_up(x, TASK_INTERRUPTIBLE,= nr, NULL) #define wake_up_interruptible_all(x)=09__wake_up(x, TASK_INTERRUPTIBLE, 0,= NULL) -#define wake_up_interruptible_sync(x)=09__wake_up_sync((x), TASK_INTERRUPT= IBLE, 1) +#define wake_up_interruptible_sync(x)=09__wake_up_sync((x), TASK_INTERRUPT= IBLE) =20 /* * Wakeup macros to be used to report events to the targets. @@ -228,7 +228,7 @@ void __wake_up_sync(struct wait_queue_head *wq_head, un= signed int mode, int nr); #define wake_up_interruptible_poll(x, m)=09=09=09=09=09\ =09__wake_up(x, TASK_INTERRUPTIBLE, 1, poll_to_key(m)) #define wake_up_interruptible_sync_poll(x, m)=09=09=09=09=09\ -=09__wake_up_sync_key((x), TASK_INTERRUPTIBLE, 1, poll_to_key(m)) +=09__wake_up_sync_key((x), TASK_INTERRUPTIBLE, poll_to_key(m)) =20 #define ___wait_cond_timeout(condition)=09=09=09=09=09=09\ ({=09=09=09=09=09=09=09=09=09=09\ diff --git a/kernel/exit.c b/kernel/exit.c index a46a50d67002..a1ff25ef050e 100644 --- a/kernel/exit.c +++ b/kernel/exit.c @@ -1435,7 +1435,7 @@ static int child_wait_callback(wait_queue_entry_t *wa= it, unsigned mode, void __wake_up_parent(struct task_struct *p, struct task_struct *parent) { =09__wake_up_sync_key(&parent->signal->wait_chldexit, -=09=09=09=09TASK_INTERRUPTIBLE, 1, p); +=09=09=09 TASK_INTERRUPTIBLE, p); } =20 static long do_wait(struct wait_opts *wo) diff --git a/kernel/sched/wait.c b/kernel/sched/wait.c index c1e566a114ca..b4b52361dab7 100644 --- a/kernel/sched/wait.c +++ b/kernel/sched/wait.c @@ -169,7 +169,6 @@ EXPORT_SYMBOL_GPL(__wake_up_locked_key_bookmark); * __wake_up_sync_key - wake up threads blocked on a waitqueue. * @wq_head: the waitqueue * @mode: which threads - * @nr_exclusive: how many wake-one or wake-many threads to wake up * @key: opaque value to be passed to wakeup targets * * The sync wakeup differs that the waker knows that it will schedule @@ -183,26 +182,21 @@ EXPORT_SYMBOL_GPL(__wake_up_locked_key_bookmark); * accessing the task state. */ void __wake_up_sync_key(struct wait_queue_head *wq_head, unsigned int mode= , -=09=09=09int nr_exclusive, void *key) +=09=09=09void *key) { -=09int wake_flags =3D 1; /* XXX WF_SYNC */ - =09if (unlikely(!wq_head)) =09=09return; =20 -=09if (unlikely(nr_exclusive !=3D 1)) -=09=09wake_flags =3D 0; - -=09__wake_up_common_lock(wq_head, mode, nr_exclusive, wake_flags, key); +=09__wake_up_common_lock(wq_head, mode, 1, WF_SYNC, key); } EXPORT_SYMBOL_GPL(__wake_up_sync_key); =20 /* * __wake_up_sync - see __wake_up_sync_key() */ -void __wake_up_sync(struct wait_queue_head *wq_head, unsigned int mode, in= t nr_exclusive) +void __wake_up_sync(struct wait_queue_head *wq_head, unsigned int mode) { -=09__wake_up_sync_key(wq_head, mode, nr_exclusive, NULL); +=09__wake_up_sync_key(wq_head, mode, NULL); } EXPORT_SYMBOL_GPL(__wake_up_sync);=09/* For internal use only */ =20