From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85950CA9EC0 for ; Tue, 29 Oct 2019 03:12:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 544FD20862 for ; Tue, 29 Oct 2019 03:12:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="hhbJeLAU"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="Ff3B31zP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731396AbfJ2DMn (ORCPT ); Mon, 28 Oct 2019 23:12:43 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:35038 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726740AbfJ2DMm (ORCPT ); Mon, 28 Oct 2019 23:12:42 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id BBB8F60D97; Tue, 29 Oct 2019 03:12:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1572318761; bh=6TC+OuBMy0RodpaYAtahI7XYuucLX/4lHyCtAfJNH/8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hhbJeLAUJliq0/zLkAdYhXLEPtoJg9JCz7HbA+p2TEwvZvKuUvLPdAybfTA0cE2ha DMT5JohPAjOKEdFvspOcXy+c8Y4jC/q/aJutg+eqxEVL+ys2uZYdGrshLpLcd34OZn yVNLozOa1WUfQvsxnS3qJXHE/4wYVQ+pdpgCP3aI= Received: from pacamara-linux.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: cang@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 123A660CDD; Tue, 29 Oct 2019 03:12:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1572318760; bh=6TC+OuBMy0RodpaYAtahI7XYuucLX/4lHyCtAfJNH/8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ff3B31zPcPdPmXbhKymDEeiE0AEoBTj10pWFr4sFoEeMzMNuW1gusleKxooBqvS0V l9a3hv1uG8aVUJuuWzruuAfHtoXMthVpTMUiFEIR1ZKA5EcHIOlrbgHYWevcamG78D Hq4jAm0MVxdu5zZViCyjktPqL5UStGUNjjMRW6LE= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 123A660CDD Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=cang@codeaurora.org From: Can Guo To: asutoshd@codeaurora.org, nguyenb@codeaurora.org, rnayak@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, salyzyn@google.com, cang@codeaurora.org Cc: Alim Akhtar , Avri Altman , Pedro Sousa , "James E.J. Bottomley" , "Martin K. Petersen" , Stanley Chu , Bean Huo , Tomas Winkler , Subhash Jadavani , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 3/5] scsi: ufs: Release clock if DMA map fails Date: Mon, 28 Oct 2019 20:10:52 -0700 Message-Id: <1572318655-28772-4-git-send-email-cang@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1572318655-28772-1-git-send-email-cang@codeaurora.org> References: <1572318655-28772-1-git-send-email-cang@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In queuecommand path, if DMA map fails, it bails out with clock held. In this case, release the clock to keep its usage paired. Signed-off-by: Can Guo --- drivers/scsi/ufs/ufshcd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 101b4d0..6e9236a 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -2480,6 +2480,7 @@ static int ufshcd_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd) if (err) { lrbp->cmd = NULL; clear_bit_unlock(tag, &hba->lrb_in_use); + ufshcd_release(hba); goto out; } /* Make sure descriptors are ready before ringing the doorbell */ -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project