Re: [PATCH v1] target/i386: set the CPUID level to 0x14 on old machine-type

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/1572413233-27015-1-git-send-email-luwei.kang@intel.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v1] target/i386: set the CPUID level to 0x14 on old machine-type
Type: series
Message-id: 1572413233-27015-1-git-send-email-luwei.kang@intel.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
c5736fe target/i386: set the CPUID level to 0x14 on old machine-type

=== OUTPUT BEGIN ===
ERROR: Error messages should not contain newlines
#36: FILE: target/i386/cpu.c:5448:
+                            "by \"-cpu ...,+intel-pt,level=0x14\"\n");

total: 1 errors, 0 warnings, 14 lines checked

Commit c5736fe95d3f (target/i386: set the CPUID level to 0x14 on old machine-type) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1572413233-27015-1-git-send-email-luwei.kang@intel.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com