From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [RFC PATCH i-g-t v4 2/4] lib: Add minimum GTT alignment helper Date: Fri, 01 Nov 2019 10:08:45 +0000 Message-ID: <157260292527.17607.2659694670117420139@skylake-alporthouse-com> References: <20191031152857.17143-1-janusz.krzysztofik@linux.intel.com> <20191031152857.17143-3-janusz.krzysztofik@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20191031152857.17143-3-janusz.krzysztofik@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Janusz Krzysztofik , igt-dev@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org UXVvdGluZyBKYW51c3ogS3J6eXN6dG9maWsgKDIwMTktMTAtMzEgMTU6Mjg6NTUpCj4gU29tZSB0 ZXN0cyBhc3N1bWUgNGtCIG9mZnNldCBhbGlnbm1lbnQgd2hpbGUgdXNpbmcgc29mdHBpbi4gIFRo YXQKPiBhc3N1bXB0aW9uIG1heSBiZSB3cm9uZyBvbiBmdXR1cmUgR0VNIGJhY2tlbmRzIHdpdGgg cG9zc2libHkgbGFyZ2VyCj4gbWluaW11bSBwYWdlIHNpemVzLiAgQXMgYSByZXN1bHQsIHRob3Nl IHRlc3RzIG1heSBlaXRoZXIgZmFpbCBvbgo+IHNvZnRwaW4gYXQgb2Zmc2V0cyB3aGljaCBhcmUg aW5jb3JyZWN0bHkgYWxpZ25lZCwgbWF5IHNpbGVudGx5IHNraXAKPiBzdWNoIGluY29ycmVjdGx5 IGFsaWduZWQgYWRkcmVzc2VzIGFzc3VtaW5nIHRoZW0gb2NjdXBpZWQgYnkgb3RoZXIKPiB1c2Vy cyBpZiBpbmNvcnJlY3QgZGV0ZWN0aW9uIG1ldGhvZCBpcyB1c2VkLCBvciBtYXkgYWx3YXlzIHN1 Y2NlZWQKPiB3aGVuIGV4YW1pbmluZyBpbnZhbGlkIHVzZSBwYXR0ZXJucy4KPiAKPiBQcm92aWRl IGEgaGVscGVyIGZ1bmN0aW9uIHRoYXQgZGV0ZWN0cyBtaW5pbXVtIEdUVCBhbGlnbm1lbnQuICBU ZXN0cwo+IG1heSB1c2UgaXQgdG8gY2FsY3VsYXRlIHNvZnRwaW4gb2Zmc2V0cyB2YWxpZCBmb3Ig YWN0dWFsbHkgdXNlZCBiYWNraW5nCj4gc3RvcmUuCj4gCj4gdjI6IFJlbmFtZSB0aGUgaGVscGVy LCB1c2UgJ21pbmltdW0gR1RUIGFsaWdubWVudCcgdGVybSBhY3Jvc3MgdGhlCj4gICAgIGNoYW5n ZSAoQ2hyaXMpLAo+ICAgLSB1c2UgZXJyb3IgbnVtYmVycyB0byBkaXN0aW5ndWlzaCBiZXR3ZWVu IGludmFsaWQgb2Zmc2V0cyBhbmQKPiAgICAgYWRkcmVzc2VzIG9jY3VwaWVkIGJ5IG90aGVyIHVz ZXJzLCB0aGVuCj4gICAtIHNpbXBsaWZ5IHRoZSBjb2RlIChDaHJpcykuCj4gCj4gU2lnbmVkLW9m Zi1ieTogSmFudXN6IEtyenlzenRvZmlrIDxqYW51c3oua3J6eXN6dG9maWtAbGludXguaW50ZWwu Y29tPgo+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzog RGFuaWVsZSBDZXJhb2xvIFNwdXJpbyA8ZGFuaWVsZS5jZXJhb2xvc3B1cmlvQGludGVsLmNvbT4K PiBDYzogU3R1YXJ0IFN1bW1lcnMgPHN0dWFydC5zdW1tZXJzQGludGVsLmNvbT4KPiAtLS0KPiAg bGliL2lvY3RsX3dyYXBwZXJzLmMgfCA0NiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKwo+ICBsaWIvaW9jdGxfd3JhcHBlcnMuaCB8ICAyICsrCj4gIDIgZmlsZXMg Y2hhbmdlZCwgNDggaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9saWIvaW9jdGxfd3Jh cHBlcnMuYyBiL2xpYi9pb2N0bF93cmFwcGVycy5jCj4gaW5kZXggNjI4ZjhiODMuLmYwZWY4YjJl IDEwMDY0NAo+IC0tLSBhL2xpYi9pb2N0bF93cmFwcGVycy5jCj4gKysrIGIvbGliL2lvY3RsX3dy YXBwZXJzLmMKPiBAQCAtNTQsNiArNTQsNyBAQAo+ICAjaW5jbHVkZSAiaW50ZWxfaW8uaCIKPiAg I2luY2x1ZGUgImlndF9kZWJ1Z2ZzLmgiCj4gICNpbmNsdWRlICJpZ3Rfc3lzZnMuaCIKPiArI2lu Y2x1ZGUgImlndF94ODYuaCIKPiAgI2luY2x1ZGUgImNvbmZpZy5oIgo+ICAKPiAgI2lmZGVmIEhB VkVfVkFMR1JJTkQKPiBAQCAtMTE1OCw2ICsxMTU5LDUxIEBAIGJvb2wgZ2VtX2hhc19zb2Z0cGlu KGludCBmZCkKPiAgICAgICAgIHJldHVybiBoYXNfc29mdHBpbjsKPiAgfQo+ICAKPiArLyoqCj4g KyAqIGdlbV9ndHRfbWluX2FsaWdubWVudF9vcmRlcjoKPiArICogQGZkOiBvcGVuIGk5MTUgZHJt IGZpbGUgZGVzY3JpcHRvcgo+ICsgKgo+ICsgKiBUaGlzIGZ1bmN0aW9uIGRldGVjdHMgdGhlIG1p bmltdW0gcG9zc2libGUgYWxpZ25tZW50IG9mIGEgc29mdC1waW5uZWQgZ2VtCj4gKyAqIG9iamVj dCBhbGxvY2F0ZWQgZnJvbSBhIGRlZmF1bHQgYmFja2luZyBzdG9yZS4gIEl0IGlzIHVzZWZ1bCBm b3IgY2FsY3VsYXRpbmcKPiArICogY29ycmVjdGx5IGFsaWduZWQgc29mdHBpbiBvZmZzZXRzLgo+ ICsgKiBTaW5jZSBzaXplIG9yZGVyIHRvIHNpemUgY29udmVyc2lvbiAoc2l6ZSA9IDEgPDwgb3Jk ZXIpIGlzIGxlc3MgdHJpdmlhbAo+ICsgKiB0aGFuIHRoZSBvcHBvc2l0ZSwgdGhlIGZ1bmN0aW9u IHJldHVybnMgdGhlIGFsaWdubWVudCBvcmRlciBhcyBtb3JlIGhhbmR5Lgo+ICsgKgo+ICsgKiBS ZXR1cm5zOgo+ICsgKiBTaXplIG9yZGVyIG9mIHRoZSBtaW5pbXVtIEdUVCBhbGlnbm1lbnQKPiAr ICovCj4gK2ludCBnZW1fZ3R0X21pbl9hbGlnbm1lbnRfb3JkZXIoaW50IGZkKQoKQnV0IG5vdCBw YXJ0IG9mIGlvY3RsX3dyYXBwZXJzLmMhCgpsaWIvaTkxNS9nZW1fZ3R0X3RvcG9sb2d5LmM/IF9x dWVyeS5jPyBfcHJvYmUuYz8KCj4gK3sKPiArICAgICAgIHN0cnVjdCBkcm1faTkxNV9nZW1fZXhl Y19vYmplY3QyIG9iajsKPiArICAgICAgIHN0cnVjdCBkcm1faTkxNV9nZW1fZXhlY2J1ZmZlcjIg ZWI7Cj4gKyAgICAgICBjb25zdCB1aW50MzJfdCBiYmUgPSBNSV9CQVRDSF9CVUZGRVJfRU5EOwo+ ICsgICAgICAgaW50IG9yZGVyOwo+ICsKPiArICAgICAgIC8qIG5vIHNvZnRwaW4gPT4gNGtCIHBh Z2Ugc2l6ZSAqLwo+ICsgICAgICAgaWYgKCFnZW1faGFzX3NvZnRwaW4oZmQpKQo+ICsgICAgICAg ICAgICAgICByZXR1cm4gMTI7Cj4gKwo+ICsgICAgICAgbWVtc2V0KCZvYmosIDAsIHNpemVvZihv YmopKTsKPiArICAgICAgIG1lbXNldCgmZWIsIDAsIHNpemVvZihlYikpOwo+ICsKPiArICAgICAg IG9iai5oYW5kbGUgPSBnZW1fY3JlYXRlKGZkLCA0MDk2KTsKPiArICAgICAgIG9iai5mbGFncyA9 IEVYRUNfT0JKRUNUX1BJTk5FRCB8IEVYRUNfT0JKRUNUX1NVUFBPUlRTXzQ4Ql9BRERSRVNTOwo+ ICsgICAgICAgZWIuYnVmZmVyc19wdHIgPSB0b191c2VyX3BvaW50ZXIoJm9iaik7Cj4gKyAgICAg ICBlYi5idWZmZXJfY291bnQgPSAxOwo+ICsgICAgICAgZ2VtX3dyaXRlKGZkLCBvYmouaGFuZGxl LCAwLCAmYmJlLCBzaXplb2YoYmJlKSk7Cj4gKwo+ICsgICAgICAgZm9yIChvcmRlciA9IDEyOyBv cmRlciA8IDY0OyBvcmRlcisrKSB7Cj4gKyAgICAgICAgICAgICAgIG9iai5vZmZzZXQgPSAxdWxs IDw8IG9yZGVyOwo+ICsgICAgICAgICAgICAgICBpZiAoX19nZW1fZXhlY2J1ZihmZCwgJmViKSAh PSAtRUlOVkFMKQo+ICsgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwo+ICsgICAgICAgfQo+ ICsgICAgICAgaWd0X2Fzc2VydChvYmoub2Zmc2V0IDwgZ2VtX2FwZXJ0dXJlX3NpemUoZmQpKTsK CkhtbSwgdGhlcmUgaXMgb25lIG1vcmUgdHJpY2sgd2UgY2FuIGFwcGx5IGhlcmU6IGFuIGludmFs aWQgcmVsb2MuCgptZW1zZXQoJnJlbG9jLCAwLCBzaXplb2YocmVsb2MpKTsKb2JqLnJlbG9jc19w dHIgPSB0b191c2VyX3BvaW50ZXIoJnJlbG9jKTsKb2JqLnJlbG9jYXRpb25fY291bnQgPSAxOwoK V2UgZmlyc3QgcHJvY2VzcyB0aGUgYnVmZmVycywgdGhlbiB3ZSBwcm9jZXNzIHRoZSByZWxvY2F0 aW9ucy4gU28gd2UKd2lsbCBnZXQgdGhlIC1FSU5WQUwgZm9yIGlsbGVnYWwgc29mdHBpbiBiZWZv cmUgd2UgZ2V0IHRoZSAtRU5PRU5UIGZvcgppbnZhbGlkIHJlbG9jIGhhbmRsZS4KClRoYXQganVz dCBzYXZlcyBhY3R1YWxseSBlbWl0dGluZyBhIHJlcXVlc3QuCi1DaHJpcwpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9697ACA9ED0 for ; Fri, 1 Nov 2019 10:09:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7322B2086D for ; Fri, 1 Nov 2019 10:09:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7322B2086D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2301F6F7B3; Fri, 1 Nov 2019 10:09:02 +0000 (UTC) Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 077146F7B2; Fri, 1 Nov 2019 10:08:59 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 19044266-1500050 for multiple; Fri, 01 Nov 2019 10:08:47 +0000 MIME-Version: 1.0 To: Janusz Krzysztofik , igt-dev@lists.freedesktop.org From: Chris Wilson In-Reply-To: <20191031152857.17143-3-janusz.krzysztofik@linux.intel.com> References: <20191031152857.17143-1-janusz.krzysztofik@linux.intel.com> <20191031152857.17143-3-janusz.krzysztofik@linux.intel.com> Message-ID: <157260292527.17607.2659694670117420139@skylake-alporthouse-com> User-Agent: alot/0.6 Date: Fri, 01 Nov 2019 10:08:45 +0000 Subject: Re: [Intel-gfx] [RFC PATCH i-g-t v4 2/4] lib: Add minimum GTT alignment helper X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Message-ID: <20191101100845.dBK-nr1CnEgi_O3THpXfe0C4lIGinE40cChLZqw_SZQ@z> UXVvdGluZyBKYW51c3ogS3J6eXN6dG9maWsgKDIwMTktMTAtMzEgMTU6Mjg6NTUpCj4gU29tZSB0 ZXN0cyBhc3N1bWUgNGtCIG9mZnNldCBhbGlnbm1lbnQgd2hpbGUgdXNpbmcgc29mdHBpbi4gIFRo YXQKPiBhc3N1bXB0aW9uIG1heSBiZSB3cm9uZyBvbiBmdXR1cmUgR0VNIGJhY2tlbmRzIHdpdGgg cG9zc2libHkgbGFyZ2VyCj4gbWluaW11bSBwYWdlIHNpemVzLiAgQXMgYSByZXN1bHQsIHRob3Nl IHRlc3RzIG1heSBlaXRoZXIgZmFpbCBvbgo+IHNvZnRwaW4gYXQgb2Zmc2V0cyB3aGljaCBhcmUg aW5jb3JyZWN0bHkgYWxpZ25lZCwgbWF5IHNpbGVudGx5IHNraXAKPiBzdWNoIGluY29ycmVjdGx5 IGFsaWduZWQgYWRkcmVzc2VzIGFzc3VtaW5nIHRoZW0gb2NjdXBpZWQgYnkgb3RoZXIKPiB1c2Vy cyBpZiBpbmNvcnJlY3QgZGV0ZWN0aW9uIG1ldGhvZCBpcyB1c2VkLCBvciBtYXkgYWx3YXlzIHN1 Y2NlZWQKPiB3aGVuIGV4YW1pbmluZyBpbnZhbGlkIHVzZSBwYXR0ZXJucy4KPiAKPiBQcm92aWRl IGEgaGVscGVyIGZ1bmN0aW9uIHRoYXQgZGV0ZWN0cyBtaW5pbXVtIEdUVCBhbGlnbm1lbnQuICBU ZXN0cwo+IG1heSB1c2UgaXQgdG8gY2FsY3VsYXRlIHNvZnRwaW4gb2Zmc2V0cyB2YWxpZCBmb3Ig YWN0dWFsbHkgdXNlZCBiYWNraW5nCj4gc3RvcmUuCj4gCj4gdjI6IFJlbmFtZSB0aGUgaGVscGVy LCB1c2UgJ21pbmltdW0gR1RUIGFsaWdubWVudCcgdGVybSBhY3Jvc3MgdGhlCj4gICAgIGNoYW5n ZSAoQ2hyaXMpLAo+ICAgLSB1c2UgZXJyb3IgbnVtYmVycyB0byBkaXN0aW5ndWlzaCBiZXR3ZWVu IGludmFsaWQgb2Zmc2V0cyBhbmQKPiAgICAgYWRkcmVzc2VzIG9jY3VwaWVkIGJ5IG90aGVyIHVz ZXJzLCB0aGVuCj4gICAtIHNpbXBsaWZ5IHRoZSBjb2RlIChDaHJpcykuCj4gCj4gU2lnbmVkLW9m Zi1ieTogSmFudXN6IEtyenlzenRvZmlrIDxqYW51c3oua3J6eXN6dG9maWtAbGludXguaW50ZWwu Y29tPgo+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzog RGFuaWVsZSBDZXJhb2xvIFNwdXJpbyA8ZGFuaWVsZS5jZXJhb2xvc3B1cmlvQGludGVsLmNvbT4K PiBDYzogU3R1YXJ0IFN1bW1lcnMgPHN0dWFydC5zdW1tZXJzQGludGVsLmNvbT4KPiAtLS0KPiAg bGliL2lvY3RsX3dyYXBwZXJzLmMgfCA0NiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKwo+ICBsaWIvaW9jdGxfd3JhcHBlcnMuaCB8ICAyICsrCj4gIDIgZmlsZXMg Y2hhbmdlZCwgNDggaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9saWIvaW9jdGxfd3Jh cHBlcnMuYyBiL2xpYi9pb2N0bF93cmFwcGVycy5jCj4gaW5kZXggNjI4ZjhiODMuLmYwZWY4YjJl IDEwMDY0NAo+IC0tLSBhL2xpYi9pb2N0bF93cmFwcGVycy5jCj4gKysrIGIvbGliL2lvY3RsX3dy YXBwZXJzLmMKPiBAQCAtNTQsNiArNTQsNyBAQAo+ICAjaW5jbHVkZSAiaW50ZWxfaW8uaCIKPiAg I2luY2x1ZGUgImlndF9kZWJ1Z2ZzLmgiCj4gICNpbmNsdWRlICJpZ3Rfc3lzZnMuaCIKPiArI2lu Y2x1ZGUgImlndF94ODYuaCIKPiAgI2luY2x1ZGUgImNvbmZpZy5oIgo+ICAKPiAgI2lmZGVmIEhB VkVfVkFMR1JJTkQKPiBAQCAtMTE1OCw2ICsxMTU5LDUxIEBAIGJvb2wgZ2VtX2hhc19zb2Z0cGlu KGludCBmZCkKPiAgICAgICAgIHJldHVybiBoYXNfc29mdHBpbjsKPiAgfQo+ICAKPiArLyoqCj4g KyAqIGdlbV9ndHRfbWluX2FsaWdubWVudF9vcmRlcjoKPiArICogQGZkOiBvcGVuIGk5MTUgZHJt IGZpbGUgZGVzY3JpcHRvcgo+ICsgKgo+ICsgKiBUaGlzIGZ1bmN0aW9uIGRldGVjdHMgdGhlIG1p bmltdW0gcG9zc2libGUgYWxpZ25tZW50IG9mIGEgc29mdC1waW5uZWQgZ2VtCj4gKyAqIG9iamVj dCBhbGxvY2F0ZWQgZnJvbSBhIGRlZmF1bHQgYmFja2luZyBzdG9yZS4gIEl0IGlzIHVzZWZ1bCBm b3IgY2FsY3VsYXRpbmcKPiArICogY29ycmVjdGx5IGFsaWduZWQgc29mdHBpbiBvZmZzZXRzLgo+ ICsgKiBTaW5jZSBzaXplIG9yZGVyIHRvIHNpemUgY29udmVyc2lvbiAoc2l6ZSA9IDEgPDwgb3Jk ZXIpIGlzIGxlc3MgdHJpdmlhbAo+ICsgKiB0aGFuIHRoZSBvcHBvc2l0ZSwgdGhlIGZ1bmN0aW9u IHJldHVybnMgdGhlIGFsaWdubWVudCBvcmRlciBhcyBtb3JlIGhhbmR5Lgo+ICsgKgo+ICsgKiBS ZXR1cm5zOgo+ICsgKiBTaXplIG9yZGVyIG9mIHRoZSBtaW5pbXVtIEdUVCBhbGlnbm1lbnQKPiAr ICovCj4gK2ludCBnZW1fZ3R0X21pbl9hbGlnbm1lbnRfb3JkZXIoaW50IGZkKQoKQnV0IG5vdCBw YXJ0IG9mIGlvY3RsX3dyYXBwZXJzLmMhCgpsaWIvaTkxNS9nZW1fZ3R0X3RvcG9sb2d5LmM/IF9x dWVyeS5jPyBfcHJvYmUuYz8KCj4gK3sKPiArICAgICAgIHN0cnVjdCBkcm1faTkxNV9nZW1fZXhl Y19vYmplY3QyIG9iajsKPiArICAgICAgIHN0cnVjdCBkcm1faTkxNV9nZW1fZXhlY2J1ZmZlcjIg ZWI7Cj4gKyAgICAgICBjb25zdCB1aW50MzJfdCBiYmUgPSBNSV9CQVRDSF9CVUZGRVJfRU5EOwo+ ICsgICAgICAgaW50IG9yZGVyOwo+ICsKPiArICAgICAgIC8qIG5vIHNvZnRwaW4gPT4gNGtCIHBh Z2Ugc2l6ZSAqLwo+ICsgICAgICAgaWYgKCFnZW1faGFzX3NvZnRwaW4oZmQpKQo+ICsgICAgICAg ICAgICAgICByZXR1cm4gMTI7Cj4gKwo+ICsgICAgICAgbWVtc2V0KCZvYmosIDAsIHNpemVvZihv YmopKTsKPiArICAgICAgIG1lbXNldCgmZWIsIDAsIHNpemVvZihlYikpOwo+ICsKPiArICAgICAg IG9iai5oYW5kbGUgPSBnZW1fY3JlYXRlKGZkLCA0MDk2KTsKPiArICAgICAgIG9iai5mbGFncyA9 IEVYRUNfT0JKRUNUX1BJTk5FRCB8IEVYRUNfT0JKRUNUX1NVUFBPUlRTXzQ4Ql9BRERSRVNTOwo+ ICsgICAgICAgZWIuYnVmZmVyc19wdHIgPSB0b191c2VyX3BvaW50ZXIoJm9iaik7Cj4gKyAgICAg ICBlYi5idWZmZXJfY291bnQgPSAxOwo+ICsgICAgICAgZ2VtX3dyaXRlKGZkLCBvYmouaGFuZGxl LCAwLCAmYmJlLCBzaXplb2YoYmJlKSk7Cj4gKwo+ICsgICAgICAgZm9yIChvcmRlciA9IDEyOyBv cmRlciA8IDY0OyBvcmRlcisrKSB7Cj4gKyAgICAgICAgICAgICAgIG9iai5vZmZzZXQgPSAxdWxs IDw8IG9yZGVyOwo+ICsgICAgICAgICAgICAgICBpZiAoX19nZW1fZXhlY2J1ZihmZCwgJmViKSAh PSAtRUlOVkFMKQo+ICsgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwo+ICsgICAgICAgfQo+ ICsgICAgICAgaWd0X2Fzc2VydChvYmoub2Zmc2V0IDwgZ2VtX2FwZXJ0dXJlX3NpemUoZmQpKTsK CkhtbSwgdGhlcmUgaXMgb25lIG1vcmUgdHJpY2sgd2UgY2FuIGFwcGx5IGhlcmU6IGFuIGludmFs aWQgcmVsb2MuCgptZW1zZXQoJnJlbG9jLCAwLCBzaXplb2YocmVsb2MpKTsKb2JqLnJlbG9jc19w dHIgPSB0b191c2VyX3BvaW50ZXIoJnJlbG9jKTsKb2JqLnJlbG9jYXRpb25fY291bnQgPSAxOwoK V2UgZmlyc3QgcHJvY2VzcyB0aGUgYnVmZmVycywgdGhlbiB3ZSBwcm9jZXNzIHRoZSByZWxvY2F0 aW9ucy4gU28gd2UKd2lsbCBnZXQgdGhlIC1FSU5WQUwgZm9yIGlsbGVnYWwgc29mdHBpbiBiZWZv cmUgd2UgZ2V0IHRoZSAtRU5PRU5UIGZvcgppbnZhbGlkIHJlbG9jIGhhbmRsZS4KClRoYXQganVz dCBzYXZlcyBhY3R1YWxseSBlbWl0dGluZyBhIHJlcXVlc3QuCi1DaHJpcwpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 From: Chris Wilson In-Reply-To: <20191031152857.17143-3-janusz.krzysztofik@linux.intel.com> References: <20191031152857.17143-1-janusz.krzysztofik@linux.intel.com> <20191031152857.17143-3-janusz.krzysztofik@linux.intel.com> Message-ID: <157260292527.17607.2659694670117420139@skylake-alporthouse-com> Date: Fri, 01 Nov 2019 10:08:45 +0000 Subject: Re: [igt-dev] [RFC PATCH i-g-t v4 2/4] lib: Add minimum GTT alignment helper List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Janusz Krzysztofik , igt-dev@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org List-ID: UXVvdGluZyBKYW51c3ogS3J6eXN6dG9maWsgKDIwMTktMTAtMzEgMTU6Mjg6NTUpCj4gU29tZSB0 ZXN0cyBhc3N1bWUgNGtCIG9mZnNldCBhbGlnbm1lbnQgd2hpbGUgdXNpbmcgc29mdHBpbi4gIFRo YXQKPiBhc3N1bXB0aW9uIG1heSBiZSB3cm9uZyBvbiBmdXR1cmUgR0VNIGJhY2tlbmRzIHdpdGgg cG9zc2libHkgbGFyZ2VyCj4gbWluaW11bSBwYWdlIHNpemVzLiAgQXMgYSByZXN1bHQsIHRob3Nl IHRlc3RzIG1heSBlaXRoZXIgZmFpbCBvbgo+IHNvZnRwaW4gYXQgb2Zmc2V0cyB3aGljaCBhcmUg aW5jb3JyZWN0bHkgYWxpZ25lZCwgbWF5IHNpbGVudGx5IHNraXAKPiBzdWNoIGluY29ycmVjdGx5 IGFsaWduZWQgYWRkcmVzc2VzIGFzc3VtaW5nIHRoZW0gb2NjdXBpZWQgYnkgb3RoZXIKPiB1c2Vy cyBpZiBpbmNvcnJlY3QgZGV0ZWN0aW9uIG1ldGhvZCBpcyB1c2VkLCBvciBtYXkgYWx3YXlzIHN1 Y2NlZWQKPiB3aGVuIGV4YW1pbmluZyBpbnZhbGlkIHVzZSBwYXR0ZXJucy4KPiAKPiBQcm92aWRl IGEgaGVscGVyIGZ1bmN0aW9uIHRoYXQgZGV0ZWN0cyBtaW5pbXVtIEdUVCBhbGlnbm1lbnQuICBU ZXN0cwo+IG1heSB1c2UgaXQgdG8gY2FsY3VsYXRlIHNvZnRwaW4gb2Zmc2V0cyB2YWxpZCBmb3Ig YWN0dWFsbHkgdXNlZCBiYWNraW5nCj4gc3RvcmUuCj4gCj4gdjI6IFJlbmFtZSB0aGUgaGVscGVy LCB1c2UgJ21pbmltdW0gR1RUIGFsaWdubWVudCcgdGVybSBhY3Jvc3MgdGhlCj4gICAgIGNoYW5n ZSAoQ2hyaXMpLAo+ICAgLSB1c2UgZXJyb3IgbnVtYmVycyB0byBkaXN0aW5ndWlzaCBiZXR3ZWVu IGludmFsaWQgb2Zmc2V0cyBhbmQKPiAgICAgYWRkcmVzc2VzIG9jY3VwaWVkIGJ5IG90aGVyIHVz ZXJzLCB0aGVuCj4gICAtIHNpbXBsaWZ5IHRoZSBjb2RlIChDaHJpcykuCj4gCj4gU2lnbmVkLW9m Zi1ieTogSmFudXN6IEtyenlzenRvZmlrIDxqYW51c3oua3J6eXN6dG9maWtAbGludXguaW50ZWwu Y29tPgo+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzog RGFuaWVsZSBDZXJhb2xvIFNwdXJpbyA8ZGFuaWVsZS5jZXJhb2xvc3B1cmlvQGludGVsLmNvbT4K PiBDYzogU3R1YXJ0IFN1bW1lcnMgPHN0dWFydC5zdW1tZXJzQGludGVsLmNvbT4KPiAtLS0KPiAg bGliL2lvY3RsX3dyYXBwZXJzLmMgfCA0NiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKwo+ICBsaWIvaW9jdGxfd3JhcHBlcnMuaCB8ICAyICsrCj4gIDIgZmlsZXMg Y2hhbmdlZCwgNDggaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9saWIvaW9jdGxfd3Jh cHBlcnMuYyBiL2xpYi9pb2N0bF93cmFwcGVycy5jCj4gaW5kZXggNjI4ZjhiODMuLmYwZWY4YjJl IDEwMDY0NAo+IC0tLSBhL2xpYi9pb2N0bF93cmFwcGVycy5jCj4gKysrIGIvbGliL2lvY3RsX3dy YXBwZXJzLmMKPiBAQCAtNTQsNiArNTQsNyBAQAo+ICAjaW5jbHVkZSAiaW50ZWxfaW8uaCIKPiAg I2luY2x1ZGUgImlndF9kZWJ1Z2ZzLmgiCj4gICNpbmNsdWRlICJpZ3Rfc3lzZnMuaCIKPiArI2lu Y2x1ZGUgImlndF94ODYuaCIKPiAgI2luY2x1ZGUgImNvbmZpZy5oIgo+ICAKPiAgI2lmZGVmIEhB VkVfVkFMR1JJTkQKPiBAQCAtMTE1OCw2ICsxMTU5LDUxIEBAIGJvb2wgZ2VtX2hhc19zb2Z0cGlu KGludCBmZCkKPiAgICAgICAgIHJldHVybiBoYXNfc29mdHBpbjsKPiAgfQo+ICAKPiArLyoqCj4g KyAqIGdlbV9ndHRfbWluX2FsaWdubWVudF9vcmRlcjoKPiArICogQGZkOiBvcGVuIGk5MTUgZHJt IGZpbGUgZGVzY3JpcHRvcgo+ICsgKgo+ICsgKiBUaGlzIGZ1bmN0aW9uIGRldGVjdHMgdGhlIG1p bmltdW0gcG9zc2libGUgYWxpZ25tZW50IG9mIGEgc29mdC1waW5uZWQgZ2VtCj4gKyAqIG9iamVj dCBhbGxvY2F0ZWQgZnJvbSBhIGRlZmF1bHQgYmFja2luZyBzdG9yZS4gIEl0IGlzIHVzZWZ1bCBm b3IgY2FsY3VsYXRpbmcKPiArICogY29ycmVjdGx5IGFsaWduZWQgc29mdHBpbiBvZmZzZXRzLgo+ ICsgKiBTaW5jZSBzaXplIG9yZGVyIHRvIHNpemUgY29udmVyc2lvbiAoc2l6ZSA9IDEgPDwgb3Jk ZXIpIGlzIGxlc3MgdHJpdmlhbAo+ICsgKiB0aGFuIHRoZSBvcHBvc2l0ZSwgdGhlIGZ1bmN0aW9u IHJldHVybnMgdGhlIGFsaWdubWVudCBvcmRlciBhcyBtb3JlIGhhbmR5Lgo+ICsgKgo+ICsgKiBS ZXR1cm5zOgo+ICsgKiBTaXplIG9yZGVyIG9mIHRoZSBtaW5pbXVtIEdUVCBhbGlnbm1lbnQKPiAr ICovCj4gK2ludCBnZW1fZ3R0X21pbl9hbGlnbm1lbnRfb3JkZXIoaW50IGZkKQoKQnV0IG5vdCBw YXJ0IG9mIGlvY3RsX3dyYXBwZXJzLmMhCgpsaWIvaTkxNS9nZW1fZ3R0X3RvcG9sb2d5LmM/IF9x dWVyeS5jPyBfcHJvYmUuYz8KCj4gK3sKPiArICAgICAgIHN0cnVjdCBkcm1faTkxNV9nZW1fZXhl Y19vYmplY3QyIG9iajsKPiArICAgICAgIHN0cnVjdCBkcm1faTkxNV9nZW1fZXhlY2J1ZmZlcjIg ZWI7Cj4gKyAgICAgICBjb25zdCB1aW50MzJfdCBiYmUgPSBNSV9CQVRDSF9CVUZGRVJfRU5EOwo+ ICsgICAgICAgaW50IG9yZGVyOwo+ICsKPiArICAgICAgIC8qIG5vIHNvZnRwaW4gPT4gNGtCIHBh Z2Ugc2l6ZSAqLwo+ICsgICAgICAgaWYgKCFnZW1faGFzX3NvZnRwaW4oZmQpKQo+ICsgICAgICAg ICAgICAgICByZXR1cm4gMTI7Cj4gKwo+ICsgICAgICAgbWVtc2V0KCZvYmosIDAsIHNpemVvZihv YmopKTsKPiArICAgICAgIG1lbXNldCgmZWIsIDAsIHNpemVvZihlYikpOwo+ICsKPiArICAgICAg IG9iai5oYW5kbGUgPSBnZW1fY3JlYXRlKGZkLCA0MDk2KTsKPiArICAgICAgIG9iai5mbGFncyA9 IEVYRUNfT0JKRUNUX1BJTk5FRCB8IEVYRUNfT0JKRUNUX1NVUFBPUlRTXzQ4Ql9BRERSRVNTOwo+ ICsgICAgICAgZWIuYnVmZmVyc19wdHIgPSB0b191c2VyX3BvaW50ZXIoJm9iaik7Cj4gKyAgICAg ICBlYi5idWZmZXJfY291bnQgPSAxOwo+ICsgICAgICAgZ2VtX3dyaXRlKGZkLCBvYmouaGFuZGxl LCAwLCAmYmJlLCBzaXplb2YoYmJlKSk7Cj4gKwo+ICsgICAgICAgZm9yIChvcmRlciA9IDEyOyBv cmRlciA8IDY0OyBvcmRlcisrKSB7Cj4gKyAgICAgICAgICAgICAgIG9iai5vZmZzZXQgPSAxdWxs IDw8IG9yZGVyOwo+ICsgICAgICAgICAgICAgICBpZiAoX19nZW1fZXhlY2J1ZihmZCwgJmViKSAh PSAtRUlOVkFMKQo+ICsgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwo+ICsgICAgICAgfQo+ ICsgICAgICAgaWd0X2Fzc2VydChvYmoub2Zmc2V0IDwgZ2VtX2FwZXJ0dXJlX3NpemUoZmQpKTsK CkhtbSwgdGhlcmUgaXMgb25lIG1vcmUgdHJpY2sgd2UgY2FuIGFwcGx5IGhlcmU6IGFuIGludmFs aWQgcmVsb2MuCgptZW1zZXQoJnJlbG9jLCAwLCBzaXplb2YocmVsb2MpKTsKb2JqLnJlbG9jc19w dHIgPSB0b191c2VyX3BvaW50ZXIoJnJlbG9jKTsKb2JqLnJlbG9jYXRpb25fY291bnQgPSAxOwoK V2UgZmlyc3QgcHJvY2VzcyB0aGUgYnVmZmVycywgdGhlbiB3ZSBwcm9jZXNzIHRoZSByZWxvY2F0 aW9ucy4gU28gd2UKd2lsbCBnZXQgdGhlIC1FSU5WQUwgZm9yIGlsbGVnYWwgc29mdHBpbiBiZWZv cmUgd2UgZ2V0IHRoZSAtRU5PRU5UIGZvcgppbnZhbGlkIHJlbG9jIGhhbmRsZS4KClRoYXQganVz dCBzYXZlcyBhY3R1YWxseSBlbWl0dGluZyBhIHJlcXVlc3QuCi1DaHJpcwpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdApp Z3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2lndC1kZXY=