[MPTCP] Re: [PATCH] Squash-to: "mptcp: add basic kselftest for mptcp"

[MPTCP] Re: [PATCH] Squash-to: "mptcp: add basic kselftest for mptcp"

[Paolo Abeni]

[-- Attachment #1: Type: text/plain, Size: 443 bytes --]

On Fri, 2020-01-10 at 17:10 -0800, Mat Martineau wrote:
> I was helping the LKP/0-day team with information on running our tests,
> and noticed some missing config options.
> 
> It looks like a toss-up between 'm' and 'y' for these, so I set values
> based on similar entries in tools/testing/selftests/net/config
> 
> Did I miss any others that aren't in the default config?

I *think* this should be enough. LGTM, thanks!

Paolo

[MPTCP] Re: [PATCH] Squash-to: "mptcp: add basic kselftest for mptcp"

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 892 bytes --]

Hi Mat, Paolo,

On 13/01/2020 17:05, Paolo Abeni wrote:
> On Fri, 2020-01-10 at 17:10 -0800, Mat Martineau wrote:
>> I was helping the LKP/0-day team with information on running our tests,
>> and noticed some missing config options.
>>
>> It looks like a toss-up between 'm' and 'y' for these, so I set values
>> based on similar entries in tools/testing/selftests/net/config
>>
>> Did I miss any others that aren't in the default config?
> 
> I *think* this should be enough. LGTM, thanks!

Thank you for the patch and the review!

- b034f1904b8e: "squashed" in "mptcp: add basic kselftest for mptcp"
- b3a959af913e..704e4fa8a50c: result

Tests + export will be launched soon

Cheers,
Matt
-- 
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium

[MPTCP] Re: [PATCH] squash-to: "mptcp: add basic kselftest for mptcp"

[Davide Caratti]

[-- Attachment #1: Type: text/plain, Size: 793 bytes --]

On Fri, 2019-12-13 at 17:15 +0100, Paolo Abeni wrote:
> On Fri, 2019-12-13 at 17:05 +0100, Davide Caratti wrote:
> > checkpatch fixes
> > 
> > Signed-off-by: Davide Caratti <dcaratti(a)redhat.com>
> > ---
> >  .../selftests/net/mptcp/mptcp_connect.c       | 28 +++++++++----------
> >  1 file changed, 14 insertions(+), 14 deletions(-)
> > 

[...]

> >  
> >  static void check_getpeername(int fd, struct sockaddr_storage *ss, socklen_t salen)
> > @@ -746,15 +746,15 @@ int parse_sndbuf(const char *size)
> >  
> >  	if (errno) {
> >  		fprintf(stderr, "Invalid sndbuf size %s (%s)\n",
> > -				size,
> > -				strerror(errno));
> > +			size,
> > +			strerror(errno));
> 
> I think here we can have:
> 			size, strerror(errno));

sure, will resend a v2 in minutes!

[MPTCP] Re: [PATCH] squash-to: "mptcp: add basic kselftest for mptcp"

[Paolo Abeni]

[-- Attachment #1: Type: text/plain, Size: 3116 bytes --]

On Fri, 2019-12-13 at 17:05 +0100, Davide Caratti wrote:
> checkpatch fixes
> 
> Signed-off-by: Davide Caratti <dcaratti(a)redhat.com>
> ---
>  .../selftests/net/mptcp/mptcp_connect.c       | 28 +++++++++----------
>  1 file changed, 14 insertions(+), 14 deletions(-)
> 
> diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.c b/tools/testing/selftests/net/mptcp/mptcp_connect.c
> index 8b8718e150d1..64550726917f 100644
> --- a/tools/testing/selftests/net/mptcp/mptcp_connect.c
> +++ b/tools/testing/selftests/net/mptcp/mptcp_connect.c
> @@ -71,7 +71,8 @@ static void xgetnameinfo(const struct sockaddr *addr, socklen_t addrlen,
>  			 char *serv, socklen_t servlen)
>  {
>  	int flags = NI_NUMERICHOST | NI_NUMERICSERV;
> -	int err = getnameinfo(addr, addrlen, host, hostlen, serv, servlen, flags);
> +	int err = getnameinfo(addr, addrlen, host, hostlen, serv, servlen,
> +			      flags);
>  
>  	if (err) {
>  		const char *errstr = getxinfo_strerr(err);
> @@ -161,7 +162,6 @@ static int sock_listen_mptcp(const char * const listenaddr,
>  static bool sock_test_tcpulp(const char * const remoteaddr,
>  			     const char * const port)
>  {
> -
>  	struct addrinfo hints = {
>  		.ai_protocol = IPPROTO_TCP,
>  		.ai_socktype = SOCK_STREAM,
> @@ -281,11 +281,12 @@ static ssize_t do_rnd_read(const int fd, char *buf, const size_t len)
>  
>  static void set_nonblock(int fd)
>  {
> -        int flags = fcntl(fd, F_GETFL);
> -        if (flags == -1)
> -                return;
> +	int flags = fcntl(fd, F_GETFL);
> +
> +	if (flags == -1)
> +		return;
>  
> -        fcntl(fd, F_SETFL, flags | O_NONBLOCK);
> +	fcntl(fd, F_SETFL, flags | O_NONBLOCK);
>  }
>  
>  static int copyfd_io_poll(int infd, int peerfd, int outfd)
> @@ -478,7 +479,7 @@ static int do_sendfile(int infd, int outfd, unsigned int count)
>  }
>  
>  static int copyfd_io_mmap(int infd, int peerfd, int outfd,
> -			      unsigned int size)
> +			  unsigned int size)
>  {
>  	int err;
>  
> @@ -501,7 +502,6 @@ static int copyfd_io_mmap(int infd, int peerfd, int outfd,
>  	return err;
>  }
>  
> -
>  static int copyfd_io_sendfile(int infd, int peerfd, int outfd,
>  			      unsigned int size)
>  {
> @@ -575,11 +575,11 @@ static void check_sockaddr(int pf, struct sockaddr_storage *ss,
>  
>  	if (salen != wanted_size)
>  		fprintf(stderr, "accept: size mismatch, got %d expected %d\n",
> -				(int)salen, wanted_size);
> +			(int)salen, wanted_size);
>  
>  	if (ss->ss_family != pf)
>  		fprintf(stderr, "accept: pf mismatch, expect %d, ss_family is %d\n",
> -				(int)ss->ss_family, pf);
> +			(int)ss->ss_family, pf);
>  }
>  
>  static void check_getpeername(int fd, struct sockaddr_storage *ss, socklen_t salen)
> @@ -746,15 +746,15 @@ int parse_sndbuf(const char *size)
>  
>  	if (errno) {
>  		fprintf(stderr, "Invalid sndbuf size %s (%s)\n",
> -				size,
> -				strerror(errno));
> +			size,
> +			strerror(errno));

I think here we can have:
			size, strerror(errno));

instead.

A similar chunk below.

Thanks!

Paolo