All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Wrap vm_mmap() around GEM objects (rev2)
Date: Wed, 06 Nov 2019 09:21:28 -0000	[thread overview]
Message-ID: <157303208850.12034.14428297513261674258@emeril.freedesktop.org> (raw)
In-Reply-To: <20191106011748.14419-1-chris@chris-wilson.co.uk>

== Series Details ==

Series: drm/i915/selftests: Wrap vm_mmap() around GEM objects (rev2)
URL   : https://patchwork.freedesktop.org/series/69024/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
d9f64b19e4f3 drm/i915/selftests: Wrap vm_mmap() around GEM objects
-:68: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#68: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c:698:
+#define expand32(x) (((x) << 0) | ((x) << 8) | ((x) << 16) | ((x) << 24))

-:119: ERROR:SPACING: space required before that '*' (ctx:VxV)
#119: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c:749:
+		u32 __user *ux = u64_to_user_ptr((u64)(addr + i * sizeof*(ux)));
 		                                                        ^

-:175: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#175: 
new file mode 100644

-:180: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#180: FILE: drivers/gpu/drm/i915/selftests/igt_mmap.c:1:
+/*

-:181: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#181: FILE: drivers/gpu/drm/i915/selftests/igt_mmap.c:2:
+ * SPDX-License-Identifier: MIT

-:251: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#251: FILE: drivers/gpu/drm/i915/selftests/igt_mmap.h:1:
+/*

-:252: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#252: FILE: drivers/gpu/drm/i915/selftests/igt_mmap.h:2:
+ * SPDX-License-Identifier: MIT

total: 1 errors, 5 warnings, 1 checks, 237 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Chris Wilson" <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Wrap vm_mmap() around GEM objects (rev2)
Date: Wed, 06 Nov 2019 09:21:28 -0000	[thread overview]
Message-ID: <157303208850.12034.14428297513261674258@emeril.freedesktop.org> (raw)
Message-ID: <20191106092128.cDHhOeuWOaN3YLuJ_wy1DYhDQkUUDlF43vzs00SXR8Q@z> (raw)
In-Reply-To: <20191106011748.14419-1-chris@chris-wilson.co.uk>

== Series Details ==

Series: drm/i915/selftests: Wrap vm_mmap() around GEM objects (rev2)
URL   : https://patchwork.freedesktop.org/series/69024/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
d9f64b19e4f3 drm/i915/selftests: Wrap vm_mmap() around GEM objects
-:68: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#68: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c:698:
+#define expand32(x) (((x) << 0) | ((x) << 8) | ((x) << 16) | ((x) << 24))

-:119: ERROR:SPACING: space required before that '*' (ctx:VxV)
#119: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c:749:
+		u32 __user *ux = u64_to_user_ptr((u64)(addr + i * sizeof*(ux)));
 		                                                        ^

-:175: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#175: 
new file mode 100644

-:180: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#180: FILE: drivers/gpu/drm/i915/selftests/igt_mmap.c:1:
+/*

-:181: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#181: FILE: drivers/gpu/drm/i915/selftests/igt_mmap.c:2:
+ * SPDX-License-Identifier: MIT

-:251: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#251: FILE: drivers/gpu/drm/i915/selftests/igt_mmap.h:1:
+/*

-:252: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#252: FILE: drivers/gpu/drm/i915/selftests/igt_mmap.h:2:
+ * SPDX-License-Identifier: MIT

total: 1 errors, 5 warnings, 1 checks, 237 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-11-06  9:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-06  1:17 [PATCH] drm/i915/selftests: Wrap vm_mmap() around GEM objects Chris Wilson
2019-11-06  1:17 ` [Intel-gfx] " Chris Wilson
2019-11-06  1:34 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-11-06  1:34   ` [Intel-gfx] " Patchwork
2019-11-06  1:54 ` ✓ Fi.CI.BAT: success " Patchwork
2019-11-06  1:54   ` [Intel-gfx] " Patchwork
2019-11-06  8:26 ` [PATCH] " Chris Wilson
2019-11-06  8:26   ` [Intel-gfx] " Chris Wilson
2019-11-07  8:50   ` Abdiel Janulgue
2019-11-07  8:50     ` [Intel-gfx] " Abdiel Janulgue
2019-11-06  9:21 ` Patchwork [this message]
2019-11-06  9:21   ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Wrap vm_mmap() around GEM objects (rev2) Patchwork
2019-11-06  9:42 ` ✓ Fi.CI.BAT: success " Patchwork
2019-11-06  9:42   ` [Intel-gfx] " Patchwork
2019-11-07  5:01 ` ✓ Fi.CI.IGT: " Patchwork
2019-11-07  5:01   ` [Intel-gfx] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=157303208850.12034.14428297513261674258@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.