From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62D0AC5DF62 for ; Wed, 6 Nov 2019 09:26:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 303B82173E for ; Wed, 6 Nov 2019 09:26:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="O4yDdzLi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 303B82173E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cqqr7w/iECpM+Ie1YAuSFVM5W/UJBCUtE6WkqtLOjQo=; b=O4yDdzLifRtEl9 013fP7rMsCRriWL2uL/U6iUmjnbCjW0ni3WyCOL7HRMpWZ+YWxyqCqvVFhrVdtoWzajqMPoMT7QBt O8yWhXY/Lsk/o8AOxELN7J2MXjmno7HMqZiTgjbPIIQvu9MwWXGntJeHLXzOxcq1pW8ErzIE2EOg5 +Eh7fc4yYWbVZlZR4OW6GLDqo+iuI6sGjQ1jaivUWGwJ/69wlLB/kKxNlrdYeoJO+6Py4zmx8vfUw TNJOn/BCXc+7RrkUvS/KcUtc3UyPKu9qnU2L0MXUzw7oAs2/qdQotvap8QC4OyaKmdZkmLIu/X9gs 531WyrlS+a/TB8MRCcuw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSHZl-0007I0-Qp; Wed, 06 Nov 2019 09:26:05 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSHZi-0007H8-Ow; Wed, 06 Nov 2019 09:26:05 +0000 X-UUID: dd6923c462a64bb78db71595165d3fc0-20191106 X-UUID: dd6923c462a64bb78db71595165d3fc0-20191106 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 719885626; Wed, 06 Nov 2019 01:25:46 -0800 Received: from MTKMBS32DR.mediatek.inc (172.27.6.104) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 6 Nov 2019 01:25:38 -0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS32DR.mediatek.inc (172.27.6.104) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 6 Nov 2019 17:25:36 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 6 Nov 2019 17:25:34 +0800 Message-ID: <1573032336.18464.81.camel@mhfsdcap03> Subject: Re: [PATCH 01/28] usb: common: change usb_debug_root as static variable From: Chunfeng Yun To: Greg Kroah-Hartman Date: Wed, 6 Nov 2019 17:25:36 +0800 In-Reply-To: <20191106085117.GB2971560@kroah.com> References: <8cb137d5376b4e317dc22dcb9e81a1125b781f8f.1573008519.git.chunfeng.yun@mediatek.com> <79fd2ebd-b8c6-ee00-c71e-782475a20de6@roeck-us.net> <20191106073310.GA1085@ninjato> <20191106085117.GB2971560@kroah.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 3B236BA865F797BDE1FBC20BEE259A6634FA0CB66CDD8E62BB0DE47988415F0A2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191106_012602_833426_5644B33E X-CRM114-Status: GOOD ( 14.98 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Chen , Alexandre Belloni , Heikki Krogerus , Wolfram Sang , Yangtao Li , Linus Walleij , linux-kernel@vger.kernel.org, Matthias Brugger , Mans Rullgard , Srinivas Kandagatla , Laurent Pinchart , Fabio Estevam , Florian Fainelli , Robert Jarzmik , Kevin Cernekee , "Gustavo A. R. Silva" , Ludovic Desroches , Alan Stern , NXP Linux Team , bcm-kernel-feedback-list@broadcom.com, David Kershner , Hans Ulli Kroll , Cristian Birsan , linux-media@vger.kernel.org, Fabrizio Castro , Mathias Payer , Mathias Nyman , Suzuki K Poulose , Sascha Hauer , Haojian Zhuang , Stephen Boyd , linux-mediatek@lists.infradead.org, Minas Harutyunyan , Simon Horman , Mauro Carvalho Chehab , Bin Liu , linux-arm-kernel@lists.infradead.org, Biju Das , Felipe Balbi , Laurentiu Tudor , Yoshihiro Shimoda , linux-usb@vger.kernel.org, Nicolas Ferre , Dmitry Torokhov , Guenter Roeck , Pengutronix Kernel Team , Colin Ian King , Shawn Guo , Daniel Mack Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, 2019-11-06 at 09:51 +0100, Greg Kroah-Hartman wrote: > On Wed, Nov 06, 2019 at 08:33:10AM +0100, Wolfram Sang wrote: > > > > > Did exported variables run out of favor ? Sorry if there was a > > > patch 0 of the series explaining the rationale and I missed it. > > > > I neither got it if there was one. If there wasn't, I agree a cover > > letter makes a lot of sense here. > > I don't understand why this whole series is needed either. > > What is wrong with the original code? No wrong at all, just think it's good practice to avoid global variable, more and more controller drivers use it now. And it's also clear enough for global variable usb_debug_root > Also, like I said before, you > broke the build here with the first patch, which is not ok. > > greg k-h _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek