From: David Howells <dhowells@redhat.com> To: torvalds@linux-foundation.org Cc: dhowells@redhat.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Casey Schaufler <casey@schaufler-ca.com>, Stephen Smalley <sds@tycho.nsa.gov>, nicolas.dichtel@6wind.com, raven@themaw.net, Christian Brauner <christian@brauner.io>, dhowells@redhat.com, keyrings@vger.kernel.org, linux-usb@vger.kernel.org, linux-block@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH 13/14] selinux: Implement the watch_key security hook [ver #2] Date: Thu, 07 Nov 2019 13:37:20 +0000 [thread overview] Message-ID: <157313384065.29677.12354003434069581212.stgit@warthog.procyon.org.uk> (raw) In-Reply-To: <157313371694.29677.15388731274912671071.stgit@warthog.procyon.org.uk> Implement the watch_key security hook to make sure that a key grants the caller View permission in order to set a watch on a key. For the moment, the watch_devices security hook is left unimplemented as it's not obvious what the object should be since the queue is global and didn't previously exist. Signed-off-by: David Howells <dhowells@redhat.com> Acked-by: Stephen Smalley <sds@tycho.nsa.gov> --- security/selinux/hooks.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index 9625b99e677f..53637dccee00 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c @@ -6579,6 +6579,17 @@ static int selinux_key_getsecurity(struct key *key, char **_buffer) *_buffer = context; return rc; } + +#ifdef CONFIG_KEY_NOTIFICATIONS +static int selinux_watch_key(struct key *key) +{ + struct key_security_struct *ksec = key->security; + u32 sid = current_sid(); + + return avc_has_perm(&selinux_state, + sid, ksec->sid, SECCLASS_KEY, KEY_NEED_VIEW, NULL); +} +#endif #endif #ifdef CONFIG_SECURITY_INFINIBAND @@ -7012,6 +7023,9 @@ static struct security_hook_list selinux_hooks[] __lsm_ro_after_init = { LSM_HOOK_INIT(key_free, selinux_key_free), LSM_HOOK_INIT(key_permission, selinux_key_permission), LSM_HOOK_INIT(key_getsecurity, selinux_key_getsecurity), +#ifdef CONFIG_KEY_NOTIFICATIONS + LSM_HOOK_INIT(watch_key, selinux_watch_key), +#endif #endif #ifdef CONFIG_AUDIT
WARNING: multiple messages have this Message-ID
From: David Howells <dhowells@redhat.com> To: torvalds@linux-foundation.org Cc: dhowells@redhat.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Casey Schaufler <casey@schaufler-ca.com>, Stephen Smalley <sds@tycho.nsa.gov>, nicolas.dichtel@6wind.com, raven@themaw.net, Christian Brauner <christian@brauner.io>dhowells@redhat.com, keyrings@vger.kernel.org, linux-usb@vger.kernel.org, linux-block@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH 13/14] selinux: Implement the watch_key security hook [ver #2] Date: Thu, 07 Nov 2019 13:37:20 +0000 [thread overview] Message-ID: <157313384065.29677.12354003434069581212.stgit@warthog.procyon.org.uk> (raw) In-Reply-To: <157313371694.29677.15388731274912671071.stgit@warthog.procyon.org.uk> Implement the watch_key security hook to make sure that a key grants the caller View permission in order to set a watch on a key. For the moment, the watch_devices security hook is left unimplemented as it's not obvious what the object should be since the queue is global and didn't previously exist. Signed-off-by: David Howells <dhowells@redhat.com> Acked-by: Stephen Smalley <sds@tycho.nsa.gov> --- security/selinux/hooks.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index 9625b99e677f..53637dccee00 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c @@ -6579,6 +6579,17 @@ static int selinux_key_getsecurity(struct key *key, char **_buffer) *_buffer = context; return rc; } + +#ifdef CONFIG_KEY_NOTIFICATIONS +static int selinux_watch_key(struct key *key) +{ + struct key_security_struct *ksec = key->security; + u32 sid = current_sid(); + + return avc_has_perm(&selinux_state, + sid, ksec->sid, SECCLASS_KEY, KEY_NEED_VIEW, NULL); +} +#endif #endif #ifdef CONFIG_SECURITY_INFINIBAND @@ -7012,6 +7023,9 @@ static struct security_hook_list selinux_hooks[] __lsm_ro_after_init = { LSM_HOOK_INIT(key_free, selinux_key_free), LSM_HOOK_INIT(key_permission, selinux_key_permission), LSM_HOOK_INIT(key_getsecurity, selinux_key_getsecurity), +#ifdef CONFIG_KEY_NOTIFICATIONS + LSM_HOOK_INIT(watch_key, selinux_watch_key), +#endif #endif #ifdef CONFIG_AUDIT
WARNING: multiple messages have this Message-ID
From: David Howells <dhowells@redhat.com> To: torvalds@linux-foundation.org Cc: dhowells@redhat.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Casey Schaufler <casey@schaufler-ca.com>, Stephen Smalley <sds@tycho.nsa.gov>, nicolas.dichtel@6wind.com, raven@themaw.net, Christian Brauner <christian@brauner.io>dhowells@redhat.com, keyrings@vger.kernel.org, linux-usb@vger.kernel.org, linux-block@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.orglinux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH 13/14] selinux: Implement the watch_key security hook [ver #2] Date: Thu, 07 Nov 2019 13:37:20 +0000 [thread overview] Message-ID: <157313384065.29677.12354003434069581212.stgit@warthog.procyon.org.uk> (raw) In-Reply-To: <157313371694.29677.15388731274912671071.stgit@warthog.procyon.org.uk> Implement the watch_key security hook to make sure that a key grants the caller View permission in order to set a watch on a key. For the moment, the watch_devices security hook is left unimplemented as it's not obvious what the object should be since the queue is global and didn't previously exist. Signed-off-by: David Howells <dhowells@redhat.com> Acked-by: Stephen Smalley <sds@tycho.nsa.gov> --- security/selinux/hooks.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index 9625b99e677f..53637dccee00 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c @@ -6579,6 +6579,17 @@ static int selinux_key_getsecurity(struct key *key, char **_buffer) *_buffer = context; return rc; } + +#ifdef CONFIG_KEY_NOTIFICATIONS +static int selinux_watch_key(struct key *key) +{ + struct key_security_struct *ksec = key->security; + u32 sid = current_sid(); + + return avc_has_perm(&selinux_state, + sid, ksec->sid, SECCLASS_KEY, KEY_NEED_VIEW, NULL); +} +#endif #endif #ifdef CONFIG_SECURITY_INFINIBAND @@ -7012,6 +7023,9 @@ static struct security_hook_list selinux_hooks[] __lsm_ro_after_init = { LSM_HOOK_INIT(key_free, selinux_key_free), LSM_HOOK_INIT(key_permission, selinux_key_permission), LSM_HOOK_INIT(key_getsecurity, selinux_key_getsecurity), +#ifdef CONFIG_KEY_NOTIFICATIONS + LSM_HOOK_INIT(watch_key, selinux_watch_key), +#endif #endif #ifdef CONFIG_AUDIT
next prev parent reply other threads:[~2019-11-07 13:37 UTC|newest] Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-07 13:35 [RFC PATCH 00/14] pipe: Keyrings, Block and USB notifications " David Howells 2019-11-07 13:35 ` David Howells 2019-11-07 13:35 ` David Howells 2019-11-07 13:35 ` [RFC PATCH 01/14] uapi: General notification queue definitions " David Howells 2019-11-07 13:35 ` David Howells 2019-11-07 13:35 ` David Howells 2019-11-07 13:35 ` [RFC PATCH 02/14] security: Add hooks to rule on setting a watch " David Howells 2019-11-07 13:35 ` David Howells 2019-11-07 13:35 ` David Howells 2019-11-07 13:35 ` [RFC PATCH 03/14] security: Add a hook for the point of notification insertion " David Howells 2019-11-07 13:35 ` David Howells 2019-11-07 13:35 ` David Howells 2019-11-07 13:35 ` [RFC PATCH 04/14] pipe: Add O_NOTIFICATION_PIPE " David Howells 2019-11-07 13:35 ` David Howells 2019-11-07 13:35 ` David Howells 2019-11-07 18:16 ` Andy Lutomirski 2019-11-07 18:16 ` Andy Lutomirski 2019-11-07 18:48 ` David Howells 2019-11-08 5:06 ` Andy Lutomirski 2019-11-08 5:06 ` Andy Lutomirski 2019-11-08 6:42 ` David Howells 2019-11-07 13:36 ` [RFC PATCH 05/14] pipe: Add general notification queue support " David Howells 2019-11-07 13:36 ` David Howells 2019-11-07 13:36 ` David Howells 2019-11-07 13:36 ` [RFC PATCH 06/14] keys: Add a notification facility " David Howells 2019-11-07 13:36 ` David Howells 2019-11-07 13:36 ` David Howells 2019-11-07 13:36 ` [RFC PATCH 07/14] Add sample notification program " David Howells 2019-11-07 13:36 ` David Howells 2019-11-07 13:36 ` David Howells 2019-11-07 13:36 ` [RFC PATCH 08/14] pipe: Allow buffers to be marked read-whole-or-error for notifications " David Howells 2019-11-07 13:36 ` David Howells 2019-11-07 13:36 ` David Howells 2019-11-07 18:15 ` Andy Lutomirski 2019-11-07 18:15 ` [RFC PATCH 08/14] pipe: Allow buffers to be marked read-whole-or-error for notifications [ver #2 Andy Lutomirski 2019-11-07 18:23 ` [RFC PATCH 08/14] pipe: Allow buffers to be marked read-whole-or-error for notifications [ver #2] David Howells 2019-11-07 18:23 ` [RFC PATCH 08/14] pipe: Allow buffers to be marked read-whole-or-error for notifications [ver #2 David Howells 2019-11-07 13:36 ` [RFC PATCH 09/14] pipe: Add notification lossage handling [ver #2] David Howells 2019-11-07 13:36 ` David Howells 2019-11-07 13:36 ` David Howells 2019-11-07 13:36 ` [RFC PATCH 10/14] Add a general, global device notification watch list " David Howells 2019-11-07 13:36 ` David Howells 2019-11-07 13:36 ` David Howells 2019-11-07 13:37 ` [RFC PATCH 11/14] block: Add block layer notifications " David Howells 2019-11-07 13:37 ` David Howells 2019-11-07 13:37 ` David Howells 2019-11-07 13:37 ` [RFC PATCH 12/14] usb: Add USB subsystem " David Howells 2019-11-07 13:37 ` David Howells 2019-11-07 13:37 ` David Howells 2019-11-07 13:37 ` David Howells [this message] 2019-11-07 13:37 ` [RFC PATCH 13/14] selinux: Implement the watch_key security hook " David Howells 2019-11-07 13:37 ` David Howells 2019-11-07 13:37 ` [RFC PATCH 14/14] smack: Implement the watch_key and post_notification hooks " David Howells 2019-11-07 13:37 ` David Howells 2019-11-07 13:37 ` David Howells 2019-11-07 17:16 ` [RFC PATCH 05/14] pipe: Add general notification queue support " David Howells 2020-01-15 13:30 [RFC PATCH 00/14] pipe: Keyrings, Block and USB notifications [ver #3] David Howells 2020-01-15 13:30 ` David Howells 2020-01-15 13:30 ` David Howells 2020-01-15 13:30 ` [RFC PATCH 01/14] uapi: General notification queue definitions " David Howells 2020-01-15 13:30 ` David Howells 2020-01-15 13:30 ` David Howells 2020-01-15 13:30 ` [RFC PATCH 02/14] security: Add hooks to rule on setting a watch " David Howells 2020-01-15 13:30 ` David Howells 2020-01-15 13:30 ` David Howells 2020-01-15 13:31 ` [RFC PATCH 03/14] security: Add a hook for the point of notification insertion " David Howells 2020-01-15 13:31 ` David Howells 2020-01-15 13:31 ` David Howells 2020-01-15 13:31 ` [RFC PATCH 04/14] pipe: Add O_NOTIFICATION_PIPE " David Howells 2020-01-15 13:31 ` David Howells 2020-01-15 13:31 ` David Howells 2020-01-15 13:31 ` [RFC PATCH 05/14] pipe: Add general notification queue support " David Howells 2020-01-15 13:31 ` David Howells 2020-01-15 13:31 ` David Howells 2020-01-15 13:31 ` [RFC PATCH 06/14] keys: Add a notification facility " David Howells 2020-01-15 13:31 ` David Howells 2020-01-15 13:31 ` David Howells 2020-01-15 13:31 ` [RFC PATCH 07/14] Add sample notification program " David Howells 2020-01-15 13:31 ` David Howells 2020-01-15 13:31 ` David Howells 2020-01-26 15:47 ` Guenter Roeck 2020-01-26 15:47 ` Guenter Roeck 2020-01-26 15:47 ` Guenter Roeck 2020-01-15 13:31 ` [RFC PATCH 08/14] pipe: Allow buffers to be marked read-whole-or-error for notifications " David Howells 2020-01-15 13:31 ` David Howells 2020-01-15 13:31 ` David Howells 2020-01-15 13:31 ` [RFC PATCH 09/14] pipe: Add notification lossage handling " David Howells 2020-01-15 13:31 ` David Howells 2020-01-15 13:31 ` David Howells 2020-01-15 13:32 ` [RFC PATCH 10/14] Add a general, global device notification watch list " David Howells 2020-01-15 13:32 ` David Howells 2020-01-15 13:32 ` David Howells 2020-01-15 13:32 ` [RFC PATCH 11/14] block: Add block layer notifications " David Howells 2020-01-15 13:32 ` David Howells 2020-01-15 13:32 ` David Howells 2020-01-15 13:32 ` [RFC PATCH 12/14] usb: Add USB subsystem " David Howells 2020-01-15 13:32 ` David Howells 2020-01-15 13:32 ` David Howells 2020-01-15 13:32 ` [RFC PATCH 13/14] selinux: Implement the watch_key security hook " David Howells 2020-01-15 13:32 ` David Howells 2020-01-15 13:32 ` David Howells 2020-01-15 13:32 ` [RFC PATCH 14/14] smack: Implement the watch_key and post_notification hooks " David Howells 2020-01-15 13:32 ` David Howells 2020-01-15 13:32 ` David Howells 2020-01-15 20:10 ` [RFC PATCH 00/14] pipe: Keyrings, Block and USB notifications " Linus Torvalds 2020-01-15 20:10 ` Linus Torvalds 2020-02-11 0:56 ` Andres Freund 2020-02-11 0:56 ` Andres Freund 2020-01-15 21:07 ` David Howells 2020-01-15 21:07 ` David Howells
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=157313384065.29677.12354003434069581212.stgit@warthog.procyon.org.uk \ --to=dhowells@redhat.com \ --cc=casey@schaufler-ca.com \ --cc=christian@brauner.io \ --cc=gregkh@linuxfoundation.org \ --cc=keyrings@vger.kernel.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=nicolas.dichtel@6wind.com \ --cc=raven@themaw.net \ --cc=sds@tycho.nsa.gov \ --cc=torvalds@linux-foundation.org \ --subject='Re: [RFC PATCH 13/14] selinux: Implement the watch_key security hook [ver #2]' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.