From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MIME_BASE64_TEXT,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EDADC432C3 for ; Thu, 14 Nov 2019 02:33:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 326C5206E1 for ; Thu, 14 Nov 2019 02:33:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="DE1IpPyB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727119AbfKNCdp (ORCPT ); Wed, 13 Nov 2019 21:33:45 -0500 Received: from mailgw02.mediatek.com ([1.203.163.81]:10737 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726473AbfKNCdp (ORCPT ); Wed, 13 Nov 2019 21:33:45 -0500 X-UUID: 273aaed76625470ebb4fee21e3be15fe-20191114 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=jdpcBWc7HBlDBSHQj9W7l/lAc9ZUoty9ehXTUgWCTGw=; b=DE1IpPyBL+mC1m1knTLKZFTpztGf8k13sLrkBIVTY6cyZX7Le3W/Huc0mCBlTe82eBmGGdmRI5p6xCcEzGIWGgk0rWP47CbEBZXXM86lDwTe2Kf1M/dQ7CGelnvi8/9ZPZkvSYG2hjOKWWyv05Lh/pAkHSveOOjHJTh2Q9HLqt0=; X-UUID: 273aaed76625470ebb4fee21e3be15fe-20191114 Received: from mtkcas32.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 2040405152; Thu, 14 Nov 2019 10:33:30 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 14 Nov 2019 10:33:21 +0800 Received: from localhost.localdomain (10.17.3.153) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 14 Nov 2019 10:33:20 +0800 From: Chunfeng Yun To: Tianping Fang CC: Greg Kroah-Hartman , Matthias Brugger , Chunfeng Yun , , , , , Subject: [RFC PATCH] usb: mtu3: fix random remote wakeup Date: Thu, 14 Nov 2019 10:33:11 +0800 Message-ID: <1573698791-24310-1-git-send-email-chunfeng.yun@mediatek.com> X-Mailer: git-send-email 1.8.1.1.dirty MIME-Version: 1.0 Content-Type: text/plain X-TM-SNTS-SMTP: 2075714ACED72CBB15C4DCA956E5D8B2E8C542FC8427F2F77C2C39642685507E2000:8 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org V2FrZXVwX3NpZ25hbCB3aWxsIHRvZ2dsZSBzdGF0dXMgYWNjb3JkaW5nIHRvIHNzdXNiX2lwX3Ns ZWVwIHNpZ25hbA0KYWZ0ZXIgZGVib3VuY2UgdGltZSwgc28gbmVlZCBhZGQgYSBkZWxheSB0aW1l IGFuZCB3YWl0IGZvciB3YWtldXBfc2lnbmFsDQp0b2dnbGUgdG8gY29tcGxldGUsIHRoZW4gZW5h YmxlIHRoZSByZW1vdGUgd2FrZXVwLiBNZWFud2hpbGUgcmVkdWNlIHRoZQ0KZGVib3VuY2UgdGlt ZSBvZiB3YWtldXBfc2lnbmFsLiBUaGVzZSB3aWxsIGF2b2lkIHNwdXJpb3VzIHdha2V1cCBldmVu dC4NCg0KU2lnbmVkLW9mZi1ieTogVGlhbnBpbmcgRmFuZyA8dGlhbnBpbmcuZmFuZ0BtZWRpYXRl ay5jb20+DQpTaWduZWQtb2ZmLWJ5OiBDaHVuZmVuZyBZdW4gPGNodW5mZW5nLnl1bkBtZWRpYXRl ay5jb20+DQotLS0NCk5vdGUsIGRlcGVuZHMgb24gZm9sbG93aW5nIHBhdGNoIG5vdCBtZXJnZWQ6 DQoNCiAgICBbdjMsMy83XSB1c2I6IG10dTM6IHN1cHBvcnQgaXAtc2xlZXAgd2FrZXVwIGZvciBN VDgxODMNCiAgICBodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3BhdGNoLzExMTIzMTUxLw0K LS0tDQogZHJpdmVycy91c2IvbXR1My9tdHUzX2hvc3QuYyB8IDYgKysrKy0tDQogMSBmaWxlIGNo YW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkNCg0KZGlmZiAtLWdpdCBhL2Ry aXZlcnMvdXNiL210dTMvbXR1M19ob3N0LmMgYi9kcml2ZXJzL3VzYi9tdHUzL210dTNfaG9zdC5j DQppbmRleCAxODJjOTQzOWMxNWEuLmNhNDhmZjc1MWM4YiAxMDA2NDQNCi0tLSBhL2RyaXZlcnMv dXNiL210dTMvbXR1M19ob3N0LmMNCisrKyBiL2RyaXZlcnMvdXNiL210dTMvbXR1M19ob3N0LmMN CkBAIC01MywxMiArNTMsMTIgQEAgc3RhdGljIHZvaWQgc3N1c2Jfd2FrZXVwX2lwX3NsZWVwX3Nl dChzdHJ1Y3Qgc3N1c2JfbXRrICpzc3VzYiwgYm9vbCBlbmFibGUpDQogCWNhc2UgU1NVU0JfVVdL X1YwOg0KIAkJcmVnID0gc3N1c2ItPnV3a19yZWdfYmFzZSArIFBFUklfV0tfQ1RSTDA7DQogCQlt c2sgPSAodTMyKShXQzBfSVNfRU4gfCBXQzBfSVNfQygweGYpIHwgV0MwX0lTX1ApOw0KLQkJdmFs ID0gZW5hYmxlID8gKFdDMF9JU19FTiB8IFdDMF9JU19DKDB4OCkpIDogMDsNCisJCXZhbCA9IGVu YWJsZSA/IChXQzBfSVNfRU4gfCBXQzBfSVNfQygweDMpKSA6IDA7DQogCQlicmVhazsNCiAJY2Fz ZSBTU1VTQl9VV0tfVjE6DQogCQlyZWcgPSBzc3VzYi0+dXdrX3JlZ19iYXNlICsgUEVSSV9XS19D VFJMMTsNCiAJCW1zayA9IFdDMV9JU19FTiB8IFdDMV9JU19DKDB4ZikgfCBXQzFfSVNfUDsNCi0J CXZhbCA9IGVuYWJsZSA/IChXQzFfSVNfRU4gfCBXQzFfSVNfQygweDgpKSA6IDA7DQorCQl2YWwg PSBlbmFibGUgPyAoV0MxX0lTX0VOIHwgV0MxX0lTX0MoMHgzKSkgOiAwOw0KIAkJYnJlYWs7DQog CWNhc2UgU1NVU0JfVVdLX1YyOg0KIAkJcmVnID0gc3N1c2ItPnV3a19yZWdfYmFzZSArIFBFUklf U1NVU0JfU1BNX0NUUkw7DQpAQCAtMTk3LDYgKzE5Nyw4IEBAIGludCBzc3VzYl9ob3N0X2Rpc2Fi bGUoc3RydWN0IHNzdXNiX210ayAqc3N1c2IsIGJvb2wgc3VzcGVuZCkNCiAJCQkgICh2YWx1ZSAm IFNTVVNCX0lQX1NMRUVQX1NUUyksIDEwMCwgMTAwMDAwKTsNCiAJaWYgKHJldCkNCiAJCWRldl9l cnIoc3N1c2ItPmRldiwgImlwIHNsZWVwIGZhaWxlZCEhIVxuIik7DQorCWVsc2UgIC8qIHdhaXQg Zm9yIHdha2V1cF9zaWduYWwgdG9nZ2xlIGRvbmUgYWZ0ZXIgZW50ZXIgaXAtc2xlZXAgKi8NCisJ CXVzbGVlcF9yYW5nZSgyNDUsIDI1NSk7DQogDQogCXJldHVybiByZXQ7DQogfQ0KLS0gDQoyLjIz LjANCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58008C43141 for ; Thu, 14 Nov 2019 02:33:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5FEEA206F3 for ; Thu, 14 Nov 2019 02:33:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="facgcm68"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="DE1IpPyB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5FEEA206F3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=/wpdThyS46BKlYm/HCDQDSz4z5JMYBoi0Hs4zjN6kTI=; b=facgcm6857v9hd JT7LF6laXQcLcPurxi364HticAfMhhPNpS4ouIG9ULVGaxUOOvsIh26seqyeFNwCN12jKHXwoZW61 8i5tIpVLVLX22Pgg3taCfSC2MRj9zeQznpnpbffBedZsH+J9ArCj4OgLx443vPtnWPp3nsC96jHVy 0nVa4tIQaV5BfHHOdt7RlKjfWfVaL2QJj0Js5I3kbhIWHY8cP41I9Wo6ehNBR0WDrXvr8O4gTXTeN rV+N7fbiUY3Yy0TMG9TPuCnyTpJ1xhXf03eMD2G2blRGbFZZQS+3iqKlg32Zrhp/vkmtLmcJpCoy9 J0GPRQjaMPpzcRiV60wA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iV4x8-0002AT-0p; Thu, 14 Nov 2019 02:33:46 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iV4x5-00029u-IA; Thu, 14 Nov 2019 02:33:45 +0000 X-UUID: 4dd235c4d2234f9299126564d22a0cb4-20191113 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=jdpcBWc7HBlDBSHQj9W7l/lAc9ZUoty9ehXTUgWCTGw=; b=DE1IpPyBL+mC1m1knTLKZFTpztGf8k13sLrkBIVTY6cyZX7Le3W/Huc0mCBlTe82eBmGGdmRI5p6xCcEzGIWGgk0rWP47CbEBZXXM86lDwTe2Kf1M/dQ7CGelnvi8/9ZPZkvSYG2hjOKWWyv05Lh/pAkHSveOOjHJTh2Q9HLqt0=; X-UUID: 4dd235c4d2234f9299126564d22a0cb4-20191113 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 759150441; Wed, 13 Nov 2019 18:33:30 -0800 Received: from MTKMBS31DR.mediatek.inc (172.27.6.102) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 13 Nov 2019 18:33:30 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 14 Nov 2019 10:33:21 +0800 Received: from localhost.localdomain (10.17.3.153) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 14 Nov 2019 10:33:20 +0800 From: Chunfeng Yun To: Tianping Fang Subject: [RFC PATCH] usb: mtu3: fix random remote wakeup Date: Thu, 14 Nov 2019 10:33:11 +0800 Message-ID: <1573698791-24310-1-git-send-email-chunfeng.yun@mediatek.com> X-Mailer: git-send-email 1.8.1.1.dirty MIME-Version: 1.0 X-TM-SNTS-SMTP: 2075714ACED72CBB15C4DCA956E5D8B2E8C542FC8427F2F77C2C39642685507E2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191113_183343_613512_862DD19C X-CRM114-Status: UNSURE ( 8.73 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Chunfeng Yun , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Wakeup_signal will toggle status according to ssusb_ip_sleep signal after debounce time, so need add a delay time and wait for wakeup_signal toggle to complete, then enable the remote wakeup. Meanwhile reduce the debounce time of wakeup_signal. These will avoid spurious wakeup event. Signed-off-by: Tianping Fang Signed-off-by: Chunfeng Yun --- Note, depends on following patch not merged: [v3,3/7] usb: mtu3: support ip-sleep wakeup for MT8183 https://patchwork.kernel.org/patch/11123151/ --- drivers/usb/mtu3/mtu3_host.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/mtu3/mtu3_host.c b/drivers/usb/mtu3/mtu3_host.c index 182c9439c15a..ca48ff751c8b 100644 --- a/drivers/usb/mtu3/mtu3_host.c +++ b/drivers/usb/mtu3/mtu3_host.c @@ -53,12 +53,12 @@ static void ssusb_wakeup_ip_sleep_set(struct ssusb_mtk *ssusb, bool enable) case SSUSB_UWK_V0: reg = ssusb->uwk_reg_base + PERI_WK_CTRL0; msk = (u32)(WC0_IS_EN | WC0_IS_C(0xf) | WC0_IS_P); - val = enable ? (WC0_IS_EN | WC0_IS_C(0x8)) : 0; + val = enable ? (WC0_IS_EN | WC0_IS_C(0x3)) : 0; break; case SSUSB_UWK_V1: reg = ssusb->uwk_reg_base + PERI_WK_CTRL1; msk = WC1_IS_EN | WC1_IS_C(0xf) | WC1_IS_P; - val = enable ? (WC1_IS_EN | WC1_IS_C(0x8)) : 0; + val = enable ? (WC1_IS_EN | WC1_IS_C(0x3)) : 0; break; case SSUSB_UWK_V2: reg = ssusb->uwk_reg_base + PERI_SSUSB_SPM_CTRL; @@ -197,6 +197,8 @@ int ssusb_host_disable(struct ssusb_mtk *ssusb, bool suspend) (value & SSUSB_IP_SLEEP_STS), 100, 100000); if (ret) dev_err(ssusb->dev, "ip sleep failed!!!\n"); + else /* wait for wakeup_signal toggle done after enter ip-sleep */ + usleep_range(245, 255); return ret; } -- 2.23.0 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11FD6C432C3 for ; Thu, 14 Nov 2019 02:33:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 24A70206E1 for ; Thu, 14 Nov 2019 02:33:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OmVTbC/b"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="DE1IpPyB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 24A70206E1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=qe+ZzKTlpuETio4xXu5n8BEQ0M+ZreD9UtbMAbwjlOI=; b=OmVTbC/blgJeMr F8nvjqtXfzaCgdBFjhE7ihEJxH9H/GZh6IgJFA5yBnCZRBAEb2y1uk05FgAT5NCW4R1tGhTU/X56C mhSvWTPn+n9KCoQZotXPmyyy8elR8zvW0/ZKbmw1ciFBa6IEm1X/aWx2lROSYYIqijdRrT70vDK/h q3vdiT0xDGze+UJQT5zzqHYciEggR9opl92Q941M8KmpjRpfJx8vOusfspbAMKB7+OM5DpFSX6sdU aWEeBmMjZvKKgZmUbgTuVwNa1aKNNh2ceGLux0MxpSrW8ORarZKjRdVsWB/oF0E210Ja+7FNWMek0 QQp30PbkuzKqZyBGjOYA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iV4x8-0002As-MQ; Thu, 14 Nov 2019 02:33:46 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iV4x5-00029u-IA; Thu, 14 Nov 2019 02:33:45 +0000 X-UUID: 4dd235c4d2234f9299126564d22a0cb4-20191113 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=jdpcBWc7HBlDBSHQj9W7l/lAc9ZUoty9ehXTUgWCTGw=; b=DE1IpPyBL+mC1m1knTLKZFTpztGf8k13sLrkBIVTY6cyZX7Le3W/Huc0mCBlTe82eBmGGdmRI5p6xCcEzGIWGgk0rWP47CbEBZXXM86lDwTe2Kf1M/dQ7CGelnvi8/9ZPZkvSYG2hjOKWWyv05Lh/pAkHSveOOjHJTh2Q9HLqt0=; X-UUID: 4dd235c4d2234f9299126564d22a0cb4-20191113 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 759150441; Wed, 13 Nov 2019 18:33:30 -0800 Received: from MTKMBS31DR.mediatek.inc (172.27.6.102) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 13 Nov 2019 18:33:30 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 14 Nov 2019 10:33:21 +0800 Received: from localhost.localdomain (10.17.3.153) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 14 Nov 2019 10:33:20 +0800 From: Chunfeng Yun To: Tianping Fang Subject: [RFC PATCH] usb: mtu3: fix random remote wakeup Date: Thu, 14 Nov 2019 10:33:11 +0800 Message-ID: <1573698791-24310-1-git-send-email-chunfeng.yun@mediatek.com> X-Mailer: git-send-email 1.8.1.1.dirty MIME-Version: 1.0 X-TM-SNTS-SMTP: 2075714ACED72CBB15C4DCA956E5D8B2E8C542FC8427F2F77C2C39642685507E2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191113_183343_613512_862DD19C X-CRM114-Status: UNSURE ( 8.73 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Chunfeng Yun , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Wakeup_signal will toggle status according to ssusb_ip_sleep signal after debounce time, so need add a delay time and wait for wakeup_signal toggle to complete, then enable the remote wakeup. Meanwhile reduce the debounce time of wakeup_signal. These will avoid spurious wakeup event. Signed-off-by: Tianping Fang Signed-off-by: Chunfeng Yun --- Note, depends on following patch not merged: [v3,3/7] usb: mtu3: support ip-sleep wakeup for MT8183 https://patchwork.kernel.org/patch/11123151/ --- drivers/usb/mtu3/mtu3_host.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/mtu3/mtu3_host.c b/drivers/usb/mtu3/mtu3_host.c index 182c9439c15a..ca48ff751c8b 100644 --- a/drivers/usb/mtu3/mtu3_host.c +++ b/drivers/usb/mtu3/mtu3_host.c @@ -53,12 +53,12 @@ static void ssusb_wakeup_ip_sleep_set(struct ssusb_mtk *ssusb, bool enable) case SSUSB_UWK_V0: reg = ssusb->uwk_reg_base + PERI_WK_CTRL0; msk = (u32)(WC0_IS_EN | WC0_IS_C(0xf) | WC0_IS_P); - val = enable ? (WC0_IS_EN | WC0_IS_C(0x8)) : 0; + val = enable ? (WC0_IS_EN | WC0_IS_C(0x3)) : 0; break; case SSUSB_UWK_V1: reg = ssusb->uwk_reg_base + PERI_WK_CTRL1; msk = WC1_IS_EN | WC1_IS_C(0xf) | WC1_IS_P; - val = enable ? (WC1_IS_EN | WC1_IS_C(0x8)) : 0; + val = enable ? (WC1_IS_EN | WC1_IS_C(0x3)) : 0; break; case SSUSB_UWK_V2: reg = ssusb->uwk_reg_base + PERI_SSUSB_SPM_CTRL; @@ -197,6 +197,8 @@ int ssusb_host_disable(struct ssusb_mtk *ssusb, bool suspend) (value & SSUSB_IP_SLEEP_STS), 100, 100000); if (ret) dev_err(ssusb->dev, "ip sleep failed!!!\n"); + else /* wait for wakeup_signal toggle done after enter ip-sleep */ + usleep_range(245, 255); return ret; } -- 2.23.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel