From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9DCDC432C3 for ; Thu, 14 Nov 2019 16:41:27 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 4D4BC206DB for ; Thu, 14 Nov 2019 16:41:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D4BC206DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=solarflare.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 749F82BF9; Thu, 14 Nov 2019 17:41:19 +0100 (CET) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 8EB832BA8 for ; Thu, 14 Nov 2019 17:41:16 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us5.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 3F89480007A; Thu, 14 Nov 2019 16:41:15 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 14 Nov 2019 08:41:12 -0800 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Thu, 14 Nov 2019 08:41:11 -0800 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id xAEGfAgg009576; Thu, 14 Nov 2019 16:41:10 GMT Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id AD39D1613C8; Thu, 14 Nov 2019 16:41:10 +0000 (GMT) From: Andrew Rybchenko To: Thomas Monjalon , Ferruh Yigit CC: Date: Thu, 14 Nov 2019 16:40:52 +0000 Message-ID: <1573749654-30038-3-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1573749654-30038-1-git-send-email-arybchenko@solarflare.com> References: <1573749654-30038-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-25042.005 X-TM-AS-Result: No-4.237800-4.000000-10 X-TMASE-MatchedRID: B6v+5gVW3HJhv4jzslbU4vKUR83BvqItJih/yo+OvlVYwVHjLI3nekAc 6DyoS2rIK4hCkIu/HdihA3e4u5sFf3XUO7Q12FRiAoNa2r+Edw1JXeUbJfbZl5soi2XrUn/Js98 n9dYnJNNQSFbL1bvQASdET58jp62S3U+ODlvHRgKTydvs2VJIIRmdB+opHAbOQhQm3ORH1O3b2Z 4uSqlyaSLz5aGkjSrh7o+uuiHmMtOa90Tc3g0UkJI0Nwd2RrjJvU24pLfQFmdAgUhku2yAbQNQf 6dUs3KIKyog/1PG+0kxvqnnvSKWdw== X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--4.237800-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-25042.005 X-MDID: 1573749675-TNyHEqkfFUnN Subject: [dpdk-dev] [PATCH 3/3] ethdev: improve message about not disabled offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Avoid usaged of "failed" in the message about not requested but enabled offload, since it is not a failure. Fixes: 1daa33805824 ("ethdev: validate offloads set by PMD") Signed-off-by: Andrew Rybchenko --- lib/librte_ethdev/rte_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index 19ca08b04a..76d4a20ed3 100644 --- a/lib/librte_ethdev/rte_ethdev.c +++ b/lib/librte_ethdev/rte_ethdev.c @@ -1205,7 +1205,7 @@ validate_offloads(uint16_t port_id, uint64_t req_offloads, /* Chech if offload couldn't be disabled. */ if (offload & set_offloads) { RTE_ETHDEV_LOG(DEBUG, - "Port %u failed to disable %s offload %s\n", + "Port %u %s offload %s is not requested but enabled\n", port_id, offload_type, offload_name(offload)); } -- 2.17.1