From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754751Ab2DNKjy (ORCPT ); Sat, 14 Apr 2012 06:39:54 -0400 Received: from wolverine02.qualcomm.com ([199.106.114.251]:1135 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751011Ab2DNKjw (ORCPT ); Sat, 14 Apr 2012 06:39:52 -0400 X-IronPort-AV: E=McAfee;i="5400,1158,6679"; a="179409976" X-IronPort-AV: E=Sophos;i="4.75,420,1330934400"; d="scan'208";a="120359554" From: "Huang, Xiong" To: Ben Hutchings CC: "davem@davemloft.net" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , qca-linux-team , nic-devel , linux-pci Subject: RE: [PATCH 12/37] atl1c: restore max-read-request-size in Device Conrol Register Thread-Topic: [PATCH 12/37] atl1c: restore max-read-request-size in Device Conrol Register Thread-Index: AQHNGQq8J6Zbpt42tE6eV9My56f0MpaZcb6AgACpWoA= Date: Sat, 14 Apr 2012 10:39:51 +0000 Message-ID: <157393863283F442885425D2C454285623D4888F@nasanexd02a.na.qualcomm.com> References: <1334276102-15866-1-git-send-email-xiong@qca.qualcomm.com> <1334276102-15866-13-git-send-email-xiong@qca.qualcomm.com> <1334336563.2606.3.camel@bwh-desktop.uk.solarflarecom.com> In-Reply-To: <1334336563.2606.3.camel@bwh-desktop.uk.solarflarecom.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.30.39.5] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id q3EAe1Tt023441 > -----Original Message----- > From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] > On Behalf Of Ben Hutchings > Sent: Saturday, April 14, 2012 1:03 > To: Huang, Xiong > Cc: davem@davemloft.net; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; qca-linux-team; nic-devel; linux-pci > Subject: Re: [PATCH 12/37] atl1c: restore max-read-request-size in Device > Conrol Register > > On Fri, 2012-04-13 at 08:14 +0800, xiong wrote: > > in some platforms, we found the max-read-request-size in Device > > Control Register is set to 0 by (BIOS?) during bootup, this will cause > > the > > performance(throughput) very bad. > > Restore it to a min-value. > > register definition of REG_DEVICE_CTRL is refined as well. > [...] > > I'm guessing this memory-mapped register is an alias for the PCIe device control > register. I think you should be using pcie_set_readrq() to ensure that the final > setting conforms to the device's Max Payload Size and system policy. > You are right, I don't know there is a system function to do the right thing. I will revise it. Thanks Xiong {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Huang, Xiong" Subject: RE: [PATCH 12/37] atl1c: restore max-read-request-size in Device Conrol Register Date: Sat, 14 Apr 2012 10:39:51 +0000 Message-ID: <157393863283F442885425D2C454285623D4888F@nasanexd02a.na.qualcomm.com> References: <1334276102-15866-1-git-send-email-xiong@qca.qualcomm.com> <1334276102-15866-13-git-send-email-xiong@qca.qualcomm.com> <1334336563.2606.3.camel@bwh-desktop.uk.solarflarecom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "davem@davemloft.net" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , qca-linux-team , nic-devel , linux-pci To: Ben Hutchings Return-path: In-Reply-To: <1334336563.2606.3.camel@bwh-desktop.uk.solarflarecom.com> Content-Language: en-US Sender: linux-pci-owner@vger.kernel.org List-Id: netdev.vger.kernel.org DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogbmV0ZGV2LW93bmVyQHZn ZXIua2VybmVsLm9yZyBbbWFpbHRvOm5ldGRldi1vd25lckB2Z2VyLmtlcm5lbC5vcmddDQo+IE9u IEJlaGFsZiBPZiBCZW4gSHV0Y2hpbmdzDQo+IFNlbnQ6IFNhdHVyZGF5LCBBcHJpbCAxNCwgMjAx MiAxOjAzDQo+IFRvOiBIdWFuZywgWGlvbmcNCj4gQ2M6IGRhdmVtQGRhdmVtbG9mdC5uZXQ7IG5l dGRldkB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4LQ0KPiBrZXJuZWxAdmdlci5rZXJuZWwub3JnOyBx Y2EtbGludXgtdGVhbTsgbmljLWRldmVsOyBsaW51eC1wY2kNCj4gU3ViamVjdDogUmU6IFtQQVRD SCAxMi8zN10gYXRsMWM6IHJlc3RvcmUgbWF4LXJlYWQtcmVxdWVzdC1zaXplIGluIERldmljZQ0K PiBDb25yb2wgUmVnaXN0ZXINCj4gDQo+IE9uIEZyaSwgMjAxMi0wNC0xMyBhdCAwODoxNCArMDgw MCwgeGlvbmcgd3JvdGU6DQo+ID4gaW4gc29tZSBwbGF0Zm9ybXMsIHdlIGZvdW5kIHRoZSBtYXgt cmVhZC1yZXF1ZXN0LXNpemUgaW4gRGV2aWNlDQo+ID4gQ29udHJvbCBSZWdpc3RlciBpcyBzZXQg dG8gMCBieSAoQklPUz8pIGR1cmluZyBib290dXAsIHRoaXMgd2lsbCBjYXVzZQ0KPiA+IHRoZQ0K PiA+IHBlcmZvcm1hbmNlKHRocm91Z2hwdXQpIHZlcnkgYmFkLg0KPiA+IFJlc3RvcmUgaXQgdG8g YSBtaW4tdmFsdWUuDQo+ID4gcmVnaXN0ZXIgZGVmaW5pdGlvbiBvZiBSRUdfREVWSUNFX0NUUkwg aXMgcmVmaW5lZCBhcyB3ZWxsLg0KPiBbLi4uXQ0KPiANCj4gSSdtIGd1ZXNzaW5nIHRoaXMgbWVt b3J5LW1hcHBlZCByZWdpc3RlciBpcyBhbiBhbGlhcyBmb3IgdGhlIFBDSWUgZGV2aWNlIGNvbnRy b2wNCj4gcmVnaXN0ZXIuICBJIHRoaW5rIHlvdSBzaG91bGQgYmUgdXNpbmcgcGNpZV9zZXRfcmVh ZHJxKCkgdG8gZW5zdXJlIHRoYXQgdGhlIGZpbmFsDQo+IHNldHRpbmcgY29uZm9ybXMgdG8gdGhl IGRldmljZSdzIE1heCBQYXlsb2FkIFNpemUgYW5kIHN5c3RlbSBwb2xpY3kuDQo+IA0KWW91IGFy ZSByaWdodCwgSSBkb24ndCBrbm93IHRoZXJlIGlzIGEgc3lzdGVtIGZ1bmN0aW9uIHRvIGRvIHRo ZSByaWdodCB0aGluZy4gSSB3aWxsIHJldmlzZSBpdC4gDQoNClRoYW5rcw0KWGlvbmcNCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:1135 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751011Ab2DNKjw (ORCPT ); Sat, 14 Apr 2012 06:39:52 -0400 From: "Huang, Xiong" To: Ben Hutchings CC: "davem@davemloft.net" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , qca-linux-team , nic-devel , linux-pci Subject: RE: [PATCH 12/37] atl1c: restore max-read-request-size in Device Conrol Register Date: Sat, 14 Apr 2012 10:39:51 +0000 Message-ID: <157393863283F442885425D2C454285623D4888F@nasanexd02a.na.qualcomm.com> References: <1334276102-15866-1-git-send-email-xiong@qca.qualcomm.com> <1334276102-15866-13-git-send-email-xiong@qca.qualcomm.com> <1334336563.2606.3.camel@bwh-desktop.uk.solarflarecom.com> In-Reply-To: <1334336563.2606.3.camel@bwh-desktop.uk.solarflarecom.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org List-ID: DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogbmV0ZGV2LW93bmVyQHZn ZXIua2VybmVsLm9yZyBbbWFpbHRvOm5ldGRldi1vd25lckB2Z2VyLmtlcm5lbC5vcmddDQo+IE9u IEJlaGFsZiBPZiBCZW4gSHV0Y2hpbmdzDQo+IFNlbnQ6IFNhdHVyZGF5LCBBcHJpbCAxNCwgMjAx MiAxOjAzDQo+IFRvOiBIdWFuZywgWGlvbmcNCj4gQ2M6IGRhdmVtQGRhdmVtbG9mdC5uZXQ7IG5l dGRldkB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4LQ0KPiBrZXJuZWxAdmdlci5rZXJuZWwub3JnOyBx Y2EtbGludXgtdGVhbTsgbmljLWRldmVsOyBsaW51eC1wY2kNCj4gU3ViamVjdDogUmU6IFtQQVRD SCAxMi8zN10gYXRsMWM6IHJlc3RvcmUgbWF4LXJlYWQtcmVxdWVzdC1zaXplIGluIERldmljZQ0K PiBDb25yb2wgUmVnaXN0ZXINCj4gDQo+IE9uIEZyaSwgMjAxMi0wNC0xMyBhdCAwODoxNCArMDgw MCwgeGlvbmcgd3JvdGU6DQo+ID4gaW4gc29tZSBwbGF0Zm9ybXMsIHdlIGZvdW5kIHRoZSBtYXgt cmVhZC1yZXF1ZXN0LXNpemUgaW4gRGV2aWNlDQo+ID4gQ29udHJvbCBSZWdpc3RlciBpcyBzZXQg dG8gMCBieSAoQklPUz8pIGR1cmluZyBib290dXAsIHRoaXMgd2lsbCBjYXVzZQ0KPiA+IHRoZQ0K PiA+IHBlcmZvcm1hbmNlKHRocm91Z2hwdXQpIHZlcnkgYmFkLg0KPiA+IFJlc3RvcmUgaXQgdG8g YSBtaW4tdmFsdWUuDQo+ID4gcmVnaXN0ZXIgZGVmaW5pdGlvbiBvZiBSRUdfREVWSUNFX0NUUkwg aXMgcmVmaW5lZCBhcyB3ZWxsLg0KPiBbLi4uXQ0KPiANCj4gSSdtIGd1ZXNzaW5nIHRoaXMgbWVt b3J5LW1hcHBlZCByZWdpc3RlciBpcyBhbiBhbGlhcyBmb3IgdGhlIFBDSWUgZGV2aWNlIGNvbnRy b2wNCj4gcmVnaXN0ZXIuICBJIHRoaW5rIHlvdSBzaG91bGQgYmUgdXNpbmcgcGNpZV9zZXRfcmVh ZHJxKCkgdG8gZW5zdXJlIHRoYXQgdGhlIGZpbmFsDQo+IHNldHRpbmcgY29uZm9ybXMgdG8gdGhl IGRldmljZSdzIE1heCBQYXlsb2FkIFNpemUgYW5kIHN5c3RlbSBwb2xpY3kuDQo+IA0KWW91IGFy ZSByaWdodCwgSSBkb24ndCBrbm93IHRoZXJlIGlzIGEgc3lzdGVtIGZ1bmN0aW9uIHRvIGRvIHRo ZSByaWdodCB0aGluZy4gSSB3aWxsIHJldmlzZSBpdC4gDQoNClRoYW5rcw0KWGlvbmcNCg0K