All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] PCI: exynos: Use PTR_ERR_OR_ZERO() to simplify code
@ 2019-11-18 11:28 ` zhengbin
  0 siblings, 0 replies; 6+ messages in thread
From: zhengbin @ 2019-11-18 11:28 UTC (permalink / raw)
  To: jingoohan1, lorenzo.pieralisi, andrew.murray, bhelgaas, kgene,
	linux-pci, linux-arm-kernel
  Cc: zhengbin13

Fixes coccicheck warning:

drivers/pci/controller/dwc/pci-exynos.c:95:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 drivers/pci/controller/dwc/pci-exynos.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/pci/controller/dwc/pci-exynos.c b/drivers/pci/controller/dwc/pci-exynos.c
index 14a6ba4..6c9509d 100644
--- a/drivers/pci/controller/dwc/pci-exynos.c
+++ b/drivers/pci/controller/dwc/pci-exynos.c
@@ -92,10 +92,7 @@ static int exynos5440_pcie_get_mem_resources(struct platform_device *pdev,

 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	ep->mem_res->elbi_base = devm_ioremap_resource(dev, res);
-	if (IS_ERR(ep->mem_res->elbi_base))
-		return PTR_ERR(ep->mem_res->elbi_base);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(ep->mem_res->elbi_base);
 }

 static int exynos5440_pcie_get_clk_resources(struct exynos_pcie *ep)
--
2.7.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] PCI: exynos: Use PTR_ERR_OR_ZERO() to simplify code
@ 2019-11-18 11:28 ` zhengbin
  0 siblings, 0 replies; 6+ messages in thread
From: zhengbin @ 2019-11-18 11:28 UTC (permalink / raw)
  To: jingoohan1, lorenzo.pieralisi, andrew.murray, bhelgaas, kgene,
	linux-pci, linux-arm-kernel
  Cc: zhengbin13

Fixes coccicheck warning:

drivers/pci/controller/dwc/pci-exynos.c:95:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 drivers/pci/controller/dwc/pci-exynos.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/pci/controller/dwc/pci-exynos.c b/drivers/pci/controller/dwc/pci-exynos.c
index 14a6ba4..6c9509d 100644
--- a/drivers/pci/controller/dwc/pci-exynos.c
+++ b/drivers/pci/controller/dwc/pci-exynos.c
@@ -92,10 +92,7 @@ static int exynos5440_pcie_get_mem_resources(struct platform_device *pdev,

 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	ep->mem_res->elbi_base = devm_ioremap_resource(dev, res);
-	if (IS_ERR(ep->mem_res->elbi_base))
-		return PTR_ERR(ep->mem_res->elbi_base);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(ep->mem_res->elbi_base);
 }

 static int exynos5440_pcie_get_clk_resources(struct exynos_pcie *ep)
--
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] PCI: exynos: Use PTR_ERR_OR_ZERO() to simplify code
  2019-11-18 11:28 ` zhengbin
@ 2019-11-18 16:35   ` Jingoo Han
  -1 siblings, 0 replies; 6+ messages in thread
From: Jingoo Han @ 2019-11-18 16:35 UTC (permalink / raw)
  To: zhengbin, lorenzo.pieralisi, andrew.murray, bhelgaas, kgene,
	linux-pci, linux-arm-kernel
  Cc: Han Jingoo

On 11/18/19, 6:20 AM, zhengbin wrote:
>
> Fixes coccicheck warning:
>
> drivers/pci/controller/dwc/pci-exynos.c:95:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>

Please write your full name correctly (First name + Second name). 
If 'zhengbin' is just your first name, you have to add your second name.
Or, if  'zhengbin' is already your full name, please separate it with capitalized characters and spaces,
for example, 'Zheng Bin'.

> ---
>  drivers/pci/controller/dwc/pci-exynos.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>

[.....]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] PCI: exynos: Use PTR_ERR_OR_ZERO() to simplify code
@ 2019-11-18 16:35   ` Jingoo Han
  0 siblings, 0 replies; 6+ messages in thread
From: Jingoo Han @ 2019-11-18 16:35 UTC (permalink / raw)
  To: zhengbin, lorenzo.pieralisi, andrew.murray, bhelgaas, kgene,
	linux-pci, linux-arm-kernel
  Cc: Han Jingoo

On 11/18/19, 6:20 AM, zhengbin wrote:
>
> Fixes coccicheck warning:
>
> drivers/pci/controller/dwc/pci-exynos.c:95:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>

Please write your full name correctly (First name + Second name). 
If 'zhengbin' is just your first name, you have to add your second name.
Or, if  'zhengbin' is already your full name, please separate it with capitalized characters and spaces,
for example, 'Zheng Bin'.

> ---
>  drivers/pci/controller/dwc/pci-exynos.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>

[.....]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] PCI: exynos: Use PTR_ERR_OR_ZERO() to simplify code
  2019-11-18 16:35   ` Jingoo Han
@ 2019-11-19  1:19     ` zhengbin (A)
  -1 siblings, 0 replies; 6+ messages in thread
From: zhengbin (A) @ 2019-11-19  1:19 UTC (permalink / raw)
  To: Jingoo Han, lorenzo.pieralisi, andrew.murray, bhelgaas, kgene,
	linux-pci, linux-arm-kernel


On 2019/11/19 0:35, Jingoo Han wrote:
> On 11/18/19, 6:20 AM, zhengbin wrote:
>> Fixes coccicheck warning:
>>
>> drivers/pci/controller/dwc/pci-exynos.c:95:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: zhengbin <zhengbin13@huawei.com>
> Please write your full name correctly (First name + Second name). 
> If 'zhengbin' is just your first name, you have to add your second name.
> Or, if  'zhengbin' is already your full name, please separate it with capitalized characters and spaces,
> for example, 'Zheng Bin'.

thanks for your remind. In the previous patch, this is rejected, see details on

https://lkml.org/lkml/2019/5/31/535

So please ignore it

>
>> ---
>>  drivers/pci/controller/dwc/pci-exynos.c | 5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>
> [.....]
>
> .
>


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] PCI: exynos: Use PTR_ERR_OR_ZERO() to simplify code
@ 2019-11-19  1:19     ` zhengbin (A)
  0 siblings, 0 replies; 6+ messages in thread
From: zhengbin (A) @ 2019-11-19  1:19 UTC (permalink / raw)
  To: Jingoo Han, lorenzo.pieralisi, andrew.murray, bhelgaas, kgene,
	linux-pci, linux-arm-kernel


On 2019/11/19 0:35, Jingoo Han wrote:
> On 11/18/19, 6:20 AM, zhengbin wrote:
>> Fixes coccicheck warning:
>>
>> drivers/pci/controller/dwc/pci-exynos.c:95:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: zhengbin <zhengbin13@huawei.com>
> Please write your full name correctly (First name + Second name). 
> If 'zhengbin' is just your first name, you have to add your second name.
> Or, if  'zhengbin' is already your full name, please separate it with capitalized characters and spaces,
> for example, 'Zheng Bin'.

thanks for your remind. In the previous patch, this is rejected, see details on

https://lkml.org/lkml/2019/5/31/535

So please ignore it

>
>> ---
>>  drivers/pci/controller/dwc/pci-exynos.c | 5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>
> [.....]
>
> .
>


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-11-19  1:20 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-18 11:28 [PATCH] PCI: exynos: Use PTR_ERR_OR_ZERO() to simplify code zhengbin
2019-11-18 11:28 ` zhengbin
2019-11-18 16:35 ` Jingoo Han
2019-11-18 16:35   ` Jingoo Han
2019-11-19  1:19   ` zhengbin (A)
2019-11-19  1:19     ` zhengbin (A)

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.