From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D06C9C43215 for ; Tue, 19 Nov 2019 20:13:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 95FF022317 for ; Tue, 19 Nov 2019 20:13:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="pmg80JZE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727222AbfKSUNG (ORCPT ); Tue, 19 Nov 2019 15:13:06 -0500 Received: from mail-qt1-f194.google.com ([209.85.160.194]:44355 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726892AbfKSUNF (ORCPT ); Tue, 19 Nov 2019 15:13:05 -0500 Received: by mail-qt1-f194.google.com with SMTP id o11so26087808qtr.11 for ; Tue, 19 Nov 2019 12:13:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=Dwf1aPW+I4uJ8oN51QPPu2dFggZ3HdhgD621r7zy2tg=; b=pmg80JZEFAAk2QOJmAgvddvAMg2LRJ/Dw7ZNwsSthRqWP8Mt5yIjRaGdh6PV6/Puql UiicJF/qqZAN7vTybwrm3hLqYTeiHvKhuRqxDqpBOsvBTVZwlPIqNA8snoR7J5VClKj5 eX9r9BUleXvAPIh6zQ/YicDwxGnUHGVwyBh1wOJkcfRzhnZGJC23h/cGlBRlW+Ah+5eD fupjg6MxhTuqsdKeL0ft3syF8ui/mnNhUn4xZVu3xaM4MIZGXgbXC0nzneU8x11yeLBG h1XLrQaFSfB9hG9vQ9V3uKivnnSZy9RJo+qcU1YAe5U9nHDJcy/6I7ohU/oc9y96ZerJ vSIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=Dwf1aPW+I4uJ8oN51QPPu2dFggZ3HdhgD621r7zy2tg=; b=XyU5Q57RQychkNCqIreHny5uTeYxg30hbzGXWJHhcZ2sZyVo460fV6t7+yizzadwyc D6AXQE1DnSfuTbCSz61wMvLf8885GUldUoWMtGaIbMm6IiELaMN4/Ove5gtFNjRRfwH4 reJGRg9dl7ry8Ifx6/cyHMhpYGAd7gHQRl/lBCJUL2tfOvCy0uAWWhu/IwMUfY/GleZv ARB/R+ZpiYnVNHMvuewtAIB8mii57bW1n9Xmg2xQpFyU1bb2yepVmOFrpJubdSXbJhvF b5JnMYup/0iqnb1414ctEF+Qb/iRfJgS4b8FlaCsO6IDZDQ5RaQnunniDt2BEDjDXgMg orAg== X-Gm-Message-State: APjAAAW0cK9UoN6h3zULBoBw3bUgNzoEjW03V99kuAQaFA81667nlx+a 6fI88HT1EpL9qSL3ETW8H0ybig== X-Google-Smtp-Source: APXvYqyIDfBPrM524yJAH7oDAah64qeBSQEqEF0MXdB+a7/R9k+0IJN7c0gzqWN86IDbfDGVy1SPew== X-Received: by 2002:ac8:22c4:: with SMTP id g4mr34398685qta.45.1574194383599; Tue, 19 Nov 2019 12:13:03 -0800 (PST) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id i10sm11900621qtj.19.2019.11.19.12.13.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Nov 2019 12:13:02 -0800 (PST) Message-ID: <1574194379.9585.10.camel@lca.pw> Subject: Re: [PATCH v4 00/10] Add Kernel Concurrency Sanitizer (KCSAN) From: Qian Cai To: Marco Elver Cc: akiyks@gmail.com, stern@rowland.harvard.edu, glider@google.com, parri.andrea@gmail.com, andreyknvl@google.com, luto@kernel.org, ard.biesheuvel@linaro.org, arnd@arndb.de, boqun.feng@gmail.com, bp@alien8.de, dja@axtens.net, dlustig@nvidia.com, dave.hansen@linux.intel.com, dhowells@redhat.com, dvyukov@google.com, hpa@zytor.com, mingo@redhat.com, j.alglave@ucl.ac.uk, joel@joelfernandes.org, corbet@lwn.net, jpoimboe@redhat.com, luc.maranget@inria.fr, mark.rutland@arm.com, npiggin@gmail.com, paulmck@kernel.org, peterz@infradead.org, tglx@linutronix.de, will@kernel.org, edumazet@google.com, kasan-dev@googlegroups.com, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-efi@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Date: Tue, 19 Nov 2019 15:12:59 -0500 In-Reply-To: <20191114180303.66955-1-elver@google.com> References: <20191114180303.66955-1-elver@google.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2019-11-14 at 19:02 +0100, 'Marco Elver' via kasan-dev wrote: > This is the patch-series for the Kernel Concurrency Sanitizer (KCSAN). > KCSAN is a sampling watchpoint-based *data race detector*. More details > are included in **Documentation/dev-tools/kcsan.rst**. This patch-series > only enables KCSAN for x86, but we expect adding support for other > architectures is relatively straightforward (we are aware of > experimental ARM64 and POWER support). This does not allow the system to boot. Just hang forever at the end. https://cailca.github.io/files/dmesg.txt the config (dselect KASAN and select KCSAN with default options): https://raw.githubusercontent.com/cailca/linux-mm/master/x86.config > > To gather early feedback, we announced KCSAN back in September, and have > integrated the feedback where possible: > http://lkml.kernel.org/r/CANpmjNPJ_bHjfLZCAPV23AXFfiPiyXXqqu72n6TgWzb2Gnu1eA@mail.gmail.com > > The current list of known upstream fixes for data races found by KCSAN > can be found here: > https://github.com/google/ktsan/wiki/KCSAN#upstream-fixes-of-data-races-found-by-kcsan > > We want to point out and acknowledge the work surrounding the LKMM, > including several articles that motivate why data races are dangerous > [1, 2], justifying a data race detector such as KCSAN. > > [1] https://lwn.net/Articles/793253/ > [2] https://lwn.net/Articles/799218/ > > Race conditions vs. data races > ------------------------------ > > Race conditions are logic bugs, where unexpected interleaving of racing > concurrent operations result in an erroneous state. > > Data races on the other hand are defined at the *memory model/language > level*. Many data races are also harmful race conditions, which a tool > like KCSAN reports! However, not all data races are race conditions and > vice-versa. KCSAN's intent is to report data races according to the > LKMM. A data race detector can only work at the memory model/language > level. > > Deeper analysis, to find high-level race conditions only, requires > conveying the intended kernel logic to a tool. This requires (1) the > developer writing a specification or model of their code, and then (2) > the tool verifying that the implementation matches. This has been done > for small bits of code using model checkers and other formal methods, > but does not scale to the level of what can be covered with a dynamic > analysis based data race detector such as KCSAN. > > For reasons outlined in [1, 2], data races can be much more subtle, but > can cause no less harm than high-level race conditions. > > Changelog > --------- > v4: > * Major changes: > - Optimizations resulting in performance improvement of 33% (on > microbenchmark). > - Deal with nested interrupts for atomic_next. > - Simplify report.c (removing double-locking as well), in preparation > for KCSAN_REPORT_VALUE_CHANGE_ONLY. > - Add patch to introduce "data_race(expr)" macro. > - Introduce KCSAN_REPORT_VALUE_CHANGE_ONLY option for further filtering of data > races: if a conflicting write was observed via a watchpoint, only report the > data race if a value change was observed as well. The option will be enabled > by default on syzbot. (rcu-functions will be excluded from this filter at > request of Paul McKenney.) Context: > http://lkml.kernel.org/r/CANpmjNOepvb6+zJmDePxj21n2rctM4Sp4rJ66x_J-L1UmNK54A@mail.gmail.com > > v3: http://lkml.kernel.org/r/20191104142745.14722-1-elver@google.com > * Major changes: > - Add microbenchmark. > - Add instruction watchpoint skip randomization. > - Refactor API and core runtime fast-path and slow-path. Compared to > the previous version, with a default config and benchmarked using the > added microbenchmark, this version is 3.8x faster. > - Make __tsan_unaligned __alias of generic accesses. > - Rename kcsan_{begin,end}_atomic -> > kcsan_{nestable,flat}_atomic_{begin,end} > - For filter list in debugfs.c use kmalloc+krealloc instead of > kvmalloc. > - Split Documentation into separate patch. > > v2: http://lkml.kernel.org/r/20191017141305.146193-1-elver@google.com > * Major changes: > - Replace kcsan_check_access(.., {true, false}) with > kcsan_check_{read,write}. > - Change atomic-instrumented.h to use __atomic_check_{read,write}. > - Use common struct kcsan_ctx in task_struct and for per-CPU interrupt > contexts. > > v1: http://lkml.kernel.org/r/20191016083959.186860-1-elver@google.com > > Marco Elver (10): > kcsan: Add Kernel Concurrency Sanitizer infrastructure > include/linux/compiler.h: Introduce data_race(expr) macro > kcsan: Add Documentation entry in dev-tools > objtool, kcsan: Add KCSAN runtime functions to whitelist > build, kcsan: Add KCSAN build exceptions > seqlock, kcsan: Add annotations for KCSAN > seqlock: Require WRITE_ONCE surrounding raw_seqcount_barrier > asm-generic, kcsan: Add KCSAN instrumentation for bitops > locking/atomics, kcsan: Add KCSAN instrumentation > x86, kcsan: Enable KCSAN for x86 > > Documentation/dev-tools/index.rst | 1 + > Documentation/dev-tools/kcsan.rst | 256 +++++++++ > MAINTAINERS | 11 + > Makefile | 3 +- > arch/x86/Kconfig | 1 + > arch/x86/boot/Makefile | 2 + > arch/x86/boot/compressed/Makefile | 2 + > arch/x86/entry/vdso/Makefile | 3 + > arch/x86/include/asm/bitops.h | 6 +- > arch/x86/kernel/Makefile | 4 + > arch/x86/kernel/cpu/Makefile | 3 + > arch/x86/lib/Makefile | 4 + > arch/x86/mm/Makefile | 4 + > arch/x86/purgatory/Makefile | 2 + > arch/x86/realmode/Makefile | 3 + > arch/x86/realmode/rm/Makefile | 3 + > drivers/firmware/efi/libstub/Makefile | 2 + > include/asm-generic/atomic-instrumented.h | 393 +++++++------- > include/asm-generic/bitops-instrumented.h | 18 + > include/linux/compiler-clang.h | 9 + > include/linux/compiler-gcc.h | 7 + > include/linux/compiler.h | 57 +- > include/linux/kcsan-checks.h | 97 ++++ > include/linux/kcsan.h | 115 ++++ > include/linux/sched.h | 4 + > include/linux/seqlock.h | 51 +- > init/init_task.c | 8 + > init/main.c | 2 + > kernel/Makefile | 6 + > kernel/kcsan/Makefile | 11 + > kernel/kcsan/atomic.h | 27 + > kernel/kcsan/core.c | 626 ++++++++++++++++++++++ > kernel/kcsan/debugfs.c | 275 ++++++++++ > kernel/kcsan/encoding.h | 94 ++++ > kernel/kcsan/kcsan.h | 108 ++++ > kernel/kcsan/report.c | 320 +++++++++++ > kernel/kcsan/test.c | 121 +++++ > kernel/sched/Makefile | 6 + > lib/Kconfig.debug | 2 + > lib/Kconfig.kcsan | 118 ++++ > lib/Makefile | 3 + > mm/Makefile | 8 + > scripts/Makefile.kcsan | 6 + > scripts/Makefile.lib | 10 + > scripts/atomic/gen-atomic-instrumented.sh | 17 +- > tools/objtool/check.c | 18 + > 46 files changed, 2641 insertions(+), 206 deletions(-) > create mode 100644 Documentation/dev-tools/kcsan.rst > create mode 100644 include/linux/kcsan-checks.h > create mode 100644 include/linux/kcsan.h > create mode 100644 kernel/kcsan/Makefile > create mode 100644 kernel/kcsan/atomic.h > create mode 100644 kernel/kcsan/core.c > create mode 100644 kernel/kcsan/debugfs.c > create mode 100644 kernel/kcsan/encoding.h > create mode 100644 kernel/kcsan/kcsan.h > create mode 100644 kernel/kcsan/report.c > create mode 100644 kernel/kcsan/test.c > create mode 100644 lib/Kconfig.kcsan > create mode 100644 scripts/Makefile.kcsan > > -- > 2.24.0.rc1.363.gb1bccd3e3d-goog > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Qian Cai Subject: Re: [PATCH v4 00/10] Add Kernel Concurrency Sanitizer (KCSAN) Date: Tue, 19 Nov 2019 15:12:59 -0500 Message-ID: <1574194379.9585.10.camel@lca.pw> References: <20191114180303.66955-1-elver@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20191114180303.66955-1-elver@google.com> Sender: linux-kernel-owner@vger.kernel.org To: Marco Elver Cc: akiyks@gmail.com, stern@rowland.harvard.edu, glider@google.com, parri.andrea@gmail.com, andreyknvl@google.com, luto@kernel.org, ard.biesheuvel@linaro.org, arnd@arndb.de, boqun.feng@gmail.com, bp@alien8.de, dja@axtens.net, dlustig@nvidia.com, dave.hansen@linux.intel.com, dhowells@redhat.com, dvyukov@google.com, hpa@zytor.com, mingo@redhat.com, j.alglave@ucl.ac.uk, joel@joelfernandes.org, corbet@lwn.net, jpoimboe@redhat.com, luc.maranget@inria.fr, mark.rutland@arm.com, npiggin@gmail.com, paulmck@kernel.org, peterz@infradead.org, tglx@linutronix.de, will@kernel.org, edumazet@google.com, kasan-dev@googlegroups.com, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-efi@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel. List-Id: linux-arch.vger.kernel.org On Thu, 2019-11-14 at 19:02 +0100, 'Marco Elver' via kasan-dev wrote: > This is the patch-series for the Kernel Concurrency Sanitizer (KCSAN). > KCSAN is a sampling watchpoint-based *data race detector*. More details > are included in **Documentation/dev-tools/kcsan.rst**. This patch-series > only enables KCSAN for x86, but we expect adding support for other > architectures is relatively straightforward (we are aware of > experimental ARM64 and POWER support). This does not allow the system to boot. Just hang forever at the end. https://cailca.github.io/files/dmesg.txt the config (dselect KASAN and select KCSAN with default options): https://raw.githubusercontent.com/cailca/linux-mm/master/x86.config > > To gather early feedback, we announced KCSAN back in September, and have > integrated the feedback where possible: > http://lkml.kernel.org/r/CANpmjNPJ_bHjfLZCAPV23AXFfiPiyXXqqu72n6TgWzb2Gnu1eA@mail.gmail.com > > The current list of known upstream fixes for data races found by KCSAN > can be found here: > https://github.com/google/ktsan/wiki/KCSAN#upstream-fixes-of-data-races-found-by-kcsan > > We want to point out and acknowledge the work surrounding the LKMM, > including several articles that motivate why data races are dangerous > [1, 2], justifying a data race detector such as KCSAN. > > [1] https://lwn.net/Articles/793253/ > [2] https://lwn.net/Articles/799218/ > > Race conditions vs. data races > ------------------------------ > > Race conditions are logic bugs, where unexpected interleaving of racing > concurrent operations result in an erroneous state. > > Data races on the other hand are defined at the *memory model/language > level*. Many data races are also harmful race conditions, which a tool > like KCSAN reports! However, not all data races are race conditions and > vice-versa. KCSAN's intent is to report data races according to the > LKMM. A data race detector can only work at the memory model/language > level. > > Deeper analysis, to find high-level race conditions only, requires > conveying the intended kernel logic to a tool. This requires (1) the > developer writing a specification or model of their code, and then (2) > the tool verifying that the implementation matches. This has been done > for small bits of code using model checkers and other formal methods, > but does not scale to the level of what can be covered with a dynamic > analysis based data race detector such as KCSAN. > > For reasons outlined in [1, 2], data races can be much more subtle, but > can cause no less harm than high-level race conditions. > > Changelog > --------- > v4: > * Major changes: > - Optimizations resulting in performance improvement of 33% (on > microbenchmark). > - Deal with nested interrupts for atomic_next. > - Simplify report.c (removing double-locking as well), in preparation > for KCSAN_REPORT_VALUE_CHANGE_ONLY. > - Add patch to introduce "data_race(expr)" macro. > - Introduce KCSAN_REPORT_VALUE_CHANGE_ONLY option for further filtering of data > races: if a conflicting write was observed via a watchpoint, only report the > data race if a value change was observed as well. The option will be enabled > by default on syzbot. (rcu-functions will be excluded from this filter at > request of Paul McKenney.) Context: > http://lkml.kernel.org/r/CANpmjNOepvb6+zJmDePxj21n2rctM4Sp4rJ66x_J-L1UmNK54A@mail.gmail.com > > v3: http://lkml.kernel.org/r/20191104142745.14722-1-elver@google.com > * Major changes: > - Add microbenchmark. > - Add instruction watchpoint skip randomization. > - Refactor API and core runtime fast-path and slow-path. Compared to > the previous version, with a default config and benchmarked using the > added microbenchmark, this version is 3.8x faster. > - Make __tsan_unaligned __alias of generic accesses. > - Rename kcsan_{begin,end}_atomic -> > kcsan_{nestable,flat}_atomic_{begin,end} > - For filter list in debugfs.c use kmalloc+krealloc instead of > kvmalloc. > - Split Documentation into separate patch. > > v2: http://lkml.kernel.org/r/20191017141305.146193-1-elver@google.com > * Major changes: > - Replace kcsan_check_access(.., {true, false}) with > kcsan_check_{read,write}. > - Change atomic-instrumented.h to use __atomic_check_{read,write}. > - Use common struct kcsan_ctx in task_struct and for per-CPU interrupt > contexts. > > v1: http://lkml.kernel.org/r/20191016083959.186860-1-elver@google.com > > Marco Elver (10): > kcsan: Add Kernel Concurrency Sanitizer infrastructure > include/linux/compiler.h: Introduce data_race(expr) macro > kcsan: Add Documentation entry in dev-tools > objtool, kcsan: Add KCSAN runtime functions to whitelist > build, kcsan: Add KCSAN build exceptions > seqlock, kcsan: Add annotations for KCSAN > seqlock: Require WRITE_ONCE surrounding raw_seqcount_barrier > asm-generic, kcsan: Add KCSAN instrumentation for bitops > locking/atomics, kcsan: Add KCSAN instrumentation > x86, kcsan: Enable KCSAN for x86 > > Documentation/dev-tools/index.rst | 1 + > Documentation/dev-tools/kcsan.rst | 256 +++++++++ > MAINTAINERS | 11 + > Makefile | 3 +- > arch/x86/Kconfig | 1 + > arch/x86/boot/Makefile | 2 + > arch/x86/boot/compressed/Makefile | 2 + > arch/x86/entry/vdso/Makefile | 3 + > arch/x86/include/asm/bitops.h | 6 +- > arch/x86/kernel/Makefile | 4 + > arch/x86/kernel/cpu/Makefile | 3 + > arch/x86/lib/Makefile | 4 + > arch/x86/mm/Makefile | 4 + > arch/x86/purgatory/Makefile | 2 + > arch/x86/realmode/Makefile | 3 + > arch/x86/realmode/rm/Makefile | 3 + > drivers/firmware/efi/libstub/Makefile | 2 + > include/asm-generic/atomic-instrumented.h | 393 +++++++------- > include/asm-generic/bitops-instrumented.h | 18 + > include/linux/compiler-clang.h | 9 + > include/linux/compiler-gcc.h | 7 + > include/linux/compiler.h | 57 +- > include/linux/kcsan-checks.h | 97 ++++ > include/linux/kcsan.h | 115 ++++ > include/linux/sched.h | 4 + > include/linux/seqlock.h | 51 +- > init/init_task.c | 8 + > init/main.c | 2 + > kernel/Makefile | 6 + > kernel/kcsan/Makefile | 11 + > kernel/kcsan/atomic.h | 27 + > kernel/kcsan/core.c | 626 ++++++++++++++++++++++ > kernel/kcsan/debugfs.c | 275 ++++++++++ > kernel/kcsan/encoding.h | 94 ++++ > kernel/kcsan/kcsan.h | 108 ++++ > kernel/kcsan/report.c | 320 +++++++++++ > kernel/kcsan/test.c | 121 +++++ > kernel/sched/Makefile | 6 + > lib/Kconfig.debug | 2 + > lib/Kconfig.kcsan | 118 ++++ > lib/Makefile | 3 + > mm/Makefile | 8 + > scripts/Makefile.kcsan | 6 + > scripts/Makefile.lib | 10 + > scripts/atomic/gen-atomic-instrumented.sh | 17 +- > tools/objtool/check.c | 18 + > 46 files changed, 2641 insertions(+), 206 deletions(-) > create mode 100644 Documentation/dev-tools/kcsan.rst > create mode 100644 include/linux/kcsan-checks.h > create mode 100644 include/linux/kcsan.h > create mode 100644 kernel/kcsan/Makefile > create mode 100644 kernel/kcsan/atomic.h > create mode 100644 kernel/kcsan/core.c > create mode 100644 kernel/kcsan/debugfs.c > create mode 100644 kernel/kcsan/encoding.h > create mode 100644 kernel/kcsan/kcsan.h > create mode 100644 kernel/kcsan/report.c > create mode 100644 kernel/kcsan/test.c > create mode 100644 lib/Kconfig.kcsan > create mode 100644 scripts/Makefile.kcsan > > -- > 2.24.0.rc1.363.gb1bccd3e3d-goog > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61FFBC432C0 for ; Tue, 19 Nov 2019 20:13:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1AF3B22444 for ; Tue, 19 Nov 2019 20:13:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="pmg80JZE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1AF3B22444 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A7F266B0003; Tue, 19 Nov 2019 15:13:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A57C16B0006; Tue, 19 Nov 2019 15:13:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 96DFF6B0007; Tue, 19 Nov 2019 15:13:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0091.hostedemail.com [216.40.44.91]) by kanga.kvack.org (Postfix) with ESMTP id 7CEFC6B0003 for ; Tue, 19 Nov 2019 15:13:05 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 2A1D8181AEF09 for ; Tue, 19 Nov 2019 20:13:05 +0000 (UTC) X-FDA: 76174125930.10.robin46_37f736c555363 X-HE-Tag: robin46_37f736c555363 X-Filterd-Recvd-Size: 12116 Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Tue, 19 Nov 2019 20:13:04 +0000 (UTC) Received: by mail-qt1-f193.google.com with SMTP id t20so26105265qtn.9 for ; Tue, 19 Nov 2019 12:13:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=Dwf1aPW+I4uJ8oN51QPPu2dFggZ3HdhgD621r7zy2tg=; b=pmg80JZEFAAk2QOJmAgvddvAMg2LRJ/Dw7ZNwsSthRqWP8Mt5yIjRaGdh6PV6/Puql UiicJF/qqZAN7vTybwrm3hLqYTeiHvKhuRqxDqpBOsvBTVZwlPIqNA8snoR7J5VClKj5 eX9r9BUleXvAPIh6zQ/YicDwxGnUHGVwyBh1wOJkcfRzhnZGJC23h/cGlBRlW+Ah+5eD fupjg6MxhTuqsdKeL0ft3syF8ui/mnNhUn4xZVu3xaM4MIZGXgbXC0nzneU8x11yeLBG h1XLrQaFSfB9hG9vQ9V3uKivnnSZy9RJo+qcU1YAe5U9nHDJcy/6I7ohU/oc9y96ZerJ vSIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=Dwf1aPW+I4uJ8oN51QPPu2dFggZ3HdhgD621r7zy2tg=; b=XumU5fxHha4BV+0c7BXpdzZZhkRqWCs8Ui0+CBJxKERQgkdYHSw72w7hPxgencj5P7 18FbgERdiEY/mLl5tCnaNJb/b5ryBZdTmslGDkkfNFOL8FTiXqWdUANDx1bwAzIpaUFv BW4Sk/Xcsao+Q8w9QRuSHX1PpxjP2V9n1ikdq+NAK57SWU11hEMvNcf2yl3W0nvyn8IT GEBPkUrs9+E/doTh4hb4zBaWiiwJSvnupGDaEQWaPJz+ondQ/aiSpatFWNuglpadBNHQ qtbhyjlaf0kVB+5O4WGOYo6BMrStdNs7qu11Xtv9G5ekJjWUFhXyFvJ+71aiBHtmr07B SHAg== X-Gm-Message-State: APjAAAVoOYyoWOIb5XmXFp1xvlUiu0h6D6aQ9r5nSGFih4qZ4WLO7qCW +3MIFJPVnb4eTEGubMxy22ANNw== X-Google-Smtp-Source: APXvYqyIDfBPrM524yJAH7oDAah64qeBSQEqEF0MXdB+a7/R9k+0IJN7c0gzqWN86IDbfDGVy1SPew== X-Received: by 2002:ac8:22c4:: with SMTP id g4mr34398685qta.45.1574194383599; Tue, 19 Nov 2019 12:13:03 -0800 (PST) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id i10sm11900621qtj.19.2019.11.19.12.13.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Nov 2019 12:13:02 -0800 (PST) Message-ID: <1574194379.9585.10.camel@lca.pw> Subject: Re: [PATCH v4 00/10] Add Kernel Concurrency Sanitizer (KCSAN) From: Qian Cai To: Marco Elver Cc: akiyks@gmail.com, stern@rowland.harvard.edu, glider@google.com, parri.andrea@gmail.com, andreyknvl@google.com, luto@kernel.org, ard.biesheuvel@linaro.org, arnd@arndb.de, boqun.feng@gmail.com, bp@alien8.de, dja@axtens.net, dlustig@nvidia.com, dave.hansen@linux.intel.com, dhowells@redhat.com, dvyukov@google.com, hpa@zytor.com, mingo@redhat.com, j.alglave@ucl.ac.uk, joel@joelfernandes.org, corbet@lwn.net, jpoimboe@redhat.com, luc.maranget@inria.fr, mark.rutland@arm.com, npiggin@gmail.com, paulmck@kernel.org, peterz@infradead.org, tglx@linutronix.de, will@kernel.org, edumazet@google.com, kasan-dev@googlegroups.com, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-efi@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Date: Tue, 19 Nov 2019 15:12:59 -0500 In-Reply-To: <20191114180303.66955-1-elver@google.com> References: <20191114180303.66955-1-elver@google.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 2019-11-14 at 19:02 +0100, 'Marco Elver' via kasan-dev wrote: > This is the patch-series for the Kernel Concurrency Sanitizer (KCSAN). > KCSAN is a sampling watchpoint-based *data race detector*. More details > are included in **Documentation/dev-tools/kcsan.rst**. This patch-series > only enables KCSAN for x86, but we expect adding support for other > architectures is relatively straightforward (we are aware of > experimental ARM64 and POWER support). This does not allow the system to boot. Just hang forever at the end. https://cailca.github.io/files/dmesg.txt the config (dselect KASAN and select KCSAN with default options): https://raw.githubusercontent.com/cailca/linux-mm/master/x86.config > > To gather early feedback, we announced KCSAN back in September, and have > integrated the feedback where possible: > http://lkml.kernel.org/r/CANpmjNPJ_bHjfLZCAPV23AXFfiPiyXXqqu72n6TgWzb2Gnu1eA@mail.gmail.com > > The current list of known upstream fixes for data races found by KCSAN > can be found here: > https://github.com/google/ktsan/wiki/KCSAN#upstream-fixes-of-data-races-found-by-kcsan > > We want to point out and acknowledge the work surrounding the LKMM, > including several articles that motivate why data races are dangerous > [1, 2], justifying a data race detector such as KCSAN. > > [1] https://lwn.net/Articles/793253/ > [2] https://lwn.net/Articles/799218/ > > Race conditions vs. data races > ------------------------------ > > Race conditions are logic bugs, where unexpected interleaving of racing > concurrent operations result in an erroneous state. > > Data races on the other hand are defined at the *memory model/language > level*. Many data races are also harmful race conditions, which a tool > like KCSAN reports! However, not all data races are race conditions and > vice-versa. KCSAN's intent is to report data races according to the > LKMM. A data race detector can only work at the memory model/language > level. > > Deeper analysis, to find high-level race conditions only, requires > conveying the intended kernel logic to a tool. This requires (1) the > developer writing a specification or model of their code, and then (2) > the tool verifying that the implementation matches. This has been done > for small bits of code using model checkers and other formal methods, > but does not scale to the level of what can be covered with a dynamic > analysis based data race detector such as KCSAN. > > For reasons outlined in [1, 2], data races can be much more subtle, but > can cause no less harm than high-level race conditions. > > Changelog > --------- > v4: > * Major changes: > - Optimizations resulting in performance improvement of 33% (on > microbenchmark). > - Deal with nested interrupts for atomic_next. > - Simplify report.c (removing double-locking as well), in preparation > for KCSAN_REPORT_VALUE_CHANGE_ONLY. > - Add patch to introduce "data_race(expr)" macro. > - Introduce KCSAN_REPORT_VALUE_CHANGE_ONLY option for further filtering of data > races: if a conflicting write was observed via a watchpoint, only report the > data race if a value change was observed as well. The option will be enabled > by default on syzbot. (rcu-functions will be excluded from this filter at > request of Paul McKenney.) Context: > http://lkml.kernel.org/r/CANpmjNOepvb6+zJmDePxj21n2rctM4Sp4rJ66x_J-L1UmNK54A@mail.gmail.com > > v3: http://lkml.kernel.org/r/20191104142745.14722-1-elver@google.com > * Major changes: > - Add microbenchmark. > - Add instruction watchpoint skip randomization. > - Refactor API and core runtime fast-path and slow-path. Compared to > the previous version, with a default config and benchmarked using the > added microbenchmark, this version is 3.8x faster. > - Make __tsan_unaligned __alias of generic accesses. > - Rename kcsan_{begin,end}_atomic -> > kcsan_{nestable,flat}_atomic_{begin,end} > - For filter list in debugfs.c use kmalloc+krealloc instead of > kvmalloc. > - Split Documentation into separate patch. > > v2: http://lkml.kernel.org/r/20191017141305.146193-1-elver@google.com > * Major changes: > - Replace kcsan_check_access(.., {true, false}) with > kcsan_check_{read,write}. > - Change atomic-instrumented.h to use __atomic_check_{read,write}. > - Use common struct kcsan_ctx in task_struct and for per-CPU interrupt > contexts. > > v1: http://lkml.kernel.org/r/20191016083959.186860-1-elver@google.com > > Marco Elver (10): > kcsan: Add Kernel Concurrency Sanitizer infrastructure > include/linux/compiler.h: Introduce data_race(expr) macro > kcsan: Add Documentation entry in dev-tools > objtool, kcsan: Add KCSAN runtime functions to whitelist > build, kcsan: Add KCSAN build exceptions > seqlock, kcsan: Add annotations for KCSAN > seqlock: Require WRITE_ONCE surrounding raw_seqcount_barrier > asm-generic, kcsan: Add KCSAN instrumentation for bitops > locking/atomics, kcsan: Add KCSAN instrumentation > x86, kcsan: Enable KCSAN for x86 > > Documentation/dev-tools/index.rst | 1 + > Documentation/dev-tools/kcsan.rst | 256 +++++++++ > MAINTAINERS | 11 + > Makefile | 3 +- > arch/x86/Kconfig | 1 + > arch/x86/boot/Makefile | 2 + > arch/x86/boot/compressed/Makefile | 2 + > arch/x86/entry/vdso/Makefile | 3 + > arch/x86/include/asm/bitops.h | 6 +- > arch/x86/kernel/Makefile | 4 + > arch/x86/kernel/cpu/Makefile | 3 + > arch/x86/lib/Makefile | 4 + > arch/x86/mm/Makefile | 4 + > arch/x86/purgatory/Makefile | 2 + > arch/x86/realmode/Makefile | 3 + > arch/x86/realmode/rm/Makefile | 3 + > drivers/firmware/efi/libstub/Makefile | 2 + > include/asm-generic/atomic-instrumented.h | 393 +++++++------- > include/asm-generic/bitops-instrumented.h | 18 + > include/linux/compiler-clang.h | 9 + > include/linux/compiler-gcc.h | 7 + > include/linux/compiler.h | 57 +- > include/linux/kcsan-checks.h | 97 ++++ > include/linux/kcsan.h | 115 ++++ > include/linux/sched.h | 4 + > include/linux/seqlock.h | 51 +- > init/init_task.c | 8 + > init/main.c | 2 + > kernel/Makefile | 6 + > kernel/kcsan/Makefile | 11 + > kernel/kcsan/atomic.h | 27 + > kernel/kcsan/core.c | 626 ++++++++++++++++++++++ > kernel/kcsan/debugfs.c | 275 ++++++++++ > kernel/kcsan/encoding.h | 94 ++++ > kernel/kcsan/kcsan.h | 108 ++++ > kernel/kcsan/report.c | 320 +++++++++++ > kernel/kcsan/test.c | 121 +++++ > kernel/sched/Makefile | 6 + > lib/Kconfig.debug | 2 + > lib/Kconfig.kcsan | 118 ++++ > lib/Makefile | 3 + > mm/Makefile | 8 + > scripts/Makefile.kcsan | 6 + > scripts/Makefile.lib | 10 + > scripts/atomic/gen-atomic-instrumented.sh | 17 +- > tools/objtool/check.c | 18 + > 46 files changed, 2641 insertions(+), 206 deletions(-) > create mode 100644 Documentation/dev-tools/kcsan.rst > create mode 100644 include/linux/kcsan-checks.h > create mode 100644 include/linux/kcsan.h > create mode 100644 kernel/kcsan/Makefile > create mode 100644 kernel/kcsan/atomic.h > create mode 100644 kernel/kcsan/core.c > create mode 100644 kernel/kcsan/debugfs.c > create mode 100644 kernel/kcsan/encoding.h > create mode 100644 kernel/kcsan/kcsan.h > create mode 100644 kernel/kcsan/report.c > create mode 100644 kernel/kcsan/test.c > create mode 100644 lib/Kconfig.kcsan > create mode 100644 scripts/Makefile.kcsan > > -- > 2.24.0.rc1.363.gb1bccd3e3d-goog >