From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9267EC432C0 for ; Fri, 22 Nov 2019 09:46:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5BF1820708 for ; Fri, 22 Nov 2019 09:46:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="QUPYlak4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727236AbfKVJqS (ORCPT ); Fri, 22 Nov 2019 04:46:18 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:24318 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727118AbfKVJqE (ORCPT ); Fri, 22 Nov 2019 04:46:04 -0500 X-UUID: b67fe2021e644565b7f2fb626ad3a460-20191122 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=2ejSPwYplNKFDxLWJEW8hsrMYzKNBiloV5tEi9RI1Ag=; b=QUPYlak4FGynWG7yjOJa/3hANi8HiwO8bQdZa7VDoXtygZWieT4qbxvzcSl4CV+L6sIuiFoSs7qnE0aWQeWTSIzfei1VCY6Bna+SqXBfE6BC0W5MfTRec76oYphJkrzHfybHXtWoGKor9QqA54EIG8G8efh79h+q/HbTxUTLpkY=; X-UUID: b67fe2021e644565b7f2fb626ad3a460-20191122 Received: from mtkcas07.mediatek.inc [(172.21.101.84)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 516072111; Fri, 22 Nov 2019 17:46:01 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 22 Nov 2019 17:45:53 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 22 Nov 2019 17:45:51 +0800 Message-ID: <1574415960.19450.23.camel@mtksdaap41> Subject: Re: [PATCH v1 10/12] soc: mediatek: cmdq: add loop function From: CK Hu To: Dennis YC Hsieh CC: Rob Herring , Matthias Brugger , Jassi Brar , , , , , Bibby Hsieh , Houlong Wei , Date: Fri, 22 Nov 2019 17:46:00 +0800 In-Reply-To: <1574327552-11806-11-git-send-email-dennis-yc.hsieh@mediatek.com> References: <1574327552-11806-1-git-send-email-dennis-yc.hsieh@mediatek.com> <1574327552-11806-11-git-send-email-dennis-yc.hsieh@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SGksIERlbm5pczoNCg0KT24gVGh1LCAyMDE5LTExLTIxIGF0IDE3OjEyICswODAwLCBEZW5uaXMg WUMgSHNpZWggd3JvdGU6DQo+IEFkZCBmaW5hbGl6ZSBsb29wIGZ1bmN0aW9uIGluIGNtZHEgaGVs cGVyIGZ1bmN0aW9ucyB3aGljaCBsb29wIHdob2xlIHBrdA0KPiBpbiBnY2UgaGFyZHdhcmUgdGhy ZWFkIHdpdGhvdXQgY3B1IG9wZXJhdGlvbi4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IERlbm5pcyBZ QyBIc2llaCA8ZGVubmlzLXljLmhzaWVoQG1lZGlhdGVrLmNvbT4NCj4gLS0tDQo+ICBkcml2ZXJz L3NvYy9tZWRpYXRlay9tdGstY21kcS1oZWxwZXIuYyB8ICAgNDEgKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysNCj4gIGluY2x1ZGUvbGludXgvc29jL21lZGlhdGVrL210ay1jbWRxLmgg IHwgICAgOCArKysrKysrDQo+ICAyIGZpbGVzIGNoYW5nZWQsIDQ5IGluc2VydGlvbnMoKykNCj4g DQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3NvYy9tZWRpYXRlay9tdGstY21kcS1oZWxwZXIuYyBi L2RyaXZlcnMvc29jL21lZGlhdGVrL210ay1jbWRxLWhlbHBlci5jDQo+IGluZGV4IDQyMzVjZjgu LjNiMTAyNDEgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvc29jL21lZGlhdGVrL210ay1jbWRxLWhl bHBlci5jDQo+ICsrKyBiL2RyaXZlcnMvc29jL21lZGlhdGVrL210ay1jbWRxLWhlbHBlci5jDQo+ IEBAIC0zODUsMTIgKzM4NSwyNyBAQCBpbnQgY21kcV9wa3RfYXNzaWduKHN0cnVjdCBjbWRxX3Br dCAqcGt0LCB1MTYgcmVnX2lkeCwgdTMyIHZhbHVlKQ0KPiAgfQ0KPiAgRVhQT1JUX1NZTUJPTChj bWRxX3BrdF9hc3NpZ24pOw0KPiAgDQo+ICtzdGF0aWMgYm9vbCBjbWRxX3BrdF9maW5hbGl6ZWQo c3RydWN0IGNtZHFfcGt0ICpwa3QpDQo+ICt7DQo+ICsJc3RydWN0IGNtZHFfaW5zdHJ1Y3Rpb24g Kmluc3Q7DQo+ICsNCj4gKwlpZiAocGt0LT5jbWRfYnVmX3NpemUgPCAyICogQ01EUV9JTlNUX1NJ WkUpDQo+ICsJCXJldHVybiBmYWxzZTsNCj4gKw0KPiArCWluc3QgPSBwa3QtPnZhX2Jhc2UgKyBw a3QtPmNtZF9idWZfc2l6ZSAtIDIgKiBDTURRX0lOU1RfU0laRTsNCj4gKwlyZXR1cm4gaW5zdC0+ b3AgPT0gQ01EUV9DT0RFX0VPQzsNCj4gK30NCj4gKw0KPiAgc3RhdGljIGludCBjbWRxX3BrdF9m aW5hbGl6ZShzdHJ1Y3QgY21kcV9wa3QgKnBrdCkNCj4gIHsNCj4gIAlzdHJ1Y3QgY21kcV9jbGll bnQgKmNsID0gcGt0LT5jbDsNCj4gIAlzdHJ1Y3QgY21kcV9pbnN0cnVjdGlvbiBpbnN0ID0geyB7 MH0gfTsNCj4gIAlpbnQgZXJyOw0KPiAgDQo+ICsJLyogZG8gbm90IGZpbmFsaXplIHR3aWNlICov DQo+ICsJaWYgKGNtZHFfcGt0X2ZpbmFsaXplZChwa3QpKQ0KPiArCQlyZXR1cm4gMDsNCj4gKw0K PiAgCS8qIGluc2VydCBFT0MgYW5kIGdlbmVyYXRlIElSUSBmb3IgZWFjaCBjb21tYW5kIGl0ZXJh dGlvbiAqLw0KPiAgCWluc3Qub3AgPSBDTURRX0NPREVfRU9DOw0KPiAgCWluc3QudmFsdWUgPSBD TURRX0VPQ19JUlFfRU47DQo+IEBAIC00MDYsNiArNDIxLDMyIEBAIHN0YXRpYyBpbnQgY21kcV9w a3RfZmluYWxpemUoc3RydWN0IGNtZHFfcGt0ICpwa3QpDQo+ICAJcmV0dXJuIGVycjsNCj4gIH0N Cj4gIA0KPiAraW50IGNtZHFfcGt0X2ZpbmFsaXplX2xvb3Aoc3RydWN0IGNtZHFfcGt0ICpwa3Qp DQo+ICt7DQo+ICsJc3RydWN0IGNtZHFfY2xpZW50ICpjbCA9IHBrdC0+Y2w7DQo+ICsJc3RydWN0 IGNtZHFfaW5zdHJ1Y3Rpb24gaW5zdCA9IHsgezB9IH07DQo+ICsJaW50IGVycjsNCj4gKw0KPiAr CS8qIGRvIG5vdCBmaW5hbGl6ZSB0d2ljZSAqLw0KPiArCWlmIChjbWRxX3BrdF9maW5hbGl6ZWQo cGt0KSkNCj4gKwkJcmV0dXJuIDA7DQoNCldoeSBub3QganVzdCBleHBvcnQgY21kcV9wa3RfZmlu YWxpemUoKSBmb3IgdXNlciBhbmQgZG8gbm90IGNhbGwNCmNtZHFfcGt0X2ZpbmFsaXplKCkgaW4g Y21kcV9wa3RfZmx1c2hfYXN5bmMoKSwgc28geW91IGRvbid0IG5lZWQgdG8NCmNoZWNrIHRoaXMu DQoNCkkgd291bGQgYmUgbW9yZSBsaWtlIHRvIGV4cG9ydCBBUEkgc3VjaCBhcyBjbWRxX3BrdF9l b2MoKSwNCmNtZHFfcGt0X2p1bXAoKSwgdGhpcyB3b3VsZCBwcm92aWRlIG1vcmUgZmxleGliaWxp dHkgZm9yIHVzZXIgdG8NCmFzc2VtYmxlIHRoZSBjb21tYW5kIGl0IHdhbnQuDQoNClJlZ2FyZHMs DQpDSw0KDQo+ICsNCj4gKwkvKiBpbnNlcnQgRU9DIGFuZCBnZW5lcmF0ZSBJUlEgZm9yIGVhY2gg Y29tbWFuZCBpdGVyYXRpb24gKi8NCj4gKwlpbnN0Lm9wID0gQ01EUV9DT0RFX0VPQzsNCj4gKwll cnIgPSBjbWRxX3BrdF9hcHBlbmRfY29tbWFuZChwa3QsIGluc3QpOw0KPiArCWlmIChlcnIgPCAw KQ0KPiArCQlyZXR1cm4gZXJyOw0KPiArDQo+ICsJLyogSlVNUCBhYmFvbHV0ZSB0byBiZWdpbiAq Lw0KPiArCWluc3Qub3AgPSBDTURRX0NPREVfSlVNUDsNCj4gKwlpbnN0Lm9mZnNldCA9IDE7DQo+ ICsJaW5zdC52YWx1ZSA9IHBrdC0+cGFfYmFzZSA+PiBjbWRxX21ib3hfc2hpZnQoY2wtPmNoYW4p Ow0KPiArCWVyciA9IGNtZHFfcGt0X2FwcGVuZF9jb21tYW5kKHBrdCwgaW5zdCk7DQo+ICsNCj4g KwlyZXR1cm4gZXJyOw0KPiArfQ0KPiArRVhQT1JUX1NZTUJPTChjbWRxX3BrdF9maW5hbGl6ZV9s b29wKTsNCj4gKw0KPiAgc3RhdGljIHZvaWQgY21kcV9wa3RfZmx1c2hfYXN5bmNfY2Ioc3RydWN0 IGNtZHFfY2JfZGF0YSBkYXRhKQ0KPiAgew0KPiAgCXN0cnVjdCBjbWRxX3BrdCAqcGt0ID0gKHN0 cnVjdCBjbWRxX3BrdCAqKWRhdGEuZGF0YTsNCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgv c29jL21lZGlhdGVrL210ay1jbWRxLmggYi9pbmNsdWRlL2xpbnV4L3NvYy9tZWRpYXRlay9tdGst Y21kcS5oDQo+IGluZGV4IGIzNDc0ZjIuLjc3ZTg5NDQgMTAwNjQ0DQo+IC0tLSBhL2luY2x1ZGUv bGludXgvc29jL21lZGlhdGVrL210ay1jbWRxLmgNCj4gKysrIGIvaW5jbHVkZS9saW51eC9zb2Mv bWVkaWF0ZWsvbXRrLWNtZHEuaA0KPiBAQCAtMjAzLDYgKzIwMywxNCBAQCBpbnQgY21kcV9wa3Rf cG9sbF9tYXNrKHN0cnVjdCBjbWRxX3BrdCAqcGt0LCB1OCBzdWJzeXMsDQo+ICBpbnQgY21kcV9w a3RfYXNzaWduKHN0cnVjdCBjbWRxX3BrdCAqcGt0LCB1MTYgcmVnX2lkeCwgdTMyIHZhbHVlKTsN Cj4gIA0KPiAgLyoqDQo+ICsgKiBjbWRxX3BrdF9maW5hbGl6ZV9sb29wKCkgLSBBcHBlbmQgRU9D IGFuZCBqdW1wIGNvbW1hbmQgdG8gbG9vcCBwa3QuDQo+ICsgKiBAcGt0Ogl0aGUgQ01EUSBwYWNr ZXQNCj4gKyAqDQo+ICsgKiBSZXR1cm46IDAgZm9yIHN1Y2Nlc3M7IGVsc2UgdGhlIGVycm9yIGNv ZGUgaXMgcmV0dXJuZWQNCj4gKyAqLw0KPiAraW50IGNtZHFfcGt0X2ZpbmFsaXplX2xvb3Aoc3Ry dWN0IGNtZHFfcGt0ICpwa3QpOw0KPiArDQo+ICsvKioNCj4gICAqIGNtZHFfcGt0X2ZsdXNoX2Fz eW5jKCkgLSB0cmlnZ2VyIENNRFEgdG8gYXN5bmNocm9ub3VzbHkgZXhlY3V0ZSB0aGUgQ01EUQ0K PiAgICogICAgICAgICAgICAgICAgICAgICAgICAgIHBhY2tldCBhbmQgY2FsbCBiYWNrIGF0IHRo ZSBlbmQgb2YgZG9uZSBwYWNrZXQNCj4gICAqIEBwa3Q6CXRoZSBDTURRIHBhY2tldA0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FC8CC432C0 for ; Fri, 22 Nov 2019 09:48:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3196420708 for ; Fri, 22 Nov 2019 09:48:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZKTICG0j"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="QUPYlak4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3196420708 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rKUjRJc+OVOg/nZhCnT9B8vIq6k3wc/Aqq+D31UJvI0=; b=ZKTICG0jVwy5Zm p6bBquBxkCyFtZXQP8NdcEPxff8lUWqSkmD12YlG20mAl/AakMlkdY4HDekzLEhEuCohcHkTLrVmK BlMsBV8ir8b6/TKEjvnVSYd6gM3/GzPphJFObFTRNz8YqiH+2mY5AGEweZDY3zJf2g7YUfc7uwAUo vD3eog652Mfth+6vHsFTjHTxci953acBOXSj0+wx5UvLALh4T7MrM7Vmtgr4uNlD8WUZenC/upzE1 xL00iPmbUw/2Pz/jbps9fjpPYlMaqnTD+h1qTRidcYoelagAH/lEzwBudfYiYFJr2eHMFMgFbUHCy qCFVpph1w54UM/24TGWQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iY5Xn-0002ze-A2; Fri, 22 Nov 2019 09:48:03 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iY5Vv-0001Eq-EH; Fri, 22 Nov 2019 09:46:09 +0000 X-UUID: f7030093493d4b19b8339ff967afe1ce-20191122 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=2ejSPwYplNKFDxLWJEW8hsrMYzKNBiloV5tEi9RI1Ag=; b=QUPYlak4FGynWG7yjOJa/3hANi8HiwO8bQdZa7VDoXtygZWieT4qbxvzcSl4CV+L6sIuiFoSs7qnE0aWQeWTSIzfei1VCY6Bna+SqXBfE6BC0W5MfTRec76oYphJkrzHfybHXtWoGKor9QqA54EIG8G8efh79h+q/HbTxUTLpkY=; X-UUID: f7030093493d4b19b8339ff967afe1ce-20191122 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1607348181; Fri, 22 Nov 2019 01:46:02 -0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 22 Nov 2019 01:46:22 -0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 22 Nov 2019 17:45:53 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 22 Nov 2019 17:45:51 +0800 Message-ID: <1574415960.19450.23.camel@mtksdaap41> Subject: Re: [PATCH v1 10/12] soc: mediatek: cmdq: add loop function From: CK Hu To: Dennis YC Hsieh Date: Fri, 22 Nov 2019 17:46:00 +0800 In-Reply-To: <1574327552-11806-11-git-send-email-dennis-yc.hsieh@mediatek.com> References: <1574327552-11806-1-git-send-email-dennis-yc.hsieh@mediatek.com> <1574327552-11806-11-git-send-email-dennis-yc.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191122_014607_693246_82949385 X-CRM114-Status: GOOD ( 15.88 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, wsd_upstream@mediatek.com, Jassi Brar , linux-kernel@vger.kernel.org, Houlong Wei , Rob Herring , linux-mediatek@lists.infradead.org, Bibby Hsieh , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi, Dennis: On Thu, 2019-11-21 at 17:12 +0800, Dennis YC Hsieh wrote: > Add finalize loop function in cmdq helper functions which loop whole pkt > in gce hardware thread without cpu operation. > > Signed-off-by: Dennis YC Hsieh > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 41 ++++++++++++++++++++++++++++++++ > include/linux/soc/mediatek/mtk-cmdq.h | 8 +++++++ > 2 files changed, 49 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > index 4235cf8..3b10241 100644 > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > @@ -385,12 +385,27 @@ int cmdq_pkt_assign(struct cmdq_pkt *pkt, u16 reg_idx, u32 value) > } > EXPORT_SYMBOL(cmdq_pkt_assign); > > +static bool cmdq_pkt_finalized(struct cmdq_pkt *pkt) > +{ > + struct cmdq_instruction *inst; > + > + if (pkt->cmd_buf_size < 2 * CMDQ_INST_SIZE) > + return false; > + > + inst = pkt->va_base + pkt->cmd_buf_size - 2 * CMDQ_INST_SIZE; > + return inst->op == CMDQ_CODE_EOC; > +} > + > static int cmdq_pkt_finalize(struct cmdq_pkt *pkt) > { > struct cmdq_client *cl = pkt->cl; > struct cmdq_instruction inst = { {0} }; > int err; > > + /* do not finalize twice */ > + if (cmdq_pkt_finalized(pkt)) > + return 0; > + > /* insert EOC and generate IRQ for each command iteration */ > inst.op = CMDQ_CODE_EOC; > inst.value = CMDQ_EOC_IRQ_EN; > @@ -406,6 +421,32 @@ static int cmdq_pkt_finalize(struct cmdq_pkt *pkt) > return err; > } > > +int cmdq_pkt_finalize_loop(struct cmdq_pkt *pkt) > +{ > + struct cmdq_client *cl = pkt->cl; > + struct cmdq_instruction inst = { {0} }; > + int err; > + > + /* do not finalize twice */ > + if (cmdq_pkt_finalized(pkt)) > + return 0; Why not just export cmdq_pkt_finalize() for user and do not call cmdq_pkt_finalize() in cmdq_pkt_flush_async(), so you don't need to check this. I would be more like to export API such as cmdq_pkt_eoc(), cmdq_pkt_jump(), this would provide more flexibility for user to assemble the command it want. Regards, CK > + > + /* insert EOC and generate IRQ for each command iteration */ > + inst.op = CMDQ_CODE_EOC; > + err = cmdq_pkt_append_command(pkt, inst); > + if (err < 0) > + return err; > + > + /* JUMP abaolute to begin */ > + inst.op = CMDQ_CODE_JUMP; > + inst.offset = 1; > + inst.value = pkt->pa_base >> cmdq_mbox_shift(cl->chan); > + err = cmdq_pkt_append_command(pkt, inst); > + > + return err; > +} > +EXPORT_SYMBOL(cmdq_pkt_finalize_loop); > + > static void cmdq_pkt_flush_async_cb(struct cmdq_cb_data data) > { > struct cmdq_pkt *pkt = (struct cmdq_pkt *)data.data; > diff --git a/include/linux/soc/mediatek/mtk-cmdq.h b/include/linux/soc/mediatek/mtk-cmdq.h > index b3474f2..77e8944 100644 > --- a/include/linux/soc/mediatek/mtk-cmdq.h > +++ b/include/linux/soc/mediatek/mtk-cmdq.h > @@ -203,6 +203,14 @@ int cmdq_pkt_poll_mask(struct cmdq_pkt *pkt, u8 subsys, > int cmdq_pkt_assign(struct cmdq_pkt *pkt, u16 reg_idx, u32 value); > > /** > + * cmdq_pkt_finalize_loop() - Append EOC and jump command to loop pkt. > + * @pkt: the CMDQ packet > + * > + * Return: 0 for success; else the error code is returned > + */ > +int cmdq_pkt_finalize_loop(struct cmdq_pkt *pkt); > + > +/** > * cmdq_pkt_flush_async() - trigger CMDQ to asynchronously execute the CMDQ > * packet and call back at the end of done packet > * @pkt: the CMDQ packet _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14ABEC43215 for ; Fri, 22 Nov 2019 09:47:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DEF8D20708 for ; Fri, 22 Nov 2019 09:47:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="og2dPFO7"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="QUPYlak4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DEF8D20708 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YINu11qCx+fsgD3ULygabQvs1fLIrk9tCj7BJWQJEY0=; b=og2dPFO7PhGkzj DT4eAzHaBjEu49c++sW5JXf/sYTYIrFuYEs51EviP6nAcwhd3m/P96j5gjnajG0qhmhd8l+1IGKTP T0odqgZsT3LcVs/zlz3DQID3no7sqiaUd7Ji0nsxXsx7Uo0T1whD0l8NLb3twIN+urgess00/f2J+ iOn+dJMZzBo5DREeW2YIuqEQvm/cX/mSK+Y9jFJZcs2YdbOdATlerUNGNfLXcfWVru5cdQ4amIiMm bRwRCcwLqpMgGfIm7jz/Fjt6OttDxxgEzbtBhVsRgTLFOBcSa/zaSBhiyrcXn2D9Tu3/p3Gn/5Ebl Utnn8wIWfTdlGIPDgUGg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iY5Xg-0002nG-3O; Fri, 22 Nov 2019 09:47:56 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iY5Vv-0001Eq-EH; Fri, 22 Nov 2019 09:46:09 +0000 X-UUID: f7030093493d4b19b8339ff967afe1ce-20191122 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=2ejSPwYplNKFDxLWJEW8hsrMYzKNBiloV5tEi9RI1Ag=; b=QUPYlak4FGynWG7yjOJa/3hANi8HiwO8bQdZa7VDoXtygZWieT4qbxvzcSl4CV+L6sIuiFoSs7qnE0aWQeWTSIzfei1VCY6Bna+SqXBfE6BC0W5MfTRec76oYphJkrzHfybHXtWoGKor9QqA54EIG8G8efh79h+q/HbTxUTLpkY=; X-UUID: f7030093493d4b19b8339ff967afe1ce-20191122 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1607348181; Fri, 22 Nov 2019 01:46:02 -0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 22 Nov 2019 01:46:22 -0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 22 Nov 2019 17:45:53 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 22 Nov 2019 17:45:51 +0800 Message-ID: <1574415960.19450.23.camel@mtksdaap41> Subject: Re: [PATCH v1 10/12] soc: mediatek: cmdq: add loop function From: CK Hu To: Dennis YC Hsieh Date: Fri, 22 Nov 2019 17:46:00 +0800 In-Reply-To: <1574327552-11806-11-git-send-email-dennis-yc.hsieh@mediatek.com> References: <1574327552-11806-1-git-send-email-dennis-yc.hsieh@mediatek.com> <1574327552-11806-11-git-send-email-dennis-yc.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191122_014607_693246_82949385 X-CRM114-Status: GOOD ( 15.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, wsd_upstream@mediatek.com, Jassi Brar , linux-kernel@vger.kernel.org, Houlong Wei , Rob Herring , linux-mediatek@lists.infradead.org, Bibby Hsieh , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Dennis: On Thu, 2019-11-21 at 17:12 +0800, Dennis YC Hsieh wrote: > Add finalize loop function in cmdq helper functions which loop whole pkt > in gce hardware thread without cpu operation. > > Signed-off-by: Dennis YC Hsieh > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 41 ++++++++++++++++++++++++++++++++ > include/linux/soc/mediatek/mtk-cmdq.h | 8 +++++++ > 2 files changed, 49 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > index 4235cf8..3b10241 100644 > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > @@ -385,12 +385,27 @@ int cmdq_pkt_assign(struct cmdq_pkt *pkt, u16 reg_idx, u32 value) > } > EXPORT_SYMBOL(cmdq_pkt_assign); > > +static bool cmdq_pkt_finalized(struct cmdq_pkt *pkt) > +{ > + struct cmdq_instruction *inst; > + > + if (pkt->cmd_buf_size < 2 * CMDQ_INST_SIZE) > + return false; > + > + inst = pkt->va_base + pkt->cmd_buf_size - 2 * CMDQ_INST_SIZE; > + return inst->op == CMDQ_CODE_EOC; > +} > + > static int cmdq_pkt_finalize(struct cmdq_pkt *pkt) > { > struct cmdq_client *cl = pkt->cl; > struct cmdq_instruction inst = { {0} }; > int err; > > + /* do not finalize twice */ > + if (cmdq_pkt_finalized(pkt)) > + return 0; > + > /* insert EOC and generate IRQ for each command iteration */ > inst.op = CMDQ_CODE_EOC; > inst.value = CMDQ_EOC_IRQ_EN; > @@ -406,6 +421,32 @@ static int cmdq_pkt_finalize(struct cmdq_pkt *pkt) > return err; > } > > +int cmdq_pkt_finalize_loop(struct cmdq_pkt *pkt) > +{ > + struct cmdq_client *cl = pkt->cl; > + struct cmdq_instruction inst = { {0} }; > + int err; > + > + /* do not finalize twice */ > + if (cmdq_pkt_finalized(pkt)) > + return 0; Why not just export cmdq_pkt_finalize() for user and do not call cmdq_pkt_finalize() in cmdq_pkt_flush_async(), so you don't need to check this. I would be more like to export API such as cmdq_pkt_eoc(), cmdq_pkt_jump(), this would provide more flexibility for user to assemble the command it want. Regards, CK > + > + /* insert EOC and generate IRQ for each command iteration */ > + inst.op = CMDQ_CODE_EOC; > + err = cmdq_pkt_append_command(pkt, inst); > + if (err < 0) > + return err; > + > + /* JUMP abaolute to begin */ > + inst.op = CMDQ_CODE_JUMP; > + inst.offset = 1; > + inst.value = pkt->pa_base >> cmdq_mbox_shift(cl->chan); > + err = cmdq_pkt_append_command(pkt, inst); > + > + return err; > +} > +EXPORT_SYMBOL(cmdq_pkt_finalize_loop); > + > static void cmdq_pkt_flush_async_cb(struct cmdq_cb_data data) > { > struct cmdq_pkt *pkt = (struct cmdq_pkt *)data.data; > diff --git a/include/linux/soc/mediatek/mtk-cmdq.h b/include/linux/soc/mediatek/mtk-cmdq.h > index b3474f2..77e8944 100644 > --- a/include/linux/soc/mediatek/mtk-cmdq.h > +++ b/include/linux/soc/mediatek/mtk-cmdq.h > @@ -203,6 +203,14 @@ int cmdq_pkt_poll_mask(struct cmdq_pkt *pkt, u8 subsys, > int cmdq_pkt_assign(struct cmdq_pkt *pkt, u16 reg_idx, u32 value); > > /** > + * cmdq_pkt_finalize_loop() - Append EOC and jump command to loop pkt. > + * @pkt: the CMDQ packet > + * > + * Return: 0 for success; else the error code is returned > + */ > +int cmdq_pkt_finalize_loop(struct cmdq_pkt *pkt); > + > +/** > * cmdq_pkt_flush_async() - trigger CMDQ to asynchronously execute the CMDQ > * packet and call back at the end of done packet > * @pkt: the CMDQ packet _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel