From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E26CDC432C0 for ; Fri, 22 Nov 2019 10:13:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B22CC2070E for ; Fri, 22 Nov 2019 10:13:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="Rz+aX8Hg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726762AbfKVKNT (ORCPT ); Fri, 22 Nov 2019 05:13:19 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:54970 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726613AbfKVKNT (ORCPT ); Fri, 22 Nov 2019 05:13:19 -0500 X-UUID: 90a7ec6875a74c60862802dee2a1de5f-20191122 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=hK85BWO5PB72avyugc76FhRfS++eD6TPM5BELRKbSFs=; b=Rz+aX8HgQ+jCzopEyCY6rKva3jwGjNbMKujh1ylJ0j2rJgQ0ZESkp+rX0aEk7To/z0aZ5M61iwQbz4yS3LA816jW2FIme7H8BaxEA66YIZi5AKaiFcjtDvOn+E3RtH3aK5C70XNEXNajrjPfdBzQcHRIE5kQJXK1eqWGD38hCRI=; X-UUID: 90a7ec6875a74c60862802dee2a1de5f-20191122 Received: from mtkmrs01.mediatek.inc [(172.21.131.159)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1789497985; Fri, 22 Nov 2019 18:13:13 +0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 22 Nov 2019 18:11:42 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 22 Nov 2019 18:12:10 +0800 Message-ID: <1574417507.11977.14.camel@mtkswgap22> Subject: Re: [PATCH v1 07/12] soc: mediatek: cmdq: add write_s function From: Dennis-YC Hsieh To: CK Hu CC: Rob Herring , Matthias Brugger , Jassi Brar , , , , , Bibby Hsieh , Houlong Wei , Date: Fri, 22 Nov 2019 18:11:47 +0800 In-Reply-To: <1574412997.19450.16.camel@mtksdaap41> References: <1574327552-11806-1-git-send-email-dennis-yc.hsieh@mediatek.com> <1574327552-11806-8-git-send-email-dennis-yc.hsieh@mediatek.com> <1574412997.19450.16.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SGkgQ0ssDQoNCk9uIEZyaSwgMjAxOS0xMS0yMiBhdCAxNjo1NiArMDgwMCwgQ0sgSHUgd3JvdGU6 DQo+IEhpLCBEZW5uaXM6DQo+IA0KPiBPbiBUaHUsIDIwMTktMTEtMjEgYXQgMTc6MTIgKzA4MDAs IERlbm5pcyBZQyBIc2llaCB3cm90ZToNCj4gPiBhZGQgd3JpdGVfcyBmdW5jdGlvbiBpbiBjbWRx IGhlbHBlciBmdW5jdGlvbnMgd2hpY2gNCj4gPiBzdXBwb3J0IGxhcmdlIGRtYSBhY2Nlc3MuDQo+ ID4gDQo+ID4gU2lnbmVkLW9mZi1ieTogRGVubmlzIFlDIEhzaWVoIDxkZW5uaXMteWMuaHNpZWhA bWVkaWF0ZWsuY29tPg0KPiA+IC0tLQ0KPiA+ICBkcml2ZXJzL3NvYy9tZWRpYXRlay9tdGstY21k cS1oZWxwZXIuYyAgIHwgICAzNCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysNCj4gPiAg aW5jbHVkZS9saW51eC9tYWlsYm94L210ay1jbWRxLW1haWxib3guaCB8ICAgIDIgKysNCj4gPiAg aW5jbHVkZS9saW51eC9zb2MvbWVkaWF0ZWsvbXRrLWNtZHEuaCAgICB8ICAgMTMgKysrKysrKysr KysrDQo+ID4gIDMgZmlsZXMgY2hhbmdlZCwgNDkgaW5zZXJ0aW9ucygrKQ0KPiA+IA0KPiA+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL3NvYy9tZWRpYXRlay9tdGstY21kcS1oZWxwZXIuYyBiL2RyaXZl cnMvc29jL21lZGlhdGVrL210ay1jbWRxLWhlbHBlci5jDQo+ID4gaW5kZXggZDQxOWU5OS4uMWIw NzRhOSAxMDA2NDQNCj4gPiAtLS0gYS9kcml2ZXJzL3NvYy9tZWRpYXRlay9tdGstY21kcS1oZWxw ZXIuYw0KPiA+ICsrKyBiL2RyaXZlcnMvc29jL21lZGlhdGVrL210ay1jbWRxLWhlbHBlci5jDQo+ ID4gQEAgLTE1LDYgKzE1LDkgQEANCj4gPiAgI2RlZmluZSBDTURRX0VPQ19DTUQJCSgodTY0KSgo Q01EUV9DT0RFX0VPQyA8PCBDTURRX09QX0NPREVfU0hJRlQpKSBcDQo+ID4gIAkJCQk8PCAzMiB8 IENNRFFfRU9DX0lSUV9FTikNCj4gPiAgI2RlZmluZSBDTURRX1JFR19UWVBFCQkxDQo+ID4gKyNk ZWZpbmUgQ01EUV9BRERSX0hJR0goYWRkcikJKCh1MzIpKCgoYWRkcikgPj4gMTYpICYgR0VOTUFT SygzMSwgMCkpKQ0KPiA+ICsjZGVmaW5lIENNRFFfQUREUl9MT1dfQklUCUJJVCgxKQ0KPiA+ICsj ZGVmaW5lIENNRFFfQUREUl9MT1coYWRkcikJKCh1MTYpKGFkZHIpIHwgQ01EUV9BRERSX0xPV19C SVQpDQo+ID4gIA0KPiA+ICBzdHJ1Y3QgY21kcV9pbnN0cnVjdGlvbiB7DQo+ID4gIAl1bmlvbiB7 DQo+ID4gQEAgLTIyNCw2ICsyMjcsMzcgQEAgaW50IGNtZHFfcGt0X3dyaXRlX21hc2soc3RydWN0 IGNtZHFfcGt0ICpwa3QsIHU4IHN1YnN5cywNCj4gPiAgfQ0KPiA+ICBFWFBPUlRfU1lNQk9MKGNt ZHFfcGt0X3dyaXRlX21hc2spOw0KPiA+ICANCj4gPiAraW50IGNtZHFfcGt0X3dyaXRlX3Moc3Ry dWN0IGNtZHFfcGt0ICpwa3QsIGRtYV9hZGRyX3QgYWRkciwNCj4gPiArCQkgICAgIHUzMiB2YWx1 ZSwgdTMyIG1hc2spDQo+ID4gK3sNCj4gPiArCXN0cnVjdCBjbWRxX2luc3RydWN0aW9uIGluc3Qg PSB7IHswfSB9Ow0KPiA+ICsJaW50IGVycjsNCj4gPiArCWNvbnN0IHUxNiBkc3RfcmVnX2lkeCA9 IENNRFFfU1BSX1RFTVA7DQo+ID4gKw0KPiA+ICsJZXJyID0gY21kcV9wa3RfYXNzaWduKHBrdCwg ZHN0X3JlZ19pZHgsIENNRFFfQUREUl9ISUdIKGFkZHIpKTsNCj4gPiArCWlmIChlcnIgPCAwKQ0K PiA+ICsJCXJldHVybiBlcnI7DQo+ID4gKw0KPiA+ICsJaWYgKG1hc2sgIT0gVTMyX01BWCkgew0K PiA+ICsJCWluc3Qub3AgPSBDTURRX0NPREVfTUFTSzsNCj4gPiArCQlpbnN0Lm1hc2sgPSB+bWFz azsNCj4gPiArCQllcnIgPSBjbWRxX3BrdF9hcHBlbmRfY29tbWFuZChwa3QsIGluc3QpOw0KPiA+ ICsJCWlmIChlcnIgPCAwKQ0KPiA+ICsJCQlyZXR1cm4gZXJyOw0KPiA+ICsNCj4gPiArCQlpbnN0 Lm9wID0gQ01EUV9DT0RFX1dSSVRFX1NfTUFTSzsNCj4gPiArCX0gZWxzZSB7DQo+ID4gKwkJaW5z dC5vcCA9IENNRFFfQ09ERV9XUklURV9TOw0KPiA+ICsJfQ0KPiA+ICsNCj4gPiArCWluc3Quc29w ID0gZHN0X3JlZ19pZHg7DQo+ID4gKwlpbnN0Lm9mZnNldCA9IENNRFFfQUREUl9MT1coYWRkcik7 DQo+ID4gKwlpbnN0LnZhbHVlID0gdmFsdWU7DQo+ID4gKw0KPiA+ICsJcmV0dXJuIGNtZHFfcGt0 X2FwcGVuZF9jb21tYW5kKHBrdCwgaW5zdCk7DQo+ID4gK30NCj4gPiArRVhQT1JUX1NZTUJPTChj bWRxX3BrdF93cml0ZV9zKTsNCj4gPiArDQo+ID4gIGludCBjbWRxX3BrdF93ZmUoc3RydWN0IGNt ZHFfcGt0ICpwa3QsIHUxNiBldmVudCkNCj4gPiAgew0KPiA+ICAJc3RydWN0IGNtZHFfaW5zdHJ1 Y3Rpb24gaW5zdCA9IHsgezB9IH07DQo+ID4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvbWFp bGJveC9tdGstY21kcS1tYWlsYm94LmggYi9pbmNsdWRlL2xpbnV4L21haWxib3gvbXRrLWNtZHEt bWFpbGJveC5oDQo+ID4gaW5kZXggMTIxYzNiYi4uOGVmODdlMSAxMDA2NDQNCj4gPiAtLS0gYS9p bmNsdWRlL2xpbnV4L21haWxib3gvbXRrLWNtZHEtbWFpbGJveC5oDQo+ID4gKysrIGIvaW5jbHVk ZS9saW51eC9tYWlsYm94L210ay1jbWRxLW1haWxib3guaA0KPiA+IEBAIC01OSw2ICs1OSw4IEBA IGVudW0gY21kcV9jb2RlIHsNCj4gPiAgCUNNRFFfQ09ERV9KVU1QID0gMHgxMCwNCj4gPiAgCUNN RFFfQ09ERV9XRkUgPSAweDIwLA0KPiA+ICAJQ01EUV9DT0RFX0VPQyA9IDB4NDAsDQo+ID4gKwlD TURRX0NPREVfV1JJVEVfUyA9IDB4OTAsDQo+ID4gKwlDTURRX0NPREVfV1JJVEVfU19NQVNLID0g MHg5MSwNCj4gPiAgCUNNRFFfQ09ERV9MT0dJQyA9IDB4YTAsDQo+ID4gIH07DQo+ID4gIA0KPiA+ IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L3NvYy9tZWRpYXRlay9tdGstY21kcS5oIGIvaW5j bHVkZS9saW51eC9zb2MvbWVkaWF0ZWsvbXRrLWNtZHEuaA0KPiA+IGluZGV4IDgzMzQwMjEuLjhk YmQwNDYgMTAwNjQ0DQo+ID4gLS0tIGEvaW5jbHVkZS9saW51eC9zb2MvbWVkaWF0ZWsvbXRrLWNt ZHEuaA0KPiA+ICsrKyBiL2luY2x1ZGUvbGludXgvc29jL21lZGlhdGVrL210ay1jbWRxLmgNCj4g PiBAQCAtMTIsNiArMTIsNyBAQA0KPiA+ICAjaW5jbHVkZSA8bGludXgvdGltZXIuaD4NCj4gPiAg DQo+ID4gICNkZWZpbmUgQ01EUV9OT19USU1FT1VUCQkweGZmZmZmZmZmdQ0KPiA+ICsjZGVmaW5l IENNRFFfU1BSX1RFTVAJCTANCj4gPiAgDQo+ID4gIHN0cnVjdCBjbWRxX3BrdDsNCj4gPiAgDQo+ ID4gQEAgLTEwMyw2ICsxMDQsMTggQEAgaW50IGNtZHFfcGt0X3dyaXRlX21hc2soc3RydWN0IGNt ZHFfcGt0ICpwa3QsIHU4IHN1YnN5cywNCj4gPiAgCQkJdTE2IG9mZnNldCwgdTMyIHZhbHVlLCB1 MzIgbWFzayk7DQo+ID4gIA0KPiA+ICAvKioNCj4gPiArICogY21kcV9wa3Rfd3JpdGVfcygpIC0g YXBwZW5kIHdyaXRlX3MgY29tbWFuZCB3aXRoIG1hc2sgdG8gdGhlIENNRFEgcGFja2V0DQo+ID4g KyAqIEBwa3Q6CXRoZSBDTURRIHBhY2tldA0KPiA+ICsgKiBAYWRkcjoJdGhlIHBoeXNpY2FsIGFk ZHJlc3Mgb2YgcmVnaXN0ZXIgb3IgZG1hDQo+ID4gKyAqIEB2YWx1ZToJdGhlIHNwZWNpZmllZCB0 YXJnZXQgdmFsdWUNCj4gPiArICogQG1hc2s6CXRoZSBzcGVjaWZpZWQgdGFyZ2V0IG1hc2sNCj4g PiArICoNCj4gPiArICogUmV0dXJuOiAwIGZvciBzdWNjZXNzOyBlbHNlIHRoZSBlcnJvciBjb2Rl IGlzIHJldHVybmVkDQo+ID4gKyAqLw0KPiA+ICtpbnQgY21kcV9wa3Rfd3JpdGVfcyhzdHJ1Y3Qg Y21kcV9wa3QgKnBrdCwgZG1hX2FkZHJfdCBhZGRyLA0KPiA+ICsJCSAgICAgdTMyIHZhbHVlLCB1 MzIgbWFzayk7DQo+IA0KPiBZb3UgaGF2ZSBhbiBBUEkgY21kcV9wa3RfcmVhZF9zKCkgd2hpY2gg cmVhZCBkYXRhIGludG8gZ2NlIGludGVybmFsDQo+IHJlZ2lzdGVyLCBzbyBJIGV4cGVjdCB0aGF0 IGNtZHFfcGt0X3dyaXRlX3MoKSBpcyBhbiBBUEkgd2hpY2ggd3JpdGUgZGF0YQ0KPiBmcm9tIGdj ZSBpbnRlcm5hbCByZWdpc3RlciwgdGhlIGV4cGVjdGVkIHByb3RvdHlwZSBpcw0KPiANCj4gaW50 IGNtZHFfcGt0X3dyaXRlX3Moc3RydWN0IGNtZHFfcGt0ICpwa3QsIHBoeXNfYWRkcl90IGFkZHIs IHUxNg0KPiByZWdfaWR4KTsNCj4gDQo+IFlvdXIgdmVyc2lvbiB3b3VsZCBjb25mdXNlIHRoZSB1 c2VyIGJlY2F1c2UgeW91IGhpZGUgdGhlIGludGVybmFsDQo+IHJlZ2lzdGVyIHBhcmFtZXRlci4g SWYgeW91IHdhbnQgdG8gcHJvdmlkZSB0aGlzIHNlcnZpY2UsIEkgd291bGQgbGlrZQ0KPiB5b3Ug dG8gY2hhbmdlIHRoZSBmdW5jdGlvbiBuYW1lIHNvIHRoYXQgdXNlciB3b3VsZCBub3QgYmUgY29u ZnVzZWQgYW5kDQo+IGVhc2lseSB0byB1bmRlcnN0YW5kIHdoYXQgeW91IHdhbnQgdG8gZG8gaW4g dGhpcyBmdW5jdGlvbi4NCj4gDQo+IEFub3RoZXIgY2hvaWNlIGlzOiBjbWRxX3BrdF93cml0ZV9z KCkgaXMgaW1wbGVtZW50ZWQgaW4gbXkgZGVmaW5pdGlvbiwNCj4gYW5kIHVzZXIgY291bGQgY2Fs bCBjbWRxX3BrdF9hc3NpZ24oKSBhbmQgY21kcV9wa3Rfd3JpdGVfcygpIHRvIGFjaGlldmUNCj4g dGhpcyBmdW5jdGlvbi4NCj4gDQo+IFJlZ2FyZHMsDQo+IENLDQo+IA0KDQpUaGFua3MgZm9yIHlv dXIgY29tbWVudC4NCg0KT2ssIHdlIGhhdmUgdG8gcHJvdmlkZSB3cml0ZSBjb25zdGFudCB2YWx1 ZSBzZXJ2aWNlIHRvIGNsaWVudCwgc28gSSB3aWxsDQpjaGFuZ2UgdGhlIGZ1bmN0aW9uIG5hbWUg dG8gY21kcV9wa3Rfd3JpdGVfc192YWx1ZSgpIGluIHRoaXMgcGF0Y2guDQoNCkFuZCBzaW5jZSBp dCBpcyBiZXR0ZXIgdG8gcHJvdmlkZSBjb25zaXN0ZW50IEFQSSBzbyBJIHdpbGwgZGVzaWduDQph bm90aGVyIGZ1bmN0aW9uIHdpdGggaW50ZXJmYWNlIGFzIHlvdXIgc3VnZ2VzdGlvbjoNCmludCBj bWRxX3BrdF93cml0ZV9zKHN0cnVjdCBjbWRxX3BrdCAqcGt0LCBwaHlzX2FkZHJfdCBhZGRyLCB1 MTYNCnJlZ19pZHgpOw0KDQpJbiBhbm90aGVyIHBhdGNoIEkgcHJvdmlkZSBjbWRxX3BrdF9tZW1f bW92ZSgpLiBJIHdpbGwgbW92ZSBwYXJ0IG9mDQppbXBsZW1lbnRhdGlvbiB0byBjbWRxX3BrdF93 cml0ZV9zKCksIHNvIHRoYXQgY21kcV9wa3RfbWVtX21vdmUoKSBjYW4gYmUNCmNvbWJpbmF0aW9u IG9mIGNtZHFfcGt0X3JlYWRfcygpIGFuZCBjbWRxX3BrdF93cml0ZV9zKCkuDQoNCkhvdyBkbyB5 b3UgdGhpbms/DQoNCg0KUmVnYXJkcywNCkRlbm5pcw0KDQo+ID4gKw0KPiA+ICsvKioNCj4gPiAg ICogY21kcV9wa3Rfd2ZlKCkgLSBhcHBlbmQgd2FpdCBmb3IgZXZlbnQgY29tbWFuZCB0byB0aGUg Q01EUSBwYWNrZXQNCj4gPiAgICogQHBrdDoJdGhlIENNRFEgcGFja2V0DQo+ID4gICAqIEBldmVu dDoJdGhlIGRlc2lyZWQgZXZlbnQgdHlwZSB0byAid2FpdCBhbmQgQ0xFQVIiDQo+IA0KPiANCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52DFCC432C0 for ; Fri, 22 Nov 2019 10:12:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1947A2070E for ; Fri, 22 Nov 2019 10:12:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tpbQ1Xbv"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="Rz+aX8Hg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1947A2070E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q8bUvgxlEIS0kPVRXmrfLQydBZ6yUzzNOkV/JU3O0jE=; b=tpbQ1XbviT6fF8 mEI/Ei4FSsfaRNu4GpkZrcZM7IDMS4Jd3sRua3I2AKUPBt+Z1hIHTlp+nyVeMeh9YUk4rrugTkdxg p25DGpr+owOaC1mYXHY8ljERPnJV188uKVjkBYWT/Ws7zLK7+DkAuKFch43ikFC+ALsxLOCRQndbB QxHxJY1bqam2PMPXV+E7Y92rCuzcj39crjuGnSahDKiptD3i6u1MXZk3xyyuf6eLD/+bE85D0Bz0f DT50OK7uLI8goKLblTI7rlg+pqksTcKxSwS8EXgFcjM8zsrnlBPj+PT3LKJnvxWFMNiOp3BdLalun VpuZcJ/E1jD9J3QlX6Ig==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iY5v3-0001d6-BF; Fri, 22 Nov 2019 10:12:05 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iY5ut-0001WC-WC; Fri, 22 Nov 2019 10:11:57 +0000 X-UUID: d1abfda572d7428489b18846ce97b856-20191122 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=hK85BWO5PB72avyugc76FhRfS++eD6TPM5BELRKbSFs=; b=Rz+aX8HgQ+jCzopEyCY6rKva3jwGjNbMKujh1ylJ0j2rJgQ0ZESkp+rX0aEk7To/z0aZ5M61iwQbz4yS3LA816jW2FIme7H8BaxEA66YIZi5AKaiFcjtDvOn+E3RtH3aK5C70XNEXNajrjPfdBzQcHRIE5kQJXK1eqWGD38hCRI=; X-UUID: d1abfda572d7428489b18846ce97b856-20191122 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 265119845; Fri, 22 Nov 2019 02:11:49 -0800 Received: from mtkmbs05n1.mediatek.inc (172.21.101.15) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 22 Nov 2019 02:11:54 -0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 22 Nov 2019 18:11:42 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 22 Nov 2019 18:12:10 +0800 Message-ID: <1574417507.11977.14.camel@mtkswgap22> Subject: Re: [PATCH v1 07/12] soc: mediatek: cmdq: add write_s function From: Dennis-YC Hsieh To: CK Hu Date: Fri, 22 Nov 2019 18:11:47 +0800 In-Reply-To: <1574412997.19450.16.camel@mtksdaap41> References: <1574327552-11806-1-git-send-email-dennis-yc.hsieh@mediatek.com> <1574327552-11806-8-git-send-email-dennis-yc.hsieh@mediatek.com> <1574412997.19450.16.camel@mtksdaap41> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191122_021156_045811_EC9821F1 X-CRM114-Status: GOOD ( 21.17 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, wsd_upstream@mediatek.com, Jassi Brar , linux-kernel@vger.kernel.org, Houlong Wei , Rob Herring , linux-mediatek@lists.infradead.org, Bibby Hsieh , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi CK, On Fri, 2019-11-22 at 16:56 +0800, CK Hu wrote: > Hi, Dennis: > > On Thu, 2019-11-21 at 17:12 +0800, Dennis YC Hsieh wrote: > > add write_s function in cmdq helper functions which > > support large dma access. > > > > Signed-off-by: Dennis YC Hsieh > > --- > > drivers/soc/mediatek/mtk-cmdq-helper.c | 34 ++++++++++++++++++++++++++++++ > > include/linux/mailbox/mtk-cmdq-mailbox.h | 2 ++ > > include/linux/soc/mediatek/mtk-cmdq.h | 13 ++++++++++++ > > 3 files changed, 49 insertions(+) > > > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > > index d419e99..1b074a9 100644 > > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > > @@ -15,6 +15,9 @@ > > #define CMDQ_EOC_CMD ((u64)((CMDQ_CODE_EOC << CMDQ_OP_CODE_SHIFT)) \ > > << 32 | CMDQ_EOC_IRQ_EN) > > #define CMDQ_REG_TYPE 1 > > +#define CMDQ_ADDR_HIGH(addr) ((u32)(((addr) >> 16) & GENMASK(31, 0))) > > +#define CMDQ_ADDR_LOW_BIT BIT(1) > > +#define CMDQ_ADDR_LOW(addr) ((u16)(addr) | CMDQ_ADDR_LOW_BIT) > > > > struct cmdq_instruction { > > union { > > @@ -224,6 +227,37 @@ int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u8 subsys, > > } > > EXPORT_SYMBOL(cmdq_pkt_write_mask); > > > > +int cmdq_pkt_write_s(struct cmdq_pkt *pkt, dma_addr_t addr, > > + u32 value, u32 mask) > > +{ > > + struct cmdq_instruction inst = { {0} }; > > + int err; > > + const u16 dst_reg_idx = CMDQ_SPR_TEMP; > > + > > + err = cmdq_pkt_assign(pkt, dst_reg_idx, CMDQ_ADDR_HIGH(addr)); > > + if (err < 0) > > + return err; > > + > > + if (mask != U32_MAX) { > > + inst.op = CMDQ_CODE_MASK; > > + inst.mask = ~mask; > > + err = cmdq_pkt_append_command(pkt, inst); > > + if (err < 0) > > + return err; > > + > > + inst.op = CMDQ_CODE_WRITE_S_MASK; > > + } else { > > + inst.op = CMDQ_CODE_WRITE_S; > > + } > > + > > + inst.sop = dst_reg_idx; > > + inst.offset = CMDQ_ADDR_LOW(addr); > > + inst.value = value; > > + > > + return cmdq_pkt_append_command(pkt, inst); > > +} > > +EXPORT_SYMBOL(cmdq_pkt_write_s); > > + > > int cmdq_pkt_wfe(struct cmdq_pkt *pkt, u16 event) > > { > > struct cmdq_instruction inst = { {0} }; > > diff --git a/include/linux/mailbox/mtk-cmdq-mailbox.h b/include/linux/mailbox/mtk-cmdq-mailbox.h > > index 121c3bb..8ef87e1 100644 > > --- a/include/linux/mailbox/mtk-cmdq-mailbox.h > > +++ b/include/linux/mailbox/mtk-cmdq-mailbox.h > > @@ -59,6 +59,8 @@ enum cmdq_code { > > CMDQ_CODE_JUMP = 0x10, > > CMDQ_CODE_WFE = 0x20, > > CMDQ_CODE_EOC = 0x40, > > + CMDQ_CODE_WRITE_S = 0x90, > > + CMDQ_CODE_WRITE_S_MASK = 0x91, > > CMDQ_CODE_LOGIC = 0xa0, > > }; > > > > diff --git a/include/linux/soc/mediatek/mtk-cmdq.h b/include/linux/soc/mediatek/mtk-cmdq.h > > index 8334021..8dbd046 100644 > > --- a/include/linux/soc/mediatek/mtk-cmdq.h > > +++ b/include/linux/soc/mediatek/mtk-cmdq.h > > @@ -12,6 +12,7 @@ > > #include > > > > #define CMDQ_NO_TIMEOUT 0xffffffffu > > +#define CMDQ_SPR_TEMP 0 > > > > struct cmdq_pkt; > > > > @@ -103,6 +104,18 @@ int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u8 subsys, > > u16 offset, u32 value, u32 mask); > > > > /** > > + * cmdq_pkt_write_s() - append write_s command with mask to the CMDQ packet > > + * @pkt: the CMDQ packet > > + * @addr: the physical address of register or dma > > + * @value: the specified target value > > + * @mask: the specified target mask > > + * > > + * Return: 0 for success; else the error code is returned > > + */ > > +int cmdq_pkt_write_s(struct cmdq_pkt *pkt, dma_addr_t addr, > > + u32 value, u32 mask); > > You have an API cmdq_pkt_read_s() which read data into gce internal > register, so I expect that cmdq_pkt_write_s() is an API which write data > from gce internal register, the expected prototype is > > int cmdq_pkt_write_s(struct cmdq_pkt *pkt, phys_addr_t addr, u16 > reg_idx); > > Your version would confuse the user because you hide the internal > register parameter. If you want to provide this service, I would like > you to change the function name so that user would not be confused and > easily to understand what you want to do in this function. > > Another choice is: cmdq_pkt_write_s() is implemented in my definition, > and user could call cmdq_pkt_assign() and cmdq_pkt_write_s() to achieve > this function. > > Regards, > CK > Thanks for your comment. Ok, we have to provide write constant value service to client, so I will change the function name to cmdq_pkt_write_s_value() in this patch. And since it is better to provide consistent API so I will design another function with interface as your suggestion: int cmdq_pkt_write_s(struct cmdq_pkt *pkt, phys_addr_t addr, u16 reg_idx); In another patch I provide cmdq_pkt_mem_move(). I will move part of implementation to cmdq_pkt_write_s(), so that cmdq_pkt_mem_move() can be combination of cmdq_pkt_read_s() and cmdq_pkt_write_s(). How do you think? Regards, Dennis > > + > > +/** > > * cmdq_pkt_wfe() - append wait for event command to the CMDQ packet > > * @pkt: the CMDQ packet > > * @event: the desired event type to "wait and CLEAR" > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B094C43215 for ; Fri, 22 Nov 2019 10:12:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70A5D2070E for ; Fri, 22 Nov 2019 10:12:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FnVnrtI2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="Rz+aX8Hg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70A5D2070E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lQKAWECWbCfvsX2iJhyjm2T082qncTu+GNtx0/QIKUY=; b=FnVnrtI2p5zJPt T0owUyLkidsmkV6B3vp7nwArs10+mWf9WVwxymxHjYKLWbYNtcBH4Z9VgJfjooomN/vWAeS8lCLnX QZBtJzr26HYNvt/cUV+mSMa9U7GsY+fwyBAlU8y44GyjinD5M/l/9I6cq92zbu1ZWS3ypjXzj5Swt GxY7HG+s72J+ka+azclctkv4eG63zafd0mjZVj/R7BmJjI9H1seyf8gVJTlFOpJQGNhtonlWPpc+B sgGzxGizCaOKjdyOiTVrrDvQyNf0WS5LKVeTyLGSHqLTjxZBjDb6IUHrvaeWXikJnfUqjCwCZLvJS OjUsICaa8usLFj2+4dMA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iY5ux-0001Wp-Mx; Fri, 22 Nov 2019 10:11:59 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iY5ut-0001WC-WC; Fri, 22 Nov 2019 10:11:57 +0000 X-UUID: d1abfda572d7428489b18846ce97b856-20191122 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=hK85BWO5PB72avyugc76FhRfS++eD6TPM5BELRKbSFs=; b=Rz+aX8HgQ+jCzopEyCY6rKva3jwGjNbMKujh1ylJ0j2rJgQ0ZESkp+rX0aEk7To/z0aZ5M61iwQbz4yS3LA816jW2FIme7H8BaxEA66YIZi5AKaiFcjtDvOn+E3RtH3aK5C70XNEXNajrjPfdBzQcHRIE5kQJXK1eqWGD38hCRI=; X-UUID: d1abfda572d7428489b18846ce97b856-20191122 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 265119845; Fri, 22 Nov 2019 02:11:49 -0800 Received: from mtkmbs05n1.mediatek.inc (172.21.101.15) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 22 Nov 2019 02:11:54 -0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 22 Nov 2019 18:11:42 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 22 Nov 2019 18:12:10 +0800 Message-ID: <1574417507.11977.14.camel@mtkswgap22> Subject: Re: [PATCH v1 07/12] soc: mediatek: cmdq: add write_s function From: Dennis-YC Hsieh To: CK Hu Date: Fri, 22 Nov 2019 18:11:47 +0800 In-Reply-To: <1574412997.19450.16.camel@mtksdaap41> References: <1574327552-11806-1-git-send-email-dennis-yc.hsieh@mediatek.com> <1574327552-11806-8-git-send-email-dennis-yc.hsieh@mediatek.com> <1574412997.19450.16.camel@mtksdaap41> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191122_021156_045811_EC9821F1 X-CRM114-Status: GOOD ( 21.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, wsd_upstream@mediatek.com, Jassi Brar , linux-kernel@vger.kernel.org, Houlong Wei , Rob Herring , linux-mediatek@lists.infradead.org, Bibby Hsieh , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi CK, On Fri, 2019-11-22 at 16:56 +0800, CK Hu wrote: > Hi, Dennis: > > On Thu, 2019-11-21 at 17:12 +0800, Dennis YC Hsieh wrote: > > add write_s function in cmdq helper functions which > > support large dma access. > > > > Signed-off-by: Dennis YC Hsieh > > --- > > drivers/soc/mediatek/mtk-cmdq-helper.c | 34 ++++++++++++++++++++++++++++++ > > include/linux/mailbox/mtk-cmdq-mailbox.h | 2 ++ > > include/linux/soc/mediatek/mtk-cmdq.h | 13 ++++++++++++ > > 3 files changed, 49 insertions(+) > > > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > > index d419e99..1b074a9 100644 > > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > > @@ -15,6 +15,9 @@ > > #define CMDQ_EOC_CMD ((u64)((CMDQ_CODE_EOC << CMDQ_OP_CODE_SHIFT)) \ > > << 32 | CMDQ_EOC_IRQ_EN) > > #define CMDQ_REG_TYPE 1 > > +#define CMDQ_ADDR_HIGH(addr) ((u32)(((addr) >> 16) & GENMASK(31, 0))) > > +#define CMDQ_ADDR_LOW_BIT BIT(1) > > +#define CMDQ_ADDR_LOW(addr) ((u16)(addr) | CMDQ_ADDR_LOW_BIT) > > > > struct cmdq_instruction { > > union { > > @@ -224,6 +227,37 @@ int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u8 subsys, > > } > > EXPORT_SYMBOL(cmdq_pkt_write_mask); > > > > +int cmdq_pkt_write_s(struct cmdq_pkt *pkt, dma_addr_t addr, > > + u32 value, u32 mask) > > +{ > > + struct cmdq_instruction inst = { {0} }; > > + int err; > > + const u16 dst_reg_idx = CMDQ_SPR_TEMP; > > + > > + err = cmdq_pkt_assign(pkt, dst_reg_idx, CMDQ_ADDR_HIGH(addr)); > > + if (err < 0) > > + return err; > > + > > + if (mask != U32_MAX) { > > + inst.op = CMDQ_CODE_MASK; > > + inst.mask = ~mask; > > + err = cmdq_pkt_append_command(pkt, inst); > > + if (err < 0) > > + return err; > > + > > + inst.op = CMDQ_CODE_WRITE_S_MASK; > > + } else { > > + inst.op = CMDQ_CODE_WRITE_S; > > + } > > + > > + inst.sop = dst_reg_idx; > > + inst.offset = CMDQ_ADDR_LOW(addr); > > + inst.value = value; > > + > > + return cmdq_pkt_append_command(pkt, inst); > > +} > > +EXPORT_SYMBOL(cmdq_pkt_write_s); > > + > > int cmdq_pkt_wfe(struct cmdq_pkt *pkt, u16 event) > > { > > struct cmdq_instruction inst = { {0} }; > > diff --git a/include/linux/mailbox/mtk-cmdq-mailbox.h b/include/linux/mailbox/mtk-cmdq-mailbox.h > > index 121c3bb..8ef87e1 100644 > > --- a/include/linux/mailbox/mtk-cmdq-mailbox.h > > +++ b/include/linux/mailbox/mtk-cmdq-mailbox.h > > @@ -59,6 +59,8 @@ enum cmdq_code { > > CMDQ_CODE_JUMP = 0x10, > > CMDQ_CODE_WFE = 0x20, > > CMDQ_CODE_EOC = 0x40, > > + CMDQ_CODE_WRITE_S = 0x90, > > + CMDQ_CODE_WRITE_S_MASK = 0x91, > > CMDQ_CODE_LOGIC = 0xa0, > > }; > > > > diff --git a/include/linux/soc/mediatek/mtk-cmdq.h b/include/linux/soc/mediatek/mtk-cmdq.h > > index 8334021..8dbd046 100644 > > --- a/include/linux/soc/mediatek/mtk-cmdq.h > > +++ b/include/linux/soc/mediatek/mtk-cmdq.h > > @@ -12,6 +12,7 @@ > > #include > > > > #define CMDQ_NO_TIMEOUT 0xffffffffu > > +#define CMDQ_SPR_TEMP 0 > > > > struct cmdq_pkt; > > > > @@ -103,6 +104,18 @@ int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u8 subsys, > > u16 offset, u32 value, u32 mask); > > > > /** > > + * cmdq_pkt_write_s() - append write_s command with mask to the CMDQ packet > > + * @pkt: the CMDQ packet > > + * @addr: the physical address of register or dma > > + * @value: the specified target value > > + * @mask: the specified target mask > > + * > > + * Return: 0 for success; else the error code is returned > > + */ > > +int cmdq_pkt_write_s(struct cmdq_pkt *pkt, dma_addr_t addr, > > + u32 value, u32 mask); > > You have an API cmdq_pkt_read_s() which read data into gce internal > register, so I expect that cmdq_pkt_write_s() is an API which write data > from gce internal register, the expected prototype is > > int cmdq_pkt_write_s(struct cmdq_pkt *pkt, phys_addr_t addr, u16 > reg_idx); > > Your version would confuse the user because you hide the internal > register parameter. If you want to provide this service, I would like > you to change the function name so that user would not be confused and > easily to understand what you want to do in this function. > > Another choice is: cmdq_pkt_write_s() is implemented in my definition, > and user could call cmdq_pkt_assign() and cmdq_pkt_write_s() to achieve > this function. > > Regards, > CK > Thanks for your comment. Ok, we have to provide write constant value service to client, so I will change the function name to cmdq_pkt_write_s_value() in this patch. And since it is better to provide consistent API so I will design another function with interface as your suggestion: int cmdq_pkt_write_s(struct cmdq_pkt *pkt, phys_addr_t addr, u16 reg_idx); In another patch I provide cmdq_pkt_mem_move(). I will move part of implementation to cmdq_pkt_write_s(), so that cmdq_pkt_mem_move() can be combination of cmdq_pkt_read_s() and cmdq_pkt_write_s(). How do you think? Regards, Dennis > > + > > +/** > > * cmdq_pkt_wfe() - append wait for event command to the CMDQ packet > > * @pkt: the CMDQ packet > > * @event: the desired event type to "wait and CLEAR" > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel