From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH 1/1] librte_ether: fix coverity errors in
	rte_eth_copy_pci_info
Date: Fri, 06 Nov 2015 17:39:43 +0100
Message-ID: <15745635.HYcjktu7yu@xps13>
References: <1446827408-32393-1-git-send-email-bernard.iremonger@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Bernard Iremonger <bernard.iremonger@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48])
 by dpdk.org (Postfix) with ESMTP id D8CDB5A6B
 for <dev@dpdk.org>; Fri,  6 Nov 2015 17:40:55 +0100 (CET)
Received: by wmll128 with SMTP id l128so45625855wml.0
 for <dev@dpdk.org>; Fri, 06 Nov 2015 08:40:55 -0800 (PST)
In-Reply-To: <1446827408-32393-1-git-send-email-bernard.iremonger@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-11-06 16:30, Bernard Iremonger:
> add else branch to if statement.

I think a return statement would be more appropriate.

> Dereferencing NULL pointer reported by Coverity, CID 119256.
> Dereferencing NULL pointer reported by Coverity, CID 119257.
> 
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
[...]
>  	if ((eth_dev == NULL) || (pci_dev == NULL)) {
>  		PMD_DEBUG_TRACE("NULL pointer eth_dev=%p pci_dev=%p\n",
>  				eth_dev, pci_dev);
> -	}
> -
> -	eth_dev->data->dev_flags = 0;
> -	if (pci_dev->driver->drv_flags & RTE_PCI_DRV_INTR_LSC)
> -		eth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_LSC;
> -	if (pci_dev->driver->drv_flags & RTE_PCI_DRV_DETACHABLE)
> -		eth_dev->data->dev_flags |= RTE_ETH_DEV_DETACHABLE;
> +	} else {
> +		eth_dev->data->dev_flags = 0;
> +		if (pci_dev->driver->drv_flags & RTE_PCI_DRV_INTR_LSC)
> +			eth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_LSC;
> +		if (pci_dev->driver->drv_flags & RTE_PCI_DRV_DETACHABLE)
> +			eth_dev->data->dev_flags |= RTE_ETH_DEV_DETACHABLE;