Re: [PATCH v2 0/2] s390x/cpumodel: Introduce dynamic feature group

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20191125172031.16282-1-david@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v2 0/2] s390x/cpumodel: Introduce dynamic feature group
Type: series
Message-id: 20191125172031.16282-1-david@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
abb1bba s390x/cpumodel: Introduce dynamic feature groups
f8b362f s390x/cpumodel: Factor out CPU feature dependencies

=== OUTPUT BEGIN ===
1/2 Checking commit f8b362f40451 (s390x/cpumodel: Factor out CPU feature dependencies)
2/2 Checking commit abb1bba82287 (s390x/cpumodel: Introduce dynamic feature groups)
WARNING: line over 80 characters
#82: FILE: target/s390x/cpu_features.c:186:
+    DYN_FEAT_GROUP_INIT("all-features", ALL, "Features valid for a CPU definition"),

ERROR: line over 90 characters
#84: FILE: target/s390x/cpu_features.c:188:
+    DYN_FEAT_GROUP_INIT("recommended-features", RECOMMENDED, "Available, recommended features supported by the accelerator in the current host for a CPU definition"),

ERROR: line over 90 characters
#86: FILE: target/s390x/cpu_features.c:190:
+    DYN_FEAT_GROUP_INIT("available-features", AVAILABLE, "Available features supported by the accelerator in the current host for a CPU definition"),

total: 2 errors, 1 warnings, 209 lines checked

Patch 2/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20191125172031.16282-1-david@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com