From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6463C432C3 for ; Tue, 3 Dec 2019 01:38:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4F353206E1 for ; Tue, 3 Dec 2019 01:38:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="j51GpkAS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726079AbfLCBik (ORCPT ); Mon, 2 Dec 2019 20:38:40 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:2248 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725899AbfLCBik (ORCPT ); Mon, 2 Dec 2019 20:38:40 -0500 X-UUID: b0881f0326c3448da76daf101593d0f0-20191203 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=sRwMLRyS13CHATbRSBNDwYj8Xi6G067HZgFuCYy6r9Q=; b=j51GpkASqoKybtF0UEFO5GYzvYBVHTZAb0ja5+kX1aCTTMcI8k3yfEYB6avjzwA7Fnp7fMi9JgRoJ0HY1S0n3xJBZa9CksS1dbRyIoi9WY8Mvkkp6EJWqZ7VNqCYD1UHjvDxS16fa5ZjdZhfHY6Gu7d64/Q7Eq/hs3nTC3X2XVw=; X-UUID: b0881f0326c3448da76daf101593d0f0-20191203 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1907750908; Tue, 03 Dec 2019 09:38:35 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 3 Dec 2019 09:38:19 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 3 Dec 2019 09:38:14 +0800 Message-ID: <1575337114.1155.4.camel@mtksdaap41> Subject: Re: [PATCH v1 6/6] drm/mediatek: apply CMDQ control flow From: CK Hu To: Bibby Hsieh CC: David Airlie , Matthias Brugger , Daniel Vetter , , , Philipp Zabel , YT Shen , Thierry Reding , , , , , , Yongqiang Niu Date: Tue, 3 Dec 2019 09:38:34 +0800 In-Reply-To: <20191128024238.9399-7-bibby.hsieh@mediatek.com> References: <20191128024238.9399-1-bibby.hsieh@mediatek.com> <20191128024238.9399-7-bibby.hsieh@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SGksIEJpYmJ5Og0KDQpPbiBUaHUsIDIwMTktMTEtMjggYXQgMTA6NDIgKzA4MDAsIEJpYmJ5IEhz aWVoIHdyb3RlOg0KPiBVbmxpa2Ugb3RoZXIgU29DcywgTVQ4MTgzIGRvZXMgbm90IGhhdmUgInNo YWRvdyINCj4gcmVnaXN0ZXJzIGZvciBwZXJmb3JtYWluZyBhbiBhdG9taWMgdmlkZW8gbW9kZQ0K PiBzZXQgb3IgcGFnZSBmbGlwIGF0IHZibGFuay92c3luYy4NCj4gDQo+IFRoZSBDTURRIChDb21t ZW5kIFF1ZXVlKSBpbiBNVDgxODMgaXMgdXNlZCB0byBoZWxwDQo+IHVwZGF0ZSBhbGwgcmVsZXZh bnQgZGlzcGxheSBjb250cm9sbGVyIHJlZ2lzdGVycw0KPiB3aXRoIGNyaXRpY2FsIHRpbWUgbGlt YXRpb24uDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBZVCBTaGVuIDx5dC5zaGVuQG1lZGlhdGVrLmNv bT4NCj4gU2lnbmVkLW9mZi1ieTogQ0sgSHUgPGNrLmh1QG1lZGlhdGVrLmNvbT4NCj4gU2lnbmVk LW9mZi1ieTogUGhpbGlwcCBaYWJlbCA8cC56YWJlbEBwZW5ndXRyb25peC5kZT4NCj4gU2lnbmVk LW9mZi1ieTogQmliYnkgSHNpZWggPGJpYmJ5LmhzaWVoQG1lZGlhdGVrLmNvbT4NCj4gU2lnbmVk LW9mZi1ieTogWW9uZ3FpYW5nIE5pdSA8eW9uZ3FpYW5nLm5pdUBtZWRpYXRlay5jb20+DQo+IC0t LQ0KPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fY3J0Yy5jICAgICB8IDg2ICsr KysrKysrKysrKysrKysrKysrLQ0KPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1f ZGRwX2NvbXAuYyB8IDMxICsrKysrKysrDQo+ICAyIGZpbGVzIGNoYW5nZWQsIDExMyBpbnNlcnRp b25zKCspLCA0IGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9tZWRpYXRlay9tdGtfZHJtX2NydGMuYyBiL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtf ZHJtX2NydGMuYw0KPiBpbmRleCBmY2Y0ZTc1NWUwYmQuLjFiNGU1MzdhYzNjMSAxMDA2NDQNCj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fY3J0Yy5jDQo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2NydGMuYw0KPiBAQCAtMTIsNiArMTIsOCBA QA0KPiAgI2luY2x1ZGUgPGRybS9kcm1fcGxhbmVfaGVscGVyLmg+DQo+ICAjaW5jbHVkZSA8ZHJt L2RybV9wcm9iZV9oZWxwZXIuaD4NCj4gICNpbmNsdWRlIDxkcm0vZHJtX3ZibGFuay5oPg0KPiAr I2luY2x1ZGUgPGxpbnV4L29mX2FkZHJlc3MuaD4NCj4gKyNpbmNsdWRlIDxsaW51eC9zb2MvbWVk aWF0ZWsvbXRrLWNtZHEuaD4NCj4gIA0KPiAgI2luY2x1ZGUgIm10a19kcm1fZHJ2LmgiDQo+ICAj aW5jbHVkZSAibXRrX2RybV9jcnRjLmgiDQo+IEBAIC00Miw2ICs0NCw5IEBAIHN0cnVjdCBtdGtf ZHJtX2NydGMgew0KPiAgCXVuc2lnbmVkIGludAkJCWxheWVyX25yOw0KPiAgCWJvb2wJCQkJcGVu ZGluZ19wbGFuZXM7DQo+ICANCj4gKwlzdHJ1Y3QgY21kcV9jbGllbnQJCSpjbWRxX2NsaWVudDsN Cj4gKwl1MzIJCQkJY21kcV9ldmVudDsNCj4gKw0KPiAgCXZvaWQgX19pb21lbQkJCSpjb25maWdf cmVnczsNCj4gIAljb25zdCBzdHJ1Y3QgbXRrX21tc3lzX3JlZ19kYXRhICptbXN5c19yZWdfZGF0 YTsNCj4gIAlzdHJ1Y3QgbXRrX2Rpc3BfbXV0ZXgJCSptdXRleDsNCj4gQEAgLTU2LDYgKzYxLDEx IEBAIHN0cnVjdCBtdGtfY3J0Y19zdGF0ZSB7DQo+ICAJdW5zaWduZWQgaW50CQkJcGVuZGluZ193 aWR0aDsNCj4gIAl1bnNpZ25lZCBpbnQJCQlwZW5kaW5nX2hlaWdodDsNCj4gIAl1bnNpZ25lZCBp bnQJCQlwZW5kaW5nX3ZyZWZyZXNoOw0KPiArCXN0cnVjdCBjbWRxX3BrdAkJCSpjbWRxX2hhbmRs ZTsNCj4gK307DQo+ICsNCj4gK3N0cnVjdCBtdGtfY21kcV9jYl9kYXRhIHsNCj4gKwlzdHJ1Y3Qg Y21kcV9wa3QJCQkqY21kcV9oYW5kbGU7DQo+ICB9Ow0KPiAgDQo+ICBzdGF0aWMgaW5saW5lIHN0 cnVjdCBtdGtfZHJtX2NydGMgKnRvX210a19jcnRjKHN0cnVjdCBkcm1fY3J0YyAqYykNCj4gQEAg LTIyOSw2ICsyMzksNDYgQEAgc3RydWN0IG10a19kZHBfY29tcCAqbXRrX2RybV9kZHBfY29tcF9m b3JfcGxhbmUoc3RydWN0IGRybV9jcnRjICpjcnRjLA0KPiAgCXJldHVybiBOVUxMOw0KPiAgfQ0K PiAgDQo+ICsjaWZkZWYgQ09ORklHX01US19DTURRDQo+ICtzdGF0aWMgdm9pZCBkZHBfY21kcV9j YihzdHJ1Y3QgY21kcV9jYl9kYXRhIGRhdGEpDQo+ICt7DQo+ICsJc3RydWN0IG10a19jbWRxX2Ni X2RhdGEgKmNiX2RhdGEgPSBkYXRhLmRhdGE7DQo+ICsNCj4gKwljbWRxX3BrdF9kZXN0cm95KGNi X2RhdGEtPmNtZHFfaGFuZGxlKTsNCj4gKwlrZnJlZShjYl9kYXRhKTsNCj4gK30NCj4gKw0KPiAr c3RhdGljIHZvaWQgbXRrX2NtZHFfYWNxdWlyZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMpDQo+ICt7 DQo+ICsJc3RydWN0IG10a19jcnRjX3N0YXRlICptdGtfY3J0Y19zdGF0ZSA9DQo+ICsJCQl0b19t dGtfY3J0Y19zdGF0ZShjcnRjLT5zdGF0ZSk7DQo+ICsJc3RydWN0IG10a19kcm1fY3J0YyAqbXRr X2NydGMgPSB0b19tdGtfY3J0YyhjcnRjKTsNCj4gKw0KPiArCW10a19jcnRjX3N0YXRlLT5jbWRx X2hhbmRsZSA9DQo+ICsJCQljbWRxX3BrdF9jcmVhdGUobXRrX2NydGMtPmNtZHFfY2xpZW50LA0K PiArCQkJCQlQQUdFX1NJWkUpOw0KDQpJIHdvdWxkIGxpa2UgdG8gcmVtb3ZlIGF0b21pYyBmZWF0 dXJlIGluIGNtZHEgZHJpdmVyIGFuZCBkcm0gZHJpdmVyDQpjb3VsZCByZXVzZSB0aGUgcGt0LiBQ bGVhc2UgcmVmZXIgdG8gWzFdIGZvciBkZXRhaWwuDQoNClsxXQ0KaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvcGlwZXJtYWlsL2xpbnV4LW1lZGlhdGVrLzIwMTktSmFudWFyeS8wMTY4NjYuaHRt bA0KDQo+ICsJY21kcV9wa3RfY2xlYXJfZXZlbnQobXRrX2NydGNfc3RhdGUtPmNtZHFfaGFuZGxl LA0KPiArCQkJICAgICBtdGtfY3J0Yy0+Y21kcV9ldmVudCk7DQo+ICsJY21kcV9wa3Rfd2ZlKG10 a19jcnRjX3N0YXRlLT5jbWRxX2hhbmRsZSwgbXRrX2NydGMtPmNtZHFfZXZlbnQpOw0KPiArfQ0K PiArDQo+ICtzdGF0aWMgdm9pZCBtdGtfY21kcV9yZWxlYXNlKHN0cnVjdCBkcm1fY3J0YyAqY3J0 YykNCj4gK3sNCj4gKwlzdHJ1Y3QgbXRrX2NydGNfc3RhdGUgKm10a19jcnRjX3N0YXRlID0NCj4g KwkJCXRvX210a19jcnRjX3N0YXRlKGNydGMtPnN0YXRlKTsNCj4gKwlzdHJ1Y3QgbXRrX2NtZHFf Y2JfZGF0YSAqY2JfZGF0YTsNCj4gKw0KPiArCWNiX2RhdGEgPSBrbWFsbG9jKHNpemVvZigqY2Jf ZGF0YSksIEdGUF9LRVJORUwpOw0KPiArCWlmICghY2JfZGF0YSkgew0KPiArCQlEUk1fREVWX0VS Uk9SKGNydGMtPmRldi0+ZGV2LCAiRmFpbGVkIHRvIGFsbG9jIGNiX2RhdGFcbiIpOw0KPiArCQly ZXR1cm47DQo+ICsJfQ0KPiArDQo+ICsJY2JfZGF0YS0+Y21kcV9oYW5kbGUgPSBtdGtfY3J0Y19z dGF0ZS0+Y21kcV9oYW5kbGU7DQo+ICsJY21kcV9wa3RfZmx1c2hfYXN5bmMobXRrX2NydGNfc3Rh dGUtPmNtZHFfaGFuZGxlLA0KPiArCQkJICAgICBkZHBfY21kcV9jYiwgY2JfZGF0YSk7DQo+ICt9 DQo+ICsjZW5kaWYNCj4gIHN0YXRpYyBpbnQgbXRrX2NydGNfZGRwX2h3X2luaXQoc3RydWN0IG10 a19kcm1fY3J0YyAqbXRrX2NydGMpDQo+ICB7DQo+ICAJc3RydWN0IGRybV9jcnRjICpjcnRjID0g Jm10a19jcnRjLT5iYXNlOw0KPiBAQCAtMzgzLDcgKzQzMyw4IEBAIHN0YXRpYyB2b2lkIG10a19j cnRjX2RkcF9jb25maWcoc3RydWN0IGRybV9jcnRjICpjcnRjKQ0KPiAgCWlmIChzdGF0ZS0+cGVu ZGluZ19jb25maWcpIHsNCj4gIAkJbXRrX2RkcF9jb21wX2NvbmZpZyhjb21wLCBzdGF0ZS0+cGVu ZGluZ193aWR0aCwNCj4gIAkJCQkgICAgc3RhdGUtPnBlbmRpbmdfaGVpZ2h0LA0KPiAtCQkJCSAg ICBzdGF0ZS0+cGVuZGluZ192cmVmcmVzaCwgMCwgTlVMTCk7DQo+ICsJCQkJICAgIHN0YXRlLT5w ZW5kaW5nX3ZyZWZyZXNoLCAwLA0KPiArCQkJCSAgICBzdGF0ZS0+Y21kcV9oYW5kbGUpOw0KPiAg DQo+ICAJCXN0YXRlLT5wZW5kaW5nX2NvbmZpZyA9IGZhbHNlOw0KPiAgCX0NCj4gQEAgLTQwMyw3 ICs0NTQsOCBAQCBzdGF0aWMgdm9pZCBtdGtfY3J0Y19kZHBfY29uZmlnKHN0cnVjdCBkcm1fY3J0 YyAqY3J0YykNCj4gIA0KPiAgCQkJaWYgKGNvbXApDQo+ICAJCQkJbXRrX2RkcF9jb21wX2xheWVy X2NvbmZpZyhjb21wLCBsb2NhbF9sYXllciwNCj4gLQkJCQkJCQkgIHBsYW5lX3N0YXRlLCBOVUxM KTsNCj4gKwkJCQkJCQkgIHBsYW5lX3N0YXRlLA0KPiArCQkJCQkJCSAgc3RhdGUtPmNtZHFfaGFu ZGxlKTsNCj4gIAkJCXBsYW5lX3N0YXRlLT5wZW5kaW5nLmNvbmZpZyA9IGZhbHNlOw0KPiAgCQl9 DQo+ICAJCW10a19jcnRjLT5wZW5kaW5nX3BsYW5lcyA9IGZhbHNlOw0KPiBAQCAtNDU0LDYgKzUw NiwxMyBAQCB2b2lkIG10a19kcm1fY3J0Y19jdXJzb3JfdXBkYXRlKHN0cnVjdCBkcm1fY3J0YyAq Y3J0Yywgc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsDQo+ICAJCW10a19jcnRjX2RkcF9jb25maWco Y3J0Yyk7DQo+ICAJCW10a19kaXNwX211dGV4X3JlbGVhc2UobXRrX2NydGMtPm11dGV4KTsNCj4g IAl9DQo+ICsjaWZkZWYgQ09ORklHX01US19DTURRDQo+ICsJaWYgKG10a19jcnRjLT5jbWRxX2Ns aWVudCkgew0KPiArCQltdGtfY21kcV9hY3F1aXJlKGNydGMpOw0KPiArCQltdGtfY3J0Y19kZHBf Y29uZmlnKGNydGMpOw0KPiArCQltdGtfY21kcV9yZWxlYXNlKGNydGMpOw0KPiArCX0NCj4gKyNl bmRpZg0KPiAgCW11dGV4X3VubG9jaygmcHJpdi0+aHdfbG9jayk7DQo+ICB9DQo+ICANCj4gQEAg LTU3MCw2ICs2MjksMTMgQEAgc3RhdGljIHZvaWQgbXRrX2RybV9jcnRjX2F0b21pY19mbHVzaChz dHJ1Y3QgZHJtX2NydGMgKmNydGMsDQo+ICAJCW10a19jcnRjX2RkcF9jb25maWcoY3J0Yyk7DQo+ ICAJCW10a19kaXNwX211dGV4X3JlbGVhc2UobXRrX2NydGMtPm11dGV4KTsNCj4gIAl9DQo+ICsj aWZkZWYgQ09ORklHX01US19DTURRDQo+ICsJaWYgKG10a19jcnRjLT5jbWRxX2NsaWVudCkgew0K PiArCQltdGtfY21kcV9hY3F1aXJlKGNydGMpOw0KPiArCQltdGtfY3J0Y19kZHBfY29uZmlnKGNy dGMpOw0KPiArCQltdGtfY21kcV9yZWxlYXNlKGNydGMpOw0KPiArCX0NCj4gKyNlbmRpZg0KDQpU aGlzIHBhcnQgaXMgYWxtb3N0IHRoZSBzYW1lIGFzIHRoZSBvbmUgaW4gbXRrX2RybV9jcnRjX2N1 cnNvcl91cGRhdGUoKSwNCnRyeSB0byBtZXJnZSB0aGVtLg0KDQo+ICB9DQo+ICANCj4gIHN0YXRp YyBjb25zdCBzdHJ1Y3QgZHJtX2NydGNfZnVuY3MgbXRrX2NydGNfZnVuY3MgPSB7DQo+IEBAIC02 MTksNyArNjg1LDcgQEAgdm9pZCBtdGtfY3J0Y19kZHBfaXJxKHN0cnVjdCBkcm1fY3J0YyAqY3J0 Yywgc3RydWN0IG10a19kZHBfY29tcCAqY29tcCkNCj4gIAlzdHJ1Y3QgbXRrX2RybV9jcnRjICpt dGtfY3J0YyA9IHRvX210a19jcnRjKGNydGMpOw0KPiAgCXN0cnVjdCBtdGtfZHJtX3ByaXZhdGUg KnByaXYgPSBjcnRjLT5kZXYtPmRldl9wcml2YXRlOw0KPiAgDQo+IC0JaWYgKCFwcml2LT5kYXRh LT5zaGFkb3dfcmVnaXN0ZXIpDQo+ICsJaWYgKCFwcml2LT5kYXRhLT5zaGFkb3dfcmVnaXN0ZXIg JiYgIW10a19jcnRjLT5jbWRxX2NsaWVudCkNCj4gIAkJbXRrX2NydGNfZGRwX2NvbmZpZyhjcnRj KTsNCj4gIA0KPiAgCW10a19kcm1fZmluaXNoX3BhZ2VfZmxpcChtdGtfY3J0Yyk7DQo+IEBAIC03 NjEsNiArODI3LDE4IEBAIGludCBtdGtfZHJtX2NydGNfY3JlYXRlKHN0cnVjdCBkcm1fZGV2aWNl ICpkcm1fZGV2LA0KPiAgCWRybV9tb2RlX2NydGNfc2V0X2dhbW1hX3NpemUoJm10a19jcnRjLT5i YXNlLCBNVEtfTFVUX1NJWkUpOw0KPiAgCWRybV9jcnRjX2VuYWJsZV9jb2xvcl9tZ210KCZtdGtf Y3J0Yy0+YmFzZSwgMCwgZmFsc2UsIE1US19MVVRfU0laRSk7DQo+ICAJcHJpdi0+bnVtX3BpcGVz Kys7DQo+IC0NCj4gKyNpZmRlZiBDT05GSUdfTVRLX0NNRFENCj4gKwltdGtfY3J0Yy0+Y21kcV9j bGllbnQgPQ0KPiArCQkJY21kcV9tYm94X2NyZWF0ZShkZXYsIGRybV9jcnRjX2luZGV4KCZtdGtf Y3J0Yy0+YmFzZSksDQo+ICsJCQkJCSAyMDAwKTsNCj4gKwlvZl9wcm9wZXJ0eV9yZWFkX3UzMl9p bmRleChkZXYtPm9mX25vZGUsICJtZWRpYXRlayxnY2UtZXZlbnRzIiwNCj4gKwkJCQkgICBkcm1f Y3J0Y19pbmRleCgmbXRrX2NydGMtPmJhc2UpLA0KPiArCQkJCSAgICZtdGtfY3J0Yy0+Y21kcV9l dmVudCk7DQo+ICsJaWYgKElTX0VSUihtdGtfY3J0Yy0+Y21kcV9jbGllbnQpKSB7DQo+ICsJCWRl dl9kYmcoZGV2LCAibXRrX2NydGMgJWQgZmFpbGVkIHRvIGNyZWF0ZSBtYWlsYm94IGNsaWVudCwg d3JpdGluZyByZWdpc3RlciBieSBDUFUgbm93XG4iLA0KPiArCQkJZHJtX2NydGNfaW5kZXgoJm10 a19jcnRjLT5iYXNlKSk7DQo+ICsJCW10a19jcnRjLT5jbWRxX2NsaWVudCA9IE5VTEw7DQo+ICsJ fQ0KPiArI2VuZGlmDQo+ICAJcmV0dXJuIDA7DQo+ICB9DQo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHBfY29tcC5jIGIvZHJpdmVycy9ncHUvZHJtL21l ZGlhdGVrL210a19kcm1fZGRwX2NvbXAuYw0KPiBpbmRleCA2ZDBmMzQ5ZGRmODIuLjljYzEyYWYy YmMwNiAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZGRw X2NvbXAuYw0KPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHBfY29t cC5jDQo+IEBAIC0zNzAsNiArMzcwLDkgQEAgaW50IG10a19kZHBfY29tcF9pbml0KHN0cnVjdCBk ZXZpY2UgKmRldiwgc3RydWN0IGRldmljZV9ub2RlICpub2RlLA0KPiAgCQkgICAgICBjb25zdCBz dHJ1Y3QgbXRrX2RkcF9jb21wX2Z1bmNzICpmdW5jcykNCj4gIHsNCj4gIAlzdHJ1Y3QgcGxhdGZv cm1fZGV2aWNlICpjb21wX3BkZXY7DQo+ICsJc3RydWN0IHJlc291cmNlIHJlczsNCj4gKwlzdHJ1 Y3QgY21kcV9jbGllbnRfcmVnICpjbWRxX3JlZzsNCj4gKwlpbnQgcmV0ID0gMDsNCj4gIA0KPiAg CWlmIChjb21wX2lkIDwgMCB8fCBjb21wX2lkID49IEREUF9DT01QT05FTlRfSURfTUFYKQ0KPiAg CQlyZXR1cm4gLUVJTlZBTDsNCj4gQEAgLTQwNCw2ICs0MDcsMzQgQEAgaW50IG10a19kZHBfY29t cF9pbml0KHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IGRldmljZV9ub2RlICpub2RlLA0KPiAg CX0NCj4gIAljb21wLT5kZXYgPSAmY29tcF9wZGV2LT5kZXY7DQo+ICANCj4gKyNpZmRlZiBDT05G SUdfTVRLX0NNRFENCj4gKwlpZiAob2ZfYWRkcmVzc190b19yZXNvdXJjZShub2RlLCAwLCAmcmVz KSAhPSAwKSB7DQo+ICsJCWRldl9lcnIoZGV2LCAiTWlzc2luZyByZWcgaW4gJXMgbm9kZVxuIiwN Cj4gKwkJCW5vZGUtPmZ1bGxfbmFtZSk7DQo+ICsJCXJldHVybiAtRUlOVkFMOw0KPiArCX0NCj4g Kwljb21wLT5yZWdzX3BhID0gcmVzLnN0YXJ0Ow0KPiArDQo+ICsJY29tcF9wZGV2ID0gb2ZfZmlu ZF9kZXZpY2VfYnlfbm9kZShub2RlKTsNCj4gKwlpZiAoIWNvbXBfcGRldikgew0KPiArCQlkZXZf d2FybihkZXYsICJXYWl0aW5nIGZvciBjb21wb25lbnQgZGV2aWNlICVzXG4iLA0KPiArCQkJIG5v ZGUtPmZ1bGxfbmFtZSk7DQo+ICsJCXJldHVybiAtRVBST0JFX0RFRkVSOw0KPiArCX0NCj4gKw0K PiArCWNtZHFfcmVnID0ga3phbGxvYyhzaXplb2YoKmNtZHFfcmVnKSwgR0ZQX0tFUk5FTCk7DQo+ ICsJaWYgKCFjbWRxX3JlZykNCj4gKwkJcmV0dXJuIC1FSU5WQUw7DQo+ICsNCj4gKwlyZXQgPSBj bWRxX2Rldl9nZXRfY2xpZW50X3JlZygmY29tcF9wZGV2LT5kZXYsIGNtZHFfcmVnLCAwKTsNCj4g KwlpZiAocmV0ICE9IDApDQo+ICsJCWRldl9kYmcoJmNvbXBfcGRldi0+ZGV2LA0KPiArCQkJImdl dCBtZWRpYXRlayxnY2UtY2xpZW50LXJlZyBmYWlsIVxuIik7DQo+ICsJZWxzZQ0KPiArCQljb21w LT5zdWJzeXMgPSBjbWRxX3JlZy0+c3Vic3lzOw0KPiArDQo+ICsJa2ZyZWUoY21kcV9yZWcpOw0K PiArI2VuZGlmDQoNCkkgd291bGQgbGlrZSB0byBtb3ZlIHRoaXMgcGFydCB0byB0aGUgcGF0Y2gg ImRybS9tZWRpYXRlazogc3VwcG9ydCBDTURRDQppbnRlcmZhY2UgaW4gZGRwIGNvbXBvbmVudCIu DQoNClJlZ2FyZHMsDQpDSw0KDQo+ICAJcmV0dXJuIDA7DQo+ICB9DQo+ICANCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DE11C432C0 for ; Tue, 3 Dec 2019 01:38:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54AA0206E1 for ; Tue, 3 Dec 2019 01:38:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="o5MAdtCC"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="j51GpkAS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54AA0206E1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=31fF8c/D9oMIi51BUdd6ToK2aCeSsdQN6yTxd7J/XVY=; b=o5MAdtCC5XZPBd tQWsYkTSkUNMjI4AcvwNK9muymYUTpaAVzzG9qGMWXxAfi49G4QBWI2vbtpdke1OCVbFfTZHf9d8h 0y2PI3AnzTmz82z9sVmBC2f/bnKFKuL+udbBOIhRnqYg4rEoPdxCIKfRKJkH7P/3qV4FfNQWs5E0K hk22WHzjejPfj9E/4sa9UTI7M0+UrNuJKKZ1X5635RKKSM0rYxxdmPyQVN4VVR08IMSneVvuzgTyM 8pbc2q30uteRw0U0S4akUww+e2uUKsCDfYAW5DSgOgPfmspKmKif7/ufipMYJK4CHiC+w2bgoYfdl cQ6YUr8sM3ubgZJG+D7g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibx9O-0005tF-R3; Tue, 03 Dec 2019 01:38:50 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibx9G-0005lb-Bg; Tue, 03 Dec 2019 01:38:44 +0000 X-UUID: 0b6a9646575d4ea9a30f1f2f0f9a112b-20191202 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=sRwMLRyS13CHATbRSBNDwYj8Xi6G067HZgFuCYy6r9Q=; b=j51GpkASqoKybtF0UEFO5GYzvYBVHTZAb0ja5+kX1aCTTMcI8k3yfEYB6avjzwA7Fnp7fMi9JgRoJ0HY1S0n3xJBZa9CksS1dbRyIoi9WY8Mvkkp6EJWqZ7VNqCYD1UHjvDxS16fa5ZjdZhfHY6Gu7d64/Q7Eq/hs3nTC3X2XVw=; X-UUID: 0b6a9646575d4ea9a30f1f2f0f9a112b-20191202 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1075197562; Mon, 02 Dec 2019 17:38:37 -0800 Received: from mtkmbs05n2.mediatek.inc (172.21.101.140) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 2 Dec 2019 17:38:47 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 3 Dec 2019 09:38:19 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 3 Dec 2019 09:38:14 +0800 Message-ID: <1575337114.1155.4.camel@mtksdaap41> Subject: Re: [PATCH v1 6/6] drm/mediatek: apply CMDQ control flow From: CK Hu To: Bibby Hsieh Date: Tue, 3 Dec 2019 09:38:34 +0800 In-Reply-To: <20191128024238.9399-7-bibby.hsieh@mediatek.com> References: <20191128024238.9399-1-bibby.hsieh@mediatek.com> <20191128024238.9399-7-bibby.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191202_173842_413419_F9D554DF X-CRM114-Status: GOOD ( 20.42 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drinkcat@chromium.org, Yongqiang Niu , srv_heupstream@mediatek.com, David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tfiga@chromium.org, Thierry Reding , linux-mediatek@lists.infradead.org, Philipp Zabel , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi, Bibby: On Thu, 2019-11-28 at 10:42 +0800, Bibby Hsieh wrote: > Unlike other SoCs, MT8183 does not have "shadow" > registers for performaing an atomic video mode > set or page flip at vblank/vsync. > > The CMDQ (Commend Queue) in MT8183 is used to help > update all relevant display controller registers > with critical time limation. > > Signed-off-by: YT Shen > Signed-off-by: CK Hu > Signed-off-by: Philipp Zabel > Signed-off-by: Bibby Hsieh > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 86 ++++++++++++++++++++- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 31 ++++++++ > 2 files changed, 113 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > index fcf4e755e0bd..1b4e537ac3c1 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > @@ -12,6 +12,8 @@ > #include > #include > #include > +#include > +#include > > #include "mtk_drm_drv.h" > #include "mtk_drm_crtc.h" > @@ -42,6 +44,9 @@ struct mtk_drm_crtc { > unsigned int layer_nr; > bool pending_planes; > > + struct cmdq_client *cmdq_client; > + u32 cmdq_event; > + > void __iomem *config_regs; > const struct mtk_mmsys_reg_data *mmsys_reg_data; > struct mtk_disp_mutex *mutex; > @@ -56,6 +61,11 @@ struct mtk_crtc_state { > unsigned int pending_width; > unsigned int pending_height; > unsigned int pending_vrefresh; > + struct cmdq_pkt *cmdq_handle; > +}; > + > +struct mtk_cmdq_cb_data { > + struct cmdq_pkt *cmdq_handle; > }; > > static inline struct mtk_drm_crtc *to_mtk_crtc(struct drm_crtc *c) > @@ -229,6 +239,46 @@ struct mtk_ddp_comp *mtk_drm_ddp_comp_for_plane(struct drm_crtc *crtc, > return NULL; > } > > +#ifdef CONFIG_MTK_CMDQ > +static void ddp_cmdq_cb(struct cmdq_cb_data data) > +{ > + struct mtk_cmdq_cb_data *cb_data = data.data; > + > + cmdq_pkt_destroy(cb_data->cmdq_handle); > + kfree(cb_data); > +} > + > +static void mtk_cmdq_acquire(struct drm_crtc *crtc) > +{ > + struct mtk_crtc_state *mtk_crtc_state = > + to_mtk_crtc_state(crtc->state); > + struct mtk_drm_crtc *mtk_crtc = to_mtk_crtc(crtc); > + > + mtk_crtc_state->cmdq_handle = > + cmdq_pkt_create(mtk_crtc->cmdq_client, > + PAGE_SIZE); I would like to remove atomic feature in cmdq driver and drm driver could reuse the pkt. Please refer to [1] for detail. [1] http://lists.infradead.org/pipermail/linux-mediatek/2019-January/016866.html > + cmdq_pkt_clear_event(mtk_crtc_state->cmdq_handle, > + mtk_crtc->cmdq_event); > + cmdq_pkt_wfe(mtk_crtc_state->cmdq_handle, mtk_crtc->cmdq_event); > +} > + > +static void mtk_cmdq_release(struct drm_crtc *crtc) > +{ > + struct mtk_crtc_state *mtk_crtc_state = > + to_mtk_crtc_state(crtc->state); > + struct mtk_cmdq_cb_data *cb_data; > + > + cb_data = kmalloc(sizeof(*cb_data), GFP_KERNEL); > + if (!cb_data) { > + DRM_DEV_ERROR(crtc->dev->dev, "Failed to alloc cb_data\n"); > + return; > + } > + > + cb_data->cmdq_handle = mtk_crtc_state->cmdq_handle; > + cmdq_pkt_flush_async(mtk_crtc_state->cmdq_handle, > + ddp_cmdq_cb, cb_data); > +} > +#endif > static int mtk_crtc_ddp_hw_init(struct mtk_drm_crtc *mtk_crtc) > { > struct drm_crtc *crtc = &mtk_crtc->base; > @@ -383,7 +433,8 @@ static void mtk_crtc_ddp_config(struct drm_crtc *crtc) > if (state->pending_config) { > mtk_ddp_comp_config(comp, state->pending_width, > state->pending_height, > - state->pending_vrefresh, 0, NULL); > + state->pending_vrefresh, 0, > + state->cmdq_handle); > > state->pending_config = false; > } > @@ -403,7 +454,8 @@ static void mtk_crtc_ddp_config(struct drm_crtc *crtc) > > if (comp) > mtk_ddp_comp_layer_config(comp, local_layer, > - plane_state, NULL); > + plane_state, > + state->cmdq_handle); > plane_state->pending.config = false; > } > mtk_crtc->pending_planes = false; > @@ -454,6 +506,13 @@ void mtk_drm_crtc_cursor_update(struct drm_crtc *crtc, struct drm_plane *plane, > mtk_crtc_ddp_config(crtc); > mtk_disp_mutex_release(mtk_crtc->mutex); > } > +#ifdef CONFIG_MTK_CMDQ > + if (mtk_crtc->cmdq_client) { > + mtk_cmdq_acquire(crtc); > + mtk_crtc_ddp_config(crtc); > + mtk_cmdq_release(crtc); > + } > +#endif > mutex_unlock(&priv->hw_lock); > } > > @@ -570,6 +629,13 @@ static void mtk_drm_crtc_atomic_flush(struct drm_crtc *crtc, > mtk_crtc_ddp_config(crtc); > mtk_disp_mutex_release(mtk_crtc->mutex); > } > +#ifdef CONFIG_MTK_CMDQ > + if (mtk_crtc->cmdq_client) { > + mtk_cmdq_acquire(crtc); > + mtk_crtc_ddp_config(crtc); > + mtk_cmdq_release(crtc); > + } > +#endif This part is almost the same as the one in mtk_drm_crtc_cursor_update(), try to merge them. > } > > static const struct drm_crtc_funcs mtk_crtc_funcs = { > @@ -619,7 +685,7 @@ void mtk_crtc_ddp_irq(struct drm_crtc *crtc, struct mtk_ddp_comp *comp) > struct mtk_drm_crtc *mtk_crtc = to_mtk_crtc(crtc); > struct mtk_drm_private *priv = crtc->dev->dev_private; > > - if (!priv->data->shadow_register) > + if (!priv->data->shadow_register && !mtk_crtc->cmdq_client) > mtk_crtc_ddp_config(crtc); > > mtk_drm_finish_page_flip(mtk_crtc); > @@ -761,6 +827,18 @@ int mtk_drm_crtc_create(struct drm_device *drm_dev, > drm_mode_crtc_set_gamma_size(&mtk_crtc->base, MTK_LUT_SIZE); > drm_crtc_enable_color_mgmt(&mtk_crtc->base, 0, false, MTK_LUT_SIZE); > priv->num_pipes++; > - > +#ifdef CONFIG_MTK_CMDQ > + mtk_crtc->cmdq_client = > + cmdq_mbox_create(dev, drm_crtc_index(&mtk_crtc->base), > + 2000); > + of_property_read_u32_index(dev->of_node, "mediatek,gce-events", > + drm_crtc_index(&mtk_crtc->base), > + &mtk_crtc->cmdq_event); > + if (IS_ERR(mtk_crtc->cmdq_client)) { > + dev_dbg(dev, "mtk_crtc %d failed to create mailbox client, writing register by CPU now\n", > + drm_crtc_index(&mtk_crtc->base)); > + mtk_crtc->cmdq_client = NULL; > + } > +#endif > return 0; > } > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > index 6d0f349ddf82..9cc12af2bc06 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > @@ -370,6 +370,9 @@ int mtk_ddp_comp_init(struct device *dev, struct device_node *node, > const struct mtk_ddp_comp_funcs *funcs) > { > struct platform_device *comp_pdev; > + struct resource res; > + struct cmdq_client_reg *cmdq_reg; > + int ret = 0; > > if (comp_id < 0 || comp_id >= DDP_COMPONENT_ID_MAX) > return -EINVAL; > @@ -404,6 +407,34 @@ int mtk_ddp_comp_init(struct device *dev, struct device_node *node, > } > comp->dev = &comp_pdev->dev; > > +#ifdef CONFIG_MTK_CMDQ > + if (of_address_to_resource(node, 0, &res) != 0) { > + dev_err(dev, "Missing reg in %s node\n", > + node->full_name); > + return -EINVAL; > + } > + comp->regs_pa = res.start; > + > + comp_pdev = of_find_device_by_node(node); > + if (!comp_pdev) { > + dev_warn(dev, "Waiting for component device %s\n", > + node->full_name); > + return -EPROBE_DEFER; > + } > + > + cmdq_reg = kzalloc(sizeof(*cmdq_reg), GFP_KERNEL); > + if (!cmdq_reg) > + return -EINVAL; > + > + ret = cmdq_dev_get_client_reg(&comp_pdev->dev, cmdq_reg, 0); > + if (ret != 0) > + dev_dbg(&comp_pdev->dev, > + "get mediatek,gce-client-reg fail!\n"); > + else > + comp->subsys = cmdq_reg->subsys; > + > + kfree(cmdq_reg); > +#endif I would like to move this part to the patch "drm/mediatek: support CMDQ interface in ddp component". Regards, CK > return 0; > } > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60E7CC432C0 for ; Tue, 3 Dec 2019 01:38:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 33C37206E1 for ; Tue, 3 Dec 2019 01:38:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jsHUU1D7"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="j51GpkAS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33C37206E1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+9NloPOI2/DnW07mouGdR+TFH2FcaHiiIdggtUh9W14=; b=jsHUU1D7/bjesm KqYZCJ/QHMHfzL1746J9J4QqwF0TD3CqU/Bb1TF7+geEnCvG38t8v6YDtfxwLBfZupsAp3gUbtdlm CXBjtHgZVwn4AW8ZsTJaVAJjlL+7/g+SuJNl18XpepZmhxgitt3KISRem8IaqgYoHnjXY3MwtB2rt bHNF3F7v9g5mkmelw8yVHri3HD9YFG/+Incl9FbXsVsysXPAlu9kWD3kPjid4SonSHCrmYWB+UFy7 qCCWucCXvzsn7QpHDd9F6EXb4E3rJXdrDSA7gb8OIQRxPTKiVFpWCxptxGTjcXrYkQwa9YZXIz2W/ 7TI7U18FSzDUpOfAwHQw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibx9K-0005md-Bh; Tue, 03 Dec 2019 01:38:46 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibx9G-0005lb-Bg; Tue, 03 Dec 2019 01:38:44 +0000 X-UUID: 0b6a9646575d4ea9a30f1f2f0f9a112b-20191202 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=sRwMLRyS13CHATbRSBNDwYj8Xi6G067HZgFuCYy6r9Q=; b=j51GpkASqoKybtF0UEFO5GYzvYBVHTZAb0ja5+kX1aCTTMcI8k3yfEYB6avjzwA7Fnp7fMi9JgRoJ0HY1S0n3xJBZa9CksS1dbRyIoi9WY8Mvkkp6EJWqZ7VNqCYD1UHjvDxS16fa5ZjdZhfHY6Gu7d64/Q7Eq/hs3nTC3X2XVw=; X-UUID: 0b6a9646575d4ea9a30f1f2f0f9a112b-20191202 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1075197562; Mon, 02 Dec 2019 17:38:37 -0800 Received: from mtkmbs05n2.mediatek.inc (172.21.101.140) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 2 Dec 2019 17:38:47 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 3 Dec 2019 09:38:19 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 3 Dec 2019 09:38:14 +0800 Message-ID: <1575337114.1155.4.camel@mtksdaap41> Subject: Re: [PATCH v1 6/6] drm/mediatek: apply CMDQ control flow From: CK Hu To: Bibby Hsieh Date: Tue, 3 Dec 2019 09:38:34 +0800 In-Reply-To: <20191128024238.9399-7-bibby.hsieh@mediatek.com> References: <20191128024238.9399-1-bibby.hsieh@mediatek.com> <20191128024238.9399-7-bibby.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191202_173842_413419_F9D554DF X-CRM114-Status: GOOD ( 20.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drinkcat@chromium.org, Yongqiang Niu , srv_heupstream@mediatek.com, David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tfiga@chromium.org, YT Shen , Thierry Reding , linux-mediatek@lists.infradead.org, Philipp Zabel , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Bibby: On Thu, 2019-11-28 at 10:42 +0800, Bibby Hsieh wrote: > Unlike other SoCs, MT8183 does not have "shadow" > registers for performaing an atomic video mode > set or page flip at vblank/vsync. > > The CMDQ (Commend Queue) in MT8183 is used to help > update all relevant display controller registers > with critical time limation. > > Signed-off-by: YT Shen > Signed-off-by: CK Hu > Signed-off-by: Philipp Zabel > Signed-off-by: Bibby Hsieh > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 86 ++++++++++++++++++++- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 31 ++++++++ > 2 files changed, 113 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > index fcf4e755e0bd..1b4e537ac3c1 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > @@ -12,6 +12,8 @@ > #include > #include > #include > +#include > +#include > > #include "mtk_drm_drv.h" > #include "mtk_drm_crtc.h" > @@ -42,6 +44,9 @@ struct mtk_drm_crtc { > unsigned int layer_nr; > bool pending_planes; > > + struct cmdq_client *cmdq_client; > + u32 cmdq_event; > + > void __iomem *config_regs; > const struct mtk_mmsys_reg_data *mmsys_reg_data; > struct mtk_disp_mutex *mutex; > @@ -56,6 +61,11 @@ struct mtk_crtc_state { > unsigned int pending_width; > unsigned int pending_height; > unsigned int pending_vrefresh; > + struct cmdq_pkt *cmdq_handle; > +}; > + > +struct mtk_cmdq_cb_data { > + struct cmdq_pkt *cmdq_handle; > }; > > static inline struct mtk_drm_crtc *to_mtk_crtc(struct drm_crtc *c) > @@ -229,6 +239,46 @@ struct mtk_ddp_comp *mtk_drm_ddp_comp_for_plane(struct drm_crtc *crtc, > return NULL; > } > > +#ifdef CONFIG_MTK_CMDQ > +static void ddp_cmdq_cb(struct cmdq_cb_data data) > +{ > + struct mtk_cmdq_cb_data *cb_data = data.data; > + > + cmdq_pkt_destroy(cb_data->cmdq_handle); > + kfree(cb_data); > +} > + > +static void mtk_cmdq_acquire(struct drm_crtc *crtc) > +{ > + struct mtk_crtc_state *mtk_crtc_state = > + to_mtk_crtc_state(crtc->state); > + struct mtk_drm_crtc *mtk_crtc = to_mtk_crtc(crtc); > + > + mtk_crtc_state->cmdq_handle = > + cmdq_pkt_create(mtk_crtc->cmdq_client, > + PAGE_SIZE); I would like to remove atomic feature in cmdq driver and drm driver could reuse the pkt. Please refer to [1] for detail. [1] http://lists.infradead.org/pipermail/linux-mediatek/2019-January/016866.html > + cmdq_pkt_clear_event(mtk_crtc_state->cmdq_handle, > + mtk_crtc->cmdq_event); > + cmdq_pkt_wfe(mtk_crtc_state->cmdq_handle, mtk_crtc->cmdq_event); > +} > + > +static void mtk_cmdq_release(struct drm_crtc *crtc) > +{ > + struct mtk_crtc_state *mtk_crtc_state = > + to_mtk_crtc_state(crtc->state); > + struct mtk_cmdq_cb_data *cb_data; > + > + cb_data = kmalloc(sizeof(*cb_data), GFP_KERNEL); > + if (!cb_data) { > + DRM_DEV_ERROR(crtc->dev->dev, "Failed to alloc cb_data\n"); > + return; > + } > + > + cb_data->cmdq_handle = mtk_crtc_state->cmdq_handle; > + cmdq_pkt_flush_async(mtk_crtc_state->cmdq_handle, > + ddp_cmdq_cb, cb_data); > +} > +#endif > static int mtk_crtc_ddp_hw_init(struct mtk_drm_crtc *mtk_crtc) > { > struct drm_crtc *crtc = &mtk_crtc->base; > @@ -383,7 +433,8 @@ static void mtk_crtc_ddp_config(struct drm_crtc *crtc) > if (state->pending_config) { > mtk_ddp_comp_config(comp, state->pending_width, > state->pending_height, > - state->pending_vrefresh, 0, NULL); > + state->pending_vrefresh, 0, > + state->cmdq_handle); > > state->pending_config = false; > } > @@ -403,7 +454,8 @@ static void mtk_crtc_ddp_config(struct drm_crtc *crtc) > > if (comp) > mtk_ddp_comp_layer_config(comp, local_layer, > - plane_state, NULL); > + plane_state, > + state->cmdq_handle); > plane_state->pending.config = false; > } > mtk_crtc->pending_planes = false; > @@ -454,6 +506,13 @@ void mtk_drm_crtc_cursor_update(struct drm_crtc *crtc, struct drm_plane *plane, > mtk_crtc_ddp_config(crtc); > mtk_disp_mutex_release(mtk_crtc->mutex); > } > +#ifdef CONFIG_MTK_CMDQ > + if (mtk_crtc->cmdq_client) { > + mtk_cmdq_acquire(crtc); > + mtk_crtc_ddp_config(crtc); > + mtk_cmdq_release(crtc); > + } > +#endif > mutex_unlock(&priv->hw_lock); > } > > @@ -570,6 +629,13 @@ static void mtk_drm_crtc_atomic_flush(struct drm_crtc *crtc, > mtk_crtc_ddp_config(crtc); > mtk_disp_mutex_release(mtk_crtc->mutex); > } > +#ifdef CONFIG_MTK_CMDQ > + if (mtk_crtc->cmdq_client) { > + mtk_cmdq_acquire(crtc); > + mtk_crtc_ddp_config(crtc); > + mtk_cmdq_release(crtc); > + } > +#endif This part is almost the same as the one in mtk_drm_crtc_cursor_update(), try to merge them. > } > > static const struct drm_crtc_funcs mtk_crtc_funcs = { > @@ -619,7 +685,7 @@ void mtk_crtc_ddp_irq(struct drm_crtc *crtc, struct mtk_ddp_comp *comp) > struct mtk_drm_crtc *mtk_crtc = to_mtk_crtc(crtc); > struct mtk_drm_private *priv = crtc->dev->dev_private; > > - if (!priv->data->shadow_register) > + if (!priv->data->shadow_register && !mtk_crtc->cmdq_client) > mtk_crtc_ddp_config(crtc); > > mtk_drm_finish_page_flip(mtk_crtc); > @@ -761,6 +827,18 @@ int mtk_drm_crtc_create(struct drm_device *drm_dev, > drm_mode_crtc_set_gamma_size(&mtk_crtc->base, MTK_LUT_SIZE); > drm_crtc_enable_color_mgmt(&mtk_crtc->base, 0, false, MTK_LUT_SIZE); > priv->num_pipes++; > - > +#ifdef CONFIG_MTK_CMDQ > + mtk_crtc->cmdq_client = > + cmdq_mbox_create(dev, drm_crtc_index(&mtk_crtc->base), > + 2000); > + of_property_read_u32_index(dev->of_node, "mediatek,gce-events", > + drm_crtc_index(&mtk_crtc->base), > + &mtk_crtc->cmdq_event); > + if (IS_ERR(mtk_crtc->cmdq_client)) { > + dev_dbg(dev, "mtk_crtc %d failed to create mailbox client, writing register by CPU now\n", > + drm_crtc_index(&mtk_crtc->base)); > + mtk_crtc->cmdq_client = NULL; > + } > +#endif > return 0; > } > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > index 6d0f349ddf82..9cc12af2bc06 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > @@ -370,6 +370,9 @@ int mtk_ddp_comp_init(struct device *dev, struct device_node *node, > const struct mtk_ddp_comp_funcs *funcs) > { > struct platform_device *comp_pdev; > + struct resource res; > + struct cmdq_client_reg *cmdq_reg; > + int ret = 0; > > if (comp_id < 0 || comp_id >= DDP_COMPONENT_ID_MAX) > return -EINVAL; > @@ -404,6 +407,34 @@ int mtk_ddp_comp_init(struct device *dev, struct device_node *node, > } > comp->dev = &comp_pdev->dev; > > +#ifdef CONFIG_MTK_CMDQ > + if (of_address_to_resource(node, 0, &res) != 0) { > + dev_err(dev, "Missing reg in %s node\n", > + node->full_name); > + return -EINVAL; > + } > + comp->regs_pa = res.start; > + > + comp_pdev = of_find_device_by_node(node); > + if (!comp_pdev) { > + dev_warn(dev, "Waiting for component device %s\n", > + node->full_name); > + return -EPROBE_DEFER; > + } > + > + cmdq_reg = kzalloc(sizeof(*cmdq_reg), GFP_KERNEL); > + if (!cmdq_reg) > + return -EINVAL; > + > + ret = cmdq_dev_get_client_reg(&comp_pdev->dev, cmdq_reg, 0); > + if (ret != 0) > + dev_dbg(&comp_pdev->dev, > + "get mediatek,gce-client-reg fail!\n"); > + else > + comp->subsys = cmdq_reg->subsys; > + > + kfree(cmdq_reg); > +#endif I would like to move this part to the patch "drm/mediatek: support CMDQ interface in ddp component". Regards, CK > return 0; > } > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: CK Hu Subject: Re: [PATCH v1 6/6] drm/mediatek: apply CMDQ control flow Date: Tue, 3 Dec 2019 09:38:34 +0800 Message-ID: <1575337114.1155.4.camel@mtksdaap41> References: <20191128024238.9399-1-bibby.hsieh@mediatek.com> <20191128024238.9399-7-bibby.hsieh@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20191128024238.9399-7-bibby.hsieh@mediatek.com> Sender: linux-kernel-owner@vger.kernel.org To: Bibby Hsieh Cc: David Airlie , Matthias Brugger , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Philipp Zabel , YT Shen , Thierry Reding , linux-arm-kernel@lists.infradead.org, tfiga@chromium.org, drinkcat@chromium.org, linux-kernel@vger.kernel.org, srv_heupstream@mediatek.com, Yongqiang Niu List-Id: dri-devel@lists.freedesktop.org SGksIEJpYmJ5Og0KDQpPbiBUaHUsIDIwMTktMTEtMjggYXQgMTA6NDIgKzA4MDAsIEJpYmJ5IEhz aWVoIHdyb3RlOg0KPiBVbmxpa2Ugb3RoZXIgU29DcywgTVQ4MTgzIGRvZXMgbm90IGhhdmUgInNo YWRvdyINCj4gcmVnaXN0ZXJzIGZvciBwZXJmb3JtYWluZyBhbiBhdG9taWMgdmlkZW8gbW9kZQ0K PiBzZXQgb3IgcGFnZSBmbGlwIGF0IHZibGFuay92c3luYy4NCj4gDQo+IFRoZSBDTURRIChDb21t ZW5kIFF1ZXVlKSBpbiBNVDgxODMgaXMgdXNlZCB0byBoZWxwDQo+IHVwZGF0ZSBhbGwgcmVsZXZh bnQgZGlzcGxheSBjb250cm9sbGVyIHJlZ2lzdGVycw0KPiB3aXRoIGNyaXRpY2FsIHRpbWUgbGlt YXRpb24uDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBZVCBTaGVuIDx5dC5zaGVuQG1lZGlhdGVrLmNv bT4NCj4gU2lnbmVkLW9mZi1ieTogQ0sgSHUgPGNrLmh1QG1lZGlhdGVrLmNvbT4NCj4gU2lnbmVk LW9mZi1ieTogUGhpbGlwcCBaYWJlbCA8cC56YWJlbEBwZW5ndXRyb25peC5kZT4NCj4gU2lnbmVk LW9mZi1ieTogQmliYnkgSHNpZWggPGJpYmJ5LmhzaWVoQG1lZGlhdGVrLmNvbT4NCj4gU2lnbmVk LW9mZi1ieTogWW9uZ3FpYW5nIE5pdSA8eW9uZ3FpYW5nLm5pdUBtZWRpYXRlay5jb20+DQo+IC0t LQ0KPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fY3J0Yy5jICAgICB8IDg2ICsr KysrKysrKysrKysrKysrKysrLQ0KPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1f ZGRwX2NvbXAuYyB8IDMxICsrKysrKysrDQo+ICAyIGZpbGVzIGNoYW5nZWQsIDExMyBpbnNlcnRp b25zKCspLCA0IGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9tZWRpYXRlay9tdGtfZHJtX2NydGMuYyBiL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtf ZHJtX2NydGMuYw0KPiBpbmRleCBmY2Y0ZTc1NWUwYmQuLjFiNGU1MzdhYzNjMSAxMDA2NDQNCj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fY3J0Yy5jDQo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2NydGMuYw0KPiBAQCAtMTIsNiArMTIsOCBA QA0KPiAgI2luY2x1ZGUgPGRybS9kcm1fcGxhbmVfaGVscGVyLmg+DQo+ICAjaW5jbHVkZSA8ZHJt L2RybV9wcm9iZV9oZWxwZXIuaD4NCj4gICNpbmNsdWRlIDxkcm0vZHJtX3ZibGFuay5oPg0KPiAr I2luY2x1ZGUgPGxpbnV4L29mX2FkZHJlc3MuaD4NCj4gKyNpbmNsdWRlIDxsaW51eC9zb2MvbWVk aWF0ZWsvbXRrLWNtZHEuaD4NCj4gIA0KPiAgI2luY2x1ZGUgIm10a19kcm1fZHJ2LmgiDQo+ICAj aW5jbHVkZSAibXRrX2RybV9jcnRjLmgiDQo+IEBAIC00Miw2ICs0NCw5IEBAIHN0cnVjdCBtdGtf ZHJtX2NydGMgew0KPiAgCXVuc2lnbmVkIGludAkJCWxheWVyX25yOw0KPiAgCWJvb2wJCQkJcGVu ZGluZ19wbGFuZXM7DQo+ICANCj4gKwlzdHJ1Y3QgY21kcV9jbGllbnQJCSpjbWRxX2NsaWVudDsN Cj4gKwl1MzIJCQkJY21kcV9ldmVudDsNCj4gKw0KPiAgCXZvaWQgX19pb21lbQkJCSpjb25maWdf cmVnczsNCj4gIAljb25zdCBzdHJ1Y3QgbXRrX21tc3lzX3JlZ19kYXRhICptbXN5c19yZWdfZGF0 YTsNCj4gIAlzdHJ1Y3QgbXRrX2Rpc3BfbXV0ZXgJCSptdXRleDsNCj4gQEAgLTU2LDYgKzYxLDEx IEBAIHN0cnVjdCBtdGtfY3J0Y19zdGF0ZSB7DQo+ICAJdW5zaWduZWQgaW50CQkJcGVuZGluZ193 aWR0aDsNCj4gIAl1bnNpZ25lZCBpbnQJCQlwZW5kaW5nX2hlaWdodDsNCj4gIAl1bnNpZ25lZCBp bnQJCQlwZW5kaW5nX3ZyZWZyZXNoOw0KPiArCXN0cnVjdCBjbWRxX3BrdAkJCSpjbWRxX2hhbmRs ZTsNCj4gK307DQo+ICsNCj4gK3N0cnVjdCBtdGtfY21kcV9jYl9kYXRhIHsNCj4gKwlzdHJ1Y3Qg Y21kcV9wa3QJCQkqY21kcV9oYW5kbGU7DQo+ICB9Ow0KPiAgDQo+ICBzdGF0aWMgaW5saW5lIHN0 cnVjdCBtdGtfZHJtX2NydGMgKnRvX210a19jcnRjKHN0cnVjdCBkcm1fY3J0YyAqYykNCj4gQEAg LTIyOSw2ICsyMzksNDYgQEAgc3RydWN0IG10a19kZHBfY29tcCAqbXRrX2RybV9kZHBfY29tcF9m b3JfcGxhbmUoc3RydWN0IGRybV9jcnRjICpjcnRjLA0KPiAgCXJldHVybiBOVUxMOw0KPiAgfQ0K PiAgDQo+ICsjaWZkZWYgQ09ORklHX01US19DTURRDQo+ICtzdGF0aWMgdm9pZCBkZHBfY21kcV9j YihzdHJ1Y3QgY21kcV9jYl9kYXRhIGRhdGEpDQo+ICt7DQo+ICsJc3RydWN0IG10a19jbWRxX2Ni X2RhdGEgKmNiX2RhdGEgPSBkYXRhLmRhdGE7DQo+ICsNCj4gKwljbWRxX3BrdF9kZXN0cm95KGNi X2RhdGEtPmNtZHFfaGFuZGxlKTsNCj4gKwlrZnJlZShjYl9kYXRhKTsNCj4gK30NCj4gKw0KPiAr c3RhdGljIHZvaWQgbXRrX2NtZHFfYWNxdWlyZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMpDQo+ICt7 DQo+ICsJc3RydWN0IG10a19jcnRjX3N0YXRlICptdGtfY3J0Y19zdGF0ZSA9DQo+ICsJCQl0b19t dGtfY3J0Y19zdGF0ZShjcnRjLT5zdGF0ZSk7DQo+ICsJc3RydWN0IG10a19kcm1fY3J0YyAqbXRr X2NydGMgPSB0b19tdGtfY3J0YyhjcnRjKTsNCj4gKw0KPiArCW10a19jcnRjX3N0YXRlLT5jbWRx X2hhbmRsZSA9DQo+ICsJCQljbWRxX3BrdF9jcmVhdGUobXRrX2NydGMtPmNtZHFfY2xpZW50LA0K PiArCQkJCQlQQUdFX1NJWkUpOw0KDQpJIHdvdWxkIGxpa2UgdG8gcmVtb3ZlIGF0b21pYyBmZWF0 dXJlIGluIGNtZHEgZHJpdmVyIGFuZCBkcm0gZHJpdmVyDQpjb3VsZCByZXVzZSB0aGUgcGt0LiBQ bGVhc2UgcmVmZXIgdG8gWzFdIGZvciBkZXRhaWwuDQoNClsxXQ0KaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvcGlwZXJtYWlsL2xpbnV4LW1lZGlhdGVrLzIwMTktSmFudWFyeS8wMTY4NjYuaHRt bA0KDQo+ICsJY21kcV9wa3RfY2xlYXJfZXZlbnQobXRrX2NydGNfc3RhdGUtPmNtZHFfaGFuZGxl LA0KPiArCQkJICAgICBtdGtfY3J0Yy0+Y21kcV9ldmVudCk7DQo+ICsJY21kcV9wa3Rfd2ZlKG10 a19jcnRjX3N0YXRlLT5jbWRxX2hhbmRsZSwgbXRrX2NydGMtPmNtZHFfZXZlbnQpOw0KPiArfQ0K PiArDQo+ICtzdGF0aWMgdm9pZCBtdGtfY21kcV9yZWxlYXNlKHN0cnVjdCBkcm1fY3J0YyAqY3J0 YykNCj4gK3sNCj4gKwlzdHJ1Y3QgbXRrX2NydGNfc3RhdGUgKm10a19jcnRjX3N0YXRlID0NCj4g KwkJCXRvX210a19jcnRjX3N0YXRlKGNydGMtPnN0YXRlKTsNCj4gKwlzdHJ1Y3QgbXRrX2NtZHFf Y2JfZGF0YSAqY2JfZGF0YTsNCj4gKw0KPiArCWNiX2RhdGEgPSBrbWFsbG9jKHNpemVvZigqY2Jf ZGF0YSksIEdGUF9LRVJORUwpOw0KPiArCWlmICghY2JfZGF0YSkgew0KPiArCQlEUk1fREVWX0VS Uk9SKGNydGMtPmRldi0+ZGV2LCAiRmFpbGVkIHRvIGFsbG9jIGNiX2RhdGFcbiIpOw0KPiArCQly ZXR1cm47DQo+ICsJfQ0KPiArDQo+ICsJY2JfZGF0YS0+Y21kcV9oYW5kbGUgPSBtdGtfY3J0Y19z dGF0ZS0+Y21kcV9oYW5kbGU7DQo+ICsJY21kcV9wa3RfZmx1c2hfYXN5bmMobXRrX2NydGNfc3Rh dGUtPmNtZHFfaGFuZGxlLA0KPiArCQkJICAgICBkZHBfY21kcV9jYiwgY2JfZGF0YSk7DQo+ICt9 DQo+ICsjZW5kaWYNCj4gIHN0YXRpYyBpbnQgbXRrX2NydGNfZGRwX2h3X2luaXQoc3RydWN0IG10 a19kcm1fY3J0YyAqbXRrX2NydGMpDQo+ICB7DQo+ICAJc3RydWN0IGRybV9jcnRjICpjcnRjID0g Jm10a19jcnRjLT5iYXNlOw0KPiBAQCAtMzgzLDcgKzQzMyw4IEBAIHN0YXRpYyB2b2lkIG10a19j cnRjX2RkcF9jb25maWcoc3RydWN0IGRybV9jcnRjICpjcnRjKQ0KPiAgCWlmIChzdGF0ZS0+cGVu ZGluZ19jb25maWcpIHsNCj4gIAkJbXRrX2RkcF9jb21wX2NvbmZpZyhjb21wLCBzdGF0ZS0+cGVu ZGluZ193aWR0aCwNCj4gIAkJCQkgICAgc3RhdGUtPnBlbmRpbmdfaGVpZ2h0LA0KPiAtCQkJCSAg ICBzdGF0ZS0+cGVuZGluZ192cmVmcmVzaCwgMCwgTlVMTCk7DQo+ICsJCQkJICAgIHN0YXRlLT5w ZW5kaW5nX3ZyZWZyZXNoLCAwLA0KPiArCQkJCSAgICBzdGF0ZS0+Y21kcV9oYW5kbGUpOw0KPiAg DQo+ICAJCXN0YXRlLT5wZW5kaW5nX2NvbmZpZyA9IGZhbHNlOw0KPiAgCX0NCj4gQEAgLTQwMyw3 ICs0NTQsOCBAQCBzdGF0aWMgdm9pZCBtdGtfY3J0Y19kZHBfY29uZmlnKHN0cnVjdCBkcm1fY3J0 YyAqY3J0YykNCj4gIA0KPiAgCQkJaWYgKGNvbXApDQo+ICAJCQkJbXRrX2RkcF9jb21wX2xheWVy X2NvbmZpZyhjb21wLCBsb2NhbF9sYXllciwNCj4gLQkJCQkJCQkgIHBsYW5lX3N0YXRlLCBOVUxM KTsNCj4gKwkJCQkJCQkgIHBsYW5lX3N0YXRlLA0KPiArCQkJCQkJCSAgc3RhdGUtPmNtZHFfaGFu ZGxlKTsNCj4gIAkJCXBsYW5lX3N0YXRlLT5wZW5kaW5nLmNvbmZpZyA9IGZhbHNlOw0KPiAgCQl9 DQo+ICAJCW10a19jcnRjLT5wZW5kaW5nX3BsYW5lcyA9IGZhbHNlOw0KPiBAQCAtNDU0LDYgKzUw NiwxMyBAQCB2b2lkIG10a19kcm1fY3J0Y19jdXJzb3JfdXBkYXRlKHN0cnVjdCBkcm1fY3J0YyAq Y3J0Yywgc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsDQo+ICAJCW10a19jcnRjX2RkcF9jb25maWco Y3J0Yyk7DQo+ICAJCW10a19kaXNwX211dGV4X3JlbGVhc2UobXRrX2NydGMtPm11dGV4KTsNCj4g IAl9DQo+ICsjaWZkZWYgQ09ORklHX01US19DTURRDQo+ICsJaWYgKG10a19jcnRjLT5jbWRxX2Ns aWVudCkgew0KPiArCQltdGtfY21kcV9hY3F1aXJlKGNydGMpOw0KPiArCQltdGtfY3J0Y19kZHBf Y29uZmlnKGNydGMpOw0KPiArCQltdGtfY21kcV9yZWxlYXNlKGNydGMpOw0KPiArCX0NCj4gKyNl bmRpZg0KPiAgCW11dGV4X3VubG9jaygmcHJpdi0+aHdfbG9jayk7DQo+ICB9DQo+ICANCj4gQEAg LTU3MCw2ICs2MjksMTMgQEAgc3RhdGljIHZvaWQgbXRrX2RybV9jcnRjX2F0b21pY19mbHVzaChz dHJ1Y3QgZHJtX2NydGMgKmNydGMsDQo+ICAJCW10a19jcnRjX2RkcF9jb25maWcoY3J0Yyk7DQo+ ICAJCW10a19kaXNwX211dGV4X3JlbGVhc2UobXRrX2NydGMtPm11dGV4KTsNCj4gIAl9DQo+ICsj aWZkZWYgQ09ORklHX01US19DTURRDQo+ICsJaWYgKG10a19jcnRjLT5jbWRxX2NsaWVudCkgew0K PiArCQltdGtfY21kcV9hY3F1aXJlKGNydGMpOw0KPiArCQltdGtfY3J0Y19kZHBfY29uZmlnKGNy dGMpOw0KPiArCQltdGtfY21kcV9yZWxlYXNlKGNydGMpOw0KPiArCX0NCj4gKyNlbmRpZg0KDQpU aGlzIHBhcnQgaXMgYWxtb3N0IHRoZSBzYW1lIGFzIHRoZSBvbmUgaW4gbXRrX2RybV9jcnRjX2N1 cnNvcl91cGRhdGUoKSwNCnRyeSB0byBtZXJnZSB0aGVtLg0KDQo+ICB9DQo+ICANCj4gIHN0YXRp YyBjb25zdCBzdHJ1Y3QgZHJtX2NydGNfZnVuY3MgbXRrX2NydGNfZnVuY3MgPSB7DQo+IEBAIC02 MTksNyArNjg1LDcgQEAgdm9pZCBtdGtfY3J0Y19kZHBfaXJxKHN0cnVjdCBkcm1fY3J0YyAqY3J0 Yywgc3RydWN0IG10a19kZHBfY29tcCAqY29tcCkNCj4gIAlzdHJ1Y3QgbXRrX2RybV9jcnRjICpt dGtfY3J0YyA9IHRvX210a19jcnRjKGNydGMpOw0KPiAgCXN0cnVjdCBtdGtfZHJtX3ByaXZhdGUg KnByaXYgPSBjcnRjLT5kZXYtPmRldl9wcml2YXRlOw0KPiAgDQo+IC0JaWYgKCFwcml2LT5kYXRh LT5zaGFkb3dfcmVnaXN0ZXIpDQo+ICsJaWYgKCFwcml2LT5kYXRhLT5zaGFkb3dfcmVnaXN0ZXIg JiYgIW10a19jcnRjLT5jbWRxX2NsaWVudCkNCj4gIAkJbXRrX2NydGNfZGRwX2NvbmZpZyhjcnRj KTsNCj4gIA0KPiAgCW10a19kcm1fZmluaXNoX3BhZ2VfZmxpcChtdGtfY3J0Yyk7DQo+IEBAIC03 NjEsNiArODI3LDE4IEBAIGludCBtdGtfZHJtX2NydGNfY3JlYXRlKHN0cnVjdCBkcm1fZGV2aWNl ICpkcm1fZGV2LA0KPiAgCWRybV9tb2RlX2NydGNfc2V0X2dhbW1hX3NpemUoJm10a19jcnRjLT5i YXNlLCBNVEtfTFVUX1NJWkUpOw0KPiAgCWRybV9jcnRjX2VuYWJsZV9jb2xvcl9tZ210KCZtdGtf Y3J0Yy0+YmFzZSwgMCwgZmFsc2UsIE1US19MVVRfU0laRSk7DQo+ICAJcHJpdi0+bnVtX3BpcGVz Kys7DQo+IC0NCj4gKyNpZmRlZiBDT05GSUdfTVRLX0NNRFENCj4gKwltdGtfY3J0Yy0+Y21kcV9j bGllbnQgPQ0KPiArCQkJY21kcV9tYm94X2NyZWF0ZShkZXYsIGRybV9jcnRjX2luZGV4KCZtdGtf Y3J0Yy0+YmFzZSksDQo+ICsJCQkJCSAyMDAwKTsNCj4gKwlvZl9wcm9wZXJ0eV9yZWFkX3UzMl9p bmRleChkZXYtPm9mX25vZGUsICJtZWRpYXRlayxnY2UtZXZlbnRzIiwNCj4gKwkJCQkgICBkcm1f Y3J0Y19pbmRleCgmbXRrX2NydGMtPmJhc2UpLA0KPiArCQkJCSAgICZtdGtfY3J0Yy0+Y21kcV9l dmVudCk7DQo+ICsJaWYgKElTX0VSUihtdGtfY3J0Yy0+Y21kcV9jbGllbnQpKSB7DQo+ICsJCWRl dl9kYmcoZGV2LCAibXRrX2NydGMgJWQgZmFpbGVkIHRvIGNyZWF0ZSBtYWlsYm94IGNsaWVudCwg d3JpdGluZyByZWdpc3RlciBieSBDUFUgbm93XG4iLA0KPiArCQkJZHJtX2NydGNfaW5kZXgoJm10 a19jcnRjLT5iYXNlKSk7DQo+ICsJCW10a19jcnRjLT5jbWRxX2NsaWVudCA9IE5VTEw7DQo+ICsJ fQ0KPiArI2VuZGlmDQo+ICAJcmV0dXJuIDA7DQo+ICB9DQo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHBfY29tcC5jIGIvZHJpdmVycy9ncHUvZHJtL21l ZGlhdGVrL210a19kcm1fZGRwX2NvbXAuYw0KPiBpbmRleCA2ZDBmMzQ5ZGRmODIuLjljYzEyYWYy YmMwNiAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZGRw X2NvbXAuYw0KPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHBfY29t cC5jDQo+IEBAIC0zNzAsNiArMzcwLDkgQEAgaW50IG10a19kZHBfY29tcF9pbml0KHN0cnVjdCBk ZXZpY2UgKmRldiwgc3RydWN0IGRldmljZV9ub2RlICpub2RlLA0KPiAgCQkgICAgICBjb25zdCBz dHJ1Y3QgbXRrX2RkcF9jb21wX2Z1bmNzICpmdW5jcykNCj4gIHsNCj4gIAlzdHJ1Y3QgcGxhdGZv cm1fZGV2aWNlICpjb21wX3BkZXY7DQo+ICsJc3RydWN0IHJlc291cmNlIHJlczsNCj4gKwlzdHJ1 Y3QgY21kcV9jbGllbnRfcmVnICpjbWRxX3JlZzsNCj4gKwlpbnQgcmV0ID0gMDsNCj4gIA0KPiAg CWlmIChjb21wX2lkIDwgMCB8fCBjb21wX2lkID49IEREUF9DT01QT05FTlRfSURfTUFYKQ0KPiAg CQlyZXR1cm4gLUVJTlZBTDsNCj4gQEAgLTQwNCw2ICs0MDcsMzQgQEAgaW50IG10a19kZHBfY29t cF9pbml0KHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IGRldmljZV9ub2RlICpub2RlLA0KPiAg CX0NCj4gIAljb21wLT5kZXYgPSAmY29tcF9wZGV2LT5kZXY7DQo+ICANCj4gKyNpZmRlZiBDT05G SUdfTVRLX0NNRFENCj4gKwlpZiAob2ZfYWRkcmVzc190b19yZXNvdXJjZShub2RlLCAwLCAmcmVz KSAhPSAwKSB7DQo+ICsJCWRldl9lcnIoZGV2LCAiTWlzc2luZyByZWcgaW4gJXMgbm9kZVxuIiwN Cj4gKwkJCW5vZGUtPmZ1bGxfbmFtZSk7DQo+ICsJCXJldHVybiAtRUlOVkFMOw0KPiArCX0NCj4g Kwljb21wLT5yZWdzX3BhID0gcmVzLnN0YXJ0Ow0KPiArDQo+ICsJY29tcF9wZGV2ID0gb2ZfZmlu ZF9kZXZpY2VfYnlfbm9kZShub2RlKTsNCj4gKwlpZiAoIWNvbXBfcGRldikgew0KPiArCQlkZXZf d2FybihkZXYsICJXYWl0aW5nIGZvciBjb21wb25lbnQgZGV2aWNlICVzXG4iLA0KPiArCQkJIG5v ZGUtPmZ1bGxfbmFtZSk7DQo+ICsJCXJldHVybiAtRVBST0JFX0RFRkVSOw0KPiArCX0NCj4gKw0K PiArCWNtZHFfcmVnID0ga3phbGxvYyhzaXplb2YoKmNtZHFfcmVnKSwgR0ZQX0tFUk5FTCk7DQo+ ICsJaWYgKCFjbWRxX3JlZykNCj4gKwkJcmV0dXJuIC1FSU5WQUw7DQo+ICsNCj4gKwlyZXQgPSBj bWRxX2Rldl9nZXRfY2xpZW50X3JlZygmY29tcF9wZGV2LT5kZXYsIGNtZHFfcmVnLCAwKTsNCj4g KwlpZiAocmV0ICE9IDApDQo+ICsJCWRldl9kYmcoJmNvbXBfcGRldi0+ZGV2LA0KPiArCQkJImdl dCBtZWRpYXRlayxnY2UtY2xpZW50LXJlZyBmYWlsIVxuIik7DQo+ICsJZWxzZQ0KPiArCQljb21w LT5zdWJzeXMgPSBjbWRxX3JlZy0+c3Vic3lzOw0KPiArDQo+ICsJa2ZyZWUoY21kcV9yZWcpOw0K PiArI2VuZGlmDQoNCkkgd291bGQgbGlrZSB0byBtb3ZlIHRoaXMgcGFydCB0byB0aGUgcGF0Y2gg ImRybS9tZWRpYXRlazogc3VwcG9ydCBDTURRDQppbnRlcmZhY2UgaW4gZGRwIGNvbXBvbmVudCIu DQoNClJlZ2FyZHMsDQpDSw0KDQo+ICAJcmV0dXJuIDA7DQo+ICB9DQo+ICANCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED4F5C432C0 for ; Tue, 3 Dec 2019 01:38:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E66D206E1 for ; Tue, 3 Dec 2019 01:38:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E66D206E1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 22AD86E362; Tue, 3 Dec 2019 01:38:40 +0000 (UTC) Received: from mailgw01.mediatek.com (unknown [210.61.82.183]) by gabe.freedesktop.org (Postfix) with ESMTP id 6B2D66E33C for ; Tue, 3 Dec 2019 01:38:38 +0000 (UTC) X-UUID: b0881f0326c3448da76daf101593d0f0-20191203 X-UUID: b0881f0326c3448da76daf101593d0f0-20191203 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1907750908; Tue, 03 Dec 2019 09:38:35 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 3 Dec 2019 09:38:19 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 3 Dec 2019 09:38:14 +0800 Message-ID: <1575337114.1155.4.camel@mtksdaap41> Subject: Re: [PATCH v1 6/6] drm/mediatek: apply CMDQ control flow From: CK Hu To: Bibby Hsieh Date: Tue, 3 Dec 2019 09:38:34 +0800 In-Reply-To: <20191128024238.9399-7-bibby.hsieh@mediatek.com> References: <20191128024238.9399-1-bibby.hsieh@mediatek.com> <20191128024238.9399-7-bibby.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=sRwMLRyS13CHATbRSBNDwYj8Xi6G067HZgFuCYy6r9Q=; b=j51GpkASqoKybtF0UEFO5GYzvYBVHTZAb0ja5+kX1aCTTMcI8k3yfEYB6avjzwA7Fnp7fMi9JgRoJ0HY1S0n3xJBZa9CksS1dbRyIoi9WY8Mvkkp6EJWqZ7VNqCYD1UHjvDxS16fa5ZjdZhfHY6Gu7d64/Q7Eq/hs3nTC3X2XVw=; X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drinkcat@chromium.org, Yongqiang Niu , srv_heupstream@mediatek.com, David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tfiga@chromium.org, Thierry Reding , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191203013834.IhjJHdx4DuXaab29EO3IXvJftif6TB_8i9zODTQpRqc@z> SGksIEJpYmJ5Og0KDQpPbiBUaHUsIDIwMTktMTEtMjggYXQgMTA6NDIgKzA4MDAsIEJpYmJ5IEhz aWVoIHdyb3RlOg0KPiBVbmxpa2Ugb3RoZXIgU29DcywgTVQ4MTgzIGRvZXMgbm90IGhhdmUgInNo YWRvdyINCj4gcmVnaXN0ZXJzIGZvciBwZXJmb3JtYWluZyBhbiBhdG9taWMgdmlkZW8gbW9kZQ0K PiBzZXQgb3IgcGFnZSBmbGlwIGF0IHZibGFuay92c3luYy4NCj4gDQo+IFRoZSBDTURRIChDb21t ZW5kIFF1ZXVlKSBpbiBNVDgxODMgaXMgdXNlZCB0byBoZWxwDQo+IHVwZGF0ZSBhbGwgcmVsZXZh bnQgZGlzcGxheSBjb250cm9sbGVyIHJlZ2lzdGVycw0KPiB3aXRoIGNyaXRpY2FsIHRpbWUgbGlt YXRpb24uDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBZVCBTaGVuIDx5dC5zaGVuQG1lZGlhdGVrLmNv bT4NCj4gU2lnbmVkLW9mZi1ieTogQ0sgSHUgPGNrLmh1QG1lZGlhdGVrLmNvbT4NCj4gU2lnbmVk LW9mZi1ieTogUGhpbGlwcCBaYWJlbCA8cC56YWJlbEBwZW5ndXRyb25peC5kZT4NCj4gU2lnbmVk LW9mZi1ieTogQmliYnkgSHNpZWggPGJpYmJ5LmhzaWVoQG1lZGlhdGVrLmNvbT4NCj4gU2lnbmVk LW9mZi1ieTogWW9uZ3FpYW5nIE5pdSA8eW9uZ3FpYW5nLm5pdUBtZWRpYXRlay5jb20+DQo+IC0t LQ0KPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fY3J0Yy5jICAgICB8IDg2ICsr KysrKysrKysrKysrKysrKysrLQ0KPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1f ZGRwX2NvbXAuYyB8IDMxICsrKysrKysrDQo+ICAyIGZpbGVzIGNoYW5nZWQsIDExMyBpbnNlcnRp b25zKCspLCA0IGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9tZWRpYXRlay9tdGtfZHJtX2NydGMuYyBiL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtf ZHJtX2NydGMuYw0KPiBpbmRleCBmY2Y0ZTc1NWUwYmQuLjFiNGU1MzdhYzNjMSAxMDA2NDQNCj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fY3J0Yy5jDQo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2NydGMuYw0KPiBAQCAtMTIsNiArMTIsOCBA QA0KPiAgI2luY2x1ZGUgPGRybS9kcm1fcGxhbmVfaGVscGVyLmg+DQo+ICAjaW5jbHVkZSA8ZHJt L2RybV9wcm9iZV9oZWxwZXIuaD4NCj4gICNpbmNsdWRlIDxkcm0vZHJtX3ZibGFuay5oPg0KPiAr I2luY2x1ZGUgPGxpbnV4L29mX2FkZHJlc3MuaD4NCj4gKyNpbmNsdWRlIDxsaW51eC9zb2MvbWVk aWF0ZWsvbXRrLWNtZHEuaD4NCj4gIA0KPiAgI2luY2x1ZGUgIm10a19kcm1fZHJ2LmgiDQo+ICAj aW5jbHVkZSAibXRrX2RybV9jcnRjLmgiDQo+IEBAIC00Miw2ICs0NCw5IEBAIHN0cnVjdCBtdGtf ZHJtX2NydGMgew0KPiAgCXVuc2lnbmVkIGludAkJCWxheWVyX25yOw0KPiAgCWJvb2wJCQkJcGVu ZGluZ19wbGFuZXM7DQo+ICANCj4gKwlzdHJ1Y3QgY21kcV9jbGllbnQJCSpjbWRxX2NsaWVudDsN Cj4gKwl1MzIJCQkJY21kcV9ldmVudDsNCj4gKw0KPiAgCXZvaWQgX19pb21lbQkJCSpjb25maWdf cmVnczsNCj4gIAljb25zdCBzdHJ1Y3QgbXRrX21tc3lzX3JlZ19kYXRhICptbXN5c19yZWdfZGF0 YTsNCj4gIAlzdHJ1Y3QgbXRrX2Rpc3BfbXV0ZXgJCSptdXRleDsNCj4gQEAgLTU2LDYgKzYxLDEx IEBAIHN0cnVjdCBtdGtfY3J0Y19zdGF0ZSB7DQo+ICAJdW5zaWduZWQgaW50CQkJcGVuZGluZ193 aWR0aDsNCj4gIAl1bnNpZ25lZCBpbnQJCQlwZW5kaW5nX2hlaWdodDsNCj4gIAl1bnNpZ25lZCBp bnQJCQlwZW5kaW5nX3ZyZWZyZXNoOw0KPiArCXN0cnVjdCBjbWRxX3BrdAkJCSpjbWRxX2hhbmRs ZTsNCj4gK307DQo+ICsNCj4gK3N0cnVjdCBtdGtfY21kcV9jYl9kYXRhIHsNCj4gKwlzdHJ1Y3Qg Y21kcV9wa3QJCQkqY21kcV9oYW5kbGU7DQo+ICB9Ow0KPiAgDQo+ICBzdGF0aWMgaW5saW5lIHN0 cnVjdCBtdGtfZHJtX2NydGMgKnRvX210a19jcnRjKHN0cnVjdCBkcm1fY3J0YyAqYykNCj4gQEAg LTIyOSw2ICsyMzksNDYgQEAgc3RydWN0IG10a19kZHBfY29tcCAqbXRrX2RybV9kZHBfY29tcF9m b3JfcGxhbmUoc3RydWN0IGRybV9jcnRjICpjcnRjLA0KPiAgCXJldHVybiBOVUxMOw0KPiAgfQ0K PiAgDQo+ICsjaWZkZWYgQ09ORklHX01US19DTURRDQo+ICtzdGF0aWMgdm9pZCBkZHBfY21kcV9j YihzdHJ1Y3QgY21kcV9jYl9kYXRhIGRhdGEpDQo+ICt7DQo+ICsJc3RydWN0IG10a19jbWRxX2Ni X2RhdGEgKmNiX2RhdGEgPSBkYXRhLmRhdGE7DQo+ICsNCj4gKwljbWRxX3BrdF9kZXN0cm95KGNi X2RhdGEtPmNtZHFfaGFuZGxlKTsNCj4gKwlrZnJlZShjYl9kYXRhKTsNCj4gK30NCj4gKw0KPiAr c3RhdGljIHZvaWQgbXRrX2NtZHFfYWNxdWlyZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMpDQo+ICt7 DQo+ICsJc3RydWN0IG10a19jcnRjX3N0YXRlICptdGtfY3J0Y19zdGF0ZSA9DQo+ICsJCQl0b19t dGtfY3J0Y19zdGF0ZShjcnRjLT5zdGF0ZSk7DQo+ICsJc3RydWN0IG10a19kcm1fY3J0YyAqbXRr X2NydGMgPSB0b19tdGtfY3J0YyhjcnRjKTsNCj4gKw0KPiArCW10a19jcnRjX3N0YXRlLT5jbWRx X2hhbmRsZSA9DQo+ICsJCQljbWRxX3BrdF9jcmVhdGUobXRrX2NydGMtPmNtZHFfY2xpZW50LA0K PiArCQkJCQlQQUdFX1NJWkUpOw0KDQpJIHdvdWxkIGxpa2UgdG8gcmVtb3ZlIGF0b21pYyBmZWF0 dXJlIGluIGNtZHEgZHJpdmVyIGFuZCBkcm0gZHJpdmVyDQpjb3VsZCByZXVzZSB0aGUgcGt0LiBQ bGVhc2UgcmVmZXIgdG8gWzFdIGZvciBkZXRhaWwuDQoNClsxXQ0KaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvcGlwZXJtYWlsL2xpbnV4LW1lZGlhdGVrLzIwMTktSmFudWFyeS8wMTY4NjYuaHRt bA0KDQo+ICsJY21kcV9wa3RfY2xlYXJfZXZlbnQobXRrX2NydGNfc3RhdGUtPmNtZHFfaGFuZGxl LA0KPiArCQkJICAgICBtdGtfY3J0Yy0+Y21kcV9ldmVudCk7DQo+ICsJY21kcV9wa3Rfd2ZlKG10 a19jcnRjX3N0YXRlLT5jbWRxX2hhbmRsZSwgbXRrX2NydGMtPmNtZHFfZXZlbnQpOw0KPiArfQ0K PiArDQo+ICtzdGF0aWMgdm9pZCBtdGtfY21kcV9yZWxlYXNlKHN0cnVjdCBkcm1fY3J0YyAqY3J0 YykNCj4gK3sNCj4gKwlzdHJ1Y3QgbXRrX2NydGNfc3RhdGUgKm10a19jcnRjX3N0YXRlID0NCj4g KwkJCXRvX210a19jcnRjX3N0YXRlKGNydGMtPnN0YXRlKTsNCj4gKwlzdHJ1Y3QgbXRrX2NtZHFf Y2JfZGF0YSAqY2JfZGF0YTsNCj4gKw0KPiArCWNiX2RhdGEgPSBrbWFsbG9jKHNpemVvZigqY2Jf ZGF0YSksIEdGUF9LRVJORUwpOw0KPiArCWlmICghY2JfZGF0YSkgew0KPiArCQlEUk1fREVWX0VS Uk9SKGNydGMtPmRldi0+ZGV2LCAiRmFpbGVkIHRvIGFsbG9jIGNiX2RhdGFcbiIpOw0KPiArCQly ZXR1cm47DQo+ICsJfQ0KPiArDQo+ICsJY2JfZGF0YS0+Y21kcV9oYW5kbGUgPSBtdGtfY3J0Y19z dGF0ZS0+Y21kcV9oYW5kbGU7DQo+ICsJY21kcV9wa3RfZmx1c2hfYXN5bmMobXRrX2NydGNfc3Rh dGUtPmNtZHFfaGFuZGxlLA0KPiArCQkJICAgICBkZHBfY21kcV9jYiwgY2JfZGF0YSk7DQo+ICt9 DQo+ICsjZW5kaWYNCj4gIHN0YXRpYyBpbnQgbXRrX2NydGNfZGRwX2h3X2luaXQoc3RydWN0IG10 a19kcm1fY3J0YyAqbXRrX2NydGMpDQo+ICB7DQo+ICAJc3RydWN0IGRybV9jcnRjICpjcnRjID0g Jm10a19jcnRjLT5iYXNlOw0KPiBAQCAtMzgzLDcgKzQzMyw4IEBAIHN0YXRpYyB2b2lkIG10a19j cnRjX2RkcF9jb25maWcoc3RydWN0IGRybV9jcnRjICpjcnRjKQ0KPiAgCWlmIChzdGF0ZS0+cGVu ZGluZ19jb25maWcpIHsNCj4gIAkJbXRrX2RkcF9jb21wX2NvbmZpZyhjb21wLCBzdGF0ZS0+cGVu ZGluZ193aWR0aCwNCj4gIAkJCQkgICAgc3RhdGUtPnBlbmRpbmdfaGVpZ2h0LA0KPiAtCQkJCSAg ICBzdGF0ZS0+cGVuZGluZ192cmVmcmVzaCwgMCwgTlVMTCk7DQo+ICsJCQkJICAgIHN0YXRlLT5w ZW5kaW5nX3ZyZWZyZXNoLCAwLA0KPiArCQkJCSAgICBzdGF0ZS0+Y21kcV9oYW5kbGUpOw0KPiAg DQo+ICAJCXN0YXRlLT5wZW5kaW5nX2NvbmZpZyA9IGZhbHNlOw0KPiAgCX0NCj4gQEAgLTQwMyw3 ICs0NTQsOCBAQCBzdGF0aWMgdm9pZCBtdGtfY3J0Y19kZHBfY29uZmlnKHN0cnVjdCBkcm1fY3J0 YyAqY3J0YykNCj4gIA0KPiAgCQkJaWYgKGNvbXApDQo+ICAJCQkJbXRrX2RkcF9jb21wX2xheWVy X2NvbmZpZyhjb21wLCBsb2NhbF9sYXllciwNCj4gLQkJCQkJCQkgIHBsYW5lX3N0YXRlLCBOVUxM KTsNCj4gKwkJCQkJCQkgIHBsYW5lX3N0YXRlLA0KPiArCQkJCQkJCSAgc3RhdGUtPmNtZHFfaGFu ZGxlKTsNCj4gIAkJCXBsYW5lX3N0YXRlLT5wZW5kaW5nLmNvbmZpZyA9IGZhbHNlOw0KPiAgCQl9 DQo+ICAJCW10a19jcnRjLT5wZW5kaW5nX3BsYW5lcyA9IGZhbHNlOw0KPiBAQCAtNDU0LDYgKzUw NiwxMyBAQCB2b2lkIG10a19kcm1fY3J0Y19jdXJzb3JfdXBkYXRlKHN0cnVjdCBkcm1fY3J0YyAq Y3J0Yywgc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsDQo+ICAJCW10a19jcnRjX2RkcF9jb25maWco Y3J0Yyk7DQo+ICAJCW10a19kaXNwX211dGV4X3JlbGVhc2UobXRrX2NydGMtPm11dGV4KTsNCj4g IAl9DQo+ICsjaWZkZWYgQ09ORklHX01US19DTURRDQo+ICsJaWYgKG10a19jcnRjLT5jbWRxX2Ns aWVudCkgew0KPiArCQltdGtfY21kcV9hY3F1aXJlKGNydGMpOw0KPiArCQltdGtfY3J0Y19kZHBf Y29uZmlnKGNydGMpOw0KPiArCQltdGtfY21kcV9yZWxlYXNlKGNydGMpOw0KPiArCX0NCj4gKyNl bmRpZg0KPiAgCW11dGV4X3VubG9jaygmcHJpdi0+aHdfbG9jayk7DQo+ICB9DQo+ICANCj4gQEAg LTU3MCw2ICs2MjksMTMgQEAgc3RhdGljIHZvaWQgbXRrX2RybV9jcnRjX2F0b21pY19mbHVzaChz dHJ1Y3QgZHJtX2NydGMgKmNydGMsDQo+ICAJCW10a19jcnRjX2RkcF9jb25maWcoY3J0Yyk7DQo+ ICAJCW10a19kaXNwX211dGV4X3JlbGVhc2UobXRrX2NydGMtPm11dGV4KTsNCj4gIAl9DQo+ICsj aWZkZWYgQ09ORklHX01US19DTURRDQo+ICsJaWYgKG10a19jcnRjLT5jbWRxX2NsaWVudCkgew0K PiArCQltdGtfY21kcV9hY3F1aXJlKGNydGMpOw0KPiArCQltdGtfY3J0Y19kZHBfY29uZmlnKGNy dGMpOw0KPiArCQltdGtfY21kcV9yZWxlYXNlKGNydGMpOw0KPiArCX0NCj4gKyNlbmRpZg0KDQpU aGlzIHBhcnQgaXMgYWxtb3N0IHRoZSBzYW1lIGFzIHRoZSBvbmUgaW4gbXRrX2RybV9jcnRjX2N1 cnNvcl91cGRhdGUoKSwNCnRyeSB0byBtZXJnZSB0aGVtLg0KDQo+ICB9DQo+ICANCj4gIHN0YXRp YyBjb25zdCBzdHJ1Y3QgZHJtX2NydGNfZnVuY3MgbXRrX2NydGNfZnVuY3MgPSB7DQo+IEBAIC02 MTksNyArNjg1LDcgQEAgdm9pZCBtdGtfY3J0Y19kZHBfaXJxKHN0cnVjdCBkcm1fY3J0YyAqY3J0 Yywgc3RydWN0IG10a19kZHBfY29tcCAqY29tcCkNCj4gIAlzdHJ1Y3QgbXRrX2RybV9jcnRjICpt dGtfY3J0YyA9IHRvX210a19jcnRjKGNydGMpOw0KPiAgCXN0cnVjdCBtdGtfZHJtX3ByaXZhdGUg KnByaXYgPSBjcnRjLT5kZXYtPmRldl9wcml2YXRlOw0KPiAgDQo+IC0JaWYgKCFwcml2LT5kYXRh LT5zaGFkb3dfcmVnaXN0ZXIpDQo+ICsJaWYgKCFwcml2LT5kYXRhLT5zaGFkb3dfcmVnaXN0ZXIg JiYgIW10a19jcnRjLT5jbWRxX2NsaWVudCkNCj4gIAkJbXRrX2NydGNfZGRwX2NvbmZpZyhjcnRj KTsNCj4gIA0KPiAgCW10a19kcm1fZmluaXNoX3BhZ2VfZmxpcChtdGtfY3J0Yyk7DQo+IEBAIC03 NjEsNiArODI3LDE4IEBAIGludCBtdGtfZHJtX2NydGNfY3JlYXRlKHN0cnVjdCBkcm1fZGV2aWNl ICpkcm1fZGV2LA0KPiAgCWRybV9tb2RlX2NydGNfc2V0X2dhbW1hX3NpemUoJm10a19jcnRjLT5i YXNlLCBNVEtfTFVUX1NJWkUpOw0KPiAgCWRybV9jcnRjX2VuYWJsZV9jb2xvcl9tZ210KCZtdGtf Y3J0Yy0+YmFzZSwgMCwgZmFsc2UsIE1US19MVVRfU0laRSk7DQo+ICAJcHJpdi0+bnVtX3BpcGVz Kys7DQo+IC0NCj4gKyNpZmRlZiBDT05GSUdfTVRLX0NNRFENCj4gKwltdGtfY3J0Yy0+Y21kcV9j bGllbnQgPQ0KPiArCQkJY21kcV9tYm94X2NyZWF0ZShkZXYsIGRybV9jcnRjX2luZGV4KCZtdGtf Y3J0Yy0+YmFzZSksDQo+ICsJCQkJCSAyMDAwKTsNCj4gKwlvZl9wcm9wZXJ0eV9yZWFkX3UzMl9p bmRleChkZXYtPm9mX25vZGUsICJtZWRpYXRlayxnY2UtZXZlbnRzIiwNCj4gKwkJCQkgICBkcm1f Y3J0Y19pbmRleCgmbXRrX2NydGMtPmJhc2UpLA0KPiArCQkJCSAgICZtdGtfY3J0Yy0+Y21kcV9l dmVudCk7DQo+ICsJaWYgKElTX0VSUihtdGtfY3J0Yy0+Y21kcV9jbGllbnQpKSB7DQo+ICsJCWRl dl9kYmcoZGV2LCAibXRrX2NydGMgJWQgZmFpbGVkIHRvIGNyZWF0ZSBtYWlsYm94IGNsaWVudCwg d3JpdGluZyByZWdpc3RlciBieSBDUFUgbm93XG4iLA0KPiArCQkJZHJtX2NydGNfaW5kZXgoJm10 a19jcnRjLT5iYXNlKSk7DQo+ICsJCW10a19jcnRjLT5jbWRxX2NsaWVudCA9IE5VTEw7DQo+ICsJ fQ0KPiArI2VuZGlmDQo+ICAJcmV0dXJuIDA7DQo+ICB9DQo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHBfY29tcC5jIGIvZHJpdmVycy9ncHUvZHJtL21l ZGlhdGVrL210a19kcm1fZGRwX2NvbXAuYw0KPiBpbmRleCA2ZDBmMzQ5ZGRmODIuLjljYzEyYWYy YmMwNiAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZGRw X2NvbXAuYw0KPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHBfY29t cC5jDQo+IEBAIC0zNzAsNiArMzcwLDkgQEAgaW50IG10a19kZHBfY29tcF9pbml0KHN0cnVjdCBk ZXZpY2UgKmRldiwgc3RydWN0IGRldmljZV9ub2RlICpub2RlLA0KPiAgCQkgICAgICBjb25zdCBz dHJ1Y3QgbXRrX2RkcF9jb21wX2Z1bmNzICpmdW5jcykNCj4gIHsNCj4gIAlzdHJ1Y3QgcGxhdGZv cm1fZGV2aWNlICpjb21wX3BkZXY7DQo+ICsJc3RydWN0IHJlc291cmNlIHJlczsNCj4gKwlzdHJ1 Y3QgY21kcV9jbGllbnRfcmVnICpjbWRxX3JlZzsNCj4gKwlpbnQgcmV0ID0gMDsNCj4gIA0KPiAg CWlmIChjb21wX2lkIDwgMCB8fCBjb21wX2lkID49IEREUF9DT01QT05FTlRfSURfTUFYKQ0KPiAg CQlyZXR1cm4gLUVJTlZBTDsNCj4gQEAgLTQwNCw2ICs0MDcsMzQgQEAgaW50IG10a19kZHBfY29t cF9pbml0KHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IGRldmljZV9ub2RlICpub2RlLA0KPiAg CX0NCj4gIAljb21wLT5kZXYgPSAmY29tcF9wZGV2LT5kZXY7DQo+ICANCj4gKyNpZmRlZiBDT05G SUdfTVRLX0NNRFENCj4gKwlpZiAob2ZfYWRkcmVzc190b19yZXNvdXJjZShub2RlLCAwLCAmcmVz KSAhPSAwKSB7DQo+ICsJCWRldl9lcnIoZGV2LCAiTWlzc2luZyByZWcgaW4gJXMgbm9kZVxuIiwN Cj4gKwkJCW5vZGUtPmZ1bGxfbmFtZSk7DQo+ICsJCXJldHVybiAtRUlOVkFMOw0KPiArCX0NCj4g Kwljb21wLT5yZWdzX3BhID0gcmVzLnN0YXJ0Ow0KPiArDQo+ICsJY29tcF9wZGV2ID0gb2ZfZmlu ZF9kZXZpY2VfYnlfbm9kZShub2RlKTsNCj4gKwlpZiAoIWNvbXBfcGRldikgew0KPiArCQlkZXZf d2FybihkZXYsICJXYWl0aW5nIGZvciBjb21wb25lbnQgZGV2aWNlICVzXG4iLA0KPiArCQkJIG5v ZGUtPmZ1bGxfbmFtZSk7DQo+ICsJCXJldHVybiAtRVBST0JFX0RFRkVSOw0KPiArCX0NCj4gKw0K PiArCWNtZHFfcmVnID0ga3phbGxvYyhzaXplb2YoKmNtZHFfcmVnKSwgR0ZQX0tFUk5FTCk7DQo+ ICsJaWYgKCFjbWRxX3JlZykNCj4gKwkJcmV0dXJuIC1FSU5WQUw7DQo+ICsNCj4gKwlyZXQgPSBj bWRxX2Rldl9nZXRfY2xpZW50X3JlZygmY29tcF9wZGV2LT5kZXYsIGNtZHFfcmVnLCAwKTsNCj4g KwlpZiAocmV0ICE9IDApDQo+ICsJCWRldl9kYmcoJmNvbXBfcGRldi0+ZGV2LA0KPiArCQkJImdl dCBtZWRpYXRlayxnY2UtY2xpZW50LXJlZyBmYWlsIVxuIik7DQo+ICsJZWxzZQ0KPiArCQljb21w LT5zdWJzeXMgPSBjbWRxX3JlZy0+c3Vic3lzOw0KPiArDQo+ICsJa2ZyZWUoY21kcV9yZWcpOw0K PiArI2VuZGlmDQoNCkkgd291bGQgbGlrZSB0byBtb3ZlIHRoaXMgcGFydCB0byB0aGUgcGF0Y2gg ImRybS9tZWRpYXRlazogc3VwcG9ydCBDTURRDQppbnRlcmZhY2UgaW4gZGRwIGNvbXBvbmVudCIu DQoNClJlZ2FyZHMsDQpDSw0KDQo+ICAJcmV0dXJuIDA7DQo+ICB9DQo+ICANCg0KX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs