From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A0ACC432C3 for ; Tue, 3 Dec 2019 03:34:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A1BA206DC for ; Tue, 3 Dec 2019 03:34:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="i5z0BJM5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726645AbfLCDeh (ORCPT ); Mon, 2 Dec 2019 22:34:37 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:23863 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726319AbfLCDeg (ORCPT ); Mon, 2 Dec 2019 22:34:36 -0500 X-UUID: 8e3c37583a844ab9ae9af2b48028fd98-20191203 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=YYdvdLxaz+GrtaamZIqTRrwxovn6ou6aNFueL+5BIUI=; b=i5z0BJM5zG4zTt49S9eba3RZRo3J16IO1cT51iOotJ7V7VOk4r9TcmgBrG2k0Ox1LfKEh12NscTYLiSd2o4guGqTVRysbIUsZS0A8Bn6eSvX6qFAs/WJwT7g5NPiWmcdZj2YKzcMcJgVTVCuaS+iKmCWl1ZAWYmKag+1C/NeLW0=; X-UUID: 8e3c37583a844ab9ae9af2b48028fd98-20191203 Received: from mtkcas06.mediatek.inc [(172.21.101.30)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1694831396; Tue, 03 Dec 2019 11:34:30 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 3 Dec 2019 11:34:13 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 3 Dec 2019 11:34:08 +0800 Message-ID: <1575344068.627.2.camel@mtksdaap41> Subject: Re: [PATCH v1 5/6] drm/mediatek: support CMDQ interface in ddp component From: CK Hu To: Bibby Hsieh CC: David Airlie , Matthias Brugger , Daniel Vetter , , , Philipp Zabel , YT Shen , Thierry Reding , , , , , , Yongqiang Niu Date: Tue, 3 Dec 2019 11:34:28 +0800 In-Reply-To: <1575341763.19788.3.camel@mtksdaap41> References: <20191128024238.9399-1-bibby.hsieh@mediatek.com> <20191128024238.9399-6-bibby.hsieh@mediatek.com> <1575341763.19788.3.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SGksIEJpYmJ5Og0KDQpPbiBUdWUsIDIwMTktMTItMDMgYXQgMTA6NTYgKzA4MDAsIENLIEh1IHdy b3RlOg0KPiBIaSwgQmliYnk6DQo+IA0KPiBPbiBUaHUsIDIwMTktMTEtMjggYXQgMTA6NDIgKzA4 MDAsIEJpYmJ5IEhzaWVoIHdyb3RlOg0KPiA+IFRoZSBDTURRIChDb21tYW5kIFF1ZXVlKSBpbiBN VDgxODMgaXMgdXNlZCB0byBoZWxwDQo+ID4gdXBkYXRlIGFsbCByZWxldmFudCBkaXNwbGF5IGNv bnRyb2xsZXIgcmVnaXN0ZXJzDQo+ID4gd2l0aCBjcml0aWNhbCB0aW1lIGxpbWF0aW9uLg0KPiA+ IFRoaXMgcGF0Y2ggYWRkIGNtZHEgaW50ZXJmYWNlIGluIGRkcF9jb21wIGludGVyZmFjZSwNCj4g PiBsZXQgYWxsIGRkcF9jb21wIGludGVyZmFjZSBjYW4gc3VwcG9ydCBjcHUvY21kcSBmdW5jdGlv bg0KPiA+IGF0IHRoZSBzYW1lIHRpbWUuDQo+ID4gDQo+ID4gU2lnbmVkLW9mZi1ieTogWVQgU2hl biA8eXQuc2hlbkBtZWRpYXRlay5jb20+DQo+ID4gU2lnbmVkLW9mZi1ieTogQ0sgSHUgPGNrLmh1 QG1lZGlhdGVrLmNvbT4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBQaGlsaXBwIFphYmVsIDxwLnphYmVs QHBlbmd1dHJvbml4LmRlPg0KPiA+IFNpZ25lZC1vZmYtYnk6IEJpYmJ5IEhzaWVoIDxiaWJieS5o c2llaEBtZWRpYXRlay5jb20+DQo+ID4gU2lnbmVkLW9mZi1ieTogWW9uZ3FpYW5nIE5pdSA8eW9u Z3FpYW5nLm5pdUBtZWRpYXRlay5jb20+DQo+ID4gLS0tDQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9t ZWRpYXRlay9tdGtfZGlzcF9jb2xvci5jICAgfCAgIDcgKy0NCj4gPiAgZHJpdmVycy9ncHUvZHJt L21lZGlhdGVrL210a19kaXNwX292bC5jICAgICB8ICA2NSArKysrKystLS0tLQ0KPiA+ICBkcml2 ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2Rpc3BfcmRtYS5jICAgIHwgIDQzICsrKystLS0NCj4g PiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fY3J0Yy5jICAgICB8ICAxMSArLQ0K PiA+ICBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHBfY29tcC5jIHwgMTIwICsr KysrKysrKysrKysrLS0tLS0tDQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJt X2RkcF9jb21wLmggfCAgNTUgKysrKysrLS0tDQo+ID4gIDYgZmlsZXMgY2hhbmdlZCwgMTkwIGlu c2VydGlvbnMoKyksIDExMSBkZWxldGlvbnMoLSkNCj4gPiANCj4gDQoNCltzbmlwXQ0KDQo+ID4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2RkcF9jb21wLmgg Yi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHBfY29tcC5oDQo+ID4gaW5kZXgg ZWM1NWM3NDg4Y2MzLi41YjBhM2Q0OGRmYTYgMTAwNjQ0DQo+ID4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL21lZGlhdGVrL210a19kcm1fZGRwX2NvbXAuaA0KPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9tZWRpYXRlay9tdGtfZHJtX2RkcF9jb21wLmgNCj4gPiBAQCAtNjksMjUgKzY5LDMwIEBAIGVu dW0gbXRrX2RkcF9jb21wX2lkIHsNCj4gPiAgfTsNCj4gPiAgDQo+ID4gIHN0cnVjdCBtdGtfZGRw X2NvbXA7DQo+ID4gLQ0KPiA+ICtzdHJ1Y3QgY21kcV9wa3Q7DQo+ID4gIHN0cnVjdCBtdGtfZGRw X2NvbXBfZnVuY3Mgew0KPiA+ICAJdm9pZCAoKmNvbmZpZykoc3RydWN0IG10a19kZHBfY29tcCAq Y29tcCwgdW5zaWduZWQgaW50IHcsDQo+ID4gLQkJICAgICAgIHVuc2lnbmVkIGludCBoLCB1bnNp Z25lZCBpbnQgdnJlZnJlc2gsIHVuc2lnbmVkIGludCBicGMpOw0KPiA+ICsJCSAgICAgICB1bnNp Z25lZCBpbnQgaCwgdW5zaWduZWQgaW50IHZyZWZyZXNoLA0KPiA+ICsJCSAgICAgICB1bnNpZ25l ZCBpbnQgYnBjLCBzdHJ1Y3QgY21kcV9wa3QgKmNtZHFfcGt0KTsNCj4gPiAgCXZvaWQgKCpzdGFy dCkoc3RydWN0IG10a19kZHBfY29tcCAqY29tcCk7DQo+ID4gIAl2b2lkICgqc3RvcCkoc3RydWN0 IG10a19kZHBfY29tcCAqY29tcCk7DQo+ID4gIAl2b2lkICgqZW5hYmxlX3ZibGFuaykoc3RydWN0 IG10a19kZHBfY29tcCAqY29tcCwgc3RydWN0IGRybV9jcnRjICpjcnRjKTsNCj4gPiAgCXZvaWQg KCpkaXNhYmxlX3ZibGFuaykoc3RydWN0IG10a19kZHBfY29tcCAqY29tcCk7DQo+ID4gIAl1bnNp Z25lZCBpbnQgKCpzdXBwb3J0ZWRfcm90YXRpb25zKShzdHJ1Y3QgbXRrX2RkcF9jb21wICpjb21w KTsNCj4gPiAgCXVuc2lnbmVkIGludCAoKmxheWVyX25yKShzdHJ1Y3QgbXRrX2RkcF9jb21wICpj b21wKTsNCj4gPiAtCXZvaWQgKCpsYXllcl9vbikoc3RydWN0IG10a19kZHBfY29tcCAqY29tcCwg dW5zaWduZWQgaW50IGlkeCk7DQo+ID4gLQl2b2lkICgqbGF5ZXJfb2ZmKShzdHJ1Y3QgbXRrX2Rk cF9jb21wICpjb21wLCB1bnNpZ25lZCBpbnQgaWR4KTsNCj4gPiArCXZvaWQgKCpsYXllcl9vbiko c3RydWN0IG10a19kZHBfY29tcCAqY29tcCwgdW5zaWduZWQgaW50IGlkeCwNCj4gPiArCQkJIHN0 cnVjdCBjbWRxX3BrdCAqY21kcV9wa3QpOw0KPiA+ICsJdm9pZCAoKmxheWVyX29mZikoc3RydWN0 IG10a19kZHBfY29tcCAqY29tcCwgdW5zaWduZWQgaW50IGlkeCwNCj4gPiArCQkJICBzdHJ1Y3Qg Y21kcV9wa3QgKmNtZHFfcGt0KTsNCg0KbGF5ZXJfb24oKSBhbmQgbGF5ZXJfb2ZmKCkgbG9va3Mg dXNlbGVzcywgc28gSSB3b3VsZCBsaWtlIHlvdSBqdXN0DQpyZW1vdmUgdGhpcyBpbnRlcmZhY2Ug aW4gYW5vdGhlciBwYXRjaC4NCg0KUmVnYXJkcywNCkNLDQoNCj4gPiAgCWludCAoKmxheWVyX2No ZWNrKShzdHJ1Y3QgbXRrX2RkcF9jb21wICpjb21wLA0KPiA+ICAJCQkgICB1bnNpZ25lZCBpbnQg aWR4LA0KPiA+ICAJCQkgICBzdHJ1Y3QgbXRrX3BsYW5lX3N0YXRlICpzdGF0ZSk7DQo+ID4gIAl2 b2lkICgqbGF5ZXJfY29uZmlnKShzdHJ1Y3QgbXRrX2RkcF9jb21wICpjb21wLCB1bnNpZ25lZCBp bnQgaWR4LA0KPiA+IC0JCQkgICAgIHN0cnVjdCBtdGtfcGxhbmVfc3RhdGUgKnN0YXRlKTsNCj4g PiArCQkJICAgICBzdHJ1Y3QgbXRrX3BsYW5lX3N0YXRlICpzdGF0ZSwNCj4gPiArCQkJICAgICBz dHJ1Y3QgY21kcV9wa3QgKmNtZHFfcGt0KTsNCj4gPiAgCXZvaWQgKCpnYW1tYV9zZXQpKHN0cnVj dCBtdGtfZGRwX2NvbXAgKmNvbXAsDQo+ID4gLQkJCSAgc3RydWN0IGRybV9jcnRjX3N0YXRlICpz dGF0ZSk7DQo+ID4gKwkJCSAgc3RydWN0IGRybV9jcnRjX3N0YXRlICpzdGF0ZSwNCj4gPiArCQkJ ICBzdHJ1Y3QgY21kcV9wa3QgKmNtZHFfcGt0KTsNCj4gPiAgCXZvaWQgKCpiZ2Nscl9pbl9vbiko c3RydWN0IG10a19kZHBfY29tcCAqY29tcCk7DQo+ID4gIAl2b2lkICgqYmdjbHJfaW5fb2ZmKShz dHJ1Y3QgbXRrX2RkcF9jb21wICpjb21wKTsNCj4gPiAgfTsNCj4gPiBAQCAtOTksMTQgKzEwNCwx NyBAQCBzdHJ1Y3QgbXRrX2RkcF9jb21wIHsNCj4gPiAgCXN0cnVjdCBkZXZpY2UgKmRldjsNCj4g PiAgCWVudW0gbXRrX2RkcF9jb21wX2lkIGlkOw0KPiA+ICAJY29uc3Qgc3RydWN0IG10a19kZHBf Y29tcF9mdW5jcyAqZnVuY3M7DQo+ID4gKwlyZXNvdXJjZV9zaXplX3QgcmVnc19wYTsNCj4gPiAr CXU4IHN1YnN5czsNCj4gPiAgfTsNCj4gPiAgDQo+ID4gIHN0YXRpYyBpbmxpbmUgdm9pZCBtdGtf ZGRwX2NvbXBfY29uZmlnKHN0cnVjdCBtdGtfZGRwX2NvbXAgKmNvbXAsDQo+ID4gIAkJCQkgICAg ICAgdW5zaWduZWQgaW50IHcsIHVuc2lnbmVkIGludCBoLA0KPiA+IC0JCQkJICAgICAgIHVuc2ln bmVkIGludCB2cmVmcmVzaCwgdW5zaWduZWQgaW50IGJwYykNCj4gPiArCQkJCSAgICAgICB1bnNp Z25lZCBpbnQgdnJlZnJlc2gsIHVuc2lnbmVkIGludCBicGMsDQo+ID4gKwkJCQkgICAgICAgc3Ry dWN0IGNtZHFfcGt0ICpjbWRxX3BrdCkNCj4gPiAgew0KPiA+ICAJaWYgKGNvbXAtPmZ1bmNzICYm IGNvbXAtPmZ1bmNzLT5jb25maWcpDQo+ID4gLQkJY29tcC0+ZnVuY3MtPmNvbmZpZyhjb21wLCB3 LCBoLCB2cmVmcmVzaCwgYnBjKTsNCj4gPiArCQljb21wLT5mdW5jcy0+Y29uZmlnKGNvbXAsIHcs IGgsIHZyZWZyZXNoLCBicGMsIGNtZHFfcGt0KTsNCj4gPiAgfQ0KPiA+ICANCj4gPiAgc3RhdGlj IGlubGluZSB2b2lkIG10a19kZHBfY29tcF9zdGFydChzdHJ1Y3QgbXRrX2RkcF9jb21wICpjb21w KQ0KPiA+IEBAIC0xNTIsMTcgKzE2MCwxOSBAQCBzdGF0aWMgaW5saW5lIHVuc2lnbmVkIGludCBt dGtfZGRwX2NvbXBfbGF5ZXJfbnIoc3RydWN0IG10a19kZHBfY29tcCAqY29tcCkNCj4gPiAgfQ0K PiA+ICANCj4gPiAgc3RhdGljIGlubGluZSB2b2lkIG10a19kZHBfY29tcF9sYXllcl9vbihzdHJ1 Y3QgbXRrX2RkcF9jb21wICpjb21wLA0KPiA+IC0JCQkJCSB1bnNpZ25lZCBpbnQgaWR4KQ0KPiA+ ICsJCQkJCSB1bnNpZ25lZCBpbnQgaWR4LA0KPiA+ICsJCQkJCSBzdHJ1Y3QgY21kcV9wa3QgKmNt ZHFfcGt0KQ0KPiA+ICB7DQo+ID4gIAlpZiAoY29tcC0+ZnVuY3MgJiYgY29tcC0+ZnVuY3MtPmxh eWVyX29uKQ0KPiA+IC0JCWNvbXAtPmZ1bmNzLT5sYXllcl9vbihjb21wLCBpZHgpOw0KPiA+ICsJ CWNvbXAtPmZ1bmNzLT5sYXllcl9vbihjb21wLCBpZHgsIGNtZHFfcGt0KTsNCj4gPiAgfQ0KPiA+ ICANCj4gPiAgc3RhdGljIGlubGluZSB2b2lkIG10a19kZHBfY29tcF9sYXllcl9vZmYoc3RydWN0 IG10a19kZHBfY29tcCAqY29tcCwNCj4gPiAtCQkJCQkgIHVuc2lnbmVkIGludCBpZHgpDQo+ID4g KwkJCQkJICB1bnNpZ25lZCBpbnQgaWR4LA0KPiA+ICsJCQkJCSAgc3RydWN0IGNtZHFfcGt0ICpj bWRxX3BrdCkNCj4gPiAgew0KPiA+ICAJaWYgKGNvbXAtPmZ1bmNzICYmIGNvbXAtPmZ1bmNzLT5s YXllcl9vZmYpDQo+ID4gLQkJY29tcC0+ZnVuY3MtPmxheWVyX29mZihjb21wLCBpZHgpOw0KPiA+ ICsJCWNvbXAtPmZ1bmNzLT5sYXllcl9vZmYoY29tcCwgaWR4LCBjbWRxX3BrdCk7DQo+ID4gIH0N Cj4gPiAgDQo+ID4gIHN0YXRpYyBpbmxpbmUgaW50IG10a19kZHBfY29tcF9sYXllcl9jaGVjayhz dHJ1Y3QgbXRrX2RkcF9jb21wICpjb21wLA0KPiA+IEBAIC0xNzYsMTcgKzE4NiwxOSBAQCBzdGF0 aWMgaW5saW5lIGludCBtdGtfZGRwX2NvbXBfbGF5ZXJfY2hlY2soc3RydWN0IG10a19kZHBfY29t cCAqY29tcCwNCj4gPiAgDQo+ID4gIHN0YXRpYyBpbmxpbmUgdm9pZCBtdGtfZGRwX2NvbXBfbGF5 ZXJfY29uZmlnKHN0cnVjdCBtdGtfZGRwX2NvbXAgKmNvbXAsDQo+ID4gIAkJCQkJICAgICB1bnNp Z25lZCBpbnQgaWR4LA0KPiA+IC0JCQkJCSAgICAgc3RydWN0IG10a19wbGFuZV9zdGF0ZSAqc3Rh dGUpDQo+ID4gKwkJCQkJICAgICBzdHJ1Y3QgbXRrX3BsYW5lX3N0YXRlICpzdGF0ZSwNCj4gPiAr CQkJCQkgICAgIHN0cnVjdCBjbWRxX3BrdCAqY21kcV9wa3QpDQo+ID4gIHsNCj4gPiAgCWlmIChj b21wLT5mdW5jcyAmJiBjb21wLT5mdW5jcy0+bGF5ZXJfY29uZmlnKQ0KPiA+IC0JCWNvbXAtPmZ1 bmNzLT5sYXllcl9jb25maWcoY29tcCwgaWR4LCBzdGF0ZSk7DQo+ID4gKwkJY29tcC0+ZnVuY3Mt PmxheWVyX2NvbmZpZyhjb21wLCBpZHgsIHN0YXRlLCBjbWRxX3BrdCk7DQo+ID4gIH0NCj4gPiAg DQo+ID4gIHN0YXRpYyBpbmxpbmUgdm9pZCBtdGtfZGRwX2dhbW1hX3NldChzdHJ1Y3QgbXRrX2Rk cF9jb21wICpjb21wLA0KPiA+IC0JCQkJICAgICBzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKnN0YXRl KQ0KPiA+ICsJCQkJICAgICBzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKnN0YXRlLA0KPiA+ICsJCQkJ ICAgICBzdHJ1Y3QgY21kcV9wa3QgKmNtZHFfcGt0KQ0KPiA+ICB7DQo+ID4gIAlpZiAoY29tcC0+ ZnVuY3MgJiYgY29tcC0+ZnVuY3MtPmdhbW1hX3NldCkNCj4gPiAtCQljb21wLT5mdW5jcy0+Z2Ft bWFfc2V0KGNvbXAsIHN0YXRlKTsNCj4gPiArCQljb21wLT5mdW5jcy0+Z2FtbWFfc2V0KGNvbXAs IHN0YXRlLCBjbWRxX3BrdCk7DQo+ID4gIH0NCj4gPiAgDQo+ID4gIHN0YXRpYyBpbmxpbmUgdm9p ZCBtdGtfZGRwX2NvbXBfYmdjbHJfaW5fb24oc3RydWN0IG10a19kZHBfY29tcCAqY29tcCkNCj4g PiBAQCAtMjA5LDYgKzIyMSwxMyBAQCBpbnQgbXRrX2RkcF9jb21wX2luaXQoc3RydWN0IGRldmlj ZSAqZGV2LCBzdHJ1Y3QgZGV2aWNlX25vZGUgKmNvbXBfbm9kZSwNCj4gPiAgaW50IG10a19kZHBf Y29tcF9yZWdpc3RlcihzdHJ1Y3QgZHJtX2RldmljZSAqZHJtLCBzdHJ1Y3QgbXRrX2RkcF9jb21w ICpjb21wKTsNCj4gPiAgdm9pZCBtdGtfZGRwX2NvbXBfdW5yZWdpc3RlcihzdHJ1Y3QgZHJtX2Rl dmljZSAqZHJtLCBzdHJ1Y3QgbXRrX2RkcF9jb21wICpjb21wKTsNCj4gPiAgdm9pZCBtdGtfZGl0 aGVyX3NldChzdHJ1Y3QgbXRrX2RkcF9jb21wICpjb21wLCB1bnNpZ25lZCBpbnQgYnBjLA0KPiA+ IC0JCSAgICB1bnNpZ25lZCBpbnQgQ0ZHKTsNCj4gPiAtDQo+ID4gKwkJICAgIHVuc2lnbmVkIGlu dCBDRkcsIHN0cnVjdCBjbWRxX3BrdCAqY21kcV9wa3QpOw0KPiA+ICtlbnVtIG10a19kZHBfY29t cF90eXBlIG10a19kZHBfY29tcF9nZXRfdHlwZShlbnVtIG10a19kZHBfY29tcF9pZCBjb21wX2lk KTsNCj4gPiArdm9pZCBtdGtfZGRwX3dyaXRlKHN0cnVjdCBjbWRxX3BrdCAqY21kcV9wa3QsIHVu c2lnbmVkIGludCB2YWx1ZSwNCj4gPiArCQkgICBzdHJ1Y3QgbXRrX2RkcF9jb21wICpjb21wLCB1 bnNpZ25lZCBpbnQgb2Zmc2V0KTsNCj4gPiArdm9pZCBtdGtfZGRwX3dyaXRlX3JlbGF4ZWQoc3Ry dWN0IGNtZHFfcGt0ICpjbWRxX3BrdCwgdW5zaWduZWQgaW50IHZhbHVlLA0KPiA+ICsJCQkgICBz dHJ1Y3QgbXRrX2RkcF9jb21wICpjb21wLCB1bnNpZ25lZCBpbnQgb2Zmc2V0KTsNCj4gPiArdm9p ZCBtdGtfZGRwX3dyaXRlX21hc2soc3RydWN0IGNtZHFfcGt0ICpjbWRxX3BrdCwgdW5zaWduZWQg aW50IHZhbHVlLA0KPiA+ICsJCQlzdHJ1Y3QgbXRrX2RkcF9jb21wICpjb21wLCB1bnNpZ25lZCBp bnQgb2Zmc2V0LA0KPiA+ICsJCQl1bnNpZ25lZCBpbnQgbWFzayk7DQo+ID4gICNlbmRpZiAvKiBN VEtfRFJNX0REUF9DT01QX0ggKi8NCj4gDQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E874C432C3 for ; Tue, 3 Dec 2019 03:34:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 42F12206DC for ; Tue, 3 Dec 2019 03:34:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eP7gHWCC"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="i5z0BJM5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42F12206DC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=o9nRPzK389IrbHbzYVL79G4Gk2STkGbj93s+hyoqFxg=; b=eP7gHWCCmPKqWw y70UWmw6z2KyXZ2dnlYtHcQ1fyJipep4dYUBKuiTttbXehVF6SNFytrFsDOexwAQQPD+3QPmEvNlQ meaP+M42/U8Aut3O9eX+6APozBRcGtta5gb1wUO4ChHuTo2Kx4CadvrkkzVlS8G03ZcnB0gJ2q7b9 nMJNxGpMi+Qi0Ir4qaYAEwcVd9oTRJTrj89xAekFae2teRY2R2FIJC245xhvE1Ez6Fkztv1DOb/7p NKlfS02avaufYQt9QLrtsgMY++hJy3tkFU9Cxn7CYdMEroQhmCluAsW55OgqAjlPO/VbzMtgHIAG4 teKEmghFZGjax54bL7GQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibyxX-0006vl-M1; Tue, 03 Dec 2019 03:34:43 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibyxR-0006qH-Cm; Tue, 03 Dec 2019 03:34:39 +0000 X-UUID: 1d13ed885f664f5cbe3bcf4b82673030-20191202 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=YYdvdLxaz+GrtaamZIqTRrwxovn6ou6aNFueL+5BIUI=; b=i5z0BJM5zG4zTt49S9eba3RZRo3J16IO1cT51iOotJ7V7VOk4r9TcmgBrG2k0Ox1LfKEh12NscTYLiSd2o4guGqTVRysbIUsZS0A8Bn6eSvX6qFAs/WJwT7g5NPiWmcdZj2YKzcMcJgVTVCuaS+iKmCWl1ZAWYmKag+1C/NeLW0=; X-UUID: 1d13ed885f664f5cbe3bcf4b82673030-20191202 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 765615208; Mon, 02 Dec 2019 19:34:31 -0800 Received: from mtkmbs05n1.mediatek.inc (172.21.101.15) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 2 Dec 2019 19:35:12 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 3 Dec 2019 11:34:13 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 3 Dec 2019 11:34:08 +0800 Message-ID: <1575344068.627.2.camel@mtksdaap41> Subject: Re: [PATCH v1 5/6] drm/mediatek: support CMDQ interface in ddp component From: CK Hu To: Bibby Hsieh Date: Tue, 3 Dec 2019 11:34:28 +0800 In-Reply-To: <1575341763.19788.3.camel@mtksdaap41> References: <20191128024238.9399-1-bibby.hsieh@mediatek.com> <20191128024238.9399-6-bibby.hsieh@mediatek.com> <1575341763.19788.3.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191202_193437_446307_FA460B28 X-CRM114-Status: GOOD ( 15.55 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drinkcat@chromium.org, Yongqiang Niu , srv_heupstream@mediatek.com, David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tfiga@chromium.org, Thierry Reding , linux-mediatek@lists.infradead.org, Philipp Zabel , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi, Bibby: On Tue, 2019-12-03 at 10:56 +0800, CK Hu wrote: > Hi, Bibby: > > On Thu, 2019-11-28 at 10:42 +0800, Bibby Hsieh wrote: > > The CMDQ (Command Queue) in MT8183 is used to help > > update all relevant display controller registers > > with critical time limation. > > This patch add cmdq interface in ddp_comp interface, > > let all ddp_comp interface can support cpu/cmdq function > > at the same time. > > > > Signed-off-by: YT Shen > > Signed-off-by: CK Hu > > Signed-off-by: Philipp Zabel > > Signed-off-by: Bibby Hsieh > > Signed-off-by: Yongqiang Niu > > --- > > drivers/gpu/drm/mediatek/mtk_disp_color.c | 7 +- > > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 65 ++++++----- > > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 43 ++++--- > > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 11 +- > > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 120 ++++++++++++++------ > > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 55 ++++++--- > > 6 files changed, 190 insertions(+), 111 deletions(-) > > > [snip] > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h > > index ec55c7488cc3..5b0a3d48dfa6 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h > > @@ -69,25 +69,30 @@ enum mtk_ddp_comp_id { > > }; > > > > struct mtk_ddp_comp; > > - > > +struct cmdq_pkt; > > struct mtk_ddp_comp_funcs { > > void (*config)(struct mtk_ddp_comp *comp, unsigned int w, > > - unsigned int h, unsigned int vrefresh, unsigned int bpc); > > + unsigned int h, unsigned int vrefresh, > > + unsigned int bpc, struct cmdq_pkt *cmdq_pkt); > > void (*start)(struct mtk_ddp_comp *comp); > > void (*stop)(struct mtk_ddp_comp *comp); > > void (*enable_vblank)(struct mtk_ddp_comp *comp, struct drm_crtc *crtc); > > void (*disable_vblank)(struct mtk_ddp_comp *comp); > > unsigned int (*supported_rotations)(struct mtk_ddp_comp *comp); > > unsigned int (*layer_nr)(struct mtk_ddp_comp *comp); > > - void (*layer_on)(struct mtk_ddp_comp *comp, unsigned int idx); > > - void (*layer_off)(struct mtk_ddp_comp *comp, unsigned int idx); > > + void (*layer_on)(struct mtk_ddp_comp *comp, unsigned int idx, > > + struct cmdq_pkt *cmdq_pkt); > > + void (*layer_off)(struct mtk_ddp_comp *comp, unsigned int idx, > > + struct cmdq_pkt *cmdq_pkt); layer_on() and layer_off() looks useless, so I would like you just remove this interface in another patch. Regards, CK > > int (*layer_check)(struct mtk_ddp_comp *comp, > > unsigned int idx, > > struct mtk_plane_state *state); > > void (*layer_config)(struct mtk_ddp_comp *comp, unsigned int idx, > > - struct mtk_plane_state *state); > > + struct mtk_plane_state *state, > > + struct cmdq_pkt *cmdq_pkt); > > void (*gamma_set)(struct mtk_ddp_comp *comp, > > - struct drm_crtc_state *state); > > + struct drm_crtc_state *state, > > + struct cmdq_pkt *cmdq_pkt); > > void (*bgclr_in_on)(struct mtk_ddp_comp *comp); > > void (*bgclr_in_off)(struct mtk_ddp_comp *comp); > > }; > > @@ -99,14 +104,17 @@ struct mtk_ddp_comp { > > struct device *dev; > > enum mtk_ddp_comp_id id; > > const struct mtk_ddp_comp_funcs *funcs; > > + resource_size_t regs_pa; > > + u8 subsys; > > }; > > > > static inline void mtk_ddp_comp_config(struct mtk_ddp_comp *comp, > > unsigned int w, unsigned int h, > > - unsigned int vrefresh, unsigned int bpc) > > + unsigned int vrefresh, unsigned int bpc, > > + struct cmdq_pkt *cmdq_pkt) > > { > > if (comp->funcs && comp->funcs->config) > > - comp->funcs->config(comp, w, h, vrefresh, bpc); > > + comp->funcs->config(comp, w, h, vrefresh, bpc, cmdq_pkt); > > } > > > > static inline void mtk_ddp_comp_start(struct mtk_ddp_comp *comp) > > @@ -152,17 +160,19 @@ static inline unsigned int mtk_ddp_comp_layer_nr(struct mtk_ddp_comp *comp) > > } > > > > static inline void mtk_ddp_comp_layer_on(struct mtk_ddp_comp *comp, > > - unsigned int idx) > > + unsigned int idx, > > + struct cmdq_pkt *cmdq_pkt) > > { > > if (comp->funcs && comp->funcs->layer_on) > > - comp->funcs->layer_on(comp, idx); > > + comp->funcs->layer_on(comp, idx, cmdq_pkt); > > } > > > > static inline void mtk_ddp_comp_layer_off(struct mtk_ddp_comp *comp, > > - unsigned int idx) > > + unsigned int idx, > > + struct cmdq_pkt *cmdq_pkt) > > { > > if (comp->funcs && comp->funcs->layer_off) > > - comp->funcs->layer_off(comp, idx); > > + comp->funcs->layer_off(comp, idx, cmdq_pkt); > > } > > > > static inline int mtk_ddp_comp_layer_check(struct mtk_ddp_comp *comp, > > @@ -176,17 +186,19 @@ static inline int mtk_ddp_comp_layer_check(struct mtk_ddp_comp *comp, > > > > static inline void mtk_ddp_comp_layer_config(struct mtk_ddp_comp *comp, > > unsigned int idx, > > - struct mtk_plane_state *state) > > + struct mtk_plane_state *state, > > + struct cmdq_pkt *cmdq_pkt) > > { > > if (comp->funcs && comp->funcs->layer_config) > > - comp->funcs->layer_config(comp, idx, state); > > + comp->funcs->layer_config(comp, idx, state, cmdq_pkt); > > } > > > > static inline void mtk_ddp_gamma_set(struct mtk_ddp_comp *comp, > > - struct drm_crtc_state *state) > > + struct drm_crtc_state *state, > > + struct cmdq_pkt *cmdq_pkt) > > { > > if (comp->funcs && comp->funcs->gamma_set) > > - comp->funcs->gamma_set(comp, state); > > + comp->funcs->gamma_set(comp, state, cmdq_pkt); > > } > > > > static inline void mtk_ddp_comp_bgclr_in_on(struct mtk_ddp_comp *comp) > > @@ -209,6 +221,13 @@ int mtk_ddp_comp_init(struct device *dev, struct device_node *comp_node, > > int mtk_ddp_comp_register(struct drm_device *drm, struct mtk_ddp_comp *comp); > > void mtk_ddp_comp_unregister(struct drm_device *drm, struct mtk_ddp_comp *comp); > > void mtk_dither_set(struct mtk_ddp_comp *comp, unsigned int bpc, > > - unsigned int CFG); > > - > > + unsigned int CFG, struct cmdq_pkt *cmdq_pkt); > > +enum mtk_ddp_comp_type mtk_ddp_comp_get_type(enum mtk_ddp_comp_id comp_id); > > +void mtk_ddp_write(struct cmdq_pkt *cmdq_pkt, unsigned int value, > > + struct mtk_ddp_comp *comp, unsigned int offset); > > +void mtk_ddp_write_relaxed(struct cmdq_pkt *cmdq_pkt, unsigned int value, > > + struct mtk_ddp_comp *comp, unsigned int offset); > > +void mtk_ddp_write_mask(struct cmdq_pkt *cmdq_pkt, unsigned int value, > > + struct mtk_ddp_comp *comp, unsigned int offset, > > + unsigned int mask); > > #endif /* MTK_DRM_DDP_COMP_H */ > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21D44C43141 for ; Tue, 3 Dec 2019 03:34:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED372206DC for ; Tue, 3 Dec 2019 03:34:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UExa0sKl"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="i5z0BJM5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED372206DC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8O3d4pOcM6kqDIHKYaLK30mje4c/tC2phtGiAPIMxuI=; b=UExa0sKlqK3KVo 1SpuHvTRy1+vvVsjIiASNTKNMLYW2fNjgzz3oTuJs9VIQ7zOLW1ic/Tt/s1MGNnqeBI45tpZbW+c8 rPi22RpLMza5SMEs//o0yk+Lx2K2ugqlRUUBm4cyRKJa9WVaJ0NsNidXg+vofGJhS1/Yvdpkv1OBY jR1qQ45NHP5m8ORwMFaOImqyP37KXUkD25yrQzcjCDdOMEgq8l2GYZDFne5RDB6BHb3XZHx0B5QX+ oiif9uxFp4IrRa48J4BXwPiZEdtV7PIZXi6AzApMCELWBj2Vjog0ee3kjBHrr94SZ2gyWDoneWURX 4tBohgr5a3RMo1HlNNUQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibyxU-0006qt-DA; Tue, 03 Dec 2019 03:34:40 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibyxR-0006qH-Cm; Tue, 03 Dec 2019 03:34:39 +0000 X-UUID: 1d13ed885f664f5cbe3bcf4b82673030-20191202 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=YYdvdLxaz+GrtaamZIqTRrwxovn6ou6aNFueL+5BIUI=; b=i5z0BJM5zG4zTt49S9eba3RZRo3J16IO1cT51iOotJ7V7VOk4r9TcmgBrG2k0Ox1LfKEh12NscTYLiSd2o4guGqTVRysbIUsZS0A8Bn6eSvX6qFAs/WJwT7g5NPiWmcdZj2YKzcMcJgVTVCuaS+iKmCWl1ZAWYmKag+1C/NeLW0=; X-UUID: 1d13ed885f664f5cbe3bcf4b82673030-20191202 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 765615208; Mon, 02 Dec 2019 19:34:31 -0800 Received: from mtkmbs05n1.mediatek.inc (172.21.101.15) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 2 Dec 2019 19:35:12 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 3 Dec 2019 11:34:13 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 3 Dec 2019 11:34:08 +0800 Message-ID: <1575344068.627.2.camel@mtksdaap41> Subject: Re: [PATCH v1 5/6] drm/mediatek: support CMDQ interface in ddp component From: CK Hu To: Bibby Hsieh Date: Tue, 3 Dec 2019 11:34:28 +0800 In-Reply-To: <1575341763.19788.3.camel@mtksdaap41> References: <20191128024238.9399-1-bibby.hsieh@mediatek.com> <20191128024238.9399-6-bibby.hsieh@mediatek.com> <1575341763.19788.3.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191202_193437_446307_FA460B28 X-CRM114-Status: GOOD ( 15.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drinkcat@chromium.org, Yongqiang Niu , srv_heupstream@mediatek.com, David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tfiga@chromium.org, YT Shen , Thierry Reding , linux-mediatek@lists.infradead.org, Philipp Zabel , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Bibby: On Tue, 2019-12-03 at 10:56 +0800, CK Hu wrote: > Hi, Bibby: > > On Thu, 2019-11-28 at 10:42 +0800, Bibby Hsieh wrote: > > The CMDQ (Command Queue) in MT8183 is used to help > > update all relevant display controller registers > > with critical time limation. > > This patch add cmdq interface in ddp_comp interface, > > let all ddp_comp interface can support cpu/cmdq function > > at the same time. > > > > Signed-off-by: YT Shen > > Signed-off-by: CK Hu > > Signed-off-by: Philipp Zabel > > Signed-off-by: Bibby Hsieh > > Signed-off-by: Yongqiang Niu > > --- > > drivers/gpu/drm/mediatek/mtk_disp_color.c | 7 +- > > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 65 ++++++----- > > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 43 ++++--- > > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 11 +- > > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 120 ++++++++++++++------ > > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 55 ++++++--- > > 6 files changed, 190 insertions(+), 111 deletions(-) > > > [snip] > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h > > index ec55c7488cc3..5b0a3d48dfa6 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h > > @@ -69,25 +69,30 @@ enum mtk_ddp_comp_id { > > }; > > > > struct mtk_ddp_comp; > > - > > +struct cmdq_pkt; > > struct mtk_ddp_comp_funcs { > > void (*config)(struct mtk_ddp_comp *comp, unsigned int w, > > - unsigned int h, unsigned int vrefresh, unsigned int bpc); > > + unsigned int h, unsigned int vrefresh, > > + unsigned int bpc, struct cmdq_pkt *cmdq_pkt); > > void (*start)(struct mtk_ddp_comp *comp); > > void (*stop)(struct mtk_ddp_comp *comp); > > void (*enable_vblank)(struct mtk_ddp_comp *comp, struct drm_crtc *crtc); > > void (*disable_vblank)(struct mtk_ddp_comp *comp); > > unsigned int (*supported_rotations)(struct mtk_ddp_comp *comp); > > unsigned int (*layer_nr)(struct mtk_ddp_comp *comp); > > - void (*layer_on)(struct mtk_ddp_comp *comp, unsigned int idx); > > - void (*layer_off)(struct mtk_ddp_comp *comp, unsigned int idx); > > + void (*layer_on)(struct mtk_ddp_comp *comp, unsigned int idx, > > + struct cmdq_pkt *cmdq_pkt); > > + void (*layer_off)(struct mtk_ddp_comp *comp, unsigned int idx, > > + struct cmdq_pkt *cmdq_pkt); layer_on() and layer_off() looks useless, so I would like you just remove this interface in another patch. Regards, CK > > int (*layer_check)(struct mtk_ddp_comp *comp, > > unsigned int idx, > > struct mtk_plane_state *state); > > void (*layer_config)(struct mtk_ddp_comp *comp, unsigned int idx, > > - struct mtk_plane_state *state); > > + struct mtk_plane_state *state, > > + struct cmdq_pkt *cmdq_pkt); > > void (*gamma_set)(struct mtk_ddp_comp *comp, > > - struct drm_crtc_state *state); > > + struct drm_crtc_state *state, > > + struct cmdq_pkt *cmdq_pkt); > > void (*bgclr_in_on)(struct mtk_ddp_comp *comp); > > void (*bgclr_in_off)(struct mtk_ddp_comp *comp); > > }; > > @@ -99,14 +104,17 @@ struct mtk_ddp_comp { > > struct device *dev; > > enum mtk_ddp_comp_id id; > > const struct mtk_ddp_comp_funcs *funcs; > > + resource_size_t regs_pa; > > + u8 subsys; > > }; > > > > static inline void mtk_ddp_comp_config(struct mtk_ddp_comp *comp, > > unsigned int w, unsigned int h, > > - unsigned int vrefresh, unsigned int bpc) > > + unsigned int vrefresh, unsigned int bpc, > > + struct cmdq_pkt *cmdq_pkt) > > { > > if (comp->funcs && comp->funcs->config) > > - comp->funcs->config(comp, w, h, vrefresh, bpc); > > + comp->funcs->config(comp, w, h, vrefresh, bpc, cmdq_pkt); > > } > > > > static inline void mtk_ddp_comp_start(struct mtk_ddp_comp *comp) > > @@ -152,17 +160,19 @@ static inline unsigned int mtk_ddp_comp_layer_nr(struct mtk_ddp_comp *comp) > > } > > > > static inline void mtk_ddp_comp_layer_on(struct mtk_ddp_comp *comp, > > - unsigned int idx) > > + unsigned int idx, > > + struct cmdq_pkt *cmdq_pkt) > > { > > if (comp->funcs && comp->funcs->layer_on) > > - comp->funcs->layer_on(comp, idx); > > + comp->funcs->layer_on(comp, idx, cmdq_pkt); > > } > > > > static inline void mtk_ddp_comp_layer_off(struct mtk_ddp_comp *comp, > > - unsigned int idx) > > + unsigned int idx, > > + struct cmdq_pkt *cmdq_pkt) > > { > > if (comp->funcs && comp->funcs->layer_off) > > - comp->funcs->layer_off(comp, idx); > > + comp->funcs->layer_off(comp, idx, cmdq_pkt); > > } > > > > static inline int mtk_ddp_comp_layer_check(struct mtk_ddp_comp *comp, > > @@ -176,17 +186,19 @@ static inline int mtk_ddp_comp_layer_check(struct mtk_ddp_comp *comp, > > > > static inline void mtk_ddp_comp_layer_config(struct mtk_ddp_comp *comp, > > unsigned int idx, > > - struct mtk_plane_state *state) > > + struct mtk_plane_state *state, > > + struct cmdq_pkt *cmdq_pkt) > > { > > if (comp->funcs && comp->funcs->layer_config) > > - comp->funcs->layer_config(comp, idx, state); > > + comp->funcs->layer_config(comp, idx, state, cmdq_pkt); > > } > > > > static inline void mtk_ddp_gamma_set(struct mtk_ddp_comp *comp, > > - struct drm_crtc_state *state) > > + struct drm_crtc_state *state, > > + struct cmdq_pkt *cmdq_pkt) > > { > > if (comp->funcs && comp->funcs->gamma_set) > > - comp->funcs->gamma_set(comp, state); > > + comp->funcs->gamma_set(comp, state, cmdq_pkt); > > } > > > > static inline void mtk_ddp_comp_bgclr_in_on(struct mtk_ddp_comp *comp) > > @@ -209,6 +221,13 @@ int mtk_ddp_comp_init(struct device *dev, struct device_node *comp_node, > > int mtk_ddp_comp_register(struct drm_device *drm, struct mtk_ddp_comp *comp); > > void mtk_ddp_comp_unregister(struct drm_device *drm, struct mtk_ddp_comp *comp); > > void mtk_dither_set(struct mtk_ddp_comp *comp, unsigned int bpc, > > - unsigned int CFG); > > - > > + unsigned int CFG, struct cmdq_pkt *cmdq_pkt); > > +enum mtk_ddp_comp_type mtk_ddp_comp_get_type(enum mtk_ddp_comp_id comp_id); > > +void mtk_ddp_write(struct cmdq_pkt *cmdq_pkt, unsigned int value, > > + struct mtk_ddp_comp *comp, unsigned int offset); > > +void mtk_ddp_write_relaxed(struct cmdq_pkt *cmdq_pkt, unsigned int value, > > + struct mtk_ddp_comp *comp, unsigned int offset); > > +void mtk_ddp_write_mask(struct cmdq_pkt *cmdq_pkt, unsigned int value, > > + struct mtk_ddp_comp *comp, unsigned int offset, > > + unsigned int mask); > > #endif /* MTK_DRM_DDP_COMP_H */ > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: CK Hu Subject: Re: [PATCH v1 5/6] drm/mediatek: support CMDQ interface in ddp component Date: Tue, 3 Dec 2019 11:34:28 +0800 Message-ID: <1575344068.627.2.camel@mtksdaap41> References: <20191128024238.9399-1-bibby.hsieh@mediatek.com> <20191128024238.9399-6-bibby.hsieh@mediatek.com> <1575341763.19788.3.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailgw01.mediatek.com (unknown [210.61.82.183]) by gabe.freedesktop.org (Postfix) with ESMTP id 36D5A8982C for ; Tue, 3 Dec 2019 03:34:33 +0000 (UTC) In-Reply-To: <1575341763.19788.3.camel@mtksdaap41> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Bibby Hsieh Cc: drinkcat@chromium.org, Yongqiang Niu , srv_heupstream@mediatek.com, David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tfiga@chromium.org, Thierry Reding , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org SGksIEJpYmJ5Og0KDQpPbiBUdWUsIDIwMTktMTItMDMgYXQgMTA6NTYgKzA4MDAsIENLIEh1IHdy b3RlOg0KPiBIaSwgQmliYnk6DQo+IA0KPiBPbiBUaHUsIDIwMTktMTEtMjggYXQgMTA6NDIgKzA4 MDAsIEJpYmJ5IEhzaWVoIHdyb3RlOg0KPiA+IFRoZSBDTURRIChDb21tYW5kIFF1ZXVlKSBpbiBN VDgxODMgaXMgdXNlZCB0byBoZWxwDQo+ID4gdXBkYXRlIGFsbCByZWxldmFudCBkaXNwbGF5IGNv bnRyb2xsZXIgcmVnaXN0ZXJzDQo+ID4gd2l0aCBjcml0aWNhbCB0aW1lIGxpbWF0aW9uLg0KPiA+ IFRoaXMgcGF0Y2ggYWRkIGNtZHEgaW50ZXJmYWNlIGluIGRkcF9jb21wIGludGVyZmFjZSwNCj4g PiBsZXQgYWxsIGRkcF9jb21wIGludGVyZmFjZSBjYW4gc3VwcG9ydCBjcHUvY21kcSBmdW5jdGlv bg0KPiA+IGF0IHRoZSBzYW1lIHRpbWUuDQo+ID4gDQo+ID4gU2lnbmVkLW9mZi1ieTogWVQgU2hl biA8eXQuc2hlbkBtZWRpYXRlay5jb20+DQo+ID4gU2lnbmVkLW9mZi1ieTogQ0sgSHUgPGNrLmh1 QG1lZGlhdGVrLmNvbT4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBQaGlsaXBwIFphYmVsIDxwLnphYmVs QHBlbmd1dHJvbml4LmRlPg0KPiA+IFNpZ25lZC1vZmYtYnk6IEJpYmJ5IEhzaWVoIDxiaWJieS5o c2llaEBtZWRpYXRlay5jb20+DQo+ID4gU2lnbmVkLW9mZi1ieTogWW9uZ3FpYW5nIE5pdSA8eW9u Z3FpYW5nLm5pdUBtZWRpYXRlay5jb20+DQo+ID4gLS0tDQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9t ZWRpYXRlay9tdGtfZGlzcF9jb2xvci5jICAgfCAgIDcgKy0NCj4gPiAgZHJpdmVycy9ncHUvZHJt L21lZGlhdGVrL210a19kaXNwX292bC5jICAgICB8ICA2NSArKysrKystLS0tLQ0KPiA+ICBkcml2 ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2Rpc3BfcmRtYS5jICAgIHwgIDQzICsrKystLS0NCj4g PiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fY3J0Yy5jICAgICB8ICAxMSArLQ0K PiA+ICBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHBfY29tcC5jIHwgMTIwICsr KysrKysrKysrKysrLS0tLS0tDQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJt X2RkcF9jb21wLmggfCAgNTUgKysrKysrLS0tDQo+ID4gIDYgZmlsZXMgY2hhbmdlZCwgMTkwIGlu c2VydGlvbnMoKyksIDExMSBkZWxldGlvbnMoLSkNCj4gPiANCj4gDQoNCltzbmlwXQ0KDQo+ID4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2RkcF9jb21wLmgg Yi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHBfY29tcC5oDQo+ID4gaW5kZXgg ZWM1NWM3NDg4Y2MzLi41YjBhM2Q0OGRmYTYgMTAwNjQ0DQo+ID4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL21lZGlhdGVrL210a19kcm1fZGRwX2NvbXAuaA0KPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9tZWRpYXRlay9tdGtfZHJtX2RkcF9jb21wLmgNCj4gPiBAQCAtNjksMjUgKzY5LDMwIEBAIGVu dW0gbXRrX2RkcF9jb21wX2lkIHsNCj4gPiAgfTsNCj4gPiAgDQo+ID4gIHN0cnVjdCBtdGtfZGRw X2NvbXA7DQo+ID4gLQ0KPiA+ICtzdHJ1Y3QgY21kcV9wa3Q7DQo+ID4gIHN0cnVjdCBtdGtfZGRw X2NvbXBfZnVuY3Mgew0KPiA+ICAJdm9pZCAoKmNvbmZpZykoc3RydWN0IG10a19kZHBfY29tcCAq Y29tcCwgdW5zaWduZWQgaW50IHcsDQo+ID4gLQkJICAgICAgIHVuc2lnbmVkIGludCBoLCB1bnNp Z25lZCBpbnQgdnJlZnJlc2gsIHVuc2lnbmVkIGludCBicGMpOw0KPiA+ICsJCSAgICAgICB1bnNp Z25lZCBpbnQgaCwgdW5zaWduZWQgaW50IHZyZWZyZXNoLA0KPiA+ICsJCSAgICAgICB1bnNpZ25l ZCBpbnQgYnBjLCBzdHJ1Y3QgY21kcV9wa3QgKmNtZHFfcGt0KTsNCj4gPiAgCXZvaWQgKCpzdGFy dCkoc3RydWN0IG10a19kZHBfY29tcCAqY29tcCk7DQo+ID4gIAl2b2lkICgqc3RvcCkoc3RydWN0 IG10a19kZHBfY29tcCAqY29tcCk7DQo+ID4gIAl2b2lkICgqZW5hYmxlX3ZibGFuaykoc3RydWN0 IG10a19kZHBfY29tcCAqY29tcCwgc3RydWN0IGRybV9jcnRjICpjcnRjKTsNCj4gPiAgCXZvaWQg KCpkaXNhYmxlX3ZibGFuaykoc3RydWN0IG10a19kZHBfY29tcCAqY29tcCk7DQo+ID4gIAl1bnNp Z25lZCBpbnQgKCpzdXBwb3J0ZWRfcm90YXRpb25zKShzdHJ1Y3QgbXRrX2RkcF9jb21wICpjb21w KTsNCj4gPiAgCXVuc2lnbmVkIGludCAoKmxheWVyX25yKShzdHJ1Y3QgbXRrX2RkcF9jb21wICpj b21wKTsNCj4gPiAtCXZvaWQgKCpsYXllcl9vbikoc3RydWN0IG10a19kZHBfY29tcCAqY29tcCwg dW5zaWduZWQgaW50IGlkeCk7DQo+ID4gLQl2b2lkICgqbGF5ZXJfb2ZmKShzdHJ1Y3QgbXRrX2Rk cF9jb21wICpjb21wLCB1bnNpZ25lZCBpbnQgaWR4KTsNCj4gPiArCXZvaWQgKCpsYXllcl9vbiko c3RydWN0IG10a19kZHBfY29tcCAqY29tcCwgdW5zaWduZWQgaW50IGlkeCwNCj4gPiArCQkJIHN0 cnVjdCBjbWRxX3BrdCAqY21kcV9wa3QpOw0KPiA+ICsJdm9pZCAoKmxheWVyX29mZikoc3RydWN0 IG10a19kZHBfY29tcCAqY29tcCwgdW5zaWduZWQgaW50IGlkeCwNCj4gPiArCQkJICBzdHJ1Y3Qg Y21kcV9wa3QgKmNtZHFfcGt0KTsNCg0KbGF5ZXJfb24oKSBhbmQgbGF5ZXJfb2ZmKCkgbG9va3Mg dXNlbGVzcywgc28gSSB3b3VsZCBsaWtlIHlvdSBqdXN0DQpyZW1vdmUgdGhpcyBpbnRlcmZhY2Ug aW4gYW5vdGhlciBwYXRjaC4NCg0KUmVnYXJkcywNCkNLDQoNCj4gPiAgCWludCAoKmxheWVyX2No ZWNrKShzdHJ1Y3QgbXRrX2RkcF9jb21wICpjb21wLA0KPiA+ICAJCQkgICB1bnNpZ25lZCBpbnQg aWR4LA0KPiA+ICAJCQkgICBzdHJ1Y3QgbXRrX3BsYW5lX3N0YXRlICpzdGF0ZSk7DQo+ID4gIAl2 b2lkICgqbGF5ZXJfY29uZmlnKShzdHJ1Y3QgbXRrX2RkcF9jb21wICpjb21wLCB1bnNpZ25lZCBp bnQgaWR4LA0KPiA+IC0JCQkgICAgIHN0cnVjdCBtdGtfcGxhbmVfc3RhdGUgKnN0YXRlKTsNCj4g PiArCQkJICAgICBzdHJ1Y3QgbXRrX3BsYW5lX3N0YXRlICpzdGF0ZSwNCj4gPiArCQkJICAgICBz dHJ1Y3QgY21kcV9wa3QgKmNtZHFfcGt0KTsNCj4gPiAgCXZvaWQgKCpnYW1tYV9zZXQpKHN0cnVj dCBtdGtfZGRwX2NvbXAgKmNvbXAsDQo+ID4gLQkJCSAgc3RydWN0IGRybV9jcnRjX3N0YXRlICpz dGF0ZSk7DQo+ID4gKwkJCSAgc3RydWN0IGRybV9jcnRjX3N0YXRlICpzdGF0ZSwNCj4gPiArCQkJ ICBzdHJ1Y3QgY21kcV9wa3QgKmNtZHFfcGt0KTsNCj4gPiAgCXZvaWQgKCpiZ2Nscl9pbl9vbiko c3RydWN0IG10a19kZHBfY29tcCAqY29tcCk7DQo+ID4gIAl2b2lkICgqYmdjbHJfaW5fb2ZmKShz dHJ1Y3QgbXRrX2RkcF9jb21wICpjb21wKTsNCj4gPiAgfTsNCj4gPiBAQCAtOTksMTQgKzEwNCwx NyBAQCBzdHJ1Y3QgbXRrX2RkcF9jb21wIHsNCj4gPiAgCXN0cnVjdCBkZXZpY2UgKmRldjsNCj4g PiAgCWVudW0gbXRrX2RkcF9jb21wX2lkIGlkOw0KPiA+ICAJY29uc3Qgc3RydWN0IG10a19kZHBf Y29tcF9mdW5jcyAqZnVuY3M7DQo+ID4gKwlyZXNvdXJjZV9zaXplX3QgcmVnc19wYTsNCj4gPiAr CXU4IHN1YnN5czsNCj4gPiAgfTsNCj4gPiAgDQo+ID4gIHN0YXRpYyBpbmxpbmUgdm9pZCBtdGtf ZGRwX2NvbXBfY29uZmlnKHN0cnVjdCBtdGtfZGRwX2NvbXAgKmNvbXAsDQo+ID4gIAkJCQkgICAg ICAgdW5zaWduZWQgaW50IHcsIHVuc2lnbmVkIGludCBoLA0KPiA+IC0JCQkJICAgICAgIHVuc2ln bmVkIGludCB2cmVmcmVzaCwgdW5zaWduZWQgaW50IGJwYykNCj4gPiArCQkJCSAgICAgICB1bnNp Z25lZCBpbnQgdnJlZnJlc2gsIHVuc2lnbmVkIGludCBicGMsDQo+ID4gKwkJCQkgICAgICAgc3Ry dWN0IGNtZHFfcGt0ICpjbWRxX3BrdCkNCj4gPiAgew0KPiA+ICAJaWYgKGNvbXAtPmZ1bmNzICYm IGNvbXAtPmZ1bmNzLT5jb25maWcpDQo+ID4gLQkJY29tcC0+ZnVuY3MtPmNvbmZpZyhjb21wLCB3 LCBoLCB2cmVmcmVzaCwgYnBjKTsNCj4gPiArCQljb21wLT5mdW5jcy0+Y29uZmlnKGNvbXAsIHcs IGgsIHZyZWZyZXNoLCBicGMsIGNtZHFfcGt0KTsNCj4gPiAgfQ0KPiA+ICANCj4gPiAgc3RhdGlj IGlubGluZSB2b2lkIG10a19kZHBfY29tcF9zdGFydChzdHJ1Y3QgbXRrX2RkcF9jb21wICpjb21w KQ0KPiA+IEBAIC0xNTIsMTcgKzE2MCwxOSBAQCBzdGF0aWMgaW5saW5lIHVuc2lnbmVkIGludCBt dGtfZGRwX2NvbXBfbGF5ZXJfbnIoc3RydWN0IG10a19kZHBfY29tcCAqY29tcCkNCj4gPiAgfQ0K PiA+ICANCj4gPiAgc3RhdGljIGlubGluZSB2b2lkIG10a19kZHBfY29tcF9sYXllcl9vbihzdHJ1 Y3QgbXRrX2RkcF9jb21wICpjb21wLA0KPiA+IC0JCQkJCSB1bnNpZ25lZCBpbnQgaWR4KQ0KPiA+ ICsJCQkJCSB1bnNpZ25lZCBpbnQgaWR4LA0KPiA+ICsJCQkJCSBzdHJ1Y3QgY21kcV9wa3QgKmNt ZHFfcGt0KQ0KPiA+ICB7DQo+ID4gIAlpZiAoY29tcC0+ZnVuY3MgJiYgY29tcC0+ZnVuY3MtPmxh eWVyX29uKQ0KPiA+IC0JCWNvbXAtPmZ1bmNzLT5sYXllcl9vbihjb21wLCBpZHgpOw0KPiA+ICsJ CWNvbXAtPmZ1bmNzLT5sYXllcl9vbihjb21wLCBpZHgsIGNtZHFfcGt0KTsNCj4gPiAgfQ0KPiA+ ICANCj4gPiAgc3RhdGljIGlubGluZSB2b2lkIG10a19kZHBfY29tcF9sYXllcl9vZmYoc3RydWN0 IG10a19kZHBfY29tcCAqY29tcCwNCj4gPiAtCQkJCQkgIHVuc2lnbmVkIGludCBpZHgpDQo+ID4g KwkJCQkJICB1bnNpZ25lZCBpbnQgaWR4LA0KPiA+ICsJCQkJCSAgc3RydWN0IGNtZHFfcGt0ICpj bWRxX3BrdCkNCj4gPiAgew0KPiA+ICAJaWYgKGNvbXAtPmZ1bmNzICYmIGNvbXAtPmZ1bmNzLT5s YXllcl9vZmYpDQo+ID4gLQkJY29tcC0+ZnVuY3MtPmxheWVyX29mZihjb21wLCBpZHgpOw0KPiA+ ICsJCWNvbXAtPmZ1bmNzLT5sYXllcl9vZmYoY29tcCwgaWR4LCBjbWRxX3BrdCk7DQo+ID4gIH0N Cj4gPiAgDQo+ID4gIHN0YXRpYyBpbmxpbmUgaW50IG10a19kZHBfY29tcF9sYXllcl9jaGVjayhz dHJ1Y3QgbXRrX2RkcF9jb21wICpjb21wLA0KPiA+IEBAIC0xNzYsMTcgKzE4NiwxOSBAQCBzdGF0 aWMgaW5saW5lIGludCBtdGtfZGRwX2NvbXBfbGF5ZXJfY2hlY2soc3RydWN0IG10a19kZHBfY29t cCAqY29tcCwNCj4gPiAgDQo+ID4gIHN0YXRpYyBpbmxpbmUgdm9pZCBtdGtfZGRwX2NvbXBfbGF5 ZXJfY29uZmlnKHN0cnVjdCBtdGtfZGRwX2NvbXAgKmNvbXAsDQo+ID4gIAkJCQkJICAgICB1bnNp Z25lZCBpbnQgaWR4LA0KPiA+IC0JCQkJCSAgICAgc3RydWN0IG10a19wbGFuZV9zdGF0ZSAqc3Rh dGUpDQo+ID4gKwkJCQkJICAgICBzdHJ1Y3QgbXRrX3BsYW5lX3N0YXRlICpzdGF0ZSwNCj4gPiAr CQkJCQkgICAgIHN0cnVjdCBjbWRxX3BrdCAqY21kcV9wa3QpDQo+ID4gIHsNCj4gPiAgCWlmIChj b21wLT5mdW5jcyAmJiBjb21wLT5mdW5jcy0+bGF5ZXJfY29uZmlnKQ0KPiA+IC0JCWNvbXAtPmZ1 bmNzLT5sYXllcl9jb25maWcoY29tcCwgaWR4LCBzdGF0ZSk7DQo+ID4gKwkJY29tcC0+ZnVuY3Mt PmxheWVyX2NvbmZpZyhjb21wLCBpZHgsIHN0YXRlLCBjbWRxX3BrdCk7DQo+ID4gIH0NCj4gPiAg DQo+ID4gIHN0YXRpYyBpbmxpbmUgdm9pZCBtdGtfZGRwX2dhbW1hX3NldChzdHJ1Y3QgbXRrX2Rk cF9jb21wICpjb21wLA0KPiA+IC0JCQkJICAgICBzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKnN0YXRl KQ0KPiA+ICsJCQkJICAgICBzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKnN0YXRlLA0KPiA+ICsJCQkJ ICAgICBzdHJ1Y3QgY21kcV9wa3QgKmNtZHFfcGt0KQ0KPiA+ICB7DQo+ID4gIAlpZiAoY29tcC0+ ZnVuY3MgJiYgY29tcC0+ZnVuY3MtPmdhbW1hX3NldCkNCj4gPiAtCQljb21wLT5mdW5jcy0+Z2Ft bWFfc2V0KGNvbXAsIHN0YXRlKTsNCj4gPiArCQljb21wLT5mdW5jcy0+Z2FtbWFfc2V0KGNvbXAs IHN0YXRlLCBjbWRxX3BrdCk7DQo+ID4gIH0NCj4gPiAgDQo+ID4gIHN0YXRpYyBpbmxpbmUgdm9p ZCBtdGtfZGRwX2NvbXBfYmdjbHJfaW5fb24oc3RydWN0IG10a19kZHBfY29tcCAqY29tcCkNCj4g PiBAQCAtMjA5LDYgKzIyMSwxMyBAQCBpbnQgbXRrX2RkcF9jb21wX2luaXQoc3RydWN0IGRldmlj ZSAqZGV2LCBzdHJ1Y3QgZGV2aWNlX25vZGUgKmNvbXBfbm9kZSwNCj4gPiAgaW50IG10a19kZHBf Y29tcF9yZWdpc3RlcihzdHJ1Y3QgZHJtX2RldmljZSAqZHJtLCBzdHJ1Y3QgbXRrX2RkcF9jb21w ICpjb21wKTsNCj4gPiAgdm9pZCBtdGtfZGRwX2NvbXBfdW5yZWdpc3RlcihzdHJ1Y3QgZHJtX2Rl dmljZSAqZHJtLCBzdHJ1Y3QgbXRrX2RkcF9jb21wICpjb21wKTsNCj4gPiAgdm9pZCBtdGtfZGl0 aGVyX3NldChzdHJ1Y3QgbXRrX2RkcF9jb21wICpjb21wLCB1bnNpZ25lZCBpbnQgYnBjLA0KPiA+ IC0JCSAgICB1bnNpZ25lZCBpbnQgQ0ZHKTsNCj4gPiAtDQo+ID4gKwkJICAgIHVuc2lnbmVkIGlu dCBDRkcsIHN0cnVjdCBjbWRxX3BrdCAqY21kcV9wa3QpOw0KPiA+ICtlbnVtIG10a19kZHBfY29t cF90eXBlIG10a19kZHBfY29tcF9nZXRfdHlwZShlbnVtIG10a19kZHBfY29tcF9pZCBjb21wX2lk KTsNCj4gPiArdm9pZCBtdGtfZGRwX3dyaXRlKHN0cnVjdCBjbWRxX3BrdCAqY21kcV9wa3QsIHVu c2lnbmVkIGludCB2YWx1ZSwNCj4gPiArCQkgICBzdHJ1Y3QgbXRrX2RkcF9jb21wICpjb21wLCB1 bnNpZ25lZCBpbnQgb2Zmc2V0KTsNCj4gPiArdm9pZCBtdGtfZGRwX3dyaXRlX3JlbGF4ZWQoc3Ry dWN0IGNtZHFfcGt0ICpjbWRxX3BrdCwgdW5zaWduZWQgaW50IHZhbHVlLA0KPiA+ICsJCQkgICBz dHJ1Y3QgbXRrX2RkcF9jb21wICpjb21wLCB1bnNpZ25lZCBpbnQgb2Zmc2V0KTsNCj4gPiArdm9p ZCBtdGtfZGRwX3dyaXRlX21hc2soc3RydWN0IGNtZHFfcGt0ICpjbWRxX3BrdCwgdW5zaWduZWQg aW50IHZhbHVlLA0KPiA+ICsJCQlzdHJ1Y3QgbXRrX2RkcF9jb21wICpjb21wLCB1bnNpZ25lZCBp bnQgb2Zmc2V0LA0KPiA+ICsJCQl1bnNpZ25lZCBpbnQgbWFzayk7DQo+ID4gICNlbmRpZiAvKiBN VEtfRFJNX0REUF9DT01QX0ggKi8NCj4gDQoNCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbA==