From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 060F8C432C0 for ; Tue, 3 Dec 2019 07:36:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD81F2073F for ; Tue, 3 Dec 2019 07:36:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="egidPDKU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727559AbfLCHgX (ORCPT ); Tue, 3 Dec 2019 02:36:23 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:59383 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727386AbfLCHgV (ORCPT ); Tue, 3 Dec 2019 02:36:21 -0500 X-UUID: 19b02910c6ba4280ab06721b2091080e-20191203 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=RS1SOJ53qB4oVEPa7QVaDgVYJ6ii69MjHwS2W7BD1SU=; b=egidPDKUQ8DvqY5vSr6pHFia0xtAL7GpEuhuTbxkJEGzM/aaPNgQXEUuBdpzKbu+sX5qdoOBhc6W+xXjKEj1gnUwhRgBP5xiUhPJjgDb7CTYZNiV8So2WACcO8K/k30F9bjzOurVqXG05JsEWw5Ljc8/GYvESGOhf3bGsQqL1+Y=; X-UUID: 19b02910c6ba4280ab06721b2091080e-20191203 Received: from mtkmrs01.mediatek.inc [(172.21.131.159)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1082560974; Tue, 03 Dec 2019 15:36:13 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 3 Dec 2019 15:36:04 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 3 Dec 2019 15:35:51 +0800 Message-ID: <1575358572.22859.16.camel@mtksdccf07> Subject: Re: [RFC PATCH V3 3/3] platform: mtk-isp: Add Mediatek FD driver From: Jerry-ch Chen To: Tomasz Figa CC: "matthias.bgg@gmail.com" , "mchehab@kernel.org" , "lkml@metux.net" , CK Hu =?UTF-8?Q?=28=E8=83=A1=E4=BF=8A=E5=85=89=29?= , "yuzhao@chromium.org" , "zwisler@chromium.org" , "linux-mediatek@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , Sean Cheng =?UTF-8?Q?=28=E9=84=AD=E6=98=87=E5=BC=98=29?= , "Sj Huang =?UTF-8?Q?=28=E9=BB=83=E4=BF=A1=E7=92=8B=29?=" , Christie Yu =?UTF-8?Q?=28=E6=B8=B8=E9=9B=85=E6=83=A0=29?= , Frederic Chen =?UTF-8?Q?=28=E9=99=B3=E4=BF=8A=E5=85=83=29?= , Jungo Lin =?UTF-8?Q?=28=E6=9E=97=E6=98=8E=E4=BF=8A=29?= , Po-Yang Huang =?UTF-8?Q?=28=E9=BB=83=E6=9F=8F=E9=99=BD=29?= , Rynn Wu =?UTF-8?Q?=28=E5=90=B3=E8=82=B2=E6=81=A9=29?= , "linux-media@vger.kernel.org" , srv_heupstream , "devicetree@vger.kernel.org" , "laurent.pinchart+renesas@ideasonboard.com" , "hans.verkuil@cisco.com" Date: Tue, 3 Dec 2019 15:36:12 +0800 In-Reply-To: References: <20190906101125.3784-1-Jerry-Ch.chen@mediatek.com> <20190906101125.3784-4-Jerry-Ch.chen@mediatek.com> <1571109375.3706.40.camel@mtksdccf07> <20191025035211.GA67000@chromium.org> <1574237450.20087.17.camel@mtksdccf07> <1575046535.22859.12.camel@mtksdccf07> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org SGkgVG9tYXN6LA0KDQpPbiBNb24sIDIwMTktMTItMDIgYXQgMTg6NDggKzA5MDAsIFRvbWFzeiBG aWdhIHdyb3RlOg0KPiBPbiBTYXQsIE5vdiAzMCwgMjAxOSBhdCAxOjU1IEFNIEplcnJ5LWNoIENo ZW4NCj4gPEplcnJ5LWNoLkNoZW5AbWVkaWF0ZWsuY29tPiB3cm90ZToNCj4gPg0KPiA+IEhpIFRv bWFzeiwNCj4gPg0KPiA+IE9uIFdlZCwgMjAxOS0xMS0yMCBhdCAxODoyOCArMDkwMCwgVG9tYXN6 IEZpZ2Egd3JvdGU6DQo+ID4gPiBPbiBXZWQsIE5vdiAyMCwgMjAxOSBhdCA1OjExIFBNIEplcnJ5 LWNoIENoZW4NCj4gPiA+IDxKZXJyeS1jaC5DaGVuQG1lZGlhdGVrLmNvbT4gd3JvdGU6DQo+ID4g PiA+DQo+ID4gPiA+IEhpIFRvbWFzeiwNCj4gPiA+ID4NCj4gPiA+ID4gT24gRnJpLCAyMDE5LTEw LTI1IGF0IDExOjUyICswODAwLCBUb21hc3ogRmlnYSB3cm90ZToNCj4gPiA+ID4gPiBPbiBUdWUs IE9jdCAxNSwgMjAxOSBhdCAxMToxNjoxNUFNICswODAwLCBKZXJyeS1jaCBDaGVuIHdyb3RlOg0K PiA+ID4gPiA+ID4gSGkgVG9tYXN6LA0KPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+IE9uIEZyaSwg MjAxOS0wOS0wNiBhdCAxODoxMSArMDgwMCwgSmVycnktY2ggQ2hlbiB3cm90ZToNCj4gPiA+ID4g PiA+ID4gRnJvbTogSmVycnktY2ggQ2hlbiA8amVycnktY2guY2hlbkBtZWRpYXRlay5jb20+DQo+ ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+IFRoaXMgcGF0Y2ggYWRkcyB0aGUgZHJpdmVyIG9m IEZhY2UgRGV0ZWN0aW9uIChGRCkgdW5pdCBpbg0KPiA+ID4gPiA+ID4gPiBNZWRpYXRlayBjYW1l cmEgc3lzdGVtLCBwcm92aWRpbmcgZmFjZSBkZXRlY3Rpb24gZnVuY3Rpb24uDQo+ID4gPiA+ID4g PiA+DQo+ID4gPiA+ID4gPiA+IFRoZSBtdGstaXNwIGRpcmVjdG9yeSB3aWxsIGNvbnRhaW4gZHJp dmVycyBmb3IgbXVsdGlwbGUgSVANCj4gPiA+ID4gPiA+ID4gYmxvY2tzIGZvdW5kIGluIE1lZGlh dGVrIElTUCBzeXN0ZW0uIEl0IHdpbGwgaW5jbHVkZSBJU1AgUGFzcyAxDQo+ID4gPiA+ID4gPiA+ IGRyaXZlciAoQ0FNKSwgc2Vuc29yIGludGVyZmFjZSBkcml2ZXIsIERJUCBkcml2ZXIgYW5kIGZh Y2UNCj4gPiA+ID4gPiA+ID4gZGV0ZWN0aW9uIGRyaXZlci4NCj4gPiA+ID4gPiA+ID4NCj4gPiA+ ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogSmVycnktY2ggQ2hlbiA8amVycnktY2guY2hlbkBtZWRp YXRlay5jb20+DQo+ID4gPiA+ID4gPiA+IC0tLQ0KPiA+ID4gPiA+ID4gPiAgZHJpdmVycy9tZWRp YS9wbGF0Zm9ybS9LY29uZmlnICAgICAgICAgICAgICAgIHwgICAgMiArDQo+ID4gPiA+ID4gPiA+ ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL01ha2VmaWxlICAgICAgICAgICAgICAgfCAgICAyICsN Cj4gPiA+ID4gPiA+ID4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vbXRrLWlzcC9mZC9LY29uZmln ICAgICB8ICAgMTkgKw0KPiA+ID4gPiA+ID4gPiAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9tdGst aXNwL2ZkL01ha2VmaWxlICAgIHwgICAgNSArDQo+ID4gPiA+ID4gPiA+ICBkcml2ZXJzL21lZGlh L3BsYXRmb3JtL210ay1pc3AvZmQvbXRrX2ZkLmggICAgfCAgMTQ4ICsrDQo+ID4gPiA+ID4gPiA+ ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL210ay1pc3AvZmQvbXRrX2ZkXzQwLmMgfCAxMjE5ICsr KysrKysrKysrKysrKysrDQo+ID4gPiA+ID4gPiA+ICBpbmNsdWRlL3VhcGkvbGludXgvbXRrLWZk LXY0bDItY29udHJvbHMuaCAgICAgfCAgIDY5ICsNCj4gPiA+ID4gPiA+ID4gIGluY2x1ZGUvdWFw aS9saW51eC92NGwyLWNvbnRyb2xzLmggICAgICAgICAgICB8ICAgIDQgKw0KPiA+ID4gPiA+ID4g PiAgOCBmaWxlcyBjaGFuZ2VkLCAxNDY4IGluc2VydGlvbnMoKykNCj4gPiA+ID4gPiA+ID4gIGNy ZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL210ay1pc3AvZmQvS2NvbmZp Zw0KPiA+ID4gPiA+ID4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvbWVkaWEvcGxhdGZv cm0vbXRrLWlzcC9mZC9NYWtlZmlsZQ0KPiA+ID4gPiA+ID4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0 IGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vbXRrLWlzcC9mZC9tdGtfZmQuaA0KPiA+ID4gPiA+ID4g PiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vbXRrLWlzcC9mZC9t dGtfZmRfNDAuYw0KPiA+ID4gPiA+ID4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGluY2x1ZGUvdWFw aS9saW51eC9tdGstZmQtdjRsMi1jb250cm9scy5oDQo+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4N Cj4gPiA+ID4gPiBbc25pcF0NCltzbmlwXQ0KPiA+ID4gPiA+IFtzbmlwXQ0KPiA+ID4gPiA+DQo+ ID4gPiA+ID4gPiA+ICsvKiBTZXQgdGhlIGZhY2UgYW5nbGUgYW5kIGRpcmVjdGlvbnMgdG8gYmUg ZGV0ZWN0ZWQgKi8NCj4gPiA+ID4gPiA+ID4gKyNkZWZpbmUgVjRMMl9DSURfTVRLX0ZEX0RFVEVD VF9QT1NFICAgICAgICAgICAgICAoVjRMMl9DSURfVVNFUl9NVEtfRkRfQkFTRSArIDEpDQo+ID4g PiA+ID4gPiA+ICsNCj4gPiA+ID4gPiA+ID4gKy8qIFNldCBpbWFnZSB3aWR0aHMgZm9yIGFuIGlu cHV0IGltYWdlIHRvIGJlIHNjYWxlZCBkb3duIGZvciBmYWNlIGRldGVjdGlvbiAqLw0KPiA+ID4g PiA+ID4gPiArI2RlZmluZSBWNEwyX0NJRF9NVEtfRkRfU0NBTEVfRE9XTl9JTUdfV0lEVEggICAg IChWNEwyX0NJRF9VU0VSX01US19GRF9CQVNFICsgMikNCj4gPiA+ID4gPiA+ID4gKw0KPiA+ID4g PiA+ID4gPiArLyogU2V0IGltYWdlIGhlaWdodHMgZm9yIGFuIGlucHV0IGltYWdlIHRvIGJlIHNj YWxlZCBkb3duIGZvciBmYWNlIGRldGVjdGlvbiAqLw0KPiA+ID4gPiA+ID4gPiArI2RlZmluZSBW NEwyX0NJRF9NVEtfRkRfU0NBTEVfRE9XTl9JTUdfSEVJR0hUICAgIChWNEwyX0NJRF9VU0VSX01U S19GRF9CQVNFICsgMykNCj4gPiA+ID4gPiA+ID4gKw0KPiA+ID4gPiA+ID4gPiArLyogU2V0IHRo ZSBsZW5ndGggb2Ygc2NhbGUgZG93biBzaXplIGFycmF5ICovDQo+ID4gPiA+ID4gPiA+ICsjZGVm aW5lIFY0TDJfQ0lEX01US19GRF9TQ0FMRV9JTUdfTlVNICAgICAgICAgICAgKFY0TDJfQ0lEX1VT RVJfTVRLX0ZEX0JBU0UgKyA0KQ0KPiA+ID4gPiA+ID4gPiArDQo+ID4gPiA+ID4gPiA+ICsvKiBT ZXQgdGhlIGRldGVjdGlvbiBzcGVlZCwgdXN1YWxseSByZWR1Y2luZyBhY2N1cmFjeS4gKi8NCj4g PiA+ID4gPiA+ID4gKyNkZWZpbmUgVjRMMl9DSURfTVRLX0ZEX0RFVEVDVF9TUEVFRCAgICAgICAg ICAgICAoVjRMMl9DSURfVVNFUl9NVEtfRkRfQkFTRSArIDUpDQo+ID4gPiA+ID4gPiA+ICsNCj4g PiA+ID4gPiA+ID4gKy8qIFNlbGVjdCB0aGUgZGV0ZWN0aW9uIG1vZGVsIG9yIGFsZ29yaXRobSB0 byBiZSB1c2VkLiAqLw0KPiA+ID4gPiA+ID4gPiArI2RlZmluZSBWNEwyX0NJRF9NVEtfRkRfREVU RUNUSU9OX01PREVMICAgICAgICAgIChWNEwyX0NJRF9VU0VSX01US19GRF9CQVNFICsgNikNCj4g PiA+ID4gPiA+ID4gKw0KPiA+ID4gPiA+ID4gPiArLyogV2UgcmVzZXJ2ZSAxNiBjb250cm9scyBm b3IgdGhpcyBkcml2ZXIuICovDQo+ID4gPiA+ID4gPiA+ICsjZGVmaW5lIFY0TDJfQ0lEX01US19G RF9NQVggICAgICAgICAgICAgICAgICAgICAgMTYNCj4gPiA+ID4gPiA+ID4gKw0KPiA+ID4gPiA+ ID4NCj4gPiA+ID4gPiA+IEZvciB0aGVzZSBjb250cm9sIElEcywgSSB0aGluayB0aGUgZm9sbG93 aW5nIHNob3VsZCBiZSByZW1haW5lZCBhcyBjaGlwDQo+ID4gPiA+ID4gPiBzcGVjaWZpYyBjb250 cm9scy4NCj4gPiA+ID4gPiA+IFY0TDJfQ0lEX01US19GRF9TQ0FMRV9ET1dOX0lNR19XSURUSCwN Cj4gPiA+ID4gPiA+IFY0TDJfQ0lEX01US19GRF9TQ0FMRV9ET1dOX0lNR19IRUlHSFQgYW5kIFY0 TDJfQ0lEX01US19GRF9TQ0FMRV9JTUdfTlVNDQo+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gSG9w ZSB0aGVyZSB3b3VsZCBiZSBzdGFuZGFyZGl6aW5nIGZhY2UgZGV0ZWN0aW9uIGFwaSB0aGF0IGNv dmVyIHRoZSByZXN0DQo+ID4gPiA+ID4gPiBjb250cm9sczogVjRMMl9DSURfTVRLX0ZEX0RFVEVD VF9QT1NFLCBWNEwyX0NJRF9NVEtfRkRfREVURUNUX1NQRUVEIGFuZA0KPiA+ID4gPiA+ID4gVjRM Ml9DSURfTVRLX0ZEX0RFVEVDVElPTl9NT0RFTA0KPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+IFdv dWxkIHlvdSBoYXZlIGFueSBzdWdnZXN0aW9ucyBvbiBob3cgdG8gcHJvcG9zZSB0aGUgc3RhbmRh cmQgZmFjZQ0KPiA+ID4gPiA+ID4gZGV0ZWN0aW9uIGFwaXM/DQo+ID4gPiA+ID4gPg0KPiA+ID4g PiA+DQo+ID4gPiA+ID4gR2l2ZW4gbm8gZm9sbG93IHVwIGZlZWRiYWNrIGZyb20gdGhlIGNvbW11 bml0eSwgSSB0aGluayB3ZSBjYW4ga2VlcCB0aGVtDQo+ID4gPiA+ID4gYXMgZHJpdmVyLXNwZWNp ZmljLCBidXQgc2hvdWxkIG1ha2Ugc3VyZSB0aGF0IHRoZXkgaGF2ZSBzb21lIHJlYXNvbmFibGUN Cj4gPiA+ID4gPiBkZWZhdWx0IHZhbHVlcyBpbiBjYXNlIGFuIGFwcGxpY2F0aW9uIGRvZXNuJ3Qg cmVjb2duaXplIHRoZW0uDQo+ID4gPiA+ID4NCj4gPiA+ID4gPiBCZXN0IHJlZ2FyZHMsDQo+ID4g PiA+ID4gVG9tYXN6DQo+ID4gPiA+ID4NCj4gPiA+ID4gU2hvdWxkIEkga2VlcCB0aGUgZmlsZSAi bXRrLWZkLXY0bDItY29udHJvbHMuaCIgd2hpY2ggZGVmaW5lcyB0aGUNCj4gPiA+ID4gY29udHJv bCBpZHMgdW5kZXIgdGhlIGZvbGRlciAiL2luY2x1ZGUvdWFwaS9saW51eCI/DQo+ID4gPg0KPiA+ ID4gV2Ugc2hvdWxkIGRlZmluZSB0aGUgQ0lEIGJhc2UgZm9yIHRoZSBGRCBkcml2ZXIgaW4gdjRs Mi1jb250cm9scy5oLA0KPiA+ID4gYnV0IHRoZSBjb250cm9scyB0aGVtc2VsdmVzIHNob3VsZCBi ZSBvbmx5IGRlZmluZWQgaW5zaWRlIHRoZSBkcml2ZXIuDQo+ID4gPg0KPiA+ID4gRm9yIGV4YW1w bGU6DQo+ID4gPiBodHRwczovL2VsaXhpci5ib290bGluLmNvbS9saW51eC92NS40LXJjOC9zb3Vy Y2UvaW5jbHVkZS91YXBpL2xpbnV4L3Y0bDItY29udHJvbHMuaCNMMTc4DQo+ID4gPiBodHRwczov L2VsaXhpci5ib290bGluLmNvbS9saW51eC92NS40LXJjOC9zb3VyY2UvZHJpdmVycy9tZWRpYS9p MmMvYWR2NzE4MC5jI0wxODENCj4gPiA+DQo+ID4gPiBCZXN0IHJlZ2FyZHMsDQo+ID4gPiBUb21h c3oNCj4gPg0KPiA+IEFwcHJlY2lhdGUgZm9yIHByb3ZpZGluZyB0aGUgZXhhbXBsZSwNCj4gPiBX b3VsZCBpdCBiZSBmaW5lIGZvciBtZSB0byBwdXQgdGhlIHByaXZhdGUgQ0lEIGluIHRoZSBtdGtf ZmQuaCh3aGljaCBpcw0KPiA+IHNpbWlsYXIgdG8gYmVmb3JlLi4uKSBvciBmb2xsb3cgdGhlIGV4 YW1wbGUgdG8gZGVmaW5lIGluc2lkZQ0KPiA+IG10a19mZF80MC5jPz8NCj4gPg0KPiA+IFRoZSBu ZXh0IHZlcnNpb24gaXMgYWxtb3N0IHJlYWR5LCBtYXliZSBJIGNhbiBzZW5kIGl0IHdoZW4gSSBy ZWFkeSBpbiBhDQo+ID4gZmV3IGRheXM/DQo+IA0KPiBTaW5jZSBtdGtfZmRfNDAuYyBpcyB0aGUg b25seSBwbGFjZSB0aGUgZGVmaW5pdGlvbnMgZnJvbSBtdGtfZmQuaCBhcmUNCj4gdXNlZCwgSSdk IHN1Z2dlc3QganVzdCBtb3ZpbmcgYWxsIHRoZSBjb250ZW50cyB0byB0aGUgLmMgZmlsZS4NCj4g DQo+IEJlc3QgcmVnYXJkcywNCj4gVG9tYXN6DQpEb25lLA0KDQpUaGFua3MgYW5kIGJlc3QgcmVn YXJkcywNCkplcnJ5DQoNCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB5EFC432C0 for ; Tue, 3 Dec 2019 07:39:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 781F920637 for ; Tue, 3 Dec 2019 07:39:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LU6bwi5n"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="egidPDKU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 781F920637 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=essDbDgxwZ77Xk3K+gsVa478di76yD1vXAUiMViHBUU=; b=LU6bwi5nOTdb6O 0Og7kd7t1mangElf0RGU+aSJrL+ZboUzAag71LqH/4kegtcQWdqCS94dviMAhBfbReQptWIJuBk6j PcKqi+o5Aw04xMnPcKtTa6oqmRvix4XaCDD5JPWNLrZNsahyMDsRRTN0nLibIPwy0n5ss2L40sD86 FBk+PNCO3YFBh0ctv5denXKB0O8sQ7UjJdYFzalYWL2aZEWIaqWEXs1YBeMcjyaKD+rvbUUytrg5U H/XZdCJ+z5EjfG7HO62C6+nI5R+4QbXkNrIR7aJpxA+xJNnrZvlqSTiaQgvp0qjwgLyf70mfSFEnW NuQFB4oLBfuS5A2IoxQA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ic2m8-0003AZ-Pu; Tue, 03 Dec 2019 07:39:12 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ic2jQ-0000Ts-Ni; Tue, 03 Dec 2019 07:36:26 +0000 X-UUID: a59a43ba20974e82b92276094b5d109d-20191202 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=RS1SOJ53qB4oVEPa7QVaDgVYJ6ii69MjHwS2W7BD1SU=; b=egidPDKUQ8DvqY5vSr6pHFia0xtAL7GpEuhuTbxkJEGzM/aaPNgQXEUuBdpzKbu+sX5qdoOBhc6W+xXjKEj1gnUwhRgBP5xiUhPJjgDb7CTYZNiV8So2WACcO8K/k30F9bjzOurVqXG05JsEWw5Ljc8/GYvESGOhf3bGsQqL1+Y=; X-UUID: a59a43ba20974e82b92276094b5d109d-20191202 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 939443402; Mon, 02 Dec 2019 23:36:15 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 2 Dec 2019 23:36:25 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 3 Dec 2019 15:36:04 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 3 Dec 2019 15:35:51 +0800 Message-ID: <1575358572.22859.16.camel@mtksdccf07> Subject: Re: [RFC PATCH V3 3/3] platform: mtk-isp: Add Mediatek FD driver From: Jerry-ch Chen To: Tomasz Figa Date: Tue, 3 Dec 2019 15:36:12 +0800 In-Reply-To: References: <20190906101125.3784-1-Jerry-Ch.chen@mediatek.com> <20190906101125.3784-4-Jerry-Ch.chen@mediatek.com> <1571109375.3706.40.camel@mtksdccf07> <20191025035211.GA67000@chromium.org> <1574237450.20087.17.camel@mtksdccf07> <1575046535.22859.12.camel@mtksdccf07> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191202_233624_888309_7734E58F X-CRM114-Status: GOOD ( 24.47 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Sean Cheng =?UTF-8?Q?=28=E9=84=AD=E6=98=87=E5=BC=98=29?= , Frederic Chen =?UTF-8?Q?=28=E9=99=B3=E4=BF=8A=E5=85=83=29?= , Rynn Wu =?UTF-8?Q?=28=E5=90=B3=E8=82=B2=E6=81=A9=29?= , Christie Yu =?UTF-8?Q?=28=E6=B8=B8=E9=9B=85=E6=83=A0=29?= , srv_heupstream , Jungo Lin =?UTF-8?Q?=28=E6=9E=97=E6=98=8E=E4=BF=8A=29?= , Po-Yang Huang =?UTF-8?Q?=28=E9=BB=83=E6=9F=8F=E9=99=BD=29?= , CK Hu =?UTF-8?Q?=28=E8=83=A1=E4=BF=8A=E5=85=89=29?= , Sj Huang =?UTF-8?Q?=28=E9=BB=83=E4=BF=A1=E7=92=8B=29?= , "yuzhao@chromium.org" , "lkml@metux.net" , "zwisler@chromium.org" , "hans.verkuil@cisco.com" , "matthias.bgg@gmail.com" , "linux-mediatek@lists.infradead.org" , "mchehab@kernel.org" , "laurent.pinchart+renesas@ideasonboard.com" , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Tomasz, On Mon, 2019-12-02 at 18:48 +0900, Tomasz Figa wrote: > On Sat, Nov 30, 2019 at 1:55 AM Jerry-ch Chen > wrote: > > > > Hi Tomasz, > > > > On Wed, 2019-11-20 at 18:28 +0900, Tomasz Figa wrote: > > > On Wed, Nov 20, 2019 at 5:11 PM Jerry-ch Chen > > > wrote: > > > > > > > > Hi Tomasz, > > > > > > > > On Fri, 2019-10-25 at 11:52 +0800, Tomasz Figa wrote: > > > > > On Tue, Oct 15, 2019 at 11:16:15AM +0800, Jerry-ch Chen wrote: > > > > > > Hi Tomasz, > > > > > > > > > > > > On Fri, 2019-09-06 at 18:11 +0800, Jerry-ch Chen wrote: > > > > > > > From: Jerry-ch Chen > > > > > > > > > > > > > > This patch adds the driver of Face Detection (FD) unit in > > > > > > > Mediatek camera system, providing face detection function. > > > > > > > > > > > > > > The mtk-isp directory will contain drivers for multiple IP > > > > > > > blocks found in Mediatek ISP system. It will include ISP Pass 1 > > > > > > > driver (CAM), sensor interface driver, DIP driver and face > > > > > > > detection driver. > > > > > > > > > > > > > > Signed-off-by: Jerry-ch Chen > > > > > > > --- > > > > > > > drivers/media/platform/Kconfig | 2 + > > > > > > > drivers/media/platform/Makefile | 2 + > > > > > > > drivers/media/platform/mtk-isp/fd/Kconfig | 19 + > > > > > > > drivers/media/platform/mtk-isp/fd/Makefile | 5 + > > > > > > > drivers/media/platform/mtk-isp/fd/mtk_fd.h | 148 ++ > > > > > > > drivers/media/platform/mtk-isp/fd/mtk_fd_40.c | 1219 +++++++++++++++++ > > > > > > > include/uapi/linux/mtk-fd-v4l2-controls.h | 69 + > > > > > > > include/uapi/linux/v4l2-controls.h | 4 + > > > > > > > 8 files changed, 1468 insertions(+) > > > > > > > create mode 100644 drivers/media/platform/mtk-isp/fd/Kconfig > > > > > > > create mode 100644 drivers/media/platform/mtk-isp/fd/Makefile > > > > > > > create mode 100644 drivers/media/platform/mtk-isp/fd/mtk_fd.h > > > > > > > create mode 100644 drivers/media/platform/mtk-isp/fd/mtk_fd_40.c > > > > > > > create mode 100644 include/uapi/linux/mtk-fd-v4l2-controls.h > > > > > > > > > > > > > > > > > [snip] [snip] > > > > > [snip] > > > > > > > > > > > > +/* Set the face angle and directions to be detected */ > > > > > > > +#define V4L2_CID_MTK_FD_DETECT_POSE (V4L2_CID_USER_MTK_FD_BASE + 1) > > > > > > > + > > > > > > > +/* Set image widths for an input image to be scaled down for face detection */ > > > > > > > +#define V4L2_CID_MTK_FD_SCALE_DOWN_IMG_WIDTH (V4L2_CID_USER_MTK_FD_BASE + 2) > > > > > > > + > > > > > > > +/* Set image heights for an input image to be scaled down for face detection */ > > > > > > > +#define V4L2_CID_MTK_FD_SCALE_DOWN_IMG_HEIGHT (V4L2_CID_USER_MTK_FD_BASE + 3) > > > > > > > + > > > > > > > +/* Set the length of scale down size array */ > > > > > > > +#define V4L2_CID_MTK_FD_SCALE_IMG_NUM (V4L2_CID_USER_MTK_FD_BASE + 4) > > > > > > > + > > > > > > > +/* Set the detection speed, usually reducing accuracy. */ > > > > > > > +#define V4L2_CID_MTK_FD_DETECT_SPEED (V4L2_CID_USER_MTK_FD_BASE + 5) > > > > > > > + > > > > > > > +/* Select the detection model or algorithm to be used. */ > > > > > > > +#define V4L2_CID_MTK_FD_DETECTION_MODEL (V4L2_CID_USER_MTK_FD_BASE + 6) > > > > > > > + > > > > > > > +/* We reserve 16 controls for this driver. */ > > > > > > > +#define V4L2_CID_MTK_FD_MAX 16 > > > > > > > + > > > > > > > > > > > > For these control IDs, I think the following should be remained as chip > > > > > > specific controls. > > > > > > V4L2_CID_MTK_FD_SCALE_DOWN_IMG_WIDTH, > > > > > > V4L2_CID_MTK_FD_SCALE_DOWN_IMG_HEIGHT and V4L2_CID_MTK_FD_SCALE_IMG_NUM > > > > > > > > > > > > Hope there would be standardizing face detection api that cover the rest > > > > > > controls: V4L2_CID_MTK_FD_DETECT_POSE, V4L2_CID_MTK_FD_DETECT_SPEED and > > > > > > V4L2_CID_MTK_FD_DETECTION_MODEL > > > > > > > > > > > > Would you have any suggestions on how to propose the standard face > > > > > > detection apis? > > > > > > > > > > > > > > > > Given no follow up feedback from the community, I think we can keep them > > > > > as driver-specific, but should make sure that they have some reasonable > > > > > default values in case an application doesn't recognize them. > > > > > > > > > > Best regards, > > > > > Tomasz > > > > > > > > > Should I keep the file "mtk-fd-v4l2-controls.h" which defines the > > > > control ids under the folder "/include/uapi/linux"? > > > > > > We should define the CID base for the FD driver in v4l2-controls.h, > > > but the controls themselves should be only defined inside the driver. > > > > > > For example: > > > https://elixir.bootlin.com/linux/v5.4-rc8/source/include/uapi/linux/v4l2-controls.h#L178 > > > https://elixir.bootlin.com/linux/v5.4-rc8/source/drivers/media/i2c/adv7180.c#L181 > > > > > > Best regards, > > > Tomasz > > > > Appreciate for providing the example, > > Would it be fine for me to put the private CID in the mtk_fd.h(which is > > similar to before...) or follow the example to define inside > > mtk_fd_40.c?? > > > > The next version is almost ready, maybe I can send it when I ready in a > > few days? > > Since mtk_fd_40.c is the only place the definitions from mtk_fd.h are > used, I'd suggest just moving all the contents to the .c file. > > Best regards, > Tomasz Done, Thanks and best regards, Jerry _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79B6FC432C0 for ; Tue, 3 Dec 2019 07:39:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3528320637 for ; Tue, 3 Dec 2019 07:39:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CdnkLIjs"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="egidPDKU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3528320637 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FOc/4Cr9sKsUdHfxR8dCCyU2DVo4NFN4UHV8OKFOshw=; b=CdnkLIjsIJWjuq tWBwu4Jc0mpF+d6V9jA0rEGnfojVau76Y14I94t98ov9Peb+ZHM5DBxQA8ybVWEtXBZVRPY/SLHQB gd3Nf2jVXGBZ1YXowo8FUkbZhxDDLwClHtktNgCn7CWs1gVXDpPGyer6dX3tEzG+fqsZOSXg/tK0X EyzPWF/7gt8rr1kr3+H4FPQ3UuJ/nYviteguiUm9Stg7NF0ndCLLk2e5h+MgK+5CjB8/fm1KtiE6m jZqntvmfQarAgcUsxHjHFqzGQASturb8e5LW2OPUkDLRJlsExBwF9kPgK1k8lTSgCTjb4+nwD4f34 ZshPn5pYnWFFI272Juxw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ic2lv-0002vr-So; Tue, 03 Dec 2019 07:38:59 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ic2jQ-0000Ts-Ni; Tue, 03 Dec 2019 07:36:26 +0000 X-UUID: a59a43ba20974e82b92276094b5d109d-20191202 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=RS1SOJ53qB4oVEPa7QVaDgVYJ6ii69MjHwS2W7BD1SU=; b=egidPDKUQ8DvqY5vSr6pHFia0xtAL7GpEuhuTbxkJEGzM/aaPNgQXEUuBdpzKbu+sX5qdoOBhc6W+xXjKEj1gnUwhRgBP5xiUhPJjgDb7CTYZNiV8So2WACcO8K/k30F9bjzOurVqXG05JsEWw5Ljc8/GYvESGOhf3bGsQqL1+Y=; X-UUID: a59a43ba20974e82b92276094b5d109d-20191202 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 939443402; Mon, 02 Dec 2019 23:36:15 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 2 Dec 2019 23:36:25 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 3 Dec 2019 15:36:04 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 3 Dec 2019 15:35:51 +0800 Message-ID: <1575358572.22859.16.camel@mtksdccf07> Subject: Re: [RFC PATCH V3 3/3] platform: mtk-isp: Add Mediatek FD driver From: Jerry-ch Chen To: Tomasz Figa Date: Tue, 3 Dec 2019 15:36:12 +0800 In-Reply-To: References: <20190906101125.3784-1-Jerry-Ch.chen@mediatek.com> <20190906101125.3784-4-Jerry-Ch.chen@mediatek.com> <1571109375.3706.40.camel@mtksdccf07> <20191025035211.GA67000@chromium.org> <1574237450.20087.17.camel@mtksdccf07> <1575046535.22859.12.camel@mtksdccf07> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191202_233624_888309_7734E58F X-CRM114-Status: GOOD ( 24.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Sean Cheng =?UTF-8?Q?=28=E9=84=AD=E6=98=87=E5=BC=98=29?= , Frederic Chen =?UTF-8?Q?=28=E9=99=B3=E4=BF=8A=E5=85=83=29?= , Rynn Wu =?UTF-8?Q?=28=E5=90=B3=E8=82=B2=E6=81=A9=29?= , Christie Yu =?UTF-8?Q?=28=E6=B8=B8=E9=9B=85=E6=83=A0=29?= , srv_heupstream , Jungo Lin =?UTF-8?Q?=28=E6=9E=97=E6=98=8E=E4=BF=8A=29?= , Po-Yang Huang =?UTF-8?Q?=28=E9=BB=83=E6=9F=8F=E9=99=BD=29?= , CK Hu =?UTF-8?Q?=28=E8=83=A1=E4=BF=8A=E5=85=89=29?= , Sj Huang =?UTF-8?Q?=28=E9=BB=83=E4=BF=A1=E7=92=8B=29?= , "yuzhao@chromium.org" , "lkml@metux.net" , "zwisler@chromium.org" , "hans.verkuil@cisco.com" , "matthias.bgg@gmail.com" , "linux-mediatek@lists.infradead.org" , "mchehab@kernel.org" , "laurent.pinchart+renesas@ideasonboard.com" , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Tomasz, On Mon, 2019-12-02 at 18:48 +0900, Tomasz Figa wrote: > On Sat, Nov 30, 2019 at 1:55 AM Jerry-ch Chen > wrote: > > > > Hi Tomasz, > > > > On Wed, 2019-11-20 at 18:28 +0900, Tomasz Figa wrote: > > > On Wed, Nov 20, 2019 at 5:11 PM Jerry-ch Chen > > > wrote: > > > > > > > > Hi Tomasz, > > > > > > > > On Fri, 2019-10-25 at 11:52 +0800, Tomasz Figa wrote: > > > > > On Tue, Oct 15, 2019 at 11:16:15AM +0800, Jerry-ch Chen wrote: > > > > > > Hi Tomasz, > > > > > > > > > > > > On Fri, 2019-09-06 at 18:11 +0800, Jerry-ch Chen wrote: > > > > > > > From: Jerry-ch Chen > > > > > > > > > > > > > > This patch adds the driver of Face Detection (FD) unit in > > > > > > > Mediatek camera system, providing face detection function. > > > > > > > > > > > > > > The mtk-isp directory will contain drivers for multiple IP > > > > > > > blocks found in Mediatek ISP system. It will include ISP Pass 1 > > > > > > > driver (CAM), sensor interface driver, DIP driver and face > > > > > > > detection driver. > > > > > > > > > > > > > > Signed-off-by: Jerry-ch Chen > > > > > > > --- > > > > > > > drivers/media/platform/Kconfig | 2 + > > > > > > > drivers/media/platform/Makefile | 2 + > > > > > > > drivers/media/platform/mtk-isp/fd/Kconfig | 19 + > > > > > > > drivers/media/platform/mtk-isp/fd/Makefile | 5 + > > > > > > > drivers/media/platform/mtk-isp/fd/mtk_fd.h | 148 ++ > > > > > > > drivers/media/platform/mtk-isp/fd/mtk_fd_40.c | 1219 +++++++++++++++++ > > > > > > > include/uapi/linux/mtk-fd-v4l2-controls.h | 69 + > > > > > > > include/uapi/linux/v4l2-controls.h | 4 + > > > > > > > 8 files changed, 1468 insertions(+) > > > > > > > create mode 100644 drivers/media/platform/mtk-isp/fd/Kconfig > > > > > > > create mode 100644 drivers/media/platform/mtk-isp/fd/Makefile > > > > > > > create mode 100644 drivers/media/platform/mtk-isp/fd/mtk_fd.h > > > > > > > create mode 100644 drivers/media/platform/mtk-isp/fd/mtk_fd_40.c > > > > > > > create mode 100644 include/uapi/linux/mtk-fd-v4l2-controls.h > > > > > > > > > > > > > > > > > [snip] [snip] > > > > > [snip] > > > > > > > > > > > > +/* Set the face angle and directions to be detected */ > > > > > > > +#define V4L2_CID_MTK_FD_DETECT_POSE (V4L2_CID_USER_MTK_FD_BASE + 1) > > > > > > > + > > > > > > > +/* Set image widths for an input image to be scaled down for face detection */ > > > > > > > +#define V4L2_CID_MTK_FD_SCALE_DOWN_IMG_WIDTH (V4L2_CID_USER_MTK_FD_BASE + 2) > > > > > > > + > > > > > > > +/* Set image heights for an input image to be scaled down for face detection */ > > > > > > > +#define V4L2_CID_MTK_FD_SCALE_DOWN_IMG_HEIGHT (V4L2_CID_USER_MTK_FD_BASE + 3) > > > > > > > + > > > > > > > +/* Set the length of scale down size array */ > > > > > > > +#define V4L2_CID_MTK_FD_SCALE_IMG_NUM (V4L2_CID_USER_MTK_FD_BASE + 4) > > > > > > > + > > > > > > > +/* Set the detection speed, usually reducing accuracy. */ > > > > > > > +#define V4L2_CID_MTK_FD_DETECT_SPEED (V4L2_CID_USER_MTK_FD_BASE + 5) > > > > > > > + > > > > > > > +/* Select the detection model or algorithm to be used. */ > > > > > > > +#define V4L2_CID_MTK_FD_DETECTION_MODEL (V4L2_CID_USER_MTK_FD_BASE + 6) > > > > > > > + > > > > > > > +/* We reserve 16 controls for this driver. */ > > > > > > > +#define V4L2_CID_MTK_FD_MAX 16 > > > > > > > + > > > > > > > > > > > > For these control IDs, I think the following should be remained as chip > > > > > > specific controls. > > > > > > V4L2_CID_MTK_FD_SCALE_DOWN_IMG_WIDTH, > > > > > > V4L2_CID_MTK_FD_SCALE_DOWN_IMG_HEIGHT and V4L2_CID_MTK_FD_SCALE_IMG_NUM > > > > > > > > > > > > Hope there would be standardizing face detection api that cover the rest > > > > > > controls: V4L2_CID_MTK_FD_DETECT_POSE, V4L2_CID_MTK_FD_DETECT_SPEED and > > > > > > V4L2_CID_MTK_FD_DETECTION_MODEL > > > > > > > > > > > > Would you have any suggestions on how to propose the standard face > > > > > > detection apis? > > > > > > > > > > > > > > > > Given no follow up feedback from the community, I think we can keep them > > > > > as driver-specific, but should make sure that they have some reasonable > > > > > default values in case an application doesn't recognize them. > > > > > > > > > > Best regards, > > > > > Tomasz > > > > > > > > > Should I keep the file "mtk-fd-v4l2-controls.h" which defines the > > > > control ids under the folder "/include/uapi/linux"? > > > > > > We should define the CID base for the FD driver in v4l2-controls.h, > > > but the controls themselves should be only defined inside the driver. > > > > > > For example: > > > https://elixir.bootlin.com/linux/v5.4-rc8/source/include/uapi/linux/v4l2-controls.h#L178 > > > https://elixir.bootlin.com/linux/v5.4-rc8/source/drivers/media/i2c/adv7180.c#L181 > > > > > > Best regards, > > > Tomasz > > > > Appreciate for providing the example, > > Would it be fine for me to put the private CID in the mtk_fd.h(which is > > similar to before...) or follow the example to define inside > > mtk_fd_40.c?? > > > > The next version is almost ready, maybe I can send it when I ready in a > > few days? > > Since mtk_fd_40.c is the only place the definitions from mtk_fd.h are > used, I'd suggest just moving all the contents to the .c file. > > Best regards, > Tomasz Done, Thanks and best regards, Jerry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel