From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/execlists: Skip nested spinlock for validating pending
Date: Tue, 03 Dec 2019 15:41:40 +0000 [thread overview]
Message-ID: <157538770092.7230.2790528772324750727@skylake-alporthouse-com> (raw)
In-Reply-To: <20191203152631.3107653-2-chris@chris-wilson.co.uk>
Quoting Chris Wilson (2019-12-03 15:26:31)
> Only along the submission path can we guarantee that the locked request
> is indeed from a foreign engine, and so the nesting of engine/rq is
> permissible. On the submission tasklet (process_csb()), we may find
> ourselves competing with the normal nesting of rq/engine, invalidating
> our nesting. As we only use the spinlock for debug purposes, skip the
> debug if we cannot acquire the spinlock for safe validation - catching
> 99% of the bugs is better than causing a hard lockup.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-12-03 15:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 15:26 [Intel-gfx] [PATCH 1/2] drm/i915/execlists: Add a couple more validity checks to assert_pending() Chris Wilson
2019-12-03 15:26 ` [Intel-gfx] [PATCH 2/2] drm/i915/execlists: Skip nested spinlock for validating pending Chris Wilson
2019-12-03 15:37 ` Chris Wilson
2019-12-03 15:41 ` Chris Wilson [this message]
2019-12-03 15:41 ` [Intel-gfx] [PATCH 1/2] drm/i915/execlists: Add a couple more validity checks to assert_pending() Chris Wilson
2019-12-03 16:43 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2019-12-03 11:53 [Intel-gfx] [PATCH 1/2] " Chris Wilson
2019-12-03 11:53 ` [Intel-gfx] [PATCH 2/2] drm/i915/execlists: Skip nested spinlock for validating pending Chris Wilson
2019-12-03 15:38 ` Tvrtko Ursulin
2019-12-03 15:40 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157538770092.7230.2790528772324750727@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.