All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Veith <sveith@amazon.de>
To: qemu-devel@nongnu.org, qemu-arm@nongnu.org
Cc: Simon Veith <sveith@amazon.de>, Eric Auger <eric.auger@redhat.com>
Subject: [PATCH 5/5] hw/arm/smmuv3: Report F_STE_FETCH fault address in correct word position
Date: Wed,  4 Dec 2019 14:55:48 +0100	[thread overview]
Message-ID: <1575467748-28898-6-git-send-email-sveith@amazon.de> (raw)
In-Reply-To: <1575467748-28898-1-git-send-email-sveith@amazon.de>

The smmuv3_record_event() function that generates the F_STE_FETCH error
uses the EVT_SET_ADDR macro to record the fetch address, placing it in
32-bit words 4 and 5.

The correct position for this address is in words 6 and 7, per the
SMMUv3 Architecture Specification.

Update the function to use the EVT_SET_ADDR2 macro instead, which is the
macro intended for writing to these words.

ref. ARM IHI 0070C, section 7.3.4.

Signed-off-by: Simon Veith <sveith@amazon.de>
Cc: Eric Auger <eric.auger@redhat.com>
Cc: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org
---
 hw/arm/smmuv3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c
index 2d6c275..125e47d 100644
--- a/hw/arm/smmuv3.c
+++ b/hw/arm/smmuv3.c
@@ -172,7 +172,7 @@ void smmuv3_record_event(SMMUv3State *s, SMMUEventInfo *info)
     case SMMU_EVT_F_STE_FETCH:
         EVT_SET_SSID(&evt, info->u.f_ste_fetch.ssid);
         EVT_SET_SSV(&evt,  info->u.f_ste_fetch.ssv);
-        EVT_SET_ADDR(&evt, info->u.f_ste_fetch.addr);
+        EVT_SET_ADDR2(&evt, info->u.f_ste_fetch.addr);
         break;
     case SMMU_EVT_C_BAD_STE:
         EVT_SET_SSID(&evt, info->u.c_bad_ste.ssid);
-- 
2.7.4



  parent reply	other threads:[~2019-12-04 14:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04 13:55 [PATCH 0/5] hw/arm/smmuv3: Correct stream ID and event address handling Simon Veith
2019-12-04 13:55 ` [PATCH 1/5] hw/arm/smmuv3: Apply address mask to linear strtab base address Simon Veith
2019-12-05  8:42   ` Auger Eric
2019-12-05 22:04     ` Simon Veith
2019-12-09  9:14       ` Auger Eric
2019-12-04 13:55 ` [PATCH 2/5] hw/arm/smmuv3: Check stream IDs against actual table LOG2SIZE Simon Veith
2019-12-05  8:41   ` Auger Eric
2019-12-04 13:55 ` [PATCH 3/5] hw/arm/smmuv3: Align stream table base address to table size Simon Veith
2019-12-05 10:39   ` Auger Eric
2019-12-04 13:55 ` [PATCH 4/5] hw/arm/smmuv3: Use correct bit positions in EVT_SET_ADDR2 macro Simon Veith
2019-12-05  8:37   ` Auger Eric
2019-12-04 13:55 ` Simon Veith [this message]
2019-12-05  8:39   ` [PATCH 5/5] hw/arm/smmuv3: Report F_STE_FETCH fault address in correct word position Auger Eric

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1575467748-28898-6-git-send-email-sveith@amazon.de \
    --to=sveith@amazon.de \
    --cc=eric.auger@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.