From: Chris Wilson <chris@chris-wilson.co.uk>
To: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 3/3] tests/i915/gem_mmap_offset: remove local mmap calls
Date: Thu, 05 Dec 2019 12:16:35 +0000 [thread overview]
Message-ID: <157554819564.22727.17486311599674289741@skylake-alporthouse-com> (raw)
In-Reply-To: <20191205075800.12625-3-zbigniew.kempczynski@intel.com>
Quoting Zbigniew Kempczyński (2019-12-05 07:58:00)
> From: Lukasz Kalamarz <lukasz.kalamarz@intel.com>
>
> Use gem_mman functions instead local versions.
> Limit available memory for 'clear' test to run it on lmem correctly.
I advise we don't do this. The lesson learnt with gem_mmap_wc.c et al
is that we want the dedicated tests for particular ioctls to be
independent of the library wrappers -- so that we do not inadvertently
change the basic ioctl tests.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-12-05 12:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 7:57 [igt-dev] [PATCH i-g-t 1/3] lib/i915/gem_mman: add mmap_offset support Zbigniew Kempczyński
2019-12-05 7:57 ` [igt-dev] [PATCH i-g-t 2/3] lib/igt_dummyload: Use mapping selection to allow run batch from lmem Zbigniew Kempczyński
2019-12-05 7:58 ` [igt-dev] [PATCH i-g-t 3/3] tests/i915/gem_mmap_offset: remove local mmap calls Zbigniew Kempczyński
2019-12-05 12:16 ` Chris Wilson [this message]
2019-12-05 8:55 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/3] lib/i915/gem_mman: add mmap_offset support Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157554819564.22727.17486311599674289741@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.