From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84E25C3F68F for ; Fri, 6 Dec 2019 08:06:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5515D2466E for ; Fri, 6 Dec 2019 08:06:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="JjUwosIi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726951AbfLFIGv (ORCPT ); Fri, 6 Dec 2019 03:06:51 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:48767 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725858AbfLFIGv (ORCPT ); Fri, 6 Dec 2019 03:06:51 -0500 X-UUID: b64d99dd417f4897b5fe8611d274e3ad-20191206 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=lVZrCUbqLoiMSbjwNFA0HHxnz+mVQqg4nD2qHvV3jxo=; b=JjUwosIigrqrNMSo7X6lD2hG7u//9qAdGptzrFB1HR5x5i/8Vrtn4N2MtvfZqos0DbRR+sbMH/orYW7Y8JlRJP7yO/eWSJclBQQZJUB0L7t2qvtnMksOR808INHTsraWKnMNMH4j6dUPVqpI5qX5Ry9ZruwNSnz2jHFEaBqcIbE=; X-UUID: b64d99dd417f4897b5fe8611d274e3ad-20191206 Received: from mtkcas07.mediatek.inc [(172.21.101.84)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1908250467; Fri, 06 Dec 2019 16:06:47 +0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 6 Dec 2019 16:06:33 +0800 Received: from [10.17.3.153] (10.17.3.153) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 6 Dec 2019 16:06:32 +0800 Message-ID: <1575619605.17879.3.camel@mhfsdcap03> Subject: Re: [PATCH v4 5/5] media: platform: Add jpeg dec/enc feature From: Xia Jiang To: Hans Verkuil CC: Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Rick Chang , "linux-media@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mediatek@lists.infradead.org" , Marek Szyprowski , Tomasz Figa , srv_heupstream Date: Fri, 6 Dec 2019 16:06:45 +0800 In-Reply-To: References: <20191017084033.28299-1-xia.jiang@mediatek.com> <20191017084033.28299-6-xia.jiang@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gTW9uLCAyMDE5LTEwLTIxIGF0IDE3OjIzICswODAwLCBIYW5zIFZlcmt1aWwgd3JvdGU6DQo+ IEhpIFhpYSwNCj4gDQo+IFNvbWUgY29tbWVudHMgYWJvdXQgdGhlIHNlbGVjdGlvbiBjb2RlOg0K PiANCj4gT24gMTAvMTcvMTkgMTA6NDAgQU0sIFhpYSBKaWFuZyB3cm90ZToNCj4gPiBBZGQgbXRr IGpwZWcgZW5jb2RlIHY0bDIgZHJpdmVyIGJhc2VkIG9uIGpwZWcgZGVjb2RlLCBiZWNhdXNlIHRo YXQganBlZw0KPiA+IGRlY29kZSBhbmQgZW5jb2RlIGhhdmUgZ3JlYXQgc2ltaWxhcml0aWVzIHdp dGggZnVuY3Rpb24gb3BlcmF0aW9uLg0KPiA+IA0KPiA+IFNpZ25lZC1vZmYtYnk6IFhpYSBKaWFu ZyA8eGlhLmppYW5nQG1lZGlhdGVrLmNvbT4NCj4gPiAtLS0NCj4gPiB2NDogc3BsaXQgbXRrX2pw ZWdfdHJ5X2ZtdF9tcGxhbmUoKSB0byB0d28gZnVuY3Rpb25zLCBvbmUgZm9yIGVuY29kZXIsDQo+ ID4gICAgIG9uZSBmb3IgZGVjb2Rlci4NCj4gPiAgICAgc3BsaXQgbXRrX2pwZWdfc2V0X2RlZmF1 bHRfcGFyYW1zKCkgdG8gdHdvIGZ1bmN0aW9ucywgb25lIGZvcg0KPiA+ICAgICBlbmNvZGVyLCBv bmUgZm9yIGRlY29kZXIuDQo+ID4gICAgIGFkZCBjcm9wcGluZyBzdXBwb3J0IGZvciBlbmNvZGVy IGluIGcvc19zZWxlY3Rpb24gaW9jdGxzLg0KPiA+ICAgICBjaGFuZ2UgZXhpZiBtb2RlIHN1cHBv cnQgYnkgdXNpbmcgVjRMMl9KUEVHX0FDVElWRV9NQVJLRVJfQVBQMS4NCj4gPiAgICAgY2hhbmdl IE1US19KUEVHX01BWF9XSURUSC9NVEtfSlBFR19NQVhfSEVJR0ggZnJvbSA4MTkyIHRvIDY1NTM1 IGJ5DQo+ID4gICAgIHNwZWNpZmljYXRpb24uDQo+ID4gICAgIG1vdmUgd2lkdGggc2hpZnRpbmcg b3BlcmF0aW9uIGJlaGluZCBhbGlnbmluZyBvcGVyYXRpb24gaW4NCj4gPiAgICAgbXRrX2pwZWdf dHJ5X2VuY19mbXRfbXBsYW5lKCkgZm9yIGJ1ZyBmaXguDQo+ID4gICAgIGZpeCB1c2VyIGFidXNl aW5nIGRhdGFfb2Zmc2V0IGlzc3VlIGZvciBETUFCVUYgaW4NCj4gPiAgICAgbXRrX2pwZWdfc2V0 X2VuY19zcmMoKS4NCj4gPiAgICAgZml4IGtidWlsZCB3YXJpbmdzOiBjaGFuZ2UgTVRLX0pQRUdf TUlOX0hFSUdIVC9NVEtfSlBFR19NQVhfSEVJR0hUDQo+ID4gICAgICAgICAgICAgICAgICAgICAg ICAgYW5kIE1US19KUEVHX01JTl9XSURUSC9NVEtfSlBFR19NQVhfV0lEVEggZnJvbQ0KPiA+ICAg ICAgICAgICAgICAgICAgICAgICAgICdpbnQnIHR5cGUgdG8gJ3Vuc2lnbmVkIGludCcgdHlwZS4N Cj4gPiAgICAgICAgICAgICAgICAgICAgICAgICBmaXggbXNsZWFkaW5nbHkgaW5kZW50ZWQgb2Yg J2Vsc2UnLg0KPiA+IA0KPiA+IHYzOiBkZWxldGUgQ2hhbmdlLUlkLg0KPiA+ICAgICBvbmx5IHRl c3Qgb25jZSBoYW5kbGVyLT5lcnJvciBhZnRlciB0aGUgbGFzdCB2NGwyX2N0cmxfbmV3X3N0ZCgp Lg0KPiA+ICAgICBzZXBlcmF0ZSBjaGFuZ2VzIG9mIHY0bDItY3RybHMuYyBhbmQgdjRsMi1jb250 cm9scy5oIHRvIG5ldyBwYXRjaC4NCj4gPiANCj4gPiB2MjogZml4IGNvbXBsaWFuY2UgdGVzdCBm YWlsLCBjaGVjayBjcmVhdGVkIGJ1ZmZlciBzaXplIGluIGRyaXZlci4NCj4gPiAtLS0NCj4gPiAg ZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9tdGstanBlZy9NYWtlZmlsZSAgICAgIHwgICA1ICstDQo+ ID4gIC4uLi9tZWRpYS9wbGF0Zm9ybS9tdGstanBlZy9tdGtfanBlZ19jb3JlLmMgICB8IDczMSAr KysrKysrKysrKysrKystLS0NCj4gPiAgLi4uL21lZGlhL3BsYXRmb3JtL210ay1qcGVnL210a19q cGVnX2NvcmUuaCAgIHwgMTIzICsrLQ0KPiA+ICAuLi4vbWVkaWEvcGxhdGZvcm0vbXRrLWpwZWcv bXRrX2pwZWdfZGVjX2h3LmggfCAgIDcgKy0NCj4gPiAgLi4uL21lZGlhL3BsYXRmb3JtL210ay1q cGVnL210a19qcGVnX2VuY19ody5jIHwgMTc1ICsrKysrDQo+ID4gIC4uLi9tZWRpYS9wbGF0Zm9y bS9tdGstanBlZy9tdGtfanBlZ19lbmNfaHcuaCB8ICA2MCArKw0KPiA+ICAuLi4vcGxhdGZvcm0v bXRrLWpwZWcvbXRrX2pwZWdfZW5jX3JlZy5oICAgICAgfCAgNDkgKysNCj4gPiAgNyBmaWxlcyBj aGFuZ2VkLCAxMDA0IGluc2VydGlvbnMoKyksIDE0NiBkZWxldGlvbnMoLSkNCj4gPiAgY3JlYXRl IG1vZGUgMTAwNjQ0IGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vbXRrLWpwZWcvbXRrX2pwZWdfZW5j X2h3LmMNCj4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vbXRr LWpwZWcvbXRrX2pwZWdfZW5jX2h3LmgNCj4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMv bWVkaWEvcGxhdGZvcm0vbXRrLWpwZWcvbXRrX2pwZWdfZW5jX3JlZy5oDQo+ID4gDQo+IA0KPiA8 c25pcD4NCj4gDQo+ID4gQEAgLTQ1NSwxMSArNjc5LDE5IEBAIHN0YXRpYyBpbnQgbXRrX2pwZWdf Z19zZWxlY3Rpb24oc3RydWN0IGZpbGUgKmZpbGUsIHZvaWQgKnByaXYsDQo+ID4gIAkJCQlzdHJ1 Y3QgdjRsMl9zZWxlY3Rpb24gKnMpDQo+ID4gIHsNCj4gPiAgCXN0cnVjdCBtdGtfanBlZ19jdHgg KmN0eCA9IG10a19qcGVnX2ZoX3RvX2N0eChwcml2KTsNCj4gPiArCXN0cnVjdCBtdGtfanBlZ19k ZXYgKmpwZWcgPSBjdHgtPmpwZWc7DQo+ID4gIA0KPiA+IC0JaWYgKHMtPnR5cGUgIT0gVjRMMl9C VUZfVFlQRV9WSURFT19DQVBUVVJFKQ0KPiA+ICsJaWYgKGpwZWctPm1vZGUgPT0gTVRLX0pQRUdf RU5DICYmIHMtPnR5cGUgIT0gVjRMMl9CVUZfVFlQRV9WSURFT19PVVRQVVQpDQo+ID4gKwkJcmV0 dXJuIC1FSU5WQUw7DQo+ID4gKw0KPiA+ICsJaWYgKGpwZWctPm1vZGUgPT0gTVRLX0pQRUdfREVD ICYmDQo+ID4gKwkgICAgcy0+dHlwZSAhPSBWNEwyX0JVRl9UWVBFX1ZJREVPX0NBUFRVUkUpDQo+ ID4gIAkJcmV0dXJuIC1FSU5WQUw7DQo+ID4gIA0KPiA+ICAJc3dpdGNoIChzLT50YXJnZXQpIHsN Cj4gPiArCWNhc2UgVjRMMl9TRUxfVEdUX0NST1A6DQo+ID4gKwljYXNlIFY0TDJfU0VMX1RHVF9D Uk9QX0JPVU5EUzoNCj4gPiArCWNhc2UgVjRMMl9TRUxfVEdUX0NST1BfREVGQVVMVDoNCj4gDQo+ IFRoaXMgaXMgd3JvbmcuLi4NCj4gDQo+ID4gIAljYXNlIFY0TDJfU0VMX1RHVF9DT01QT1NFOg0K PiA+ICAJY2FzZSBWNEwyX1NFTF9UR1RfQ09NUE9TRV9ERUZBVUxUOg0KPiA+ICAJCXMtPnIud2lk dGggPSBjdHgtPm91dF9xLnc7DQo+ID4gQEAgLTQ4NCwxMSArNzE2LDE3IEBAIHN0YXRpYyBpbnQg bXRrX2pwZWdfc19zZWxlY3Rpb24oc3RydWN0IGZpbGUgKmZpbGUsIHZvaWQgKnByaXYsDQo+ID4g IAkJCQlzdHJ1Y3QgdjRsMl9zZWxlY3Rpb24gKnMpDQo+ID4gIHsNCj4gPiAgCXN0cnVjdCBtdGtf anBlZ19jdHggKmN0eCA9IG10a19qcGVnX2ZoX3RvX2N0eChwcml2KTsNCj4gPiArCXN0cnVjdCBt dGtfanBlZ19kZXYgKmpwZWcgPSBjdHgtPmpwZWc7DQo+ID4gIA0KPiA+IC0JaWYgKHMtPnR5cGUg IT0gVjRMMl9CVUZfVFlQRV9WSURFT19DQVBUVVJFKQ0KPiA+ICsJaWYgKGpwZWctPm1vZGUgPT0g TVRLX0pQRUdfRU5DICYmIHMtPnR5cGUgIT0gVjRMMl9CVUZfVFlQRV9WSURFT19PVVRQVVQpDQo+ ID4gKwkJcmV0dXJuIC1FSU5WQUw7DQo+ID4gKw0KPiA+ICsJaWYgKGpwZWctPm1vZGUgPT0gTVRL X0pQRUdfREVDICYmDQo+ID4gKwkgICAgcy0+dHlwZSAhPSBWNEwyX0JVRl9UWVBFX1ZJREVPX0NB UFRVUkUpDQo+ID4gIAkJcmV0dXJuIC1FSU5WQUw7DQo+ID4gIA0KPiA+ICAJc3dpdGNoIChzLT50 YXJnZXQpIHsNCj4gPiArCWNhc2UgVjRMMl9TRUxfVEdUX0NST1A6DQo+IA0KPiAuLi5hbmQgc28g aXMgdGhpcy4NCj4gDQo+IFRoZSBkZWNvZGVyIG9ubHkgc3VwcG9ydHMgQ09NUE9TRSwgdGhlIGVu Y29kZXIgb25seSBzdXBwb3J0cyBDUk9QLg0KPiANCj4gVGhpcyBzaWduYWxzIHN1cHBvcnQgZm9y IGJvdGggY3JvcHBpbmcgYW5kIGNvbXBvc2l0aW9uIGZvciBib3RoIGVuY29kZXIgYW5kDQo+IGRl Y29kZXIsIGFuZCB0aGF0J3Mgd3JvbmcuIFlvdSBjYW4gc2VlIHRoaXMgaW4gdGhlIGNvbXBsaWFu Y2Ugb3V0cHV0IGFzIHdlbGw6DQo+IGl0IHNheXMgdGhhdCBib3RoIGNyb3BwaW5nIGFuZCBjb21w b3NpdGlvbiBhcmUgJ09LJywgbWVhbmluZyB0aGF0IGJvdGggZmVhdHVyZXMNCj4gYXJlIGltcGxl bWVudGVkLg0KPiANCj4gSXQgYWxzbyBjbGFpbXMgdGhhdCB0aGUgZGVjb2RlciBzdXBwb3J0cyBz Y2FsaW5nLiBJcyB0aGF0IGNvcnJlY3Q/IElzIHRoZXJlIGENCj4gc2NhbGVyIGluIHRoZSBKUEVH IGRlY29kZXI/IFVzdWFsbHkgY29kZWNzIGRvIG5vdCBoYXZlIGEgc2NhbGVyLg0KPiANCj4gUmVn YXJkcywNCj4gDQo+IAlIYW5zDQpEZWFyIEhhbnMsDQpDcm9wIG9ubHkgZm9yIGVuY29kZXIgYW5k IGNvbXBvc2Ugb25seSBmb3IgZGVjb2RlciBpbiB0aGUgbGF0ZXN0IHZlc2lvbi4NCg0KQmVzdCBS ZWdhcmRzLA0KWGlhIEppYW5nDQo+IA0KPiA+ICAJY2FzZSBWNEwyX1NFTF9UR1RfQ09NUE9TRToN Cj4gPiAgCQlzLT5yLmxlZnQgPSAwOw0KPiA+ICAJCXMtPnIudG9wID0gMDsNCj4gPiBAQCAtNjU4 LDEwICs4OTYsOTIgQEAgc3RhdGljIHZvaWQgbXRrX2pwZWdfc2V0X3F1ZXVlX2RhdGEoc3RydWN0 IG10a19qcGVnX2N0eCAqY3R4LA0KPiA+ICAJCSBwYXJhbS0+ZGVjX3csIHBhcmFtLT5kZWNfaCk7 DQo+ID4gIH0NCj4gDQo+IA0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C584FC43603 for ; Fri, 6 Dec 2019 08:07:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A93C2466E for ; Fri, 6 Dec 2019 08:07:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="H+qchgks"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="JjUwosIi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A93C2466E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DgwlcOCjTXPpJYXcEvPWZy2Rm82yU8sTvHyDWN5Q1EI=; b=H+qchgkslASrQI I6kTdjK+Sbcbmsg3T4bna+g7bLfB8ibXFQe3MszqJuvfr91y2oucf2K539Hs35xLJMA51bC88nFw6 iVMberFy0g7l+i8f+MGj9tgnB3SEf+X3QuQLg0REMzCUmT/C35a8MetAj3rnX0Y99pIY5PyLlessU w+wWL+bWmArk5+4zfNPuUonp22UJKdzjqSJlWlZnRGk3NBUJbVDBwyb8DECXwEfYvknqHLm5HVTPi rb2OMy/lBuTr0+sqEPfaESHe9h7GPln13YnMgVgTBfP2eiVuwYss2TsHThgB60p8P4doWRMe5SHQw oUeVBYkQBrufqHICA2tA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1id8dh-0005FH-4b; Fri, 06 Dec 2019 08:07:01 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1id8dZ-00057I-7M; Fri, 06 Dec 2019 08:06:54 +0000 X-UUID: ba47a2fd43c24fab8f74f5f9062a2fa4-20191206 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=lVZrCUbqLoiMSbjwNFA0HHxnz+mVQqg4nD2qHvV3jxo=; b=JjUwosIigrqrNMSo7X6lD2hG7u//9qAdGptzrFB1HR5x5i/8Vrtn4N2MtvfZqos0DbRR+sbMH/orYW7Y8JlRJP7yO/eWSJclBQQZJUB0L7t2qvtnMksOR808INHTsraWKnMNMH4j6dUPVqpI5qX5Ry9ZruwNSnz2jHFEaBqcIbE=; X-UUID: ba47a2fd43c24fab8f74f5f9062a2fa4-20191206 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 886913013; Fri, 06 Dec 2019 00:06:49 -0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 6 Dec 2019 00:07:41 -0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 6 Dec 2019 16:06:33 +0800 Received: from [10.17.3.153] (10.17.3.153) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 6 Dec 2019 16:06:32 +0800 Message-ID: <1575619605.17879.3.camel@mhfsdcap03> Subject: Re: [PATCH v4 5/5] media: platform: Add jpeg dec/enc feature From: Xia Jiang To: Hans Verkuil Date: Fri, 6 Dec 2019 16:06:45 +0800 In-Reply-To: References: <20191017084033.28299-1-xia.jiang@mediatek.com> <20191017084033.28299-6-xia.jiang@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191206_000653_273470_1224012B X-CRM114-Status: GOOD ( 23.51 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , srv_heupstream , Rick Chang , "linux-kernel@vger.kernel.org" , Tomasz Figa , Matthias Brugger , Rob Herring , "linux-mediatek@lists.infradead.org" , Mauro Carvalho Chehab , Marek Szyprowski , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, 2019-10-21 at 17:23 +0800, Hans Verkuil wrote: > Hi Xia, > > Some comments about the selection code: > > On 10/17/19 10:40 AM, Xia Jiang wrote: > > Add mtk jpeg encode v4l2 driver based on jpeg decode, because that jpeg > > decode and encode have great similarities with function operation. > > > > Signed-off-by: Xia Jiang > > --- > > v4: split mtk_jpeg_try_fmt_mplane() to two functions, one for encoder, > > one for decoder. > > split mtk_jpeg_set_default_params() to two functions, one for > > encoder, one for decoder. > > add cropping support for encoder in g/s_selection ioctls. > > change exif mode support by using V4L2_JPEG_ACTIVE_MARKER_APP1. > > change MTK_JPEG_MAX_WIDTH/MTK_JPEG_MAX_HEIGH from 8192 to 65535 by > > specification. > > move width shifting operation behind aligning operation in > > mtk_jpeg_try_enc_fmt_mplane() for bug fix. > > fix user abuseing data_offset issue for DMABUF in > > mtk_jpeg_set_enc_src(). > > fix kbuild warings: change MTK_JPEG_MIN_HEIGHT/MTK_JPEG_MAX_HEIGHT > > and MTK_JPEG_MIN_WIDTH/MTK_JPEG_MAX_WIDTH from > > 'int' type to 'unsigned int' type. > > fix msleadingly indented of 'else'. > > > > v3: delete Change-Id. > > only test once handler->error after the last v4l2_ctrl_new_std(). > > seperate changes of v4l2-ctrls.c and v4l2-controls.h to new patch. > > > > v2: fix compliance test fail, check created buffer size in driver. > > --- > > drivers/media/platform/mtk-jpeg/Makefile | 5 +- > > .../media/platform/mtk-jpeg/mtk_jpeg_core.c | 731 +++++++++++++++--- > > .../media/platform/mtk-jpeg/mtk_jpeg_core.h | 123 ++- > > .../media/platform/mtk-jpeg/mtk_jpeg_dec_hw.h | 7 +- > > .../media/platform/mtk-jpeg/mtk_jpeg_enc_hw.c | 175 +++++ > > .../media/platform/mtk-jpeg/mtk_jpeg_enc_hw.h | 60 ++ > > .../platform/mtk-jpeg/mtk_jpeg_enc_reg.h | 49 ++ > > 7 files changed, 1004 insertions(+), 146 deletions(-) > > create mode 100644 drivers/media/platform/mtk-jpeg/mtk_jpeg_enc_hw.c > > create mode 100644 drivers/media/platform/mtk-jpeg/mtk_jpeg_enc_hw.h > > create mode 100644 drivers/media/platform/mtk-jpeg/mtk_jpeg_enc_reg.h > > > > > > > @@ -455,11 +679,19 @@ static int mtk_jpeg_g_selection(struct file *file, void *priv, > > struct v4l2_selection *s) > > { > > struct mtk_jpeg_ctx *ctx = mtk_jpeg_fh_to_ctx(priv); > > + struct mtk_jpeg_dev *jpeg = ctx->jpeg; > > > > - if (s->type != V4L2_BUF_TYPE_VIDEO_CAPTURE) > > + if (jpeg->mode == MTK_JPEG_ENC && s->type != V4L2_BUF_TYPE_VIDEO_OUTPUT) > > + return -EINVAL; > > + > > + if (jpeg->mode == MTK_JPEG_DEC && > > + s->type != V4L2_BUF_TYPE_VIDEO_CAPTURE) > > return -EINVAL; > > > > switch (s->target) { > > + case V4L2_SEL_TGT_CROP: > > + case V4L2_SEL_TGT_CROP_BOUNDS: > > + case V4L2_SEL_TGT_CROP_DEFAULT: > > This is wrong... > > > case V4L2_SEL_TGT_COMPOSE: > > case V4L2_SEL_TGT_COMPOSE_DEFAULT: > > s->r.width = ctx->out_q.w; > > @@ -484,11 +716,17 @@ static int mtk_jpeg_s_selection(struct file *file, void *priv, > > struct v4l2_selection *s) > > { > > struct mtk_jpeg_ctx *ctx = mtk_jpeg_fh_to_ctx(priv); > > + struct mtk_jpeg_dev *jpeg = ctx->jpeg; > > > > - if (s->type != V4L2_BUF_TYPE_VIDEO_CAPTURE) > > + if (jpeg->mode == MTK_JPEG_ENC && s->type != V4L2_BUF_TYPE_VIDEO_OUTPUT) > > + return -EINVAL; > > + > > + if (jpeg->mode == MTK_JPEG_DEC && > > + s->type != V4L2_BUF_TYPE_VIDEO_CAPTURE) > > return -EINVAL; > > > > switch (s->target) { > > + case V4L2_SEL_TGT_CROP: > > ...and so is this. > > The decoder only supports COMPOSE, the encoder only supports CROP. > > This signals support for both cropping and composition for both encoder and > decoder, and that's wrong. You can see this in the compliance output as well: > it says that both cropping and composition are 'OK', meaning that both features > are implemented. > > It also claims that the decoder supports scaling. Is that correct? Is there a > scaler in the JPEG decoder? Usually codecs do not have a scaler. > > Regards, > > Hans Dear Hans, Crop only for encoder and compose only for decoder in the latest vesion. Best Regards, Xia Jiang > > > case V4L2_SEL_TGT_COMPOSE: > > s->r.left = 0; > > s->r.top = 0; > > @@ -658,10 +896,92 @@ static void mtk_jpeg_set_queue_data(struct mtk_jpeg_ctx *ctx, > > param->dec_w, param->dec_h); > > } > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 338A5C2D0B1 for ; Fri, 6 Dec 2019 08:06:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2C242466E for ; Fri, 6 Dec 2019 08:06:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RDmM3Op8"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="JjUwosIi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2C242466E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nBAogMbUOQ/Q4oTiDc8xvJW0rJXXdJgvjcF9KFufgMc=; b=RDmM3Op8oFeYfc GJlB6lQlahv6RhktIv0c1gDXxkEdA+mJ7eUZpvTabZ7SmX7i25OeIGwCtv4vTxk6VtmiAISkWe/Ex BfeIogBMCB07ft8Omr5uu9nDavgnU5FP+wpqgDs5ufhsNzGtOLtLmPNvR+4HC0AMm2PlKbvAoGnSg rutSuRXUFJwIfEG4ntjn70tFz9d0ofNEZwqTnLo1CelR1lkotsDBB2JEP2VAkX4hJU2yjRfbnW8Sa n5VeLJskVJDwli7Ia1rjs9mYkrkgGpf9SzgV8UWhV/1G3i35hbEzeGWV2IqX1hKvCk7G2UPyEJM6/ IDNCObxHpg6wdBkF02ug==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1id8dc-00058M-95; Fri, 06 Dec 2019 08:06:56 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1id8dZ-00057I-7M; Fri, 06 Dec 2019 08:06:54 +0000 X-UUID: ba47a2fd43c24fab8f74f5f9062a2fa4-20191206 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=lVZrCUbqLoiMSbjwNFA0HHxnz+mVQqg4nD2qHvV3jxo=; b=JjUwosIigrqrNMSo7X6lD2hG7u//9qAdGptzrFB1HR5x5i/8Vrtn4N2MtvfZqos0DbRR+sbMH/orYW7Y8JlRJP7yO/eWSJclBQQZJUB0L7t2qvtnMksOR808INHTsraWKnMNMH4j6dUPVqpI5qX5Ry9ZruwNSnz2jHFEaBqcIbE=; X-UUID: ba47a2fd43c24fab8f74f5f9062a2fa4-20191206 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 886913013; Fri, 06 Dec 2019 00:06:49 -0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 6 Dec 2019 00:07:41 -0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 6 Dec 2019 16:06:33 +0800 Received: from [10.17.3.153] (10.17.3.153) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 6 Dec 2019 16:06:32 +0800 Message-ID: <1575619605.17879.3.camel@mhfsdcap03> Subject: Re: [PATCH v4 5/5] media: platform: Add jpeg dec/enc feature From: Xia Jiang To: Hans Verkuil Date: Fri, 6 Dec 2019 16:06:45 +0800 In-Reply-To: References: <20191017084033.28299-1-xia.jiang@mediatek.com> <20191017084033.28299-6-xia.jiang@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191206_000653_273470_1224012B X-CRM114-Status: GOOD ( 23.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , srv_heupstream , Rick Chang , "linux-kernel@vger.kernel.org" , Tomasz Figa , Matthias Brugger , Rob Herring , "linux-mediatek@lists.infradead.org" , Mauro Carvalho Chehab , Marek Szyprowski , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2019-10-21 at 17:23 +0800, Hans Verkuil wrote: > Hi Xia, > > Some comments about the selection code: > > On 10/17/19 10:40 AM, Xia Jiang wrote: > > Add mtk jpeg encode v4l2 driver based on jpeg decode, because that jpeg > > decode and encode have great similarities with function operation. > > > > Signed-off-by: Xia Jiang > > --- > > v4: split mtk_jpeg_try_fmt_mplane() to two functions, one for encoder, > > one for decoder. > > split mtk_jpeg_set_default_params() to two functions, one for > > encoder, one for decoder. > > add cropping support for encoder in g/s_selection ioctls. > > change exif mode support by using V4L2_JPEG_ACTIVE_MARKER_APP1. > > change MTK_JPEG_MAX_WIDTH/MTK_JPEG_MAX_HEIGH from 8192 to 65535 by > > specification. > > move width shifting operation behind aligning operation in > > mtk_jpeg_try_enc_fmt_mplane() for bug fix. > > fix user abuseing data_offset issue for DMABUF in > > mtk_jpeg_set_enc_src(). > > fix kbuild warings: change MTK_JPEG_MIN_HEIGHT/MTK_JPEG_MAX_HEIGHT > > and MTK_JPEG_MIN_WIDTH/MTK_JPEG_MAX_WIDTH from > > 'int' type to 'unsigned int' type. > > fix msleadingly indented of 'else'. > > > > v3: delete Change-Id. > > only test once handler->error after the last v4l2_ctrl_new_std(). > > seperate changes of v4l2-ctrls.c and v4l2-controls.h to new patch. > > > > v2: fix compliance test fail, check created buffer size in driver. > > --- > > drivers/media/platform/mtk-jpeg/Makefile | 5 +- > > .../media/platform/mtk-jpeg/mtk_jpeg_core.c | 731 +++++++++++++++--- > > .../media/platform/mtk-jpeg/mtk_jpeg_core.h | 123 ++- > > .../media/platform/mtk-jpeg/mtk_jpeg_dec_hw.h | 7 +- > > .../media/platform/mtk-jpeg/mtk_jpeg_enc_hw.c | 175 +++++ > > .../media/platform/mtk-jpeg/mtk_jpeg_enc_hw.h | 60 ++ > > .../platform/mtk-jpeg/mtk_jpeg_enc_reg.h | 49 ++ > > 7 files changed, 1004 insertions(+), 146 deletions(-) > > create mode 100644 drivers/media/platform/mtk-jpeg/mtk_jpeg_enc_hw.c > > create mode 100644 drivers/media/platform/mtk-jpeg/mtk_jpeg_enc_hw.h > > create mode 100644 drivers/media/platform/mtk-jpeg/mtk_jpeg_enc_reg.h > > > > > > > @@ -455,11 +679,19 @@ static int mtk_jpeg_g_selection(struct file *file, void *priv, > > struct v4l2_selection *s) > > { > > struct mtk_jpeg_ctx *ctx = mtk_jpeg_fh_to_ctx(priv); > > + struct mtk_jpeg_dev *jpeg = ctx->jpeg; > > > > - if (s->type != V4L2_BUF_TYPE_VIDEO_CAPTURE) > > + if (jpeg->mode == MTK_JPEG_ENC && s->type != V4L2_BUF_TYPE_VIDEO_OUTPUT) > > + return -EINVAL; > > + > > + if (jpeg->mode == MTK_JPEG_DEC && > > + s->type != V4L2_BUF_TYPE_VIDEO_CAPTURE) > > return -EINVAL; > > > > switch (s->target) { > > + case V4L2_SEL_TGT_CROP: > > + case V4L2_SEL_TGT_CROP_BOUNDS: > > + case V4L2_SEL_TGT_CROP_DEFAULT: > > This is wrong... > > > case V4L2_SEL_TGT_COMPOSE: > > case V4L2_SEL_TGT_COMPOSE_DEFAULT: > > s->r.width = ctx->out_q.w; > > @@ -484,11 +716,17 @@ static int mtk_jpeg_s_selection(struct file *file, void *priv, > > struct v4l2_selection *s) > > { > > struct mtk_jpeg_ctx *ctx = mtk_jpeg_fh_to_ctx(priv); > > + struct mtk_jpeg_dev *jpeg = ctx->jpeg; > > > > - if (s->type != V4L2_BUF_TYPE_VIDEO_CAPTURE) > > + if (jpeg->mode == MTK_JPEG_ENC && s->type != V4L2_BUF_TYPE_VIDEO_OUTPUT) > > + return -EINVAL; > > + > > + if (jpeg->mode == MTK_JPEG_DEC && > > + s->type != V4L2_BUF_TYPE_VIDEO_CAPTURE) > > return -EINVAL; > > > > switch (s->target) { > > + case V4L2_SEL_TGT_CROP: > > ...and so is this. > > The decoder only supports COMPOSE, the encoder only supports CROP. > > This signals support for both cropping and composition for both encoder and > decoder, and that's wrong. You can see this in the compliance output as well: > it says that both cropping and composition are 'OK', meaning that both features > are implemented. > > It also claims that the decoder supports scaling. Is that correct? Is there a > scaler in the JPEG decoder? Usually codecs do not have a scaler. > > Regards, > > Hans Dear Hans, Crop only for encoder and compose only for decoder in the latest vesion. Best Regards, Xia Jiang > > > case V4L2_SEL_TGT_COMPOSE: > > s->r.left = 0; > > s->r.top = 0; > > @@ -658,10 +896,92 @@ static void mtk_jpeg_set_queue_data(struct mtk_jpeg_ctx *ctx, > > param->dec_w, param->dec_h); > > } > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel