From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15B39C2D0B1 for ; Fri, 6 Dec 2019 09:35:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D70BB21835 for ; Fri, 6 Dec 2019 09:35:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="FEJKPtO6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726261AbfLFJff (ORCPT ); Fri, 6 Dec 2019 04:35:35 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:5461 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726070AbfLFJfe (ORCPT ); Fri, 6 Dec 2019 04:35:34 -0500 X-UUID: 2dfcf66ed612406c98283f1ad3fb97d1-20191206 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=vR5+TmnGL8k18O3RfwhBu/Xl8JNbLQTJoi3SA28TkwA=; b=FEJKPtO6DGFE/HBnaQa1tq7mNOXQMTKic6YvCv9ETOPxmUS4driR3Uwkhc3saEfbP6jV+LUGqLK98mmgBsfHG8G5J/qQ+AnGR5EX05ECxxOk1xoLnFLLj4RbxynbYAr7y3GPA7JKhp/LMS1ZWZ+/A7o4jTD3G16AHGDC4ZXspBM=; X-UUID: 2dfcf66ed612406c98283f1ad3fb97d1-20191206 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 583983391; Fri, 06 Dec 2019 17:35:29 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs06n2.mediatek.inc (172.21.101.130) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 6 Dec 2019 17:35:27 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 6 Dec 2019 17:34:50 +0800 Message-ID: <1575624927.1631.7.camel@mtksdccf07> Subject: Re: [PATCH v2 7/8] thermal: mediatek: add another get_temp ops for thermal sensors From: Michael Kao To: Hsin-Yi Wang CC: Zhang Rui , Eduardo Valentin , Daniel Lezcano , Rob Herring , Mark Rutland , "Matthias Brugger" , , Devicetree List , lkml , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Date: Fri, 6 Dec 2019 17:35:27 +0800 In-Reply-To: References: <1557494826-6044-1-git-send-email-michael.kao@mediatek.com> <1557494826-6044-8-git-send-email-michael.kao@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-TM-SNTS-SMTP: B074D70E04D46F7F6E1F3B63CE826B399628CA35CC3E3E458B7FA485D552647E2000:8 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gVGh1LCAyMDE5LTExLTIxIGF0IDE1OjAwICswODAwLCBIc2luLVlpIFdhbmcgd3JvdGU6DQo+ IE9uIEZyaSwgTWF5IDEwLCAyMDE5IGF0IDk6MjcgUE0gbWljaGFlbC5rYW8gPG1pY2hhZWwua2Fv QG1lZGlhdGVrLmNvbT4gd3JvdGU6DQo+IA0KPiA+IC0gICAgICAgdHpkZXYgPSBkZXZtX3RoZXJt YWxfem9uZV9vZl9zZW5zb3JfcmVnaXN0ZXIoJnBkZXYtPmRldiwgMCwgbXQsDQo+ID4gLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAmbXRrX3RoZXJt YWxfb3BzKTsNCj4gPiAtICAgICAgIGlmIChJU19FUlIodHpkZXYpKSB7DQo+ID4gLSAgICAgICAg ICAgICAgIHJldCA9IFBUUl9FUlIodHpkZXYpOw0KPiA+IC0gICAgICAgICAgICAgICBnb3RvIGVy cl9kaXNhYmxlX2Nsa19wZXJpX3RoZXJtOw0KPiA+ICsgICAgICAgZm9yIChpID0gMDsgaSA8IG10 LT5jb25mLT5udW1fc2Vuc29ycyArIDE7IGkrKykgew0KPiA+ICsgICAgICAgICAgICAgICB0eiA9 IGttYWxsb2Moc2l6ZW9mKCp0eiksIEdGUF9LRVJORUwpOw0KPiA+ICsgICAgICAgICAgICAgICBp ZiAoIXR6KQ0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiAtRU5PTUVNOw0KPiA+ ICsNCj4gPiArICAgICAgICAgICAgICAgdHotPm10ID0gbXQ7DQo+ID4gKyAgICAgICAgICAgICAg IHR6LT5pZCA9IGk7DQo+ID4gKw0KPiA+ICsgICAgICAgICAgICAgICB0emRldiA9IGRldm1fdGhl cm1hbF96b25lX29mX3NlbnNvcl9yZWdpc3RlcigmcGRldi0+ZGV2LCBpLA0KPiA+ICsgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgdHosIChpID09IDApID8NCj4gPiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICZtdGtfdGhlcm1hbF9vcHMgOiAmbXRrX3RoZXJtYWxfc2Vuc29y X29wcyk7DQo+ID4gKw0KPiA+ICsgICAgICAgICAgICAgICBpZiAoSVNfRVJSKHR6ZGV2KSkgew0K PiA+ICsgICAgICAgICAgICAgICAgICAgICAgIGlmIChJU19FUlIodHpkZXYpICE9IC1FQUNDRVMp IHsNCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBQVFJfRVJSKHR6ZGV2KQ0KPiAN Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJldCA9IFBUUl9FUlIodHpkZXYp Ow0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ290byBlcnJfZGlzYWJsZV9j bGtfcGVyaV90aGVybTsNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICB9DQo+ID4gKyAgICAg ICAgICAgICAgIH0NCj4gDQo+IFRoaXMgZm9yIGxvb3AgYWRkaW5nIHRoZXJtYWwgem9uZSBzZW5z b3JzIHdpbGwgbm90IHdvcmsgZm9yIG10ODE3My4gSXQNCj4gYXNzdW1lcyB0aGF0IHRoZXJtYWwt em9uZXMgaW4gZHRzIGhhdmUgc3Vibm9kZXMgKGVnLiBjcHVfdGhlcm1hbCwNCj4gdHp0cy4uKSBh bW91bnQgZXF1YWwgdG8gbnVtX3NlbnNvcnMrMS4gT3RoZXJ3aXNlIHR6ZGV2IHdvdWxkIGJlDQo+ IC1FTk9ERVYgYW5kIHRoZXJtYWwgZmFpbGVkIHRvIGJlIHByb2JlZC4NCj4gSW4gbXQ4MTgzIHRo aXMgaXMgZmluZSwgc2luY2UgZWFjaCB0aGVybWFsIHpvbmUgb25seSBoYXMgb25lIHNlbnNvciwN Cj4gYnV0IGluIG10ODE3Mywgc29tZSBzZW5zb3IgYXBwZWFycyBpbiBtdWx0aXBsZSB0aGVybWFs IHpvbmVzLg0KPiANCj4gSW4gb3JkZXIgdG8gbGV0IHRoZSBjaGFuZ2UgYWxzbyB3b3JrcyBmb3Ig ODE3MywgSSB0aGluayBpZiB0aGUgZXJyb3INCj4gaXMgLUVOT0RFViwgYW5kIHRoZSBpZCBpcyBu b3QgMCAoMCBpcyBjcHVfdGhlcm1hbCksIHByb21wdCBhIHdhcm5pbmcNCj4gaW5zdGVhZCBvZiBm YWlsaW5nLiBFZy4NCj4gDQo+ICAgICAgICAgICAgICAgICBpZiAoSVNfRVJSKHR6ZGV2KSkgew0K PiArICAgICAgICAgICAgICAgICAgICAgICBpZiAoaSA+IDAgJiYgUFRSX0VSUih0emRldikgPT0g LUVOT0RFVikgew0KPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRldl93YXJuKCZw ZGV2LT5kZXYsICJjYW4ndCBmaW5kDQo+IHRoZXJtYWwgc2Vuc29yICVkXG4iLCBpKTsNCj4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsNCj4gKyAgICAgICAgICAgICAg ICAgICAgICAgfQ0KPiAgICAgICAgICAgICAgICAgICAgICAgICBpZiAoUFRSX0VSUih0emRldikg IT0gLUVBQ0NFUykgew0KDQpPSywgSSB3aWxsIHVwZGF0ZSB0aGlzIHBhdGNoLg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01A2BC43603 for ; Fri, 6 Dec 2019 09:35:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C7A6221823 for ; Fri, 6 Dec 2019 09:35:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vC+Rv8RB"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="IT0M4fxl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C7A6221823 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XCzekPvDq6Ttumu50RKNfgdpRbuAtBLho/iyVqR6ftY=; b=vC+Rv8RBOeSeAI gDj/r0hH8cN3JtmBlov857Eb+hraQ1sX2EeUzukDPVJ9pzcofy/b7gDqH+yBVtHfUd1Og5/G1WtTK wk3O365pXcugCqdBhEB6nePQcTeHE0J84Btx1nZmY9A/b5mW1R0iwP9VTJuOvFqWWsExGmVwnrBII OsEQqhD2xL2zJmWnb58Rn97bYBkivDHkYxSpN04szxY6eEsEQ1m/wJ0vTlxpjgN8AepuNCF5FuZ2/ YFLnZi+5zIM0l/r5FW930qTqcqTsv9JfEGu96C7U9CU1zJ12xIC9zMSKk7UnXzDuK1uVWVc7nxrAZ QEyI5zpN1aj6RNBbboJw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1idA1V-00019u-IP; Fri, 06 Dec 2019 09:35:41 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1idA1T-00018u-J7; Fri, 06 Dec 2019 09:35:40 +0000 X-UUID: 53829ed671054a31b02ef0970f3a8bd5-20191206 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=vR5+TmnGL8k18O3RfwhBu/Xl8JNbLQTJoi3SA28TkwA=; b=IT0M4fxlf04vCZUmXKfd8p6Z8eU6EiLiGcyUDVQ6sv7ieEMEZWYZffaAQqurBHjuGJcLBxwn14KQrJrLgxSP+PGNPcr/2MEROwY97f8qMMA1huT6oSkCJkH1RlJfhQa4kDm6cPr3ey97YuPFT+Ejf+U7rMeffl/Mcgl9aq6hA2Q=; X-UUID: 53829ed671054a31b02ef0970f3a8bd5-20191206 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 143918802; Fri, 06 Dec 2019 01:35:33 -0800 Received: from MTKMBS06N2.mediatek.inc (172.21.101.130) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 6 Dec 2019 01:36:20 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs06n2.mediatek.inc (172.21.101.130) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 6 Dec 2019 17:35:27 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 6 Dec 2019 17:34:50 +0800 Message-ID: <1575624927.1631.7.camel@mtksdccf07> Subject: Re: [PATCH v2 7/8] thermal: mediatek: add another get_temp ops for thermal sensors From: Michael Kao To: Hsin-Yi Wang Date: Fri, 6 Dec 2019 17:35:27 +0800 In-Reply-To: References: <1557494826-6044-1-git-send-email-michael.kao@mediatek.com> <1557494826-6044-8-git-send-email-michael.kao@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-TM-SNTS-SMTP: B074D70E04D46F7F6E1F3B63CE826B399628CA35CC3E3E458B7FA485D552647E2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191206_013539_639495_2F6650A5 X-CRM114-Status: GOOD ( 15.06 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Devicetree List , linux-pm@vger.kernel.org, Daniel Lezcano , lkml , Eduardo Valentin , Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , Zhang Rui , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, 2019-11-21 at 15:00 +0800, Hsin-Yi Wang wrote: > On Fri, May 10, 2019 at 9:27 PM michael.kao wrote: > > > - tzdev = devm_thermal_zone_of_sensor_register(&pdev->dev, 0, mt, > > - &mtk_thermal_ops); > > - if (IS_ERR(tzdev)) { > > - ret = PTR_ERR(tzdev); > > - goto err_disable_clk_peri_therm; > > + for (i = 0; i < mt->conf->num_sensors + 1; i++) { > > + tz = kmalloc(sizeof(*tz), GFP_KERNEL); > > + if (!tz) > > + return -ENOMEM; > > + > > + tz->mt = mt; > > + tz->id = i; > > + > > + tzdev = devm_thermal_zone_of_sensor_register(&pdev->dev, i, > > + tz, (i == 0) ? > > + &mtk_thermal_ops : &mtk_thermal_sensor_ops); > > + > > + if (IS_ERR(tzdev)) { > > + if (IS_ERR(tzdev) != -EACCES) { > PTR_ERR(tzdev) > > > + ret = PTR_ERR(tzdev); > > + goto err_disable_clk_peri_therm; > > + } > > + } > > This for loop adding thermal zone sensors will not work for mt8173. It > assumes that thermal-zones in dts have subnodes (eg. cpu_thermal, > tzts..) amount equal to num_sensors+1. Otherwise tzdev would be > -ENODEV and thermal failed to be probed. > In mt8183 this is fine, since each thermal zone only has one sensor, > but in mt8173, some sensor appears in multiple thermal zones. > > In order to let the change also works for 8173, I think if the error > is -ENODEV, and the id is not 0 (0 is cpu_thermal), prompt a warning > instead of failing. Eg. > > if (IS_ERR(tzdev)) { > + if (i > 0 && PTR_ERR(tzdev) == -ENODEV) { > + dev_warn(&pdev->dev, "can't find > thermal sensor %d\n", i); > + continue; > + } > if (PTR_ERR(tzdev) != -EACCES) { OK, I will update this patch. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C8E0C43603 for ; Fri, 6 Dec 2019 09:35:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02A6521823 for ; Fri, 6 Dec 2019 09:35:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SvpddmJJ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="IT0M4fxl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02A6521823 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3S4d63n2oYzvxPGo5RLgCs8Jua3Rsx5DDoGXKpKOwvM=; b=SvpddmJJNCvN7b HXoUdI2mv8Wi1uZ9XHZMeF3j9/aA+bDIvIx85f8Qy7knOf1d86FDhr8oGk38+smBByzhdYsQ/y/zZ WidPAKTfRt/rnpgBWqDreSC6aM5ExbtdzvCBJNLY9Vb4udZH3LL2UFWsET8xsp+bMkcWk/yT3j30J VkX7A0rExD3qxv/zTdyJXTL2v5CMwHX5HJBriiJ8gmzQkgf/8ZhqRzAzRrGaUhHTFlL8JUKr+wPt9 M2QTbxH/9Ex1s0zdBLG4o5IldqOeW/ryBvpAgkJJV6qqYOrl1o72V92IOzu2nQECzVZiwsQyIFNO0 Uol39ranWvTVdgkZFdLQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1idA1X-0001As-G2; Fri, 06 Dec 2019 09:35:43 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1idA1T-00018u-J7; Fri, 06 Dec 2019 09:35:40 +0000 X-UUID: 53829ed671054a31b02ef0970f3a8bd5-20191206 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=vR5+TmnGL8k18O3RfwhBu/Xl8JNbLQTJoi3SA28TkwA=; b=IT0M4fxlf04vCZUmXKfd8p6Z8eU6EiLiGcyUDVQ6sv7ieEMEZWYZffaAQqurBHjuGJcLBxwn14KQrJrLgxSP+PGNPcr/2MEROwY97f8qMMA1huT6oSkCJkH1RlJfhQa4kDm6cPr3ey97YuPFT+Ejf+U7rMeffl/Mcgl9aq6hA2Q=; X-UUID: 53829ed671054a31b02ef0970f3a8bd5-20191206 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 143918802; Fri, 06 Dec 2019 01:35:33 -0800 Received: from MTKMBS06N2.mediatek.inc (172.21.101.130) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 6 Dec 2019 01:36:20 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs06n2.mediatek.inc (172.21.101.130) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 6 Dec 2019 17:35:27 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 6 Dec 2019 17:34:50 +0800 Message-ID: <1575624927.1631.7.camel@mtksdccf07> Subject: Re: [PATCH v2 7/8] thermal: mediatek: add another get_temp ops for thermal sensors From: Michael Kao To: Hsin-Yi Wang Date: Fri, 6 Dec 2019 17:35:27 +0800 In-Reply-To: References: <1557494826-6044-1-git-send-email-michael.kao@mediatek.com> <1557494826-6044-8-git-send-email-michael.kao@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-TM-SNTS-SMTP: B074D70E04D46F7F6E1F3B63CE826B399628CA35CC3E3E458B7FA485D552647E2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191206_013539_639495_2F6650A5 X-CRM114-Status: GOOD ( 15.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Devicetree List , linux-pm@vger.kernel.org, Daniel Lezcano , lkml , Eduardo Valentin , Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , Zhang Rui , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2019-11-21 at 15:00 +0800, Hsin-Yi Wang wrote: > On Fri, May 10, 2019 at 9:27 PM michael.kao wrote: > > > - tzdev = devm_thermal_zone_of_sensor_register(&pdev->dev, 0, mt, > > - &mtk_thermal_ops); > > - if (IS_ERR(tzdev)) { > > - ret = PTR_ERR(tzdev); > > - goto err_disable_clk_peri_therm; > > + for (i = 0; i < mt->conf->num_sensors + 1; i++) { > > + tz = kmalloc(sizeof(*tz), GFP_KERNEL); > > + if (!tz) > > + return -ENOMEM; > > + > > + tz->mt = mt; > > + tz->id = i; > > + > > + tzdev = devm_thermal_zone_of_sensor_register(&pdev->dev, i, > > + tz, (i == 0) ? > > + &mtk_thermal_ops : &mtk_thermal_sensor_ops); > > + > > + if (IS_ERR(tzdev)) { > > + if (IS_ERR(tzdev) != -EACCES) { > PTR_ERR(tzdev) > > > + ret = PTR_ERR(tzdev); > > + goto err_disable_clk_peri_therm; > > + } > > + } > > This for loop adding thermal zone sensors will not work for mt8173. It > assumes that thermal-zones in dts have subnodes (eg. cpu_thermal, > tzts..) amount equal to num_sensors+1. Otherwise tzdev would be > -ENODEV and thermal failed to be probed. > In mt8183 this is fine, since each thermal zone only has one sensor, > but in mt8173, some sensor appears in multiple thermal zones. > > In order to let the change also works for 8173, I think if the error > is -ENODEV, and the id is not 0 (0 is cpu_thermal), prompt a warning > instead of failing. Eg. > > if (IS_ERR(tzdev)) { > + if (i > 0 && PTR_ERR(tzdev) == -ENODEV) { > + dev_warn(&pdev->dev, "can't find > thermal sensor %d\n", i); > + continue; > + } > if (PTR_ERR(tzdev) != -EACCES) { OK, I will update this patch. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel