[Intel-gfx] [PATCH] drm/i915/gem: Comment on inability to check args.pad for MMAP_OFFSET

[Intel-gfx] [PATCH] drm/i915/gem: Comment on inability to check args.pad for MMAP_OFFSET

[Chris Wilson]

Since we didn't check and insist that args.pad must be zero for MMAP_GTT
historically, we cannot insert a check now as old userspace may be
feeding in garbage. As such the lack of check is enshrined into the ABI,
so add a comment to remind us we cannot add the check later.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
 drivers/gpu/drm/i915/gem/i915_gem_mman.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
index 3a3f30bc8ac7..15faf95d74ca 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
@@ -620,6 +620,15 @@ i915_gem_mmap_offset_ioctl(struct drm_device *dev, void *data,
 	enum i915_mmap_type type;
 	int err;
 
+	/*
+	 * Historically we failed to check args.pad and args.offset
+	 * and so we cannot those fields for user input and we cannot
+	 * add -EINVAL for them as the ABI is fixed, i.e. old userspace
+	 * may be feeding in garbage in those fields.
+	 *
+	 * if (args->pad) return -EINVAL; is verbotten!
+	 */
+
 	err = i915_user_extensions(u64_to_user_ptr(args->extensions),
 				   NULL, 0, NULL);
 	if (err)
-- 
2.24.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Comment on inability to check args.pad for MMAP_OFFSET

[Patchwork]

== Series Details ==

Series: drm/i915/gem: Comment on inability to check args.pad for MMAP_OFFSET
URL   : https://patchwork.freedesktop.org/series/70593/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7508 -> Patchwork_15640
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/index.html

Known issues
------------

  Here are the changes found in Patchwork_15640 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live_blt:
    - fi-ivb-3770:        [PASS][1] -> [DMESG-FAIL][2] ([i915#725])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/fi-ivb-3770/igt@i915_selftest@live_blt.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/fi-ivb-3770/igt@i915_selftest@live_blt.html
    - fi-hsw-4770:        [PASS][3] -> [DMESG-FAIL][4] ([i915#553] / [i915#725])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/fi-hsw-4770/igt@i915_selftest@live_blt.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/fi-hsw-4770/igt@i915_selftest@live_blt.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-hsw-peppy:       [PASS][5] -> [DMESG-WARN][6] ([i915#44])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html

  
#### Possible fixes ####

  * igt@i915_selftest@live_blt:
    - fi-hsw-4770r:       [DMESG-FAIL][7] ([i915#725]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/fi-hsw-4770r/igt@i915_selftest@live_blt.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/fi-hsw-4770r/igt@i915_selftest@live_blt.html

  
#### Warnings ####

  * igt@i915_selftest@live_gem_contexts:
    - fi-byt-n2820:       [DMESG-FAIL][9] ([i915#722]) -> [INCOMPLETE][10] ([i915#45])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html

  
  [i915#44]: https://gitlab.freedesktop.org/drm/intel/issues/44
  [i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
  [i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
  [i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722
  [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725


Participating hosts (34 -> 27)
------------------------------

  Missing    (7): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-icl-dsi fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7508 -> Patchwork_15640

  CI-20190529: 20190529
  CI_DRM_7508: fbef44ec6bab20b9e703b38d7456ffd4842dda86 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5335: 06aa2c377ed40df1e246fca009c441fa18e53825 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_15640: aa72bf9f8b419814e3f590b05b16a7e7263fc8cb @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

aa72bf9f8b41 drm/i915/gem: Comment on inability to check args.pad for MMAP_OFFSET

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gem: Comment on inability to check args.pad for MMAP_OFFSET

[Patchwork]

== Series Details ==

Series: drm/i915/gem: Comment on inability to check args.pad for MMAP_OFFSET
URL   : https://patchwork.freedesktop.org/series/70593/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7508_full -> Patchwork_15640_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_15640_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_15640_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_15640_full:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_ctx_isolation@bcs0-nonpriv-switch:
    - shard-iclb:         NOTRUN -> [FAIL][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-iclb4/igt@gem_ctx_isolation@bcs0-nonpriv-switch.html

  * igt@gem_ctx_isolation@vcs0-nonpriv:
    - shard-iclb:         [PASS][2] -> [FAIL][3]
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-iclb1/igt@gem_ctx_isolation@vcs0-nonpriv.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-iclb4/igt@gem_ctx_isolation@vcs0-nonpriv.html

  * igt@gem_ctx_persistence@vecs0-mixed-process:
    - shard-apl:          [PASS][4] -> [FAIL][5]
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-apl8/igt@gem_ctx_persistence@vecs0-mixed-process.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-apl6/igt@gem_ctx_persistence@vecs0-mixed-process.html

  * igt@i915_selftest@mock_sanitycheck:
    - shard-kbl:          [PASS][6] -> [DMESG-WARN][7]
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-kbl3/igt@i915_selftest@mock_sanitycheck.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-kbl4/igt@i915_selftest@mock_sanitycheck.html
    - shard-skl:          [PASS][8] -> [DMESG-WARN][9]
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-skl9/igt@i915_selftest@mock_sanitycheck.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-skl7/igt@i915_selftest@mock_sanitycheck.html

  * igt@kms_frontbuffer_tracking@psr-1p-rte:
    - shard-tglb:         [PASS][10] -> [INCOMPLETE][11]
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-tglb2/igt@kms_frontbuffer_tracking@psr-1p-rte.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-tglb7/igt@kms_frontbuffer_tracking@psr-1p-rte.html

  
Known issues
------------

  Here are the changes found in Patchwork_15640_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@drm_read@short-buffer-block:
    - shard-snb:          [PASS][12] -> [SKIP][13] ([fdo#109271])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-snb2/igt@drm_read@short-buffer-block.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-snb1/igt@drm_read@short-buffer-block.html

  * igt@gem_ctx_freq@sysfs:
    - shard-apl:          [PASS][14] -> [INCOMPLETE][15] ([fdo#103927])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-apl6/igt@gem_ctx_freq@sysfs.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-apl6/igt@gem_ctx_freq@sysfs.html

  * igt@gem_ctx_isolation@rcs0-s3:
    - shard-kbl:          [PASS][16] -> [DMESG-WARN][17] ([i915#180]) +6 similar issues
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-kbl6/igt@gem_ctx_isolation@rcs0-s3.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-kbl4/igt@gem_ctx_isolation@rcs0-s3.html

  * igt@gem_ctx_isolation@vcs1-none:
    - shard-iclb:         [PASS][18] -> [SKIP][19] ([fdo#112080]) +1 similar issue
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-iclb1/igt@gem_ctx_isolation@vcs1-none.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-iclb3/igt@gem_ctx_isolation@vcs1-none.html

  * igt@gem_ctx_shared@q-smoketest-all:
    - shard-tglb:         [PASS][20] -> [INCOMPLETE][21] ([fdo#111735])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-tglb7/igt@gem_ctx_shared@q-smoketest-all.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-tglb6/igt@gem_ctx_shared@q-smoketest-all.html

  * igt@gem_exec_async@concurrent-writes-bsd:
    - shard-iclb:         [PASS][22] -> [SKIP][23] ([fdo#112146]) +3 similar issues
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-iclb3/igt@gem_exec_async@concurrent-writes-bsd.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-iclb4/igt@gem_exec_async@concurrent-writes-bsd.html

  * igt@gem_exec_schedule@promotion-bsd1:
    - shard-iclb:         [PASS][24] -> [SKIP][25] ([fdo#109276]) +1 similar issue
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-iclb1/igt@gem_exec_schedule@promotion-bsd1.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-iclb3/igt@gem_exec_schedule@promotion-bsd1.html

  * igt@gem_persistent_relocs@forked-interruptible-thrash-inactive:
    - shard-hsw:          [PASS][26] -> [INCOMPLETE][27] ([i915#530] / [i915#61])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-hsw5/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-hsw1/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html

  * igt@kms_cursor_crc@pipe-b-cursor-256x85-sliding:
    - shard-skl:          [PASS][28] -> [FAIL][29] ([i915#54]) +2 similar issues
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-skl7/igt@kms_cursor_crc@pipe-b-cursor-256x85-sliding.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-skl3/igt@kms_cursor_crc@pipe-b-cursor-256x85-sliding.html

  * igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
    - shard-glk:          [PASS][30] -> [FAIL][31] ([i915#117] / [i915#133])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-glk7/igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-glk1/igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic.html

  * igt@kms_cursor_legacy@flip-vs-cursor-legacy:
    - shard-tglb:         [PASS][32] -> [FAIL][33] ([IGT#5])
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-tglb2/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-tglb8/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html

  * igt@kms_draw_crc@draw-method-xrgb8888-pwrite-xtiled:
    - shard-skl:          [PASS][34] -> [FAIL][35] ([i915#52] / [i915#54])
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-skl2/igt@kms_draw_crc@draw-method-xrgb8888-pwrite-xtiled.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-skl6/igt@kms_draw_crc@draw-method-xrgb8888-pwrite-xtiled.html

  * igt@kms_fbcon_fbt@fbc-suspend:
    - shard-tglb:         [PASS][36] -> [INCOMPLETE][37] ([i915#435] / [i915#456] / [i915#460])
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-tglb8/igt@kms_fbcon_fbt@fbc-suspend.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-tglb1/igt@kms_fbcon_fbt@fbc-suspend.html

  * igt@kms_flip@flip-vs-modeset-interruptible:
    - shard-hsw:          [PASS][38] -> [DMESG-WARN][39] ([i915#44])
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-hsw5/igt@kms_flip@flip-vs-modeset-interruptible.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-hsw5/igt@kms_flip@flip-vs-modeset-interruptible.html

  * igt@kms_flip@flip-vs-suspend:
    - shard-hsw:          [PASS][40] -> [INCOMPLETE][41] ([i915#61])
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-hsw6/igt@kms_flip@flip-vs-suspend.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-hsw2/igt@kms_flip@flip-vs-suspend.html

  * igt@kms_flip@flip-vs-suspend-interruptible:
    - shard-apl:          [PASS][42] -> [DMESG-WARN][43] ([i915#180]) +1 similar issue
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-apl2/igt@kms_flip@flip-vs-suspend-interruptible.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-apl4/igt@kms_flip@flip-vs-suspend-interruptible.html

  * igt@kms_frontbuffer_tracking@basic:
    - shard-iclb:         [PASS][44] -> [FAIL][45] ([i915#49]) +1 similar issue
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-iclb1/igt@kms_frontbuffer_tracking@basic.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-iclb4/igt@kms_frontbuffer_tracking@basic.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt:
    - shard-kbl:          [PASS][46] -> [INCOMPLETE][47] ([fdo#103665] / [i915#634])
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt.html
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-render:
    - shard-iclb:         [PASS][48] -> [INCOMPLETE][49] ([i915#123] / [i915#140])
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-render.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-render.html

  * igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-cpu:
    - shard-tglb:         [PASS][50] -> [FAIL][51] ([i915#49]) +2 similar issues
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-cpu.html
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-cpu.html

  * igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
    - shard-skl:          [PASS][52] -> [INCOMPLETE][53] ([fdo#112347] / [i915#648])
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-skl4/igt@kms_plane@pixel-format-pipe-b-planes-source-clamping.html
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-skl1/igt@kms_plane@pixel-format-pipe-b-planes-source-clamping.html

  * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
    - shard-skl:          [PASS][54] -> [FAIL][55] ([fdo#108145]) +3 similar issues
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html

  * igt@kms_vblank@pipe-a-ts-continuation-suspend:
    - shard-tglb:         [PASS][56] -> [INCOMPLETE][57] ([i915#456] / [i915#460]) +4 similar issues
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-tglb7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-tglb5/igt@kms_vblank@pipe-a-ts-continuation-suspend.html

  * igt@perf@oa-exponents:
    - shard-iclb:         [PASS][58] -> [INCOMPLETE][59] ([i915#140])
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-iclb2/igt@perf@oa-exponents.html
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-iclb4/igt@perf@oa-exponents.html

  
#### Possible fixes ####

  * igt@gem_ctx_isolation@vcs0-nonpriv:
    - shard-kbl:          [FAIL][60] -> [PASS][61]
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-kbl3/igt@gem_ctx_isolation@vcs0-nonpriv.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-kbl7/igt@gem_ctx_isolation@vcs0-nonpriv.html

  * igt@gem_ctx_persistence@processes:
    - shard-skl:          [FAIL][62] ([i915#570]) -> [PASS][63]
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-skl9/igt@gem_ctx_persistence@processes.html
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-skl2/igt@gem_ctx_persistence@processes.html

  * igt@gem_ctx_shared@exec-shared-gtt-bsd2:
    - shard-iclb:         [SKIP][64] ([fdo#109276]) -> [PASS][65] +2 similar issues
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-iclb6/igt@gem_ctx_shared@exec-shared-gtt-bsd2.html
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-iclb2/igt@gem_ctx_shared@exec-shared-gtt-bsd2.html

  * igt@gem_exec_capture@capture-bsd:
    - shard-iclb:         [SKIP][66] ([fdo#112146]) -> [PASS][67]
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-iclb1/igt@gem_exec_capture@capture-bsd.html
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-iclb3/igt@gem_exec_capture@capture-bsd.html

  * {igt@gem_exec_schedule@pi-distinct-iova-bsd}:
    - shard-iclb:         [SKIP][68] ([i915#677]) -> [PASS][69]
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-iclb1/igt@gem_exec_schedule@pi-distinct-iova-bsd.html
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-iclb3/igt@gem_exec_schedule@pi-distinct-iova-bsd.html

  * igt@gem_exec_schedule@preempt-queue-chain-bsd1:
    - shard-tglb:         [INCOMPLETE][70] ([fdo#111606] / [fdo#111677]) -> [PASS][71]
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-tglb6/igt@gem_exec_schedule@preempt-queue-chain-bsd1.html
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-tglb8/igt@gem_exec_schedule@preempt-queue-chain-bsd1.html

  * igt@gem_pipe_control_store_loop@reused-buffer:
    - shard-tglb:         [INCOMPLETE][72] ([i915#707]) -> [PASS][73]
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-tglb6/igt@gem_pipe_control_store_loop@reused-buffer.html
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-tglb7/igt@gem_pipe_control_store_loop@reused-buffer.html

  * igt@gem_ppgtt@flink-and-close-vma-leak:
    - shard-kbl:          [FAIL][74] ([i915#644]) -> [PASS][75]
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-kbl4/igt@gem_ppgtt@flink-and-close-vma-leak.html
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-kbl6/igt@gem_ppgtt@flink-and-close-vma-leak.html

  * igt@gem_userptr_blits@dmabuf-unsync:
    - shard-snb:          [DMESG-WARN][76] ([fdo#111870]) -> [PASS][77]
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-snb7/igt@gem_userptr_blits@dmabuf-unsync.html
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-snb1/igt@gem_userptr_blits@dmabuf-unsync.html

  * igt@i915_pm_rpm@system-suspend-modeset:
    - shard-skl:          [INCOMPLETE][78] ([i915#151] / [i915#69]) -> [PASS][79]
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-skl10/igt@i915_pm_rpm@system-suspend-modeset.html
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-skl3/igt@i915_pm_rpm@system-suspend-modeset.html

  * igt@i915_pm_rps@reset:
    - shard-apl:          [FAIL][80] ([i915#39]) -> [PASS][81]
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-apl6/igt@i915_pm_rps@reset.html
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-apl2/igt@i915_pm_rps@reset.html

  * igt@i915_selftest@live_gem_contexts:
    - shard-tglb:         [INCOMPLETE][82] ([i915#455]) -> [PASS][83]
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-tglb6/igt@i915_selftest@live_gem_contexts.html
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-tglb5/igt@i915_selftest@live_gem_contexts.html

  * igt@i915_selftest@mock_sanitycheck:
    - shard-snb:          [DMESG-WARN][84] -> [PASS][85] +1 similar issue
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-snb5/igt@i915_selftest@mock_sanitycheck.html
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-snb4/igt@i915_selftest@mock_sanitycheck.html

  * igt@i915_suspend@fence-restore-tiled2untiled:
    - shard-tglb:         [INCOMPLETE][86] ([i915#456] / [i915#460]) -> [PASS][87]
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-tglb5/igt@i915_suspend@fence-restore-tiled2untiled.html
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-tglb3/igt@i915_suspend@fence-restore-tiled2untiled.html

  * igt@kms_cursor_crc@pipe-a-cursor-128x42-sliding:
    - shard-skl:          [FAIL][88] ([i915#54]) -> [PASS][89] +1 similar issue
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-skl8/igt@kms_cursor_crc@pipe-a-cursor-128x42-sliding.html
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-skl4/igt@kms_cursor_crc@pipe-a-cursor-128x42-sliding.html

  * igt@kms_cursor_crc@pipe-c-cursor-suspend:
    - shard-kbl:          [DMESG-WARN][90] ([i915#180]) -> [PASS][91] +3 similar issues
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html

  * igt@kms_flip@flip-vs-suspend:
    - shard-apl:          [DMESG-WARN][92] ([i915#180]) -> [PASS][93] +2 similar issues
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-apl6/igt@kms_flip@flip-vs-suspend.html
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-apl2/igt@kms_flip@flip-vs-suspend.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt:
    - shard-tglb:         [FAIL][94] ([i915#49]) -> [PASS][95] +7 similar issues
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-tglb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt:
    - shard-iclb:         [FAIL][96] ([i915#49]) -> [PASS][97]
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt.html
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt.html

  * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
    - shard-skl:          [FAIL][98] ([fdo#108145] / [i915#265]) -> [PASS][99] +1 similar issue
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html

  * igt@kms_psr@no_drrs:
    - shard-iclb:         [FAIL][100] ([i915#173]) -> [PASS][101]
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-iclb1/igt@kms_psr@no_drrs.html
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-iclb3/igt@kms_psr@no_drrs.html

  * igt@kms_psr@psr2_no_drrs:
    - shard-iclb:         [SKIP][102] ([fdo#109441]) -> [PASS][103]
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-iclb6/igt@kms_psr@psr2_no_drrs.html
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-iclb2/igt@kms_psr@psr2_no_drrs.html

  * igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
    - shard-tglb:         [INCOMPLETE][104] ([i915#460]) -> [PASS][105]
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-tglb7/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-tglb6/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html

  * igt@perf_pmu@busy-check-all-vcs1:
    - shard-iclb:         [SKIP][106] ([fdo#112080]) -> [PASS][107] +4 similar issues
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-iclb3/igt@perf_pmu@busy-check-all-vcs1.html
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-iclb4/igt@perf_pmu@busy-check-all-vcs1.html

  
#### Warnings ####

  * igt@i915_selftest@live_blt:
    - shard-hsw:          [DMESG-FAIL][108] ([i915#725]) -> [DMESG-FAIL][109] ([i915#553] / [i915#725])
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-hsw6/igt@i915_selftest@live_blt.html
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-hsw5/igt@i915_selftest@live_blt.html

  * igt@kms_dp_dsc@basic-dsc-enable-edp:
    - shard-iclb:         [DMESG-WARN][110] ([fdo#107724]) -> [SKIP][111] ([fdo#109349])
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7508/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/shard-iclb4/igt@kms_dp_dsc@basic-dsc-enable-edp.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [IGT#5]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/5
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
  [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#111606]: https://bugs.freedesktop.org/show_bug.cgi?id=111606
  [fdo#111677]: https://bugs.freedesktop.org/show_bug.cgi?id=111677
  [fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
  [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
  [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
  [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
  [fdo#112347]: https://bugs.freedesktop.org/show_bug.cgi?id=112347
  [i915#117]: https://gitlab.freedesktop.org/drm/intel/issues/117
  [i915#123]: https://gitlab.freedesktop.org/drm/intel/issues/123
  [i915#133]: https://gitlab.freedesktop.org/drm/intel/issues/133
  [i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140
  [i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151
  [i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173
  [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
  [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
  [i915#39]: https://gitlab.freedesktop.org/drm/intel/issues/39
  [i915#435]: https://gitlab.freedesktop.org/drm/intel/issues/435
  [i915#44]: https://gitlab.freedesktop.org/drm/intel/issues/44
  [i915#455]: https://gitlab.freedesktop.org/drm/intel/issues/455
  [i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
  [i915#460]: https://gitlab.freedesktop.org/drm/intel/issues/460
  [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
  [i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
  [i915#530]: https://gitlab.freedesktop.org/drm/intel/issues/530
  [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
  [i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
  [i915#570]: https://gitlab.freedesktop.org/drm/intel/issues/570
  [i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
  [i915#634]: https://gitlab.freedesktop.org/drm/intel/issues/634
  [i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
  [i915#648]: https://gitlab.freedesktop.org/drm/intel/issues/648
  [i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
  [i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
  [i915#707]: https://gitlab.freedesktop.org/drm/intel/issues/707
  [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725


Participating hosts (11 -> 11)
------------------------------

  No changes in participating hosts


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7508 -> Patchwork_15640

  CI-20190529: 20190529
  CI_DRM_7508: fbef44ec6bab20b9e703b38d7456ffd4842dda86 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5335: 06aa2c377ed40df1e246fca009c441fa18e53825 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_15640: aa72bf9f8b419814e3f590b05b16a7e7263fc8cb @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15640/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915/gem: Comment on inability to check args.pad for MMAP_OFFSET

[Joonas Lahtinen]

Quoting Chris Wilson (2019-12-08 00:26:44)
> Since we didn't check and insist that args.pad must be zero for MMAP_GTT
> historically, we cannot insert a check now as old userspace may be
> feeding in garbage. As such the lack of check is enshrined into the ABI,
> so add a comment to remind us we cannot add the check later.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx