From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D37C2C43603 for ; Mon, 9 Dec 2019 08:51:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A33A72075B for ; Mon, 9 Dec 2019 08:51:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="P1xvWC6H" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727294AbfLIIvW (ORCPT ); Mon, 9 Dec 2019 03:51:22 -0500 Received: from mailgw02.mediatek.com ([216.200.240.185]:51580 "EHLO mailgw02.mediatek.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726377AbfLIIvW (ORCPT ); Mon, 9 Dec 2019 03:51:22 -0500 X-UUID: ff33343a19fb4fcc9e4480a7861245f0-20191209 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=Xr2/g3CmQSCe7XSe29tjEitMS2VOZyuM620kmLXWO6Q=; b=P1xvWC6HDaWhqgmYSncCgQAH8w+XZKpkMz44/oBFhr3zDee4L99O/yiaD85cTEOn8EXnEagEfkFkVPxxVmnbqNJOMLxJS/m3Gz9GOeQyUnuS9vcBkk7Dcx0jEiaGsAWnzwfrYy3zLCfeFRAqBT9QE8qDuQWL09gK29ybu4yV3ig=; X-UUID: ff33343a19fb4fcc9e4480a7861245f0-20191209 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1426792079; Mon, 09 Dec 2019 00:51:20 -0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 9 Dec 2019 00:52:19 -0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 9 Dec 2019 16:51:03 +0800 Message-ID: <1575881471.14479.2.camel@mtksdaap41> Subject: Re: [resend PATCH v6 10/12] clk: mediatek: mt8183: switch mmsys to platform device probing From: CK Hu To: CC: , , , , , , , , , , , , , , , , , , , , , , , Date: Mon, 9 Dec 2019 16:51:11 +0800 In-Reply-To: <20191207224740.24536-11-matthias.bgg@kernel.org> References: <20191207224740.24536-1-matthias.bgg@kernel.org> <20191207224740.24536-11-matthias.bgg@kernel.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SGksIE1hdHRoaWFzOg0KDQpPbiBTYXQsIDIwMTktMTItMDcgYXQgMjM6NDcgKzAxMDAsIG1hdHRo aWFzLmJnZ0BrZXJuZWwub3JnIHdyb3RlOg0KPiBGcm9tOiBNYXR0aGlhcyBCcnVnZ2VyIDxtYnJ1 Z2dlckBzdXNlLmNvbT4NCj4gDQo+IFN3aXRjaCBwcm9iaW5nIGZvciB0aGUgTU1TWVMgdG8gc3Vw cG9ydCBpbnZvY2F0aW9uIHRvIGENCj4gcGxhaW4gcGFsdGZvcm0gZGV2aWNlLiBUaGUgZHJpdmVy IHdpbGwgYmUgcHJvYmVkIGJ5IHRoZSBEUk0gc3Vic3lzdGVtLg0KPiANCj4gU2luZ2VkLW9mZi1i eTogTWF0dGhpYXMgQnJ1Z2dlciA8bWJydWdnZXJAc3VzZS5jb20+DQo+IC0tLQ0KPiAgZHJpdmVy cy9jbGsvbWVkaWF0ZWsvY2xrLW10ODE4My1tbS5jIHwgMzkgKysrKysrKysrKysrKysrKysrKy0t LS0tLS0tLQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDI3IGluc2VydGlvbnMoKyksIDEyIGRlbGV0aW9u cygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvY2xrL21lZGlhdGVrL2Nsay1tdDgxODMt bW0uYyBiL2RyaXZlcnMvY2xrL21lZGlhdGVrL2Nsay1tdDgxODMtbW0uYw0KPiBpbmRleCA3MjBj Njk2YjUwNmQuLmU2ZGNhZDE4ZDgxYSAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9jbGsvbWVkaWF0 ZWsvY2xrLW10ODE4My1tbS5jDQo+ICsrKyBiL2RyaXZlcnMvY2xrL21lZGlhdGVrL2Nsay1tdDgx ODMtbW0uYw0KPiBAQCAtMywxNCArMywyMCBAQA0KPiAgLy8gQ29weXJpZ2h0IChjKSAyMDE4IE1l ZGlhVGVrIEluYy4NCj4gIC8vIEF1dGhvcjogV2VpeWkgTHUgPHdlaXlpLmx1QG1lZGlhdGVrLmNv bT4NCj4gIA0KPiArI2luY2x1ZGUgPGxpbnV4L21vZHVsZS5oPg0KPiAgI2luY2x1ZGUgPGxpbnV4 L2Nsay1wcm92aWRlci5oPg0KPiAgI2luY2x1ZGUgPGxpbnV4L3BsYXRmb3JtX2RldmljZS5oPg0K PiArI2luY2x1ZGUgPGxpbnV4L3NsYWIuaD4NCj4gIA0KPiAgI2luY2x1ZGUgImNsay1tdGsuaCIN Cj4gICNpbmNsdWRlICJjbGstZ2F0ZS5oIg0KPiAgDQo+ICAjaW5jbHVkZSA8ZHQtYmluZGluZ3Mv Y2xvY2svbXQ4MTgzLWNsay5oPg0KPiAgDQo+ICtzdHJ1Y3QgY2xrX210ODE4M19tbV9wcml2IHsN Cj4gKwlzdHJ1Y3QgY2xrX29uZWNlbGxfZGF0YSAqY2xrX2RhdGE7DQo+ICt9Ow0KPiArDQo+ICBz dGF0aWMgY29uc3Qgc3RydWN0IG10a19nYXRlX3JlZ3MgbW0wX2NnX3JlZ3MgPSB7DQo+ICAJLnNl dF9vZnMgPSAweDEwNCwNCj4gIAkuY2xyX29mcyA9IDB4MTA4LA0KPiBAQCAtODQsMjggKzkwLDM3 IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgbXRrX2dhdGUgbW1fY2xrc1tdID0gew0KPiAgDQo+ICBz dGF0aWMgaW50IGNsa19tdDgxODNfbW1fcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRl dikNCj4gIHsNCj4gLQlzdHJ1Y3QgY2xrX29uZWNlbGxfZGF0YSAqY2xrX2RhdGE7DQo+IC0Jc3Ry dWN0IGRldmljZV9ub2RlICpub2RlID0gcGRldi0+ZGV2Lm9mX25vZGU7DQo+ICsJc3RydWN0IGNs a19tdDgxODNfbW1fcHJpdiAqcHJpdmF0ZTsNCj4gKwlzdHJ1Y3QgZGV2aWNlX25vZGUgKm5vZGUg PSBwZGV2LT5kZXYucGFyZW50LT5vZl9ub2RlOw0KPiArDQo+ICsJcHJpdmF0ZSA9IGRldm1fa3ph bGxvYygmcGRldi0+ZGV2LCBzaXplb2YoKnByaXZhdGUpLCBHRlBfS0VSTkVMKTsNCj4gKwlpZiAo IXByaXZhdGUpDQo+ICsJCXJldHVybiAtRU5PTUVNOw0KPiAgDQo+IC0JY2xrX2RhdGEgPSBtdGtf YWxsb2NfY2xrX2RhdGEoQ0xLX01NX05SX0NMSyk7DQo+ICsJcHJpdmF0ZS0+Y2xrX2RhdGEgPSBt dGtfYWxsb2NfY2xrX2RhdGEoQ0xLX01NX05SX0NMSyk7DQo+ICsJcGxhdGZvcm1fc2V0X2RydmRh dGEocGRldiwgcHJpdmF0ZSk7DQoNClRoZXJlIGlzIGEgbW9yZSBzaW1wbGUgbW9kaWZpY2F0aW9u IHRoYXQgeW91IG5lZWQgbm90IHRvIGRlZmluZSBzdHJ1Y3QNCmNsa19tdDgxODNfbW1fcHJpdiwN Cg0KY2xrX2RhdGEgPSBtdGtfYWxsb2NfY2xrX2RhdGEoQ0xLX01NX05SX0NMSyk7DQpwbGF0Zm9y bV9zZXRfZHJ2ZGF0YShwZGV2LCBjbGtfZGF0YSk7DQoNClJlZ2FyZHMsDQpDSw0KDQo+ICANCj4g IAltdGtfY2xrX3JlZ2lzdGVyX2dhdGVzKG5vZGUsIG1tX2Nsa3MsIEFSUkFZX1NJWkUobW1fY2xr cyksDQo+IC0JCQljbGtfZGF0YSk7DQo+ICsJCQlwcml2YXRlLT5jbGtfZGF0YSk7DQo+ICANCj4g LQlyZXR1cm4gb2ZfY2xrX2FkZF9wcm92aWRlcihub2RlLCBvZl9jbGtfc3JjX29uZWNlbGxfZ2V0 LCBjbGtfZGF0YSk7DQo+ICsJcmV0dXJuIG9mX2Nsa19hZGRfcHJvdmlkZXIobm9kZSwgb2ZfY2xr X3NyY19vbmVjZWxsX2dldCwNCj4gKwkJCXByaXZhdGUtPmNsa19kYXRhKTsNCj4gIH0NCj4gIA0K PiAtc3RhdGljIGNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQgb2ZfbWF0Y2hfY2xrX210ODE4M19t bVtdID0gew0KPiAtCXsgLmNvbXBhdGlibGUgPSAibWVkaWF0ZWssbXQ4MTgzLW1tc3lzIiwgfSwN Cj4gLQl7fQ0KPiAtfTsNCj4gK3N0YXRpYyBpbnQgY2xrX210ODE4M19tbV9yZW1vdmUoc3RydWN0 IHBsYXRmb3JtX2RldmljZSAqcGRldikNCj4gK3sNCj4gKwlzdHJ1Y3QgY2xrX210ODE4M19tbV9w cml2ICpwcml2YXRlID0gcGxhdGZvcm1fZ2V0X2RydmRhdGEocGRldik7DQo+ICsNCj4gKwlrZnJl ZShwcml2YXRlLT5jbGtfZGF0YSk7DQo+ICsNCj4gKwlyZXR1cm4gMDsNCj4gK30NCj4gIA0KPiAg c3RhdGljIHN0cnVjdCBwbGF0Zm9ybV9kcml2ZXIgY2xrX210ODE4M19tbV9kcnYgPSB7DQo+ICAJ LnByb2JlID0gY2xrX210ODE4M19tbV9wcm9iZSwNCj4gKwkucmVtb3ZlID0gY2xrX210ODE4M19t bV9yZW1vdmUsDQo+ICAJLmRyaXZlciA9IHsNCj4gIAkJLm5hbWUgPSAiY2xrLW10ODE4My1tbSIs DQo+IC0JCS5vZl9tYXRjaF90YWJsZSA9IG9mX21hdGNoX2Nsa19tdDgxODNfbW0sDQo+ICAJfSwN Cj4gIH07DQo+IC0NCj4gLWJ1aWx0aW5fcGxhdGZvcm1fZHJpdmVyKGNsa19tdDgxODNfbW1fZHJ2 KTsNCj4gK21vZHVsZV9wbGF0Zm9ybV9kcml2ZXIoY2xrX210ODE4M19tbV9kcnYpOw0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DA6CC2D0C0 for ; Mon, 9 Dec 2019 08:51:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0392F207FF for ; Mon, 9 Dec 2019 08:51:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="B16pJ3NM"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="P1xvWC6H" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0392F207FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oTogsZRiq4oAQRGc4L+3RnXzFVhrq7ff20NGLm0FjYo=; b=B16pJ3NM+8MJmY m7tgrHlSgiyNJN4gCPzcWYECQfKw7kVf6gylggBD5YQhxgsd/JvylqDWTvasMiskPq3kdWf87ley9 zNVGedNQnGyVTkp0njlTyeUqFhtrC/F1PpB5Nzn40c1EuZeOFG0TQYwMTNg7j8D3ZHN5Jxmdr2hqz xjaAvWxpFbz2ffVEkO8AXoCABB8GJZvSSZH4z6YWF2L38VPd8gr+pyscheemZE9CRp7MlYwsfF4fR CdCD+paMqfUS7zkQt05UquGitn2/Kh/yrOc+cBj+iP1BQ1wBfN5V7MSqefCvF/5OjgriscQWEYtM+ p2/5zY/D4zV1CX90+0nw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ieElP-0005Ws-Kl; Mon, 09 Dec 2019 08:51:31 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ieElM-0005WD-MR; Mon, 09 Dec 2019 08:51:30 +0000 X-UUID: 1e711ad201c34c7fa79c6174845fa194-20191209 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=Xr2/g3CmQSCe7XSe29tjEitMS2VOZyuM620kmLXWO6Q=; b=P1xvWC6HDaWhqgmYSncCgQAH8w+XZKpkMz44/oBFhr3zDee4L99O/yiaD85cTEOn8EXnEagEfkFkVPxxVmnbqNJOMLxJS/m3Gz9GOeQyUnuS9vcBkk7Dcx0jEiaGsAWnzwfrYy3zLCfeFRAqBT9QE8qDuQWL09gK29ybu4yV3ig=; X-UUID: 1e711ad201c34c7fa79c6174845fa194-20191209 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1497410360; Mon, 09 Dec 2019 00:51:20 -0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 9 Dec 2019 00:52:19 -0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 9 Dec 2019 16:51:03 +0800 Message-ID: <1575881471.14479.2.camel@mtksdaap41> Subject: Re: [resend PATCH v6 10/12] clk: mediatek: mt8183: switch mmsys to platform device probing From: CK Hu To: Date: Mon, 9 Dec 2019 16:51:11 +0800 In-Reply-To: <20191207224740.24536-11-matthias.bgg@kernel.org> References: <20191207224740.24536-1-matthias.bgg@kernel.org> <20191207224740.24536-11-matthias.bgg@kernel.org> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191209_005128_740836_EBBF505D X-CRM114-Status: GOOD ( 13.09 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, rdunlap@infradead.org, airlied@linux.ie, mturquette@baylibre.com, dri-devel@lists.freedesktop.org, laurent.pinchart@ideasonboard.com, ulrich.hecht+renesas@gmail.com, linux-clk@vger.kernel.org, drinkcat@chromium.org, wens@csie.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, frank-w@public-files.de, sean.wang@mediatek.com, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, hsinyi@chromium.org, linux-arm-kernel@lists.infradead.org, mbrugger@suse.com, sboyd@kernel.org, sean.wang@kernel.org, linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, enric.balletbo@collabora.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi, Matthias: On Sat, 2019-12-07 at 23:47 +0100, matthias.bgg@kernel.org wrote: > From: Matthias Brugger > > Switch probing for the MMSYS to support invocation to a > plain paltform device. The driver will be probed by the DRM subsystem. > > Singed-off-by: Matthias Brugger > --- > drivers/clk/mediatek/clk-mt8183-mm.c | 39 +++++++++++++++++++--------- > 1 file changed, 27 insertions(+), 12 deletions(-) > > diff --git a/drivers/clk/mediatek/clk-mt8183-mm.c b/drivers/clk/mediatek/clk-mt8183-mm.c > index 720c696b506d..e6dcad18d81a 100644 > --- a/drivers/clk/mediatek/clk-mt8183-mm.c > +++ b/drivers/clk/mediatek/clk-mt8183-mm.c > @@ -3,14 +3,20 @@ > // Copyright (c) 2018 MediaTek Inc. > // Author: Weiyi Lu > > +#include > #include > #include > +#include > > #include "clk-mtk.h" > #include "clk-gate.h" > > #include > > +struct clk_mt8183_mm_priv { > + struct clk_onecell_data *clk_data; > +}; > + > static const struct mtk_gate_regs mm0_cg_regs = { > .set_ofs = 0x104, > .clr_ofs = 0x108, > @@ -84,28 +90,37 @@ static const struct mtk_gate mm_clks[] = { > > static int clk_mt8183_mm_probe(struct platform_device *pdev) > { > - struct clk_onecell_data *clk_data; > - struct device_node *node = pdev->dev.of_node; > + struct clk_mt8183_mm_priv *private; > + struct device_node *node = pdev->dev.parent->of_node; > + > + private = devm_kzalloc(&pdev->dev, sizeof(*private), GFP_KERNEL); > + if (!private) > + return -ENOMEM; > > - clk_data = mtk_alloc_clk_data(CLK_MM_NR_CLK); > + private->clk_data = mtk_alloc_clk_data(CLK_MM_NR_CLK); > + platform_set_drvdata(pdev, private); There is a more simple modification that you need not to define struct clk_mt8183_mm_priv, clk_data = mtk_alloc_clk_data(CLK_MM_NR_CLK); platform_set_drvdata(pdev, clk_data); Regards, CK > > mtk_clk_register_gates(node, mm_clks, ARRAY_SIZE(mm_clks), > - clk_data); > + private->clk_data); > > - return of_clk_add_provider(node, of_clk_src_onecell_get, clk_data); > + return of_clk_add_provider(node, of_clk_src_onecell_get, > + private->clk_data); > } > > -static const struct of_device_id of_match_clk_mt8183_mm[] = { > - { .compatible = "mediatek,mt8183-mmsys", }, > - {} > -}; > +static int clk_mt8183_mm_remove(struct platform_device *pdev) > +{ > + struct clk_mt8183_mm_priv *private = platform_get_drvdata(pdev); > + > + kfree(private->clk_data); > + > + return 0; > +} > > static struct platform_driver clk_mt8183_mm_drv = { > .probe = clk_mt8183_mm_probe, > + .remove = clk_mt8183_mm_remove, > .driver = { > .name = "clk-mt8183-mm", > - .of_match_table = of_match_clk_mt8183_mm, > }, > }; > - > -builtin_platform_driver(clk_mt8183_mm_drv); > +module_platform_driver(clk_mt8183_mm_drv); _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84ABCC2BD09 for ; Mon, 9 Dec 2019 08:51:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59DF8207FF for ; Mon, 9 Dec 2019 08:51:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mS123ZT8"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="P1xvWC6H" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59DF8207FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DsWo0j59nBcGsbQ8KsmhBkzoH0MHiTn4c9R7xza+l54=; b=mS123ZT8hJNVsF R7JysIEBnsUjTxvxsWPfeXG6RHKkT8FYgQzV/bRLC/q+sj0oipMuDAssWFMaojuxFDhtosUQ4QD7y H4xdHfigZ2bnH3ce5kZDnnQV2idjo0LM4gGClwBDO4ZnlJGVHFAl1YWS1IsP3NYF6gYXkHjHyO6N3 2nJZx628eCVQywpZgTaXhI+Z5qD+8Qw75oS7ebwO/lZ+xtMd83L2P4bee31w2YsvrsrAwFdDxkOu0 6dPfGFAA6IQ+rkpIoNm2em6lA/UtTYzI4QRwDv1S6BOI+4rBlxoSTnL/VIW5Lc5cqDudxRkHaIvk6 uAFj/1O5qA8WuP9O1JrQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ieElQ-0005XY-M3; Mon, 09 Dec 2019 08:51:32 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ieElM-0005WD-MR; Mon, 09 Dec 2019 08:51:30 +0000 X-UUID: 1e711ad201c34c7fa79c6174845fa194-20191209 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=Xr2/g3CmQSCe7XSe29tjEitMS2VOZyuM620kmLXWO6Q=; b=P1xvWC6HDaWhqgmYSncCgQAH8w+XZKpkMz44/oBFhr3zDee4L99O/yiaD85cTEOn8EXnEagEfkFkVPxxVmnbqNJOMLxJS/m3Gz9GOeQyUnuS9vcBkk7Dcx0jEiaGsAWnzwfrYy3zLCfeFRAqBT9QE8qDuQWL09gK29ybu4yV3ig=; X-UUID: 1e711ad201c34c7fa79c6174845fa194-20191209 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1497410360; Mon, 09 Dec 2019 00:51:20 -0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 9 Dec 2019 00:52:19 -0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 9 Dec 2019 16:51:03 +0800 Message-ID: <1575881471.14479.2.camel@mtksdaap41> Subject: Re: [resend PATCH v6 10/12] clk: mediatek: mt8183: switch mmsys to platform device probing From: CK Hu To: Date: Mon, 9 Dec 2019 16:51:11 +0800 In-Reply-To: <20191207224740.24536-11-matthias.bgg@kernel.org> References: <20191207224740.24536-1-matthias.bgg@kernel.org> <20191207224740.24536-11-matthias.bgg@kernel.org> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191209_005128_740836_EBBF505D X-CRM114-Status: GOOD ( 13.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, rdunlap@infradead.org, airlied@linux.ie, mturquette@baylibre.com, dri-devel@lists.freedesktop.org, laurent.pinchart@ideasonboard.com, ulrich.hecht+renesas@gmail.com, linux-clk@vger.kernel.org, drinkcat@chromium.org, wens@csie.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, frank-w@public-files.de, sean.wang@mediatek.com, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, hsinyi@chromium.org, linux-arm-kernel@lists.infradead.org, mbrugger@suse.com, sboyd@kernel.org, sean.wang@kernel.org, linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, enric.balletbo@collabora.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Matthias: On Sat, 2019-12-07 at 23:47 +0100, matthias.bgg@kernel.org wrote: > From: Matthias Brugger > > Switch probing for the MMSYS to support invocation to a > plain paltform device. The driver will be probed by the DRM subsystem. > > Singed-off-by: Matthias Brugger > --- > drivers/clk/mediatek/clk-mt8183-mm.c | 39 +++++++++++++++++++--------- > 1 file changed, 27 insertions(+), 12 deletions(-) > > diff --git a/drivers/clk/mediatek/clk-mt8183-mm.c b/drivers/clk/mediatek/clk-mt8183-mm.c > index 720c696b506d..e6dcad18d81a 100644 > --- a/drivers/clk/mediatek/clk-mt8183-mm.c > +++ b/drivers/clk/mediatek/clk-mt8183-mm.c > @@ -3,14 +3,20 @@ > // Copyright (c) 2018 MediaTek Inc. > // Author: Weiyi Lu > > +#include > #include > #include > +#include > > #include "clk-mtk.h" > #include "clk-gate.h" > > #include > > +struct clk_mt8183_mm_priv { > + struct clk_onecell_data *clk_data; > +}; > + > static const struct mtk_gate_regs mm0_cg_regs = { > .set_ofs = 0x104, > .clr_ofs = 0x108, > @@ -84,28 +90,37 @@ static const struct mtk_gate mm_clks[] = { > > static int clk_mt8183_mm_probe(struct platform_device *pdev) > { > - struct clk_onecell_data *clk_data; > - struct device_node *node = pdev->dev.of_node; > + struct clk_mt8183_mm_priv *private; > + struct device_node *node = pdev->dev.parent->of_node; > + > + private = devm_kzalloc(&pdev->dev, sizeof(*private), GFP_KERNEL); > + if (!private) > + return -ENOMEM; > > - clk_data = mtk_alloc_clk_data(CLK_MM_NR_CLK); > + private->clk_data = mtk_alloc_clk_data(CLK_MM_NR_CLK); > + platform_set_drvdata(pdev, private); There is a more simple modification that you need not to define struct clk_mt8183_mm_priv, clk_data = mtk_alloc_clk_data(CLK_MM_NR_CLK); platform_set_drvdata(pdev, clk_data); Regards, CK > > mtk_clk_register_gates(node, mm_clks, ARRAY_SIZE(mm_clks), > - clk_data); > + private->clk_data); > > - return of_clk_add_provider(node, of_clk_src_onecell_get, clk_data); > + return of_clk_add_provider(node, of_clk_src_onecell_get, > + private->clk_data); > } > > -static const struct of_device_id of_match_clk_mt8183_mm[] = { > - { .compatible = "mediatek,mt8183-mmsys", }, > - {} > -}; > +static int clk_mt8183_mm_remove(struct platform_device *pdev) > +{ > + struct clk_mt8183_mm_priv *private = platform_get_drvdata(pdev); > + > + kfree(private->clk_data); > + > + return 0; > +} > > static struct platform_driver clk_mt8183_mm_drv = { > .probe = clk_mt8183_mm_probe, > + .remove = clk_mt8183_mm_remove, > .driver = { > .name = "clk-mt8183-mm", > - .of_match_table = of_match_clk_mt8183_mm, > }, > }; > - > -builtin_platform_driver(clk_mt8183_mm_drv); > +module_platform_driver(clk_mt8183_mm_drv); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2205C2BD09 for ; Mon, 9 Dec 2019 08:51:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE5492073D for ; Mon, 9 Dec 2019 08:51:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE5492073D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 165106E0C4; Mon, 9 Dec 2019 08:51:24 +0000 (UTC) Received: from mailgw02.mediatek.com (mailgw02.mediatek.com [216.200.240.185]) by gabe.freedesktop.org (Postfix) with ESMTPS id C18406E0C4 for ; Mon, 9 Dec 2019 08:51:22 +0000 (UTC) X-UUID: ff33343a19fb4fcc9e4480a7861245f0-20191209 X-UUID: ff33343a19fb4fcc9e4480a7861245f0-20191209 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1426792079; Mon, 09 Dec 2019 00:51:20 -0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 9 Dec 2019 00:52:19 -0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 9 Dec 2019 16:51:03 +0800 Message-ID: <1575881471.14479.2.camel@mtksdaap41> Subject: Re: [resend PATCH v6 10/12] clk: mediatek: mt8183: switch mmsys to platform device probing From: CK Hu To: Date: Mon, 9 Dec 2019 16:51:11 +0800 In-Reply-To: <20191207224740.24536-11-matthias.bgg@kernel.org> References: <20191207224740.24536-1-matthias.bgg@kernel.org> <20191207224740.24536-11-matthias.bgg@kernel.org> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=Xr2/g3CmQSCe7XSe29tjEitMS2VOZyuM620kmLXWO6Q=; b=P1xvWC6HDaWhqgmYSncCgQAH8w+XZKpkMz44/oBFhr3zDee4L99O/yiaD85cTEOn8EXnEagEfkFkVPxxVmnbqNJOMLxJS/m3Gz9GOeQyUnuS9vcBkk7Dcx0jEiaGsAWnzwfrYy3zLCfeFRAqBT9QE8qDuQWL09gK29ybu4yV3ig=; X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, rdunlap@infradead.org, airlied@linux.ie, mturquette@baylibre.com, dri-devel@lists.freedesktop.org, laurent.pinchart@ideasonboard.com, ulrich.hecht+renesas@gmail.com, linux-clk@vger.kernel.org, drinkcat@chromium.org, wens@csie.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, frank-w@public-files.de, sean.wang@mediatek.com, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, hsinyi@chromium.org, linux-arm-kernel@lists.infradead.org, mbrugger@suse.com, sboyd@kernel.org, sean.wang@kernel.org, linux-kernel@vger.kernel.org, enric.balletbo@collabora.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGksIE1hdHRoaWFzOg0KDQpPbiBTYXQsIDIwMTktMTItMDcgYXQgMjM6NDcgKzAxMDAsIG1hdHRo aWFzLmJnZ0BrZXJuZWwub3JnIHdyb3RlOg0KPiBGcm9tOiBNYXR0aGlhcyBCcnVnZ2VyIDxtYnJ1 Z2dlckBzdXNlLmNvbT4NCj4gDQo+IFN3aXRjaCBwcm9iaW5nIGZvciB0aGUgTU1TWVMgdG8gc3Vw cG9ydCBpbnZvY2F0aW9uIHRvIGENCj4gcGxhaW4gcGFsdGZvcm0gZGV2aWNlLiBUaGUgZHJpdmVy IHdpbGwgYmUgcHJvYmVkIGJ5IHRoZSBEUk0gc3Vic3lzdGVtLg0KPiANCj4gU2luZ2VkLW9mZi1i eTogTWF0dGhpYXMgQnJ1Z2dlciA8bWJydWdnZXJAc3VzZS5jb20+DQo+IC0tLQ0KPiAgZHJpdmVy cy9jbGsvbWVkaWF0ZWsvY2xrLW10ODE4My1tbS5jIHwgMzkgKysrKysrKysrKysrKysrKysrKy0t LS0tLS0tLQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDI3IGluc2VydGlvbnMoKyksIDEyIGRlbGV0aW9u cygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvY2xrL21lZGlhdGVrL2Nsay1tdDgxODMt bW0uYyBiL2RyaXZlcnMvY2xrL21lZGlhdGVrL2Nsay1tdDgxODMtbW0uYw0KPiBpbmRleCA3MjBj Njk2YjUwNmQuLmU2ZGNhZDE4ZDgxYSAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9jbGsvbWVkaWF0 ZWsvY2xrLW10ODE4My1tbS5jDQo+ICsrKyBiL2RyaXZlcnMvY2xrL21lZGlhdGVrL2Nsay1tdDgx ODMtbW0uYw0KPiBAQCAtMywxNCArMywyMCBAQA0KPiAgLy8gQ29weXJpZ2h0IChjKSAyMDE4IE1l ZGlhVGVrIEluYy4NCj4gIC8vIEF1dGhvcjogV2VpeWkgTHUgPHdlaXlpLmx1QG1lZGlhdGVrLmNv bT4NCj4gIA0KPiArI2luY2x1ZGUgPGxpbnV4L21vZHVsZS5oPg0KPiAgI2luY2x1ZGUgPGxpbnV4 L2Nsay1wcm92aWRlci5oPg0KPiAgI2luY2x1ZGUgPGxpbnV4L3BsYXRmb3JtX2RldmljZS5oPg0K PiArI2luY2x1ZGUgPGxpbnV4L3NsYWIuaD4NCj4gIA0KPiAgI2luY2x1ZGUgImNsay1tdGsuaCIN Cj4gICNpbmNsdWRlICJjbGstZ2F0ZS5oIg0KPiAgDQo+ICAjaW5jbHVkZSA8ZHQtYmluZGluZ3Mv Y2xvY2svbXQ4MTgzLWNsay5oPg0KPiAgDQo+ICtzdHJ1Y3QgY2xrX210ODE4M19tbV9wcml2IHsN Cj4gKwlzdHJ1Y3QgY2xrX29uZWNlbGxfZGF0YSAqY2xrX2RhdGE7DQo+ICt9Ow0KPiArDQo+ICBz dGF0aWMgY29uc3Qgc3RydWN0IG10a19nYXRlX3JlZ3MgbW0wX2NnX3JlZ3MgPSB7DQo+ICAJLnNl dF9vZnMgPSAweDEwNCwNCj4gIAkuY2xyX29mcyA9IDB4MTA4LA0KPiBAQCAtODQsMjggKzkwLDM3 IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgbXRrX2dhdGUgbW1fY2xrc1tdID0gew0KPiAgDQo+ICBz dGF0aWMgaW50IGNsa19tdDgxODNfbW1fcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRl dikNCj4gIHsNCj4gLQlzdHJ1Y3QgY2xrX29uZWNlbGxfZGF0YSAqY2xrX2RhdGE7DQo+IC0Jc3Ry dWN0IGRldmljZV9ub2RlICpub2RlID0gcGRldi0+ZGV2Lm9mX25vZGU7DQo+ICsJc3RydWN0IGNs a19tdDgxODNfbW1fcHJpdiAqcHJpdmF0ZTsNCj4gKwlzdHJ1Y3QgZGV2aWNlX25vZGUgKm5vZGUg PSBwZGV2LT5kZXYucGFyZW50LT5vZl9ub2RlOw0KPiArDQo+ICsJcHJpdmF0ZSA9IGRldm1fa3ph bGxvYygmcGRldi0+ZGV2LCBzaXplb2YoKnByaXZhdGUpLCBHRlBfS0VSTkVMKTsNCj4gKwlpZiAo IXByaXZhdGUpDQo+ICsJCXJldHVybiAtRU5PTUVNOw0KPiAgDQo+IC0JY2xrX2RhdGEgPSBtdGtf YWxsb2NfY2xrX2RhdGEoQ0xLX01NX05SX0NMSyk7DQo+ICsJcHJpdmF0ZS0+Y2xrX2RhdGEgPSBt dGtfYWxsb2NfY2xrX2RhdGEoQ0xLX01NX05SX0NMSyk7DQo+ICsJcGxhdGZvcm1fc2V0X2RydmRh dGEocGRldiwgcHJpdmF0ZSk7DQoNClRoZXJlIGlzIGEgbW9yZSBzaW1wbGUgbW9kaWZpY2F0aW9u IHRoYXQgeW91IG5lZWQgbm90IHRvIGRlZmluZSBzdHJ1Y3QNCmNsa19tdDgxODNfbW1fcHJpdiwN Cg0KY2xrX2RhdGEgPSBtdGtfYWxsb2NfY2xrX2RhdGEoQ0xLX01NX05SX0NMSyk7DQpwbGF0Zm9y bV9zZXRfZHJ2ZGF0YShwZGV2LCBjbGtfZGF0YSk7DQoNClJlZ2FyZHMsDQpDSw0KDQo+ICANCj4g IAltdGtfY2xrX3JlZ2lzdGVyX2dhdGVzKG5vZGUsIG1tX2Nsa3MsIEFSUkFZX1NJWkUobW1fY2xr cyksDQo+IC0JCQljbGtfZGF0YSk7DQo+ICsJCQlwcml2YXRlLT5jbGtfZGF0YSk7DQo+ICANCj4g LQlyZXR1cm4gb2ZfY2xrX2FkZF9wcm92aWRlcihub2RlLCBvZl9jbGtfc3JjX29uZWNlbGxfZ2V0 LCBjbGtfZGF0YSk7DQo+ICsJcmV0dXJuIG9mX2Nsa19hZGRfcHJvdmlkZXIobm9kZSwgb2ZfY2xr X3NyY19vbmVjZWxsX2dldCwNCj4gKwkJCXByaXZhdGUtPmNsa19kYXRhKTsNCj4gIH0NCj4gIA0K PiAtc3RhdGljIGNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQgb2ZfbWF0Y2hfY2xrX210ODE4M19t bVtdID0gew0KPiAtCXsgLmNvbXBhdGlibGUgPSAibWVkaWF0ZWssbXQ4MTgzLW1tc3lzIiwgfSwN Cj4gLQl7fQ0KPiAtfTsNCj4gK3N0YXRpYyBpbnQgY2xrX210ODE4M19tbV9yZW1vdmUoc3RydWN0 IHBsYXRmb3JtX2RldmljZSAqcGRldikNCj4gK3sNCj4gKwlzdHJ1Y3QgY2xrX210ODE4M19tbV9w cml2ICpwcml2YXRlID0gcGxhdGZvcm1fZ2V0X2RydmRhdGEocGRldik7DQo+ICsNCj4gKwlrZnJl ZShwcml2YXRlLT5jbGtfZGF0YSk7DQo+ICsNCj4gKwlyZXR1cm4gMDsNCj4gK30NCj4gIA0KPiAg c3RhdGljIHN0cnVjdCBwbGF0Zm9ybV9kcml2ZXIgY2xrX210ODE4M19tbV9kcnYgPSB7DQo+ICAJ LnByb2JlID0gY2xrX210ODE4M19tbV9wcm9iZSwNCj4gKwkucmVtb3ZlID0gY2xrX210ODE4M19t bV9yZW1vdmUsDQo+ICAJLmRyaXZlciA9IHsNCj4gIAkJLm5hbWUgPSAiY2xrLW10ODE4My1tbSIs DQo+IC0JCS5vZl9tYXRjaF90YWJsZSA9IG9mX21hdGNoX2Nsa19tdDgxODNfbW0sDQo+ICAJfSwN Cj4gIH07DQo+IC0NCj4gLWJ1aWx0aW5fcGxhdGZvcm1fZHJpdmVyKGNsa19tdDgxODNfbW1fZHJ2 KTsNCj4gK21vZHVsZV9wbGF0Zm9ybV9kcml2ZXIoY2xrX210ODE4M19tbV9kcnYpOw0KDQpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=