From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88815C2D0C7 for ; Wed, 11 Dec 2019 21:33:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 67C0C222C4 for ; Wed, 11 Dec 2019 21:33:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 67C0C222C4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1BE286EBF8; Wed, 11 Dec 2019 21:33:45 +0000 (UTC) Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 236366EBF8 for ; Wed, 11 Dec 2019 21:33:42 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 19547394-1500050 for multiple; Wed, 11 Dec 2019 21:33:12 +0000 MIME-Version: 1.0 To: Daniele Ceraolo Spurio , intel-gfx@lists.freedesktop.org From: Chris Wilson In-Reply-To: <157609925197.27099.7914911837320369934@skylake-alporthouse-com> References: <20191211211244.7831-1-daniele.ceraolospurio@intel.com> <20191211211244.7831-2-daniele.ceraolospurio@intel.com> <157609925197.27099.7914911837320369934@skylake-alporthouse-com> Message-ID: <157609999216.27099.10632108353946439815@skylake-alporthouse-com> User-Agent: alot/0.6 Date: Wed, 11 Dec 2019 21:33:12 +0000 Subject: Re: [Intel-gfx] [RFC 1/5] drm/i915: introduce logical_ring and lr_context naming X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Chris Wilson (2019-12-11 21:20:52) > Quoting Daniele Ceraolo Spurio (2019-12-11 21:12:40) > > +static void lr_context_init_reg_state(u32 *reg_state, > > + const struct intel_context *ce, > > + const struct intel_engine_cs *engine, > > + const struct intel_ring *ring, > > + bool close); > > lrc. lrc should just be the register offsets and default context image. Fwiw, I also put the w/a batch buffers into intel_lrc.c as they seemed HW/lrc specific as opposed to being specialised for submission -- although we may want to do that at some point. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx