From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9EC5C2D0C9 for ; Thu, 12 Dec 2019 15:14:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 975EC205C9 for ; Thu, 12 Dec 2019 15:14:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="pLg+4cv2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729111AbfLLPOk (ORCPT ); Thu, 12 Dec 2019 10:14:40 -0500 Received: from mailgw02.mediatek.com ([216.200.240.185]:33650 "EHLO mailgw02.mediatek.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728818AbfLLPOj (ORCPT ); Thu, 12 Dec 2019 10:14:39 -0500 X-UUID: 570f561f5b0b4658a53dd63d9d56ad04-20191212 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=rc1N+2mn11vQnuHKJzeaj4YyfZJLE0LcAj+lNO1fVFk=; b=pLg+4cv2VvvAIXJsMEcXb85SuEhZhUu0t0/ywWL7GP+8QjX+TVcjrX+V1YNcITaWjq3tL4HEArB6rS7yoU4s5ZWqqOoGzttOuyKW1WieABsuoVR1JyP4Sz+rYLtJomr06PZsAcDrjAf3XBDDudKKF8G6w1+Cu2gt8V1iHURkLY0=; X-UUID: 570f561f5b0b4658a53dd63d9d56ad04-20191212 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 607824229; Thu, 12 Dec 2019 07:14:35 -0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 12 Dec 2019 07:05:41 -0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 12 Dec 2019 23:04:30 +0800 Message-ID: <1576163072.18168.0.camel@mtksdccf07> Subject: Re: [PATCH net-next 4/6] net: dsa: mt7530: Add the support of MT7531 switch From: Landen Chao To: Andrew Lunn CC: "f.fainelli@gmail.com" , "vivien.didelot@savoirfairelinux.com" , "matthias.bgg@gmail.com" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "davem@davemloft.net" , Sean Wang , "opensource@vdorst.com" , "frank-w@public-files.de" Date: Thu, 12 Dec 2019 23:04:32 +0800 In-Reply-To: <20191211192703.GC30053@lunn.ch> References: <6d608dd024edc90b09ba4fe35417b693847f973c.1575914275.git.landen.chao@mediatek.com> <20191210164438.GD27714@lunn.ch> <1576088280.23763.73.camel@mtksdccf07> <20191211192703.GC30053@lunn.ch> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gVGh1LCAyMDE5LTEyLTEyIGF0IDAzOjI3ICswODAwLCBBbmRyZXcgTHVubiB3cm90ZToNCj4g PiBEbyB5b3UgYWxzbyBoaW50IGF0IHVzaW5nIHRoZSBzYW1lIG51bWJlciBvZiBwYXJhbWV0ZXJz IGZvcg0KPiA+IG10NzUzMV9pbmRfYzIyX3BoeV9yZWFkKCkgYW5kIG10NzUzMV9pbmRfYzQ1X3Bo eV9yZWFkKCk/DQo+IA0KPiBUaGF0IGlzIHVwIHRvIHlvdS4gSXQganVzdCBzZWVtcyBsaWtlIHlv dXIgTURJTyBidXMgY2FuIGRvIGJvdGggQzIyDQo+IGFuZCBDNDUuIEFuZCBzb21lYm9keSBtaWdo dCBjb25uZWN0IGFuIGV4dGVybmFsIEM0NSBQSFksIHNvIHlvdSBtaWdodA0KPiBhcyB3ZWxsIHN1 cHBvcnQgaXQuDQpZZXMsIGl0IGlzIGJldHRlciB0byBzdXBwb3J0IGV4dGVybmFsIEM0NSBQSFku IFRoYW5rcyBmb3IgeW91ciBhZHZpY2UuDQoNCkxhbmRlbg0KPiANCj4gICAgQW5kcmV3DQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D009C43603 for ; Thu, 12 Dec 2019 15:08:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 739A32067C for ; Thu, 12 Dec 2019 15:08:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Jxe8HsFa"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="pLg+4cv2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 739A32067C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XCHMyZu2a66ZVCCGZtqOgoNzqzCdIo+Jb6dxS9jRFx8=; b=Jxe8HsFadCRCsL H3mleOeGIrZ4upQlsUtG2xxu5YmDmfMlfjZDyAXqZqZt3Cv5WfejQPO+us6Q4r5/oYWwTfjHae6w+ /qHvD2YGiVl/TuE8nYp+Oq062WU2WRRLgtFgMxDASVGTXBv5DOqw2CtdVsjgFgyrkuZIsO+HVlNsT JBHvUp3bZAiD6VrHMAWgJm8d5EcCBT3VG7qS+mCfU5oxM+/dmtn7OtGFP/AEPtf31zaiQLMb2jHV8 YK7fsWhO/kMxF5/2jggHJaA59e89UdwrGSqTc3nin837Ff/2GsErQmDx+cG6gSQ7+7nk6ass+8YaD rb9do8qFgWGjmj/P4aWA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifQ4Z-0002Tn-3A; Thu, 12 Dec 2019 15:08:11 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifQ4W-0002TB-0z for linux-mediatek@lists.infradead.org; Thu, 12 Dec 2019 15:08:09 +0000 X-UUID: 093160adcd2d460c8dddca3720c7be7b-20191212 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=rc1N+2mn11vQnuHKJzeaj4YyfZJLE0LcAj+lNO1fVFk=; b=pLg+4cv2VvvAIXJsMEcXb85SuEhZhUu0t0/ywWL7GP+8QjX+TVcjrX+V1YNcITaWjq3tL4HEArB6rS7yoU4s5ZWqqOoGzttOuyKW1WieABsuoVR1JyP4Sz+rYLtJomr06PZsAcDrjAf3XBDDudKKF8G6w1+Cu2gt8V1iHURkLY0=; X-UUID: 093160adcd2d460c8dddca3720c7be7b-20191212 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1180134537; Thu, 12 Dec 2019 07:08:06 -0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 12 Dec 2019 07:05:41 -0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 12 Dec 2019 23:04:30 +0800 Message-ID: <1576163072.18168.0.camel@mtksdccf07> Subject: Re: [PATCH net-next 4/6] net: dsa: mt7530: Add the support of MT7531 switch From: Landen Chao To: Andrew Lunn Date: Thu, 12 Dec 2019 23:04:32 +0800 In-Reply-To: <20191211192703.GC30053@lunn.ch> References: <6d608dd024edc90b09ba4fe35417b693847f973c.1575914275.git.landen.chao@mediatek.com> <20191210164438.GD27714@lunn.ch> <1576088280.23763.73.camel@mtksdccf07> <20191211192703.GC30053@lunn.ch> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191212_070808_070967_46624A0D X-CRM114-Status: UNSURE ( 6.56 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "frank-w@public-files.de" , "f.fainelli@gmail.com" , "vivien.didelot@savoirfairelinux.com" , "netdev@vger.kernel.org" , Sean Wang , "linux-kernel@vger.kernel.org" , "opensource@vdorst.com" , "robh+dt@kernel.org" , "linux-mediatek@lists.infradead.org" , "matthias.bgg@gmail.com" , "davem@davemloft.net" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, 2019-12-12 at 03:27 +0800, Andrew Lunn wrote: > > Do you also hint at using the same number of parameters for > > mt7531_ind_c22_phy_read() and mt7531_ind_c45_phy_read()? > > That is up to you. It just seems like your MDIO bus can do both C22 > and C45. And somebody might connect an external C45 PHY, so you might > as well support it. Yes, it is better to support external C45 PHY. Thanks for your advice. Landen > > Andrew _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek