From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B01FC3F68F for ; Fri, 13 Dec 2019 08:22:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3C86C2465A for ; Fri, 13 Dec 2019 08:22:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="E0OJZXP7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726518AbfLMIWs (ORCPT ); Fri, 13 Dec 2019 03:22:48 -0500 Received: from mailgw02.mediatek.com ([216.200.240.185]:60221 "EHLO mailgw02.mediatek.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725468AbfLMIWr (ORCPT ); Fri, 13 Dec 2019 03:22:47 -0500 X-UUID: 02c8eb1eb31443d59c20f316aad7c71e-20191213 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:Reply-To:From:Subject:Message-ID; bh=3iGzWvQ973vDVy2jTOS5BARL9ANWb/8ieSVfodrTkr4=; b=E0OJZXP7CFIIiOND7EZdxZ/6RSDw+BPQGnB2xYPTcp27ez2h0wA5iduHuekmT7ygbheSIjLwb1mXEZXyyf4Wd4ODg1++1KNEoiA7HLxuJJWNo4AqjNU7s4UDqjE2epMKL3nWHQBgnPrHlW7zJMAPge2J2RdTVbHEoeNlDYvTXlc=; X-UUID: 02c8eb1eb31443d59c20f316aad7c71e-20191213 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1009231870; Fri, 13 Dec 2019 00:22:45 -0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 13 Dec 2019 16:02:52 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 13 Dec 2019 16:03:11 +0800 Message-ID: <1576224191.31822.2.camel@mhfsdcap03> Subject: Re: [PATCH v2, 1/2] drm/mediatek: Fix gamma correction issue From: Yongqiang Niu Reply-To: Yongqiang Niu To: CK Hu CC: Philipp Zabel , Rob Herring , Matthias Brugger , "David Airlie" , Daniel Vetter , Mark Rutland , , , , , Date: Fri, 13 Dec 2019 16:03:11 +0800 In-Reply-To: <1576223336.9817.3.camel@mtksdaap41> References: <1576222132-31586-1-git-send-email-yongqiang.niu@mediatek.com> <1576222132-31586-2-git-send-email-yongqiang.niu@mediatek.com> <1576223336.9817.3.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gRnJpLCAyMDE5LTEyLTEzIGF0IDE1OjQ4ICswODAwLCBDSyBIdSB3cm90ZToNCj4gSGksIFlv bmdxaWFuZzoNCj4gDQo+IFRoZSB0aXRsZSBpcyB0b28gcm91Z2guIEFueSBidWcgb2YgZ2FtbWEg d291bGQgYmUgdGhpcyB0aXRsZS4gSSB3b3VsZA0KPiBsaWtlIHRoZSB0aXRsZSBzaG93IGV4cGxp Y2l0bHkgd2hhdCBpdCBkb2VzLg0KPiANCj4gT24gRnJpLCAyMDE5LTEyLTEzIGF0IDE1OjI4ICsw ODAwLCBZb25ncWlhbmcgTml1IHdyb3RlOg0KPiA+IGlmIHRoZXJlIGlzIG5vIGdhbW1hIGZ1bmN0 aW9uIGluIHRoZSBjcnRjDQo+ID4gZGlzcGxheSBwYXRoLCBkb24ndCBhZGQgZ2FtbWEgcHJvcGVy dHkNCj4gPiBmb3IgY3J0Yw0KPiA+IA0KPiA+IFNpZ25lZC1vZmYtYnk6IFlvbmdxaWFuZyBOaXUg PHlvbmdxaWFuZy5uaXVAbWVkaWF0ZWsuY29tPg0KPiA+IC0tLQ0KPiA+ICBkcml2ZXJzL2dwdS9k cm0vbWVkaWF0ZWsvbXRrX2RybV9jcnRjLmMgfCAxMCArKysrKysrKy0tDQo+ID4gIDEgZmlsZSBj aGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pDQo+ID4gDQo+ID4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2NydGMuYyBiL2RyaXZlcnMv Z3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2NydGMuYw0KPiA+IGluZGV4IGNhNGZjNDcuLjlhOGUx ZDQgMTAwNjQ0DQo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fY3J0 Yy5jDQo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fY3J0Yy5jDQo+ ID4gQEAgLTczNCw2ICs3MzQsNyBAQCBpbnQgbXRrX2RybV9jcnRjX2NyZWF0ZShzdHJ1Y3QgZHJt X2RldmljZSAqZHJtX2RldiwNCj4gPiAgCWludCBwaXBlID0gcHJpdi0+bnVtX3BpcGVzOw0KPiA+ ICAJaW50IHJldDsNCj4gPiAgCWludCBpOw0KPiA+ICsJdWludCBnYW1tYV9sdXRfc2l6ZSA9IDA7 DQo+ID4gIA0KPiA+ICAJaWYgKCFwYXRoKQ0KPiA+ICAJCXJldHVybiAwOw0KPiA+IEBAIC03ODUs NiArNzg2LDkgQEAgaW50IG10a19kcm1fY3J0Y19jcmVhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRy bV9kZXYsDQo+ID4gIAkJfQ0KPiA+ICANCj4gPiAgCQltdGtfY3J0Yy0+ZGRwX2NvbXBbaV0gPSBj b21wOw0KPiA+ICsNCj4gPiArCQlpZiAoY29tcC0+ZnVuY3MtPmdhbW1hX3NldCkNCj4gPiArCQkJ Z2FtbWFfbHV0X3NpemUgPSBNVEtfTFVUX1NJWkU7DQo+ID4gIAl9DQo+ID4gIA0KPiA+ICAJZm9y IChpID0gMDsgaSA8IG10a19jcnRjLT5kZHBfY29tcF9ucjsgaSsrKQ0KPiA+IEBAIC04MDUsOCAr ODA5LDEwIEBAIGludCBtdGtfZHJtX2NydGNfY3JlYXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkcm1f ZGV2LA0KPiA+ICAJCQkJTlVMTCwgcGlwZSk7DQo+ID4gIAlpZiAocmV0IDwgMCkNCj4gPiAgCQly ZXR1cm4gcmV0Ow0KPiA+IC0JZHJtX21vZGVfY3J0Y19zZXRfZ2FtbWFfc2l6ZSgmbXRrX2NydGMt PmJhc2UsIE1US19MVVRfU0laRSk7DQo+ID4gLQlkcm1fY3J0Y19lbmFibGVfY29sb3JfbWdtdCgm bXRrX2NydGMtPmJhc2UsIDAsIGZhbHNlLCBNVEtfTFVUX1NJWkUpOw0KPiA+ICsNCj4gPiArCWlm IChnYW1tYV9sdXRfc2l6ZSkNCj4gPiArCQlkcm1fbW9kZV9jcnRjX3NldF9nYW1tYV9zaXplKCZt dGtfY3J0Yy0+YmFzZSwgZ2FtbWFfbHV0X3NpemUpOw0KPiA+ICsJZHJtX2NydGNfZW5hYmxlX2Nv bG9yX21nbXQoJm10a19jcnRjLT5iYXNlLCAwLCBmYWxzZSwgZ2FtbWFfbHV0X3NpemUpOw0KPiAN Cj4gSWYgdGhlcmUgaXMgbm8gZ2FtbWEsIHNoYWxsIHdlIGVuYWJsZSBjb2xvciBtYW5hZ2VtZW50 Pw0KPiANCj4gUmVnYXJkcywNCj4gQ0sNCg0KZHJtX2NydGNfZW5hYmxlX2NvbG9yX21nbXQgd2ls bCBjaGVjayB0aGUgZ2FtbWFfbHV0X3NpemUgcGFyYW1ldGVyLA0KaWYgbm8gZ2FtbWEsIGdhbW1h X2x1dF9zaXplIHdpbGwgYmUgMCwgYW5kIGdhbW1hX2x1dF9zaXplIHdpbGwgbm90IGF0dGNoDQpn YW1tYSBwcm9wZXJ0eSBmb3IgdGhlIGNydGMNCj4gDQo+ID4gIAlwcml2LT5udW1fcGlwZXMrKzsN Cj4gPiAgCW11dGV4X2luaXQoJm10a19jcnRjLT5od19sb2NrKTsNCj4gPiAgDQo+IA0KPiANCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83D2CC43603 for ; Fri, 13 Dec 2019 08:03:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F10F206B7 for ; Fri, 13 Dec 2019 08:03:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="efal9N/X"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="Q8dA/9WQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F10F206B7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:References: In-Reply-To:Date:To:From:Subject:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xyw0A6dJAz0KTOENAxz9y0RfD0j4KSuyQzZEhYPD/Wc=; b=efal9N/XUHLDmA /+tQ6sLPwyAjSxgSnSID9f6QlD5qWFKUvrWDR72RBvnXmwTl90Tn8Am/kHSVDlxdKUIZ7FYqHaq4T IUCpwk8Ng1CUvtEbwFFLurtlU9vgkmaKHGA/KKEe0KephgFVmXmOpZ3ATVWk7CYH7H+78QCyMPJVq TbKBYaeEzGnR3QHuXMhtv1NBB88WowUCxh40mlEyluPV1lhSopMGpafr6H6DPTMT05iaBJQbNrfEX hdiodhHSwXbD/09JE/m7t8sXgoIK4RFUbTigQKib5371Y3J6g36IyzsD7w5yKZy6lCJMsEBN7rOsP HusyUi7HVUSLWsOhVIcQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iffvC-0004Le-N1; Fri, 13 Dec 2019 08:03:34 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iffv1-0004CZ-Jr; Fri, 13 Dec 2019 08:03:25 +0000 X-UUID: b538c21a97f84202bcfd5a1fe8964f26-20191213 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:Reply-To:From:Subject:Message-ID; bh=3iGzWvQ973vDVy2jTOS5BARL9ANWb/8ieSVfodrTkr4=; b=Q8dA/9WQLk57H+t7aqd0+s6RFLHlGomn33rqYN8MFiu2AmwQZaL9ZKkEt8OgkmgKMxTk+T9D/0sE+QFrOJkk6QuuL2qT+m9rNVUGt1cOUz7s27C+CivdDGHLC7F15R9xKKnm4i04kZowdudB8TmQA43W7Id36QDeI1vfAXIiVTE=; X-UUID: b538c21a97f84202bcfd5a1fe8964f26-20191213 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1632271844; Fri, 13 Dec 2019 00:03:15 -0800 Received: from mtkmbs05n2.mediatek.inc (172.21.101.140) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 13 Dec 2019 00:04:17 -0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 13 Dec 2019 16:02:52 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 13 Dec 2019 16:03:11 +0800 Message-ID: <1576224191.31822.2.camel@mhfsdcap03> Subject: Re: [PATCH v2, 1/2] drm/mediatek: Fix gamma correction issue From: Yongqiang Niu To: CK Hu Date: Fri, 13 Dec 2019 16:03:11 +0800 In-Reply-To: <1576223336.9817.3.camel@mtksdaap41> References: <1576222132-31586-1-git-send-email-yongqiang.niu@mediatek.com> <1576222132-31586-2-git-send-email-yongqiang.niu@mediatek.com> <1576223336.9817.3.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191213_000323_659598_27967D7B X-CRM114-Status: GOOD ( 16.17 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Yongqiang Niu Cc: Mark Rutland , devicetree@vger.kernel.org, Philipp Zabel , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-mediatek@lists.infradead.org, Daniel Vetter , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, 2019-12-13 at 15:48 +0800, CK Hu wrote: > Hi, Yongqiang: > > The title is too rough. Any bug of gamma would be this title. I would > like the title show explicitly what it does. > > On Fri, 2019-12-13 at 15:28 +0800, Yongqiang Niu wrote: > > if there is no gamma function in the crtc > > display path, don't add gamma property > > for crtc > > > > Signed-off-by: Yongqiang Niu > > --- > > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 10 ++++++++-- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > > index ca4fc47..9a8e1d4 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > > @@ -734,6 +734,7 @@ int mtk_drm_crtc_create(struct drm_device *drm_dev, > > int pipe = priv->num_pipes; > > int ret; > > int i; > > + uint gamma_lut_size = 0; > > > > if (!path) > > return 0; > > @@ -785,6 +786,9 @@ int mtk_drm_crtc_create(struct drm_device *drm_dev, > > } > > > > mtk_crtc->ddp_comp[i] = comp; > > + > > + if (comp->funcs->gamma_set) > > + gamma_lut_size = MTK_LUT_SIZE; > > } > > > > for (i = 0; i < mtk_crtc->ddp_comp_nr; i++) > > @@ -805,8 +809,10 @@ int mtk_drm_crtc_create(struct drm_device *drm_dev, > > NULL, pipe); > > if (ret < 0) > > return ret; > > - drm_mode_crtc_set_gamma_size(&mtk_crtc->base, MTK_LUT_SIZE); > > - drm_crtc_enable_color_mgmt(&mtk_crtc->base, 0, false, MTK_LUT_SIZE); > > + > > + if (gamma_lut_size) > > + drm_mode_crtc_set_gamma_size(&mtk_crtc->base, gamma_lut_size); > > + drm_crtc_enable_color_mgmt(&mtk_crtc->base, 0, false, gamma_lut_size); > > If there is no gamma, shall we enable color management? > > Regards, > CK drm_crtc_enable_color_mgmt will check the gamma_lut_size parameter, if no gamma, gamma_lut_size will be 0, and gamma_lut_size will not attch gamma property for the crtc > > > priv->num_pipes++; > > mutex_init(&mtk_crtc->hw_lock); > > > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3BC9C43603 for ; Fri, 13 Dec 2019 08:03:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A356124656 for ; Fri, 13 Dec 2019 08:03:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aIdf4E9f"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="Q8dA/9WQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A356124656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:References: In-Reply-To:Date:To:From:Subject:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XOy+/zahDcMdZQ+tsHBw9PFN1J7e64Lz32DbJdFLRuE=; b=aIdf4E9fqboCT5 X865k8s9fbDMJYAcG5sjB+kzRA/guwJYg7FPQpDG9vv2D+9zKp9qzXdGiyywHQSO0hoJDTF7DDTZg /bHr4zx1Izbb4sxYHCZrKNdKYmKigzlO97o8pkhCUFSU4jM7ERVzgsmFdQNB4VS28qGxMsRBetDub VmhVwYTGKquJ/Ed1sDF8CcPdSXbBLZf7Hlwqx0d4it+kLjFFUQvxwEbLJsrownPyiCT287j4yKlyq lz0DTsZMqpaLHsgjIJBuSO7x44FlQcLlRwVzYkJxC8k4vdValwfychSV4SXcWyOlLXDemiG0dNmQp IbyEsibR9jO1W9LeiIIQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iffv4-0004Cy-TU; Fri, 13 Dec 2019 08:03:26 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iffv1-0004CZ-Jr; Fri, 13 Dec 2019 08:03:25 +0000 X-UUID: b538c21a97f84202bcfd5a1fe8964f26-20191213 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:Reply-To:From:Subject:Message-ID; bh=3iGzWvQ973vDVy2jTOS5BARL9ANWb/8ieSVfodrTkr4=; b=Q8dA/9WQLk57H+t7aqd0+s6RFLHlGomn33rqYN8MFiu2AmwQZaL9ZKkEt8OgkmgKMxTk+T9D/0sE+QFrOJkk6QuuL2qT+m9rNVUGt1cOUz7s27C+CivdDGHLC7F15R9xKKnm4i04kZowdudB8TmQA43W7Id36QDeI1vfAXIiVTE=; X-UUID: b538c21a97f84202bcfd5a1fe8964f26-20191213 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1632271844; Fri, 13 Dec 2019 00:03:15 -0800 Received: from mtkmbs05n2.mediatek.inc (172.21.101.140) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 13 Dec 2019 00:04:17 -0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 13 Dec 2019 16:02:52 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 13 Dec 2019 16:03:11 +0800 Message-ID: <1576224191.31822.2.camel@mhfsdcap03> Subject: Re: [PATCH v2, 1/2] drm/mediatek: Fix gamma correction issue From: Yongqiang Niu To: CK Hu Date: Fri, 13 Dec 2019 16:03:11 +0800 In-Reply-To: <1576223336.9817.3.camel@mtksdaap41> References: <1576222132-31586-1-git-send-email-yongqiang.niu@mediatek.com> <1576222132-31586-2-git-send-email-yongqiang.niu@mediatek.com> <1576223336.9817.3.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191213_000323_659598_27967D7B X-CRM114-Status: GOOD ( 16.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Yongqiang Niu Cc: Mark Rutland , devicetree@vger.kernel.org, Philipp Zabel , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-mediatek@lists.infradead.org, Daniel Vetter , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2019-12-13 at 15:48 +0800, CK Hu wrote: > Hi, Yongqiang: > > The title is too rough. Any bug of gamma would be this title. I would > like the title show explicitly what it does. > > On Fri, 2019-12-13 at 15:28 +0800, Yongqiang Niu wrote: > > if there is no gamma function in the crtc > > display path, don't add gamma property > > for crtc > > > > Signed-off-by: Yongqiang Niu > > --- > > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 10 ++++++++-- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > > index ca4fc47..9a8e1d4 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > > @@ -734,6 +734,7 @@ int mtk_drm_crtc_create(struct drm_device *drm_dev, > > int pipe = priv->num_pipes; > > int ret; > > int i; > > + uint gamma_lut_size = 0; > > > > if (!path) > > return 0; > > @@ -785,6 +786,9 @@ int mtk_drm_crtc_create(struct drm_device *drm_dev, > > } > > > > mtk_crtc->ddp_comp[i] = comp; > > + > > + if (comp->funcs->gamma_set) > > + gamma_lut_size = MTK_LUT_SIZE; > > } > > > > for (i = 0; i < mtk_crtc->ddp_comp_nr; i++) > > @@ -805,8 +809,10 @@ int mtk_drm_crtc_create(struct drm_device *drm_dev, > > NULL, pipe); > > if (ret < 0) > > return ret; > > - drm_mode_crtc_set_gamma_size(&mtk_crtc->base, MTK_LUT_SIZE); > > - drm_crtc_enable_color_mgmt(&mtk_crtc->base, 0, false, MTK_LUT_SIZE); > > + > > + if (gamma_lut_size) > > + drm_mode_crtc_set_gamma_size(&mtk_crtc->base, gamma_lut_size); > > + drm_crtc_enable_color_mgmt(&mtk_crtc->base, 0, false, gamma_lut_size); > > If there is no gamma, shall we enable color management? > > Regards, > CK drm_crtc_enable_color_mgmt will check the gamma_lut_size parameter, if no gamma, gamma_lut_size will be 0, and gamma_lut_size will not attch gamma property for the crtc > > > priv->num_pipes++; > > mutex_init(&mtk_crtc->hw_lock); > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79558C00454 for ; Sat, 14 Dec 2019 14:43:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4CCA4214AF for ; Sat, 14 Dec 2019 14:43:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="E0OJZXP7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4CCA4214AF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8C4106E379; Sat, 14 Dec 2019 14:43:28 +0000 (UTC) Received: from mailgw02.mediatek.com (mailgw02.mediatek.com [216.200.240.185]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8B3D86E2E5 for ; Fri, 13 Dec 2019 08:22:48 +0000 (UTC) X-UUID: 02c8eb1eb31443d59c20f316aad7c71e-20191213 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:Reply-To:From:Subject:Message-ID; bh=3iGzWvQ973vDVy2jTOS5BARL9ANWb/8ieSVfodrTkr4=; b=E0OJZXP7CFIIiOND7EZdxZ/6RSDw+BPQGnB2xYPTcp27ez2h0wA5iduHuekmT7ygbheSIjLwb1mXEZXyyf4Wd4ODg1++1KNEoiA7HLxuJJWNo4AqjNU7s4UDqjE2epMKL3nWHQBgnPrHlW7zJMAPge2J2RdTVbHEoeNlDYvTXlc=; X-UUID: 02c8eb1eb31443d59c20f316aad7c71e-20191213 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1009231870; Fri, 13 Dec 2019 00:22:45 -0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 13 Dec 2019 16:02:52 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 13 Dec 2019 16:03:11 +0800 Message-ID: <1576224191.31822.2.camel@mhfsdcap03> Subject: Re: [PATCH v2, 1/2] drm/mediatek: Fix gamma correction issue From: Yongqiang Niu To: CK Hu Date: Fri, 13 Dec 2019 16:03:11 +0800 In-Reply-To: <1576223336.9817.3.camel@mtksdaap41> References: <1576222132-31586-1-git-send-email-yongqiang.niu@mediatek.com> <1576222132-31586-2-git-send-email-yongqiang.niu@mediatek.com> <1576223336.9817.3.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-Mailman-Approved-At: Sat, 14 Dec 2019 14:42:54 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Yongqiang Niu Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, 2019-12-13 at 15:48 +0800, CK Hu wrote: > Hi, Yongqiang: > > The title is too rough. Any bug of gamma would be this title. I would > like the title show explicitly what it does. > > On Fri, 2019-12-13 at 15:28 +0800, Yongqiang Niu wrote: > > if there is no gamma function in the crtc > > display path, don't add gamma property > > for crtc > > > > Signed-off-by: Yongqiang Niu > > --- > > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 10 ++++++++-- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > > index ca4fc47..9a8e1d4 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > > @@ -734,6 +734,7 @@ int mtk_drm_crtc_create(struct drm_device *drm_dev, > > int pipe = priv->num_pipes; > > int ret; > > int i; > > + uint gamma_lut_size = 0; > > > > if (!path) > > return 0; > > @@ -785,6 +786,9 @@ int mtk_drm_crtc_create(struct drm_device *drm_dev, > > } > > > > mtk_crtc->ddp_comp[i] = comp; > > + > > + if (comp->funcs->gamma_set) > > + gamma_lut_size = MTK_LUT_SIZE; > > } > > > > for (i = 0; i < mtk_crtc->ddp_comp_nr; i++) > > @@ -805,8 +809,10 @@ int mtk_drm_crtc_create(struct drm_device *drm_dev, > > NULL, pipe); > > if (ret < 0) > > return ret; > > - drm_mode_crtc_set_gamma_size(&mtk_crtc->base, MTK_LUT_SIZE); > > - drm_crtc_enable_color_mgmt(&mtk_crtc->base, 0, false, MTK_LUT_SIZE); > > + > > + if (gamma_lut_size) > > + drm_mode_crtc_set_gamma_size(&mtk_crtc->base, gamma_lut_size); > > + drm_crtc_enable_color_mgmt(&mtk_crtc->base, 0, false, gamma_lut_size); > > If there is no gamma, shall we enable color management? > > Regards, > CK drm_crtc_enable_color_mgmt will check the gamma_lut_size parameter, if no gamma, gamma_lut_size will be 0, and gamma_lut_size will not attch gamma property for the crtc > > > priv->num_pipes++; > > mutex_init(&mtk_crtc->hw_lock); > > > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel