From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Date: Fri, 13 Dec 2019 10:59:47 +0000 Subject: Re: [PATCH] drm/i915/selftests: remove a condition Message-Id: <157623478741.2219.10541788661599243416@skylake-alporthouse-com> List-Id: References: <20191213105050.y2v5nylsuxvc44jj@kili.mountain> In-Reply-To: <20191213105050.y2v5nylsuxvc44jj@kili.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , Jani Nikula Cc: David Airlie , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, Matthew Auld Quoting Dan Carpenter (2019-12-13 10:50:50) > We know that "err" is non-zero so there is no need to check. > > Signed-off-by: Dan Carpenter > --- > drivers/gpu/drm/i915/selftests/i915_request.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c > index 99c94b4f69fb..71a4ca38fbac 100644 > --- a/drivers/gpu/drm/i915/selftests/i915_request.c > +++ b/drivers/gpu/drm/i915/selftests/i915_request.c > @@ -1086,8 +1086,7 @@ static int __live_parallel_engine1(void *arg) > rq = i915_request_create(engine->kernel_context); > if (IS_ERR(rq)) { > err = PTR_ERR(rq); > - if (err) > - break; > + break; I don't know how that got there. Reviewed-by: Chris Wilson -Chris From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9A00C43603 for ; Fri, 13 Dec 2019 10:59:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9469F2073D for ; Fri, 13 Dec 2019 10:59:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9469F2073D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 261BE89EBB; Fri, 13 Dec 2019 10:59:58 +0000 (UTC) Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8E6FD6E4A2 for ; Fri, 13 Dec 2019 10:59:56 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 19566010-1500050 for multiple; Fri, 13 Dec 2019 10:59:50 +0000 MIME-Version: 1.0 To: Dan Carpenter , Jani Nikula From: Chris Wilson In-Reply-To: <20191213105050.y2v5nylsuxvc44jj@kili.mountain> References: <20191213105050.y2v5nylsuxvc44jj@kili.mountain> Message-ID: <157623478741.2219.10541788661599243416@skylake-alporthouse-com> User-Agent: alot/0.6 Date: Fri, 13 Dec 2019 10:59:47 +0000 Subject: Re: [Intel-gfx] [PATCH] drm/i915/selftests: remove a condition X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, Matthew Auld Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Dan Carpenter (2019-12-13 10:50:50) > We know that "err" is non-zero so there is no need to check. > > Signed-off-by: Dan Carpenter > --- > drivers/gpu/drm/i915/selftests/i915_request.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c > index 99c94b4f69fb..71a4ca38fbac 100644 > --- a/drivers/gpu/drm/i915/selftests/i915_request.c > +++ b/drivers/gpu/drm/i915/selftests/i915_request.c > @@ -1086,8 +1086,7 @@ static int __live_parallel_engine1(void *arg) > rq = i915_request_create(engine->kernel_context); > if (IS_ERR(rq)) { > err = PTR_ERR(rq); > - if (err) > - break; > + break; I don't know how that got there. Reviewed-by: Chris Wilson -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx