From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F2E8C43603 for ; Sat, 14 Dec 2019 10:58:54 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A4AF24125 for ; Sat, 14 Dec 2019 10:58:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A4AF24125 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 83D586E32F; Sat, 14 Dec 2019 10:58:53 +0000 (UTC) Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3FB506E32F; Sat, 14 Dec 2019 10:58:52 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 19577194-1500050 for multiple; Sat, 14 Dec 2019 10:58:37 +0000 MIME-Version: 1.0 To: Niranjana Vishwanathapura , intel-gfx@lists.freedesktop.org From: Chris Wilson In-Reply-To: <20191213215614.24558-4-niranjana.vishwanathapura@intel.com> References: <20191213215614.24558-1-niranjana.vishwanathapura@intel.com> <20191213215614.24558-4-niranjana.vishwanathapura@intel.com> Message-ID: <157632111528.7535.2801931080292335530@skylake-alporthouse-com> User-Agent: alot/0.6 Subject: Re: [Intel-gfx] [RFC v2 03/12] drm/i915/svm: Implicitly migrate BOs upon CPU access Date: Sat, 14 Dec 2019 10:58:35 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kenneth.w.graunke@intel.com, sanjay.k.kumar@intel.com, dri-devel@lists.freedesktop.org, jason.ekstrand@intel.com, dave.hansen@intel.com, jglisse@redhat.com, jgg@mellanox.com, daniel.vetter@intel.com, dan.j.williams@intel.com, ira.weiny@intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Niranjana Vishwanathapura (2019-12-13 21:56:05) > +int i915_gem_object_migrate_region(struct drm_i915_gem_object *obj, > + u32 *regions, int size) > +{ > + struct drm_i915_private *dev_priv = to_i915(obj->base.dev); > + struct intel_context *ce = dev_priv->engine[BCS0]->kernel_context; > + int i, ret; > + > mutex_lock(&dev_priv->drm.struct_mutex); > ret = i915_gem_object_prepare_move(obj); You appear to be based on a very broken code base. I'd recommend not doing that. -Chris _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FD91C2D0C9 for ; Sat, 14 Dec 2019 10:58:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E7C724125 for ; Sat, 14 Dec 2019 10:58:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E7C724125 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DE8AB6E334; Sat, 14 Dec 2019 10:58:53 +0000 (UTC) Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3FB506E32F; Sat, 14 Dec 2019 10:58:52 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 19577194-1500050 for multiple; Sat, 14 Dec 2019 10:58:37 +0000 MIME-Version: 1.0 To: Niranjana Vishwanathapura , intel-gfx@lists.freedesktop.org From: Chris Wilson In-Reply-To: <20191213215614.24558-4-niranjana.vishwanathapura@intel.com> References: <20191213215614.24558-1-niranjana.vishwanathapura@intel.com> <20191213215614.24558-4-niranjana.vishwanathapura@intel.com> Message-ID: <157632111528.7535.2801931080292335530@skylake-alporthouse-com> User-Agent: alot/0.6 Date: Sat, 14 Dec 2019 10:58:35 +0000 Subject: Re: [Intel-gfx] [RFC v2 03/12] drm/i915/svm: Implicitly migrate BOs upon CPU access X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kenneth.w.graunke@intel.com, sanjay.k.kumar@intel.com, dri-devel@lists.freedesktop.org, jason.ekstrand@intel.com, dave.hansen@intel.com, jglisse@redhat.com, jgg@mellanox.com, daniel.vetter@intel.com, dan.j.williams@intel.com, ira.weiny@intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Niranjana Vishwanathapura (2019-12-13 21:56:05) > +int i915_gem_object_migrate_region(struct drm_i915_gem_object *obj, > + u32 *regions, int size) > +{ > + struct drm_i915_private *dev_priv = to_i915(obj->base.dev); > + struct intel_context *ce = dev_priv->engine[BCS0]->kernel_context; > + int i, ret; > + > mutex_lock(&dev_priv->drm.struct_mutex); > ret = i915_gem_object_prepare_move(obj); You appear to be based on a very broken code base. I'd recommend not doing that. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx