From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F00D1C43603 for ; Tue, 17 Dec 2019 02:50:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B7EEC2176D for ; Tue, 17 Dec 2019 02:50:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="nrIaNHV2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726939AbfLQCuz (ORCPT ); Mon, 16 Dec 2019 21:50:55 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:25223 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726616AbfLQCuz (ORCPT ); Mon, 16 Dec 2019 21:50:55 -0500 X-UUID: d03b831c095c4d30afbbd12e2b0bcea0-20191217 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=LX30lj8mLQVTtpAKiV/zXtanwXXaFbc1xBxLxcZmnMQ=; b=nrIaNHV2yuAOhrQ9+Ghww+UVVXb5yvtWfuGMafMjUxEYhNf/Vb+/ZPwIF7LvutddoqIHvD66wo3YAWEVxBEP2Tj7AxyOvaTrTKRp6YUJyKEj421IwFXFTIHn4NNQ7yFZ7H1hlCzjNENgMHxu+RNApAy2HOdRADS2Q1nxa82GjTc=; X-UUID: d03b831c095c4d30afbbd12e2b0bcea0-20191217 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1851522241; Tue, 17 Dec 2019 10:50:50 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs02n2.mediatek.inc (172.21.101.101) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 17 Dec 2019 10:50:13 +0800 Received: from [172.21.77.4] (172.21.77.4) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 17 Dec 2019 10:49:57 +0800 Message-ID: <1576551044.14035.18.camel@mtksdaap41> Subject: Re: [PATCH v9 3/9] soc: mediatek: Add basic_clk_id to scp_power_data From: Weiyi Lu To: Nicolas Boichat CC: Matthias Brugger , Rob Herring , James Liao , Fan Chen , linux-arm Mailing List , lkml , "moderated list:ARM/Mediatek SoC support" , srv_heupstream , Yong Wu Date: Tue, 17 Dec 2019 10:50:44 +0800 In-Reply-To: References: <1575960413-6900-1-git-send-email-weiyi.lu@mediatek.com> <1575960413-6900-4-git-send-email-weiyi.lu@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 642B78DF808E55FC0C5C4E033F841D60DDCD4CB0A219E378767E8FE960F53DE02000:8 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gTW9uLCAyMDE5LTEyLTE2IGF0IDE1OjAxICswODAwLCBOaWNvbGFzIEJvaWNoYXQgd3JvdGU6 DQo+IE9uIFR1ZSwgRGVjIDEwLCAyMDE5IGF0IDI6NDcgUE0gV2VpeWkgTHUgPHdlaXlpLmx1QG1l ZGlhdGVrLmNvbT4gd3JvdGU6DQo+ID4NCj4gPiBUcnkgdG8gc3RvcCBleHRlbmRpbmcgdGhlIGNs a19pZCBvciBjbGtfbmFtZXMgaWYgdGhlcmUgYXJlDQo+ID4gbW9yZSBhbmQgbW9yZSBuZXcgQkFT SUMgY2xvY2tzLiBUbyBnZXQgaXRzIG93biBjbG9ja3MgYnkgdGhlDQo+ID4gYmFzaWNfY2xrX2lk IG9mIGVhY2ggcG93ZXIgZG9tYWluLg0KPiANCj4gTG9va2luZyBhdCB0aGlzIGEgYml0IG1vcmUs IEknbSBub3Qgc3VyZSB3aHkgd2UgbWFrZSB0aGlzIGFuIG9wdGlvbi4uLg0KPiANCj4gVGhlIGVh c2llc3Qgd2F5IHRvIG1ha2UgdGhpcyBjb25zaXN0ZW50IHdpdGggbm9uLU1UODE4MyBzY3BzeXMg ZHJpdmVycw0KPiBpcyB0byBhZGQgeW91ciBtaXNzaW5nIGNsb2NrcyB0byAiZW51bSBjbGtfaWQi IGFuZCBjbGtfbmFtZXMsIGJ1dCBJDQo+IHVuZGVyc3RhbmQgaXQncyBub3QgZGVzaXJlZCAobnVt YmVyIG9mIGNsb2NrcyB3b3VsZCBibG93IHVwKS4NCj4gDQo+IENhbiB3ZSwgaW5zdGVhZCwgY29u dmVydCBhbGwgZXhpc3Rpbmcgc2Nwc3lzIGRyaXZlcnMgdG8gdXNlICJjaGFyICoiDQo+IGNsb2Nr IG5hbWVzIGluc3RlYWQ/DQo+IEkgbWFkZSBhbiBhdHRlbXB0IGhlcmUgYW5kIGl0IHNlZW1zIHNp bXBsZSBlbm91Z2g6DQo+IGh0dHBzOi8vY2hyb21pdW0tcmV2aWV3Lmdvb2dsZXNvdXJjZS5jb20v Yy9jaHJvbWl1bW9zL3RoaXJkX3BhcnR5L2tlcm5lbC8rLzE5NjkxMDMNCj4gDQoNClRoYXQncyB3 aGF0IHdlJ2QgbGlrZSB0byBkbyBpbiB0aGUgZnV0dXJlLiBCdXQgeW91J3JlIHJpZ2h0ISBJIHNo b3VsZA0KY29tcGxldGUgaXQgYXQgb25lIGdvLg0KDQo+ID4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBX ZWl5aSBMdSA8d2VpeWkubHVAbWVkaWF0ZWsuY29tPg0KPiA+IC0tLQ0KPiA+ICBkcml2ZXJzL3Nv Yy9tZWRpYXRlay9tdGstc2Nwc3lzLmMgfCAyOSArKysrKysrKysrKysrKysrKysrKystLS0tLS0t LQ0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkN Cj4gPg0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3NvYy9tZWRpYXRlay9tdGstc2Nwc3lzLmMg Yi9kcml2ZXJzL3NvYy9tZWRpYXRlay9tdGstc2Nwc3lzLmMNCj4gPiBpbmRleCBmNjY5ZDM3Li45 MTVkNjM1IDEwMDY0NA0KPiA+IC0tLSBhL2RyaXZlcnMvc29jL21lZGlhdGVrL210ay1zY3BzeXMu Yw0KPiA+ICsrKyBiL2RyaXZlcnMvc29jL21lZGlhdGVrL210ay1zY3BzeXMuYw0KPiA+IEBAIC0x MTcsNiArMTE3LDggQEAgZW51bSBjbGtfaWQgew0KPiA+ICAgKiBAc3JhbV9wZG5fYWNrX2JpdHM6 IFRoZSBtYXNrIGZvciBzcmFtIHBvd2VyIGNvbnRyb2wgYWNrZWQgYml0cy4NCj4gPiAgICogQGJ1 c19wcm90X21hc2s6IFRoZSBtYXNrIGZvciBzaW5nbGUgc3RlcCBidXMgcHJvdGVjdGlvbi4NCj4g PiAgICogQGNsa19pZDogVGhlIGJhc2ljIGNsb2NrcyByZXF1aXJlZCBieSB0aGlzIHBvd2VyIGRv bWFpbi4NCj4gPiArICogQGJhc2ljX2Nsa19pZDogcHJvdmlkZSB0aGUgc2FtZSBwdXJwb3NlIHdp dGggZmllbGQgImNsa19pZCINCj4gPiArICogICAgICAgICAgICAgICAgYnkgZGVjbGFyaW5nIGJh c2ljIGNsb2NrIHByZWZpeCBuYW1lIHJhdGhlciB0aGFuIGNsa19pZC4NCj4gDQo+IEFjdHVhbGx5 LCBJIHByZWZlciB0aGUgbmFtZSBjbGtfbmFtZSwgbm90IHN1cmUgd2h5IEkgcHVzaGVkIHlvdSBp bg0KPiB0aGF0IGRpcmVjdGlvbi4uLg0KPiANCg0KT0ssIEknbGwgZml4IGl0IGluIG5leHQgdmVy c2lvbi4gQnV0IEknZCBsaWtlIHRvIHVzZSAiYmFzaWNfY2xrX25hbWUiDQpiZWNhdXNlIHdlIHdp bGwgYWRkICJzdWJzeXNfY2xrX3ByZWZpeCIgaW4gZm9sbG93aW5nIHBhdGNoLg0KDQo+ID4gICAq IEBjYXBzOiBUaGUgZmxhZyBmb3IgYWN0aXZlIHdha2UtdXAgYWN0aW9uLg0KPiA+ICAgKi8NCj4g PiAgc3RydWN0IHNjcF9kb21haW5fZGF0YSB7DQo+ID4gQEAgLTEyNyw2ICsxMjksNyBAQCBzdHJ1 Y3Qgc2NwX2RvbWFpbl9kYXRhIHsNCj4gPiAgICAgICAgIHUzMiBzcmFtX3Bkbl9hY2tfYml0czsN Cj4gPiAgICAgICAgIHUzMiBidXNfcHJvdF9tYXNrOw0KPiA+ICAgICAgICAgZW51bSBjbGtfaWQg Y2xrX2lkW01BWF9DTEtTXTsNCj4gPiArICAgICAgIGNvbnN0IGNoYXIgKmJhc2ljX2Nsa19pZFtN QVhfQ0xLU107DQo+ID4gICAgICAgICB1OCBjYXBzOw0KPiA+ICB9Ow0KPiA+DQo+ID4gQEAgLTQ5 MywxNiArNDk2LDI2IEBAIHN0YXRpYyBzdHJ1Y3Qgc2NwICppbml0X3NjcChzdHJ1Y3QgcGxhdGZv cm1fZGV2aWNlICpwZGV2LA0KPiA+DQo+ID4gICAgICAgICAgICAgICAgIHNjcGQtPmRhdGEgPSBk YXRhOw0KPiA+DQo+ID4gLSAgICAgICAgICAgICAgIGZvciAoaiA9IDA7IGogPCBNQVhfQ0xLUyAm JiBkYXRhLT5jbGtfaWRbal07IGorKykgew0KPiA+IC0gICAgICAgICAgICAgICAgICAgICAgIHN0 cnVjdCBjbGsgKmMgPSBjbGtbZGF0YS0+Y2xrX2lkW2pdXTsNCj4gPiArICAgICAgICAgICAgICAg aWYgKGRhdGEtPmNsa19pZFswXSkgew0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIFdBUk5f T04oZGF0YS0+YmFzaWNfY2xrX2lkWzBdKTsNCj4gPg0KPiA+IC0gICAgICAgICAgICAgICAgICAg ICAgIGlmIChJU19FUlIoYykpIHsNCj4gPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGRldl9lcnIoJnBkZXYtPmRldiwgIiVzOiBjbGsgdW5hdmFpbGFibGVcbiIsDQo+ID4gLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRhdGEtPm5hbWUpOw0KPiA+IC0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIEVSUl9DQVNUKGMpOw0KPiA+IC0gICAg ICAgICAgICAgICAgICAgICAgIH0NCj4gPiArICAgICAgICAgICAgICAgICAgICAgICBmb3IgKGog PSAwOyBqIDwgTUFYX0NMS1MgJiYgZGF0YS0+Y2xrX2lkW2pdOyBqKyspIHsNCj4gPiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBjbGsgKmMgPSBjbGtbZGF0YS0+Y2xrX2lk W2pdXTsNCj4gPiArDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpZiAoSVNf RVJSKGMpKSB7DQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRl dl9lcnIoJnBkZXYtPmRldiwNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAiJXM6IGNsayB1bmF2YWlsYWJsZVxuIiwNCj4gPiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkYXRhLT5uYW1lKTsNCj4gPiArICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIEVSUl9DQVNUKGMpOw0K PiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfQ0KPiA+DQo+ID4gLSAgICAgICAg ICAgICAgICAgICAgICAgc2NwZC0+Y2xrW2pdID0gYzsNCj4gPiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHNjcGQtPmNsa1tqXSA9IGM7DQo+ID4gKyAgICAgICAgICAgICAgICAgICAg ICAgfQ0KPiA+ICsgICAgICAgICAgICAgICB9IGVsc2UgaWYgKGRhdGEtPmJhc2ljX2Nsa19pZFsw XSkgew0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIGZvciAoaiA9IDA7IGogPCBNQVhfQ0xL UyAmJg0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkYXRhLT5i YXNpY19jbGtfaWRbal07IGorKykNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHNjcGQtPmNsa1tqXSA9IGRldm1fY2xrX2dldCgmcGRldi0+ZGV2LA0KPiA+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRhdGEtPmJhc2ljX2Nsa19pZFtq XSk7DQo+ID4gICAgICAgICAgICAgICAgIH0NCj4gPg0KPiA+ICAgICAgICAgICAgICAgICBnZW5w ZC0+bmFtZSA9IGRhdGEtPm5hbWU7DQo+ID4gLS0NCj4gPiAxLjguMS4xLmRpcnR5DQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10BA3C43603 for ; Tue, 17 Dec 2019 02:51:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D510E2176D for ; Tue, 17 Dec 2019 02:51:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Hhqrcubk"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="nrIaNHV2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D510E2176D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=A/vzlFvdUEn5mfNXvB9KBHxILQ4EOGX2jS5bz3vc0o4=; b=Hhqrcubkh+PNBz RN0mgyt3rKcswrO+SOQ0CtoPHFqcpK+pYlHGvlMz99b+QEKzpGh/NubWe40PGTsxKWUdBa/jvs0ZH QDYgX9mG98t7lvWXs22l1I7XP1n8irgPX1Cv3fPnfTBoDXFNP05Yecd+0N0OP/0Obxtfdu5Ok4r9H kF95JgMNJqSfrRLpd/dE+hJz4llvyDlqJNTW3BCTalE4OleVUA/VsdpFkyp+A3vYQPMv15JH3F2/h 6i/RWOpl/KjWAKvt1E5VScGjJE83pT4+xzfahA8knnD4Vl5iPxnw0hpHsMp2gf3x6JOXKn18/Hv8H Jn7gWaThzSmuEAHhNImg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ih2wz-00036D-2D; Tue, 17 Dec 2019 02:51:05 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ih2ww-000359-74; Tue, 17 Dec 2019 02:51:03 +0000 X-UUID: 281cfac2fb784c84a880b023454453ff-20191216 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=LX30lj8mLQVTtpAKiV/zXtanwXXaFbc1xBxLxcZmnMQ=; b=nrIaNHV2yuAOhrQ9+Ghww+UVVXb5yvtWfuGMafMjUxEYhNf/Vb+/ZPwIF7LvutddoqIHvD66wo3YAWEVxBEP2Tj7AxyOvaTrTKRp6YUJyKEj421IwFXFTIHn4NNQ7yFZ7H1hlCzjNENgMHxu+RNApAy2HOdRADS2Q1nxa82GjTc=; X-UUID: 281cfac2fb784c84a880b023454453ff-20191216 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 2128832383; Mon, 16 Dec 2019 18:50:59 -0800 Received: from MTKMBS02N2.mediatek.inc (172.21.101.101) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 16 Dec 2019 18:51:16 -0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs02n2.mediatek.inc (172.21.101.101) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 17 Dec 2019 10:50:13 +0800 Received: from [172.21.77.4] (172.21.77.4) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 17 Dec 2019 10:49:57 +0800 Message-ID: <1576551044.14035.18.camel@mtksdaap41> Subject: Re: [PATCH v9 3/9] soc: mediatek: Add basic_clk_id to scp_power_data From: Weiyi Lu To: Nicolas Boichat Date: Tue, 17 Dec 2019 10:50:44 +0800 In-Reply-To: References: <1575960413-6900-1-git-send-email-weiyi.lu@mediatek.com> <1575960413-6900-4-git-send-email-weiyi.lu@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 642B78DF808E55FC0C5C4E033F841D60DDCD4CB0A219E378767E8FE960F53DE02000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191216_185102_264623_F50EC31C X-CRM114-Status: GOOD ( 21.89 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , srv_heupstream , James Liao , lkml , Fan Chen , "moderated list:ARM/Mediatek SoC support" , Yong Wu , Matthias Brugger , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, 2019-12-16 at 15:01 +0800, Nicolas Boichat wrote: > On Tue, Dec 10, 2019 at 2:47 PM Weiyi Lu wrote: > > > > Try to stop extending the clk_id or clk_names if there are > > more and more new BASIC clocks. To get its own clocks by the > > basic_clk_id of each power domain. > > Looking at this a bit more, I'm not sure why we make this an option... > > The easiest way to make this consistent with non-MT8183 scpsys drivers > is to add your missing clocks to "enum clk_id" and clk_names, but I > understand it's not desired (number of clocks would blow up). > > Can we, instead, convert all existing scpsys drivers to use "char *" > clock names instead? > I made an attempt here and it seems simple enough: > https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1969103 > That's what we'd like to do in the future. But you're right! I should complete it at one go. > > > > Signed-off-by: Weiyi Lu > > --- > > drivers/soc/mediatek/mtk-scpsys.c | 29 +++++++++++++++++++++-------- > > 1 file changed, 21 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/soc/mediatek/mtk-scpsys.c b/drivers/soc/mediatek/mtk-scpsys.c > > index f669d37..915d635 100644 > > --- a/drivers/soc/mediatek/mtk-scpsys.c > > +++ b/drivers/soc/mediatek/mtk-scpsys.c > > @@ -117,6 +117,8 @@ enum clk_id { > > * @sram_pdn_ack_bits: The mask for sram power control acked bits. > > * @bus_prot_mask: The mask for single step bus protection. > > * @clk_id: The basic clocks required by this power domain. > > + * @basic_clk_id: provide the same purpose with field "clk_id" > > + * by declaring basic clock prefix name rather than clk_id. > > Actually, I prefer the name clk_name, not sure why I pushed you in > that direction... > OK, I'll fix it in next version. But I'd like to use "basic_clk_name" because we will add "subsys_clk_prefix" in following patch. > > * @caps: The flag for active wake-up action. > > */ > > struct scp_domain_data { > > @@ -127,6 +129,7 @@ struct scp_domain_data { > > u32 sram_pdn_ack_bits; > > u32 bus_prot_mask; > > enum clk_id clk_id[MAX_CLKS]; > > + const char *basic_clk_id[MAX_CLKS]; > > u8 caps; > > }; > > > > @@ -493,16 +496,26 @@ static struct scp *init_scp(struct platform_device *pdev, > > > > scpd->data = data; > > > > - for (j = 0; j < MAX_CLKS && data->clk_id[j]; j++) { > > - struct clk *c = clk[data->clk_id[j]]; > > + if (data->clk_id[0]) { > > + WARN_ON(data->basic_clk_id[0]); > > > > - if (IS_ERR(c)) { > > - dev_err(&pdev->dev, "%s: clk unavailable\n", > > - data->name); > > - return ERR_CAST(c); > > - } > > + for (j = 0; j < MAX_CLKS && data->clk_id[j]; j++) { > > + struct clk *c = clk[data->clk_id[j]]; > > + > > + if (IS_ERR(c)) { > > + dev_err(&pdev->dev, > > + "%s: clk unavailable\n", > > + data->name); > > + return ERR_CAST(c); > > + } > > > > - scpd->clk[j] = c; > > + scpd->clk[j] = c; > > + } > > + } else if (data->basic_clk_id[0]) { > > + for (j = 0; j < MAX_CLKS && > > + data->basic_clk_id[j]; j++) > > + scpd->clk[j] = devm_clk_get(&pdev->dev, > > + data->basic_clk_id[j]); > > } > > > > genpd->name = data->name; > > -- > > 1.8.1.1.dirty _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B84DC43603 for ; Tue, 17 Dec 2019 02:51:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1AD92176D for ; Tue, 17 Dec 2019 02:51:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KHaD//C8"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="nrIaNHV2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1AD92176D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xD53xGI+b4+ZQEETaHC89/VO37s2Ko25/vN4q5vRNrM=; b=KHaD//C8/MRvf0 NLUk8ffgjg1FKa/MnbRGlQtPpAX989OgYDVIIIq1Zw23UBHIrjwSJeqvEQIVazzlMesQd1Qpfh/TS B24rvm4x1a4TwSzY7LCKobFa8Z4iJJhNwhvuxqKafU2F3hhbsHXFM4Ioy+WwlVLfGxCkVoUxALrMw YCHW/gUwOyT0A2PYA1jTLge9TwEbQo9VriHF5kJuLmrG+iXedqGs8AFs1OtcpaSTaXllEQq3kAdag lVJljBUupCpQ33rK0Fvy4hfSn0F0Ae3Csv0K7/76xY02fVVjv3D/KkaDLoH0I0YvDjmggLVy7sg46 /OxC6dRbJGxASUtdRmjw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ih2x0-00036r-60; Tue, 17 Dec 2019 02:51:06 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ih2ww-000359-74; Tue, 17 Dec 2019 02:51:03 +0000 X-UUID: 281cfac2fb784c84a880b023454453ff-20191216 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=LX30lj8mLQVTtpAKiV/zXtanwXXaFbc1xBxLxcZmnMQ=; b=nrIaNHV2yuAOhrQ9+Ghww+UVVXb5yvtWfuGMafMjUxEYhNf/Vb+/ZPwIF7LvutddoqIHvD66wo3YAWEVxBEP2Tj7AxyOvaTrTKRp6YUJyKEj421IwFXFTIHn4NNQ7yFZ7H1hlCzjNENgMHxu+RNApAy2HOdRADS2Q1nxa82GjTc=; X-UUID: 281cfac2fb784c84a880b023454453ff-20191216 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 2128832383; Mon, 16 Dec 2019 18:50:59 -0800 Received: from MTKMBS02N2.mediatek.inc (172.21.101.101) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 16 Dec 2019 18:51:16 -0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs02n2.mediatek.inc (172.21.101.101) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 17 Dec 2019 10:50:13 +0800 Received: from [172.21.77.4] (172.21.77.4) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 17 Dec 2019 10:49:57 +0800 Message-ID: <1576551044.14035.18.camel@mtksdaap41> Subject: Re: [PATCH v9 3/9] soc: mediatek: Add basic_clk_id to scp_power_data From: Weiyi Lu To: Nicolas Boichat Date: Tue, 17 Dec 2019 10:50:44 +0800 In-Reply-To: References: <1575960413-6900-1-git-send-email-weiyi.lu@mediatek.com> <1575960413-6900-4-git-send-email-weiyi.lu@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 642B78DF808E55FC0C5C4E033F841D60DDCD4CB0A219E378767E8FE960F53DE02000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191216_185102_264623_F50EC31C X-CRM114-Status: GOOD ( 21.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , srv_heupstream , James Liao , lkml , Fan Chen , "moderated list:ARM/Mediatek SoC support" , Yong Wu , Matthias Brugger , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2019-12-16 at 15:01 +0800, Nicolas Boichat wrote: > On Tue, Dec 10, 2019 at 2:47 PM Weiyi Lu wrote: > > > > Try to stop extending the clk_id or clk_names if there are > > more and more new BASIC clocks. To get its own clocks by the > > basic_clk_id of each power domain. > > Looking at this a bit more, I'm not sure why we make this an option... > > The easiest way to make this consistent with non-MT8183 scpsys drivers > is to add your missing clocks to "enum clk_id" and clk_names, but I > understand it's not desired (number of clocks would blow up). > > Can we, instead, convert all existing scpsys drivers to use "char *" > clock names instead? > I made an attempt here and it seems simple enough: > https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1969103 > That's what we'd like to do in the future. But you're right! I should complete it at one go. > > > > Signed-off-by: Weiyi Lu > > --- > > drivers/soc/mediatek/mtk-scpsys.c | 29 +++++++++++++++++++++-------- > > 1 file changed, 21 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/soc/mediatek/mtk-scpsys.c b/drivers/soc/mediatek/mtk-scpsys.c > > index f669d37..915d635 100644 > > --- a/drivers/soc/mediatek/mtk-scpsys.c > > +++ b/drivers/soc/mediatek/mtk-scpsys.c > > @@ -117,6 +117,8 @@ enum clk_id { > > * @sram_pdn_ack_bits: The mask for sram power control acked bits. > > * @bus_prot_mask: The mask for single step bus protection. > > * @clk_id: The basic clocks required by this power domain. > > + * @basic_clk_id: provide the same purpose with field "clk_id" > > + * by declaring basic clock prefix name rather than clk_id. > > Actually, I prefer the name clk_name, not sure why I pushed you in > that direction... > OK, I'll fix it in next version. But I'd like to use "basic_clk_name" because we will add "subsys_clk_prefix" in following patch. > > * @caps: The flag for active wake-up action. > > */ > > struct scp_domain_data { > > @@ -127,6 +129,7 @@ struct scp_domain_data { > > u32 sram_pdn_ack_bits; > > u32 bus_prot_mask; > > enum clk_id clk_id[MAX_CLKS]; > > + const char *basic_clk_id[MAX_CLKS]; > > u8 caps; > > }; > > > > @@ -493,16 +496,26 @@ static struct scp *init_scp(struct platform_device *pdev, > > > > scpd->data = data; > > > > - for (j = 0; j < MAX_CLKS && data->clk_id[j]; j++) { > > - struct clk *c = clk[data->clk_id[j]]; > > + if (data->clk_id[0]) { > > + WARN_ON(data->basic_clk_id[0]); > > > > - if (IS_ERR(c)) { > > - dev_err(&pdev->dev, "%s: clk unavailable\n", > > - data->name); > > - return ERR_CAST(c); > > - } > > + for (j = 0; j < MAX_CLKS && data->clk_id[j]; j++) { > > + struct clk *c = clk[data->clk_id[j]]; > > + > > + if (IS_ERR(c)) { > > + dev_err(&pdev->dev, > > + "%s: clk unavailable\n", > > + data->name); > > + return ERR_CAST(c); > > + } > > > > - scpd->clk[j] = c; > > + scpd->clk[j] = c; > > + } > > + } else if (data->basic_clk_id[0]) { > > + for (j = 0; j < MAX_CLKS && > > + data->basic_clk_id[j]; j++) > > + scpd->clk[j] = devm_clk_get(&pdev->dev, > > + data->basic_clk_id[j]); > > } > > > > genpd->name = data->name; > > -- > > 1.8.1.1.dirty _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel