* Re: [Intel-gfx] [PATCH] drm/i915/display: nuke skl workaround for pre-production hw
2019-12-20 22:06 [Intel-gfx] [PATCH] drm/i915/display: nuke skl workaround for pre-production hw Lucas De Marchi
@ 2019-12-20 22:11 ` Chris Wilson
2019-12-23 20:59 ` Lucas De Marchi
2019-12-21 1:00 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
` (4 subsequent siblings)
5 siblings, 1 reply; 10+ messages in thread
From: Chris Wilson @ 2019-12-20 22:11 UTC (permalink / raw)
To: Lucas De Marchi, intel-gfx; +Cc: jani.nikula
Quoting Lucas De Marchi (2019-12-20 22:06:50)
> According to intel_detect_preproduction_hw(), the SKL steeping D0 is
> still pre-preproduction so we can nuke the additional workaround.
>
> While at it, nuke dangling new line.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Ville and Jani are more likely to know if the pre-production comment is
telling porkies.
-Chris
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index e6702b9b9117..4aa7dfa88c7c 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -16018,14 +16018,8 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv)
> if (intel_ddi_crt_present(dev_priv))
> intel_crt_init(dev_priv);
>
> - /*
> - * Haswell uses DDI functions to detect digital outputs.
> - * On SKL pre-D0 the strap isn't connected, so we assume
> - * it's there.
> - */
> found = I915_READ(DDI_BUF_CTL(PORT_A)) & DDI_INIT_DISPLAY_DETECTED;
> - /* WaIgnoreDDIAStrap: skl */
> - if (found || IS_GEN9_BC(dev_priv))
> + if (found)
> intel_ddi_init(dev_priv, PORT_A);
>
> /* DDI B, C, D, and F detection is indicated by the SFUSE_STRAP
> @@ -16046,7 +16040,6 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv)
> if (IS_GEN9_BC(dev_priv) &&
> intel_bios_is_port_present(dev_priv, PORT_E))
> intel_ddi_init(dev_priv, PORT_E);
> -
> } else if (HAS_PCH_SPLIT(dev_priv)) {
> int found;
>
> --
> 2.24.0
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915/display: nuke skl workaround for pre-production hw
2019-12-20 22:11 ` Chris Wilson
@ 2019-12-23 20:59 ` Lucas De Marchi
2020-01-07 16:36 ` Ville Syrjälä
0 siblings, 1 reply; 10+ messages in thread
From: Lucas De Marchi @ 2019-12-23 20:59 UTC (permalink / raw)
To: Chris Wilson; +Cc: jani.nikula, intel-gfx
On Fri, Dec 20, 2019 at 10:11:15PM +0000, Chris Wilson wrote:
>Quoting Lucas De Marchi (2019-12-20 22:06:50)
>> According to intel_detect_preproduction_hw(), the SKL steeping D0 is
>> still pre-preproduction so we can nuke the additional workaround.
>>
>> While at it, nuke dangling new line.
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
>Ville and Jani are more likely to know if the pre-production comment is
>telling porkies.
Bspec 7534 says "The DDIA port presence strap is not connected on the SKL A-C steppings."
I would expect to catch a failure in CI if the spec was wrong. I can add
the bspec # to the commit message while fixing up the typos there.
Lucas De Marchi
>-Chris
>
>> ---
>> drivers/gpu/drm/i915/display/intel_display.c | 9 +--------
>> 1 file changed, 1 insertion(+), 8 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
>> index e6702b9b9117..4aa7dfa88c7c 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display.c
>> +++ b/drivers/gpu/drm/i915/display/intel_display.c
>> @@ -16018,14 +16018,8 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv)
>> if (intel_ddi_crt_present(dev_priv))
>> intel_crt_init(dev_priv);
>>
>> - /*
>> - * Haswell uses DDI functions to detect digital outputs.
>> - * On SKL pre-D0 the strap isn't connected, so we assume
>> - * it's there.
>> - */
>> found = I915_READ(DDI_BUF_CTL(PORT_A)) & DDI_INIT_DISPLAY_DETECTED;
>> - /* WaIgnoreDDIAStrap: skl */
>> - if (found || IS_GEN9_BC(dev_priv))
>> + if (found)
>> intel_ddi_init(dev_priv, PORT_A);
>>
>> /* DDI B, C, D, and F detection is indicated by the SFUSE_STRAP
>> @@ -16046,7 +16040,6 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv)
>> if (IS_GEN9_BC(dev_priv) &&
>> intel_bios_is_port_present(dev_priv, PORT_E))
>> intel_ddi_init(dev_priv, PORT_E);
>> -
>> } else if (HAS_PCH_SPLIT(dev_priv)) {
>> int found;
>>
>> --
>> 2.24.0
>>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915/display: nuke skl workaround for pre-production hw
2019-12-23 20:59 ` Lucas De Marchi
@ 2020-01-07 16:36 ` Ville Syrjälä
2020-02-27 23:03 ` Lucas De Marchi
0 siblings, 1 reply; 10+ messages in thread
From: Ville Syrjälä @ 2020-01-07 16:36 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: jani.nikula, intel-gfx
On Mon, Dec 23, 2019 at 12:59:55PM -0800, Lucas De Marchi wrote:
> On Fri, Dec 20, 2019 at 10:11:15PM +0000, Chris Wilson wrote:
> >Quoting Lucas De Marchi (2019-12-20 22:06:50)
> >> According to intel_detect_preproduction_hw(), the SKL steeping D0 is
> >> still pre-preproduction so we can nuke the additional workaround.
> >>
> >> While at it, nuke dangling new line.
> >>
> >> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> >
> >Ville and Jani are more likely to know if the pre-production comment is
> >telling porkies.
>
> Bspec 7534 says "The DDIA port presence strap is not connected on the SKL A-C steppings."
>
> I would expect to catch a failure in CI if the spec was wrong. I can add
> the bspec # to the commit message while fixing up the typos there.
IIRC the w/a db has this listed as "forever". So not really sure what
the truth is on this one. But easy enough to revert if it doesn't work
out I supoose. Maybe toss in a note about the w/a db thing into the
commit message?
>
>
> Lucas De Marchi
>
> >-Chris
> >
> >> ---
> >> drivers/gpu/drm/i915/display/intel_display.c | 9 +--------
> >> 1 file changed, 1 insertion(+), 8 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> >> index e6702b9b9117..4aa7dfa88c7c 100644
> >> --- a/drivers/gpu/drm/i915/display/intel_display.c
> >> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> >> @@ -16018,14 +16018,8 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv)
> >> if (intel_ddi_crt_present(dev_priv))
> >> intel_crt_init(dev_priv);
> >>
> >> - /*
> >> - * Haswell uses DDI functions to detect digital outputs.
> >> - * On SKL pre-D0 the strap isn't connected, so we assume
> >> - * it's there.
> >> - */
> >> found = I915_READ(DDI_BUF_CTL(PORT_A)) & DDI_INIT_DISPLAY_DETECTED;
> >> - /* WaIgnoreDDIAStrap: skl */
> >> - if (found || IS_GEN9_BC(dev_priv))
> >> + if (found)
> >> intel_ddi_init(dev_priv, PORT_A);
> >>
> >> /* DDI B, C, D, and F detection is indicated by the SFUSE_STRAP
> >> @@ -16046,7 +16040,6 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv)
> >> if (IS_GEN9_BC(dev_priv) &&
> >> intel_bios_is_port_present(dev_priv, PORT_E))
> >> intel_ddi_init(dev_priv, PORT_E);
> >> -
> >> } else if (HAS_PCH_SPLIT(dev_priv)) {
> >> int found;
> >>
> >> --
> >> 2.24.0
> >>
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915/display: nuke skl workaround for pre-production hw
2020-01-07 16:36 ` Ville Syrjälä
@ 2020-02-27 23:03 ` Lucas De Marchi
0 siblings, 0 replies; 10+ messages in thread
From: Lucas De Marchi @ 2020-02-27 23:03 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: jani.nikula, intel-gfx
On Tue, Jan 07, 2020 at 06:36:55PM +0200, Ville Syrjälä wrote:
>On Mon, Dec 23, 2019 at 12:59:55PM -0800, Lucas De Marchi wrote:
>> On Fri, Dec 20, 2019 at 10:11:15PM +0000, Chris Wilson wrote:
>> >Quoting Lucas De Marchi (2019-12-20 22:06:50)
>> >> According to intel_detect_preproduction_hw(), the SKL steeping D0 is
>> >> still pre-preproduction so we can nuke the additional workaround.
>> >>
>> >> While at it, nuke dangling new line.
>> >>
>> >> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>> >
>> >Ville and Jani are more likely to know if the pre-production comment is
>> >telling porkies.
>>
>> Bspec 7534 says "The DDIA port presence strap is not connected on the SKL A-C steppings."
>>
>> I would expect to catch a failure in CI if the spec was wrong. I can add
>> the bspec # to the commit message while fixing up the typos there.
>
>IIRC the w/a db has this listed as "forever". So not really sure what
>the truth is on this one. But easy enough to revert if it doesn't work
yep, just checked that as well.
>out I supoose. Maybe toss in a note about the w/a db thing into the
>commit message?
Humn.. I add a comment on the spec to give them a chance to chime in.
Let's see if we receive a response before commiting this.
thanks
Lucas De Marchi
>
>>
>>
>> Lucas De Marchi
>>
>> >-Chris
>> >
>> >> ---
>> >> drivers/gpu/drm/i915/display/intel_display.c | 9 +--------
>> >> 1 file changed, 1 insertion(+), 8 deletions(-)
>> >>
>> >> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
>> >> index e6702b9b9117..4aa7dfa88c7c 100644
>> >> --- a/drivers/gpu/drm/i915/display/intel_display.c
>> >> +++ b/drivers/gpu/drm/i915/display/intel_display.c
>> >> @@ -16018,14 +16018,8 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv)
>> >> if (intel_ddi_crt_present(dev_priv))
>> >> intel_crt_init(dev_priv);
>> >>
>> >> - /*
>> >> - * Haswell uses DDI functions to detect digital outputs.
>> >> - * On SKL pre-D0 the strap isn't connected, so we assume
>> >> - * it's there.
>> >> - */
>> >> found = I915_READ(DDI_BUF_CTL(PORT_A)) & DDI_INIT_DISPLAY_DETECTED;
>> >> - /* WaIgnoreDDIAStrap: skl */
>> >> - if (found || IS_GEN9_BC(dev_priv))
>> >> + if (found)
>> >> intel_ddi_init(dev_priv, PORT_A);
>> >>
>> >> /* DDI B, C, D, and F detection is indicated by the SFUSE_STRAP
>> >> @@ -16046,7 +16040,6 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv)
>> >> if (IS_GEN9_BC(dev_priv) &&
>> >> intel_bios_is_port_present(dev_priv, PORT_E))
>> >> intel_ddi_init(dev_priv, PORT_E);
>> >> -
>> >> } else if (HAS_PCH_SPLIT(dev_priv)) {
>> >> int found;
>> >>
>> >> --
>> >> 2.24.0
>> >>
>
>--
>Ville Syrjälä
>Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: nuke skl workaround for pre-production hw
2019-12-20 22:06 [Intel-gfx] [PATCH] drm/i915/display: nuke skl workaround for pre-production hw Lucas De Marchi
2019-12-20 22:11 ` Chris Wilson
@ 2019-12-21 1:00 ` Patchwork
2019-12-23 20:35 ` [Intel-gfx] [PATCH] " Matt Roper
` (3 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-12-21 1:00 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/display: nuke skl workaround for pre-production hw
URL : https://patchwork.freedesktop.org/series/71230/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7616 -> Patchwork_15866
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15866 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15866, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15866/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15866:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_gt_heartbeat:
- fi-bsw-n3050: NOTRUN -> [DMESG-FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15866/fi-bsw-n3050/igt@i915_selftest@live_gt_heartbeat.html
Known issues
------------
Here are the changes found in Patchwork_15866 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_blt:
- fi-ivb-3770: [PASS][2] -> [DMESG-FAIL][3] ([i915#725])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7616/fi-ivb-3770/igt@i915_selftest@live_blt.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15866/fi-ivb-3770/igt@i915_selftest@live_blt.html
- fi-hsw-4770: [PASS][4] -> [DMESG-FAIL][5] ([i915#725])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7616/fi-hsw-4770/igt@i915_selftest@live_blt.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15866/fi-hsw-4770/igt@i915_selftest@live_blt.html
* igt@i915_selftest@live_gem_contexts:
- fi-cfl-8700k: [PASS][6] -> [INCOMPLETE][7] ([i915#424])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7616/fi-cfl-8700k/igt@i915_selftest@live_gem_contexts.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15866/fi-cfl-8700k/igt@i915_selftest@live_gem_contexts.html
- fi-byt-n2820: [PASS][8] -> [INCOMPLETE][9] ([i915#45])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7616/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15866/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
#### Possible fixes ####
* igt@gem_close_race@basic-threads:
- {fi-tgl-guc}: [INCOMPLETE][10] ([i915#435]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7616/fi-tgl-guc/igt@gem_close_race@basic-threads.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15866/fi-tgl-guc/igt@gem_close_race@basic-threads.html
#### Warnings ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-kbl-x1275: [DMESG-WARN][12] ([i915#62] / [i915#92]) -> [DMESG-WARN][13] ([i915#62] / [i915#92] / [i915#95]) +5 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7616/fi-kbl-x1275/igt@i915_pm_rpm@basic-pci-d3-state.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15866/fi-kbl-x1275/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
- fi-kbl-x1275: [DMESG-WARN][14] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][15] ([i915#62] / [i915#92]) +7 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7616/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15866/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#424]: https://gitlab.freedesktop.org/drm/intel/issues/424
[i915#435]: https://gitlab.freedesktop.org/drm/intel/issues/435
[i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
[i915#476]: https://gitlab.freedesktop.org/drm/intel/issues/476
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (46 -> 45)
------------------------------
Additional (5): fi-bsw-n3050 fi-hsw-peppy fi-elk-e7500 fi-tgl-y fi-bsw-nick
Missing (6): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7616 -> Patchwork_15866
CI-20190529: 20190529
CI_DRM_7616: 81105b549355270c1d15073dc7f7b137cdc3d5c4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5351: e7fdcef72d1d6b3bb9f3003bbc37571959e6e8bb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15866: 71b76ffcf2ed8a2396845ce978b9a7ec21b6a731 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
71b76ffcf2ed drm/i915/display: nuke skl workaround for pre-production hw
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15866/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915/display: nuke skl workaround for pre-production hw
2019-12-20 22:06 [Intel-gfx] [PATCH] drm/i915/display: nuke skl workaround for pre-production hw Lucas De Marchi
2019-12-20 22:11 ` Chris Wilson
2019-12-21 1:00 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
@ 2019-12-23 20:35 ` Matt Roper
2019-12-24 0:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: nuke skl workaround for pre-production hw (rev2) Patchwork
` (2 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Matt Roper @ 2019-12-23 20:35 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
On Fri, Dec 20, 2019 at 02:06:50PM -0800, Lucas De Marchi wrote:
> According to intel_detect_preproduction_hw(), the SKL steeping D0 is
> still pre-preproduction so we can nuke the additional workaround.
>
> While at it, nuke dangling new line.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Bspec 13626 agrees that everything up to and including F0 is
pre-production.
s/steeping/stepping/ in the commit message, but otherwise
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index e6702b9b9117..4aa7dfa88c7c 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -16018,14 +16018,8 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv)
> if (intel_ddi_crt_present(dev_priv))
> intel_crt_init(dev_priv);
>
> - /*
> - * Haswell uses DDI functions to detect digital outputs.
> - * On SKL pre-D0 the strap isn't connected, so we assume
> - * it's there.
> - */
> found = I915_READ(DDI_BUF_CTL(PORT_A)) & DDI_INIT_DISPLAY_DETECTED;
> - /* WaIgnoreDDIAStrap: skl */
> - if (found || IS_GEN9_BC(dev_priv))
> + if (found)
> intel_ddi_init(dev_priv, PORT_A);
>
> /* DDI B, C, D, and F detection is indicated by the SFUSE_STRAP
> @@ -16046,7 +16040,6 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv)
> if (IS_GEN9_BC(dev_priv) &&
> intel_bios_is_port_present(dev_priv, PORT_E))
> intel_ddi_init(dev_priv, PORT_E);
> -
> } else if (HAS_PCH_SPLIT(dev_priv)) {
> int found;
>
> --
> 2.24.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: nuke skl workaround for pre-production hw (rev2)
2019-12-20 22:06 [Intel-gfx] [PATCH] drm/i915/display: nuke skl workaround for pre-production hw Lucas De Marchi
` (2 preceding siblings ...)
2019-12-23 20:35 ` [Intel-gfx] [PATCH] " Matt Roper
@ 2019-12-24 0:00 ` Patchwork
2019-12-27 4:49 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-01-03 17:01 ` [Intel-gfx] [PATCH] drm/i915/display: nuke skl workaround for pre-production hw Ruhl, Michael J
5 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-12-24 0:00 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/display: nuke skl workaround for pre-production hw (rev2)
URL : https://patchwork.freedesktop.org/series/71230/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7630 -> Patchwork_15906
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/index.html
Known issues
------------
Here are the changes found in Patchwork_15906 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@reload-with-fault-injection:
- fi-cfl-guc: [PASS][1] -> [INCOMPLETE][2] ([i915#505] / [i915#671])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/fi-cfl-guc/igt@i915_module_load@reload-with-fault-injection.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/fi-cfl-guc/igt@i915_module_load@reload-with-fault-injection.html
#### Possible fixes ####
* igt@gem_exec_create@basic:
- {fi-tgl-u}: [INCOMPLETE][3] ([fdo#111736]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/fi-tgl-u/igt@gem_exec_create@basic.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/fi-tgl-u/igt@gem_exec_create@basic.html
* igt@i915_selftest@live_execlists:
- fi-kbl-soraka: [DMESG-FAIL][5] ([i915#656]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/fi-kbl-soraka/igt@i915_selftest@live_execlists.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/fi-kbl-soraka/igt@i915_selftest@live_execlists.html
* igt@i915_selftest@live_memory_region:
- fi-bwr-2160: [FAIL][7] -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/fi-bwr-2160/igt@i915_selftest@live_memory_region.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/fi-bwr-2160/igt@i915_selftest@live_memory_region.html
#### Warnings ####
* igt@i915_selftest@live_blt:
- fi-hsw-4770: [DMESG-FAIL][9] ([i915#725]) -> [DMESG-FAIL][10] ([i915#553] / [i915#725])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/fi-hsw-4770/igt@i915_selftest@live_blt.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/fi-hsw-4770/igt@i915_selftest@live_blt.html
* igt@kms_busy@basic-flip-pipe-b:
- fi-kbl-x1275: [DMESG-WARN][11] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][12] ([i915#62] / [i915#92]) +6 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/fi-kbl-x1275/igt@kms_busy@basic-flip-pipe-b.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/fi-kbl-x1275/igt@kms_busy@basic-flip-pipe-b.html
* igt@kms_force_connector_basic@prune-stale-modes:
- fi-kbl-x1275: [DMESG-WARN][13] ([i915#62] / [i915#92]) -> [DMESG-WARN][14] ([i915#62] / [i915#92] / [i915#95]) +6 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/fi-kbl-x1275/igt@kms_force_connector_basic@prune-stale-modes.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/fi-kbl-x1275/igt@kms_force_connector_basic@prune-stale-modes.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#111736]: https://bugs.freedesktop.org/show_bug.cgi?id=111736
[i915#435]: https://gitlab.freedesktop.org/drm/intel/issues/435
[i915#505]: https://gitlab.freedesktop.org/drm/intel/issues/505
[i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#656]: https://gitlab.freedesktop.org/drm/intel/issues/656
[i915#671]: https://gitlab.freedesktop.org/drm/intel/issues/671
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (43 -> 38)
------------------------------
Additional (6): fi-hsw-4770r fi-skl-6770hq fi-glk-dsi fi-whl-u fi-ivb-3770 fi-bsw-nick
Missing (11): fi-ilk-m540 fi-bsw-n3050 fi-byt-squawks fi-bsw-cyan fi-tgl-y fi-ctg-p8600 fi-blb-e6850 fi-byt-n2820 fi-byt-clapper fi-bdw-samus fi-kbl-r
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7630 -> Patchwork_15906
CI-20190529: 20190529
CI_DRM_7630: 28a2aa0ebf1520ea8a0dd89299f7ceea80dfd96f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5352: 0586d205f651674e575351c2d5a7d0760716c9f1 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15906: 4e4667cba36744fe229627ebd76b0d3298a79b33 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
4e4667cba367 drm/i915/display: nuke skl workaround for pre-production hw
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: nuke skl workaround for pre-production hw (rev2)
2019-12-20 22:06 [Intel-gfx] [PATCH] drm/i915/display: nuke skl workaround for pre-production hw Lucas De Marchi
` (3 preceding siblings ...)
2019-12-24 0:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: nuke skl workaround for pre-production hw (rev2) Patchwork
@ 2019-12-27 4:49 ` Patchwork
2020-01-03 17:01 ` [Intel-gfx] [PATCH] drm/i915/display: nuke skl workaround for pre-production hw Ruhl, Michael J
5 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-12-27 4:49 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/display: nuke skl workaround for pre-production hw (rev2)
URL : https://patchwork.freedesktop.org/series/71230/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7630_full -> Patchwork_15906_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
New tests
---------
New tests have been introduced between CI_DRM_7630_full and Patchwork_15906_full:
### New Piglit tests (8) ###
* spec@arb_draw_buffers@fbo-mrt-new-bind:
- Statuses : 1 fail(s)
- Exec time: [0.12] s
* spec@arb_texture_cube_map_array@texturesize@tes-texturesize-usamplercubearray:
- Statuses : 1 fail(s)
- Exec time: [0.09] s
* spec@arb_texture_cube_map_array@texturesize@vs-texturesize-usamplercubearray:
- Statuses : 1 fail(s)
- Exec time: [0.11] s
* spec@arb_vertex_attrib_64bit@execution@vs_in@vs-input-double_double_array3-position-double_dmat2x4_array2:
- Statuses : 1 fail(s)
- Exec time: [0.16] s
* spec@arb_vertex_attrib_64bit@execution@vs_in@vs-input-uint_uint_array3-position-double_dmat4x3:
- Statuses : 1 fail(s)
- Exec time: [0.12] s
* spec@ext_framebuffer_multisample@draw-buffers-alpha-to-coverage 8:
- Statuses : 1 fail(s)
- Exec time: [0.20] s
* spec@ext_framebuffer_multisample@sample-alpha-to-coverage 8 color:
- Statuses : 1 fail(s)
- Exec time: [0.16] s
* spec@glsl-4.20@execution@vs_in@vs-input-position-double_dmat4x2_array3-double_dvec4:
- Statuses : 1 fail(s)
- Exec time: [0.16] s
Known issues
------------
Here are the changes found in Patchwork_15906_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_busy@close-race:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2] ([i915#435])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-tglb8/igt@gem_busy@close-race.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-tglb6/igt@gem_busy@close-race.html
* igt@gem_ctx_persistence@processes:
- shard-skl: [PASS][3] -> [FAIL][4] ([i915#570])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-skl9/igt@gem_ctx_persistence@processes.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-skl5/igt@gem_ctx_persistence@processes.html
* igt@gem_exec_suspend@basic-s3:
- shard-tglb: [PASS][5] -> [INCOMPLETE][6] ([fdo#111736] / [i915#460])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-tglb8/igt@gem_exec_suspend@basic-s3.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-tglb4/igt@gem_exec_suspend@basic-s3.html
* igt@gem_sync@basic-each:
- shard-tglb: [PASS][7] -> [INCOMPLETE][8] ([i915#472] / [i915#707])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-tglb9/igt@gem_sync@basic-each.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-tglb6/igt@gem_sync@basic-each.html
* igt@gem_sync@basic-store-all:
- shard-tglb: [PASS][9] -> [INCOMPLETE][10] ([i915#472])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-tglb1/igt@gem_sync@basic-store-all.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-tglb3/igt@gem_sync@basic-store-all.html
* igt@i915_pm_rpm@system-suspend:
- shard-tglb: [PASS][11] -> [INCOMPLETE][12] ([i915#435] / [i915#460])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-tglb8/igt@i915_pm_rpm@system-suspend.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-tglb7/igt@i915_pm_rpm@system-suspend.html
* igt@i915_selftest@live_gem_contexts:
- shard-tglb: [PASS][13] -> [INCOMPLETE][14] ([i915#455])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-tglb2/igt@i915_selftest@live_gem_contexts.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-tglb4/igt@i915_selftest@live_gem_contexts.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-skl: [PASS][15] -> [INCOMPLETE][16] ([i915#300])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-skl10/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-skl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-tglb: [PASS][17] -> [INCOMPLETE][18] ([i915#456] / [i915#460])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-tglb6/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-tglb5/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_cursor_crc@pipe-c-cursor-256x256-onscreen:
- shard-skl: [PASS][19] -> [FAIL][20] ([i915#54])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-skl7/igt@kms_cursor_crc@pipe-c-cursor-256x256-onscreen.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-skl4/igt@kms_cursor_crc@pipe-c-cursor-256x256-onscreen.html
* igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-untiled:
- shard-skl: [PASS][21] -> [FAIL][22] ([i915#52] / [i915#54])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-skl1/igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-untiled.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-skl2/igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-untiled.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: [PASS][23] -> [FAIL][24] ([i915#79])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-skl5/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-skl6/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-apl: [PASS][25] -> [DMESG-WARN][26] ([i915#180]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-apl8/igt@kms_flip@flip-vs-suspend-interruptible.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-apl7/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_flip_tiling@flip-to-yf-tiled:
- shard-skl: [PASS][27] -> [FAIL][28] ([fdo#107931] / [i915#167])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-skl9/igt@kms_flip_tiling@flip-to-yf-tiled.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-skl5/igt@kms_flip_tiling@flip-to-yf-tiled.html
* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-tglb: [PASS][29] -> [FAIL][30] ([i915#49]) +3 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-stridechange.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-stridechange.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-snb: [PASS][31] -> [DMESG-WARN][32] ([i915#42])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-snb7/igt@kms_frontbuffer_tracking@fbc-suspend.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-snb6/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][33] -> [FAIL][34] ([fdo#108145] / [i915#265])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-skl9/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-skl3/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][35] -> [FAIL][36] ([i915#31])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-apl1/igt@kms_setmode@basic.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-apl2/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][37] -> [DMESG-WARN][38] ([i915#180]) +6 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-kbl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-kbl3/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend:
- shard-tglb: [PASS][39] -> [INCOMPLETE][40] ([i915#460]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-tglb9/igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-tglb4/igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend.html
#### Possible fixes ####
* igt@gem_ctx_isolation@bcs0-s3:
- shard-kbl: [DMESG-WARN][41] ([i915#180]) -> [PASS][42] +2 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-kbl7/igt@gem_ctx_isolation@bcs0-s3.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-kbl4/igt@gem_ctx_isolation@bcs0-s3.html
* igt@gem_ctx_persistence@bcs0-mixed-process:
- shard-skl: [FAIL][43] ([i915#679]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-skl7/igt@gem_ctx_persistence@bcs0-mixed-process.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-skl2/igt@gem_ctx_persistence@bcs0-mixed-process.html
* igt@gem_ctx_shared@q-smoketest-blt:
- shard-tglb: [INCOMPLETE][45] ([fdo#111735]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-tglb6/igt@gem_ctx_shared@q-smoketest-blt.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-tglb7/igt@gem_ctx_shared@q-smoketest-blt.html
* igt@gem_eio@unwedge-stress:
- shard-tglb: [INCOMPLETE][47] ([i915#469]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-tglb6/igt@gem_eio@unwedge-stress.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-tglb3/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_gttfill@basic:
- shard-tglb: [INCOMPLETE][49] ([fdo#111593]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-tglb5/igt@gem_exec_gttfill@basic.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-tglb2/igt@gem_exec_gttfill@basic.html
* igt@gem_exec_nop@basic-sequential:
- shard-tglb: [INCOMPLETE][51] ([i915#435]) -> [PASS][52] +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-tglb6/igt@gem_exec_nop@basic-sequential.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-tglb7/igt@gem_exec_nop@basic-sequential.html
* igt@gem_exec_parallel@contexts:
- shard-tglb: [INCOMPLETE][53] ([i915#470]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-tglb9/igt@gem_exec_parallel@contexts.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-tglb1/igt@gem_exec_parallel@contexts.html
* igt@gem_exec_schedule@smoketest-bsd2:
- shard-tglb: [INCOMPLETE][55] ([i915#707]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-tglb4/igt@gem_exec_schedule@smoketest-bsd2.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-tglb2/igt@gem_exec_schedule@smoketest-bsd2.html
* igt@kms_color@pipe-a-ctm-0-5:
- shard-skl: [DMESG-WARN][57] ([i915#109]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-skl4/igt@kms_color@pipe-a-ctm-0-5.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-skl1/igt@kms_color@pipe-a-ctm-0-5.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-tglb: [INCOMPLETE][59] ([i915#456] / [i915#460]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-tglb3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-tglb9/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding:
- shard-skl: [FAIL][61] ([i915#54]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-skl6/igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-skl5/igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding.html
* igt@kms_flip@2x-plain-flip-ts-check-interruptible:
- shard-glk: [FAIL][63] -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-glk7/igt@kms_flip@2x-plain-flip-ts-check-interruptible.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-glk8/igt@kms_flip@2x-plain-flip-ts-check-interruptible.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [FAIL][65] ([i915#79]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-skl4/igt@kms_flip@flip-vs-expired-vblank.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-skl10/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: [FAIL][67] ([i915#79]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-glk5/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-glk8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-tglb: [INCOMPLETE][69] ([i915#456] / [i915#460] / [i915#516]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-tglb1/igt@kms_flip@flip-vs-suspend-interruptible.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-tglb9/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][71] ([fdo#108145]) -> [PASS][72] +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-skl1/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][73] ([fdo#108145] / [i915#265]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-apl: [DMESG-WARN][75] ([i915#180]) -> [PASS][76] +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-apl1/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-apl2/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
#### Warnings ####
* igt@gem_tiled_blits@interruptible:
- shard-hsw: [FAIL][77] ([i915#818]) -> [INCOMPLETE][78] ([i915#61])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-hsw1/igt@gem_tiled_blits@interruptible.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/shard-hsw1/igt@gem_tiled_blits@interruptible.html
[fdo#107931]: https://bugs.freedesktop.org/show_bug.cgi?id=107931
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#111593]: https://bugs.freedesktop.org/show_bug.cgi?id=111593
[fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
[fdo#111736]: https://bugs.freedesktop.org/show_bug.cgi?id=111736
[i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109
[i915#167]: https://gitlab.freedesktop.org/drm/intel/issues/167
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#42]: https://gitlab.freedesktop.org/drm/intel/issues/42
[i915#435]: https://gitlab.freedesktop.org/drm/intel/issues/435
[i915#455]: https://gitlab.freedesktop.org/drm/intel/issues/455
[i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
[i915#460]: https://gitlab.freedesktop.org/drm/intel/issues/460
[i915#469]: https://gitlab.freedesktop.org/drm/intel/issues/469
[i915#470]: https://gitlab.freedesktop.org/drm/intel/issues/470
[i915#472]: https://gitlab.freedesktop.org/drm/intel/issues/472
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#516]: https://gitlab.freedesktop.org/drm/intel/issues/516
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#570]: https://gitlab.freedesktop.org/drm/intel/issues/570
[i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
[i915#679]: https://gitlab.freedesktop.org/drm/intel/issues/679
[i915#707]: https://gitlab.freedesktop.org/drm/intel/issues/707
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#818]: https://gitlab.freedesktop.org/drm/intel/issues/818
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7630 -> Patchwork_15906
CI-20190529: 20190529
CI_DRM_7630: 28a2aa0ebf1520ea8a0dd89299f7ceea80dfd96f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5352: 0586d205f651674e575351c2d5a7d0760716c9f1 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15906: 4e4667cba36744fe229627ebd76b0d3298a79b33 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15906/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915/display: nuke skl workaround for pre-production hw
2019-12-20 22:06 [Intel-gfx] [PATCH] drm/i915/display: nuke skl workaround for pre-production hw Lucas De Marchi
` (4 preceding siblings ...)
2019-12-27 4:49 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2020-01-03 17:01 ` Ruhl, Michael J
5 siblings, 0 replies; 10+ messages in thread
From: Ruhl, Michael J @ 2020-01-03 17:01 UTC (permalink / raw)
To: De Marchi, Lucas, intel-gfx
>-----Original Message-----
>From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Lucas
>De Marchi
>Sent: Friday, December 20, 2019 5:07 PM
>To: intel-gfx@lists.freedesktop.org
>Subject: [Intel-gfx] [PATCH] drm/i915/display: nuke skl workaround for pre-
>production hw
>
>According to intel_detect_preproduction_hw(), the SKL steeping D0 is
s/steeping/stepping/
?
M
>still pre-preproduction so we can nuke the additional workaround.
>
>While at it, nuke dangling new line.
>
>Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>---
> drivers/gpu/drm/i915/display/intel_display.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_display.c
>b/drivers/gpu/drm/i915/display/intel_display.c
>index e6702b9b9117..4aa7dfa88c7c 100644
>--- a/drivers/gpu/drm/i915/display/intel_display.c
>+++ b/drivers/gpu/drm/i915/display/intel_display.c
>@@ -16018,14 +16018,8 @@ static void intel_setup_outputs(struct
>drm_i915_private *dev_priv)
> if (intel_ddi_crt_present(dev_priv))
> intel_crt_init(dev_priv);
>
>- /*
>- * Haswell uses DDI functions to detect digital outputs.
>- * On SKL pre-D0 the strap isn't connected, so we assume
>- * it's there.
>- */
> found = I915_READ(DDI_BUF_CTL(PORT_A)) &
>DDI_INIT_DISPLAY_DETECTED;
>- /* WaIgnoreDDIAStrap: skl */
>- if (found || IS_GEN9_BC(dev_priv))
>+ if (found)
> intel_ddi_init(dev_priv, PORT_A);
>
> /* DDI B, C, D, and F detection is indicated by the
>SFUSE_STRAP
>@@ -16046,7 +16040,6 @@ static void intel_setup_outputs(struct
>drm_i915_private *dev_priv)
> if (IS_GEN9_BC(dev_priv) &&
> intel_bios_is_port_present(dev_priv, PORT_E))
> intel_ddi_init(dev_priv, PORT_E);
>-
> } else if (HAS_PCH_SPLIT(dev_priv)) {
> int found;
>
>--
>2.24.0
>
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread