From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 840B0C2D0C0 for ; Mon, 23 Dec 2019 21:55:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 58FD5206B7 for ; Mon, 23 Dec 2019 21:55:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58FD5206B7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1EC506E44A; Mon, 23 Dec 2019 21:55:01 +0000 (UTC) Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id A50DC6E44A for ; Mon, 23 Dec 2019 21:54:59 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 19676691-1500050 for multiple; Mon, 23 Dec 2019 21:54:57 +0000 MIME-Version: 1.0 To: Lucas De Marchi From: Chris Wilson In-Reply-To: <20191223212336.tcwyxtpovhsgh32r@ldmartin-desk1> References: <20191223204411.2355304-1-chris@chris-wilson.co.uk> <20191223212336.tcwyxtpovhsgh32r@ldmartin-desk1> Message-ID: <157713809505.2689.9297067467556760741@skylake-alporthouse-com> User-Agent: alot/0.6 Date: Mon, 23 Dec 2019 21:54:55 +0000 Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915: Add spaces before compound GEM_TRACE X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Lucas De Marchi (2019-12-23 21:23:36) > On Mon, Dec 23, 2019 at 08:44:10PM +0000, Chris Wilson wrote: > >Add a space between the prefixed format and the users format so that the > >join are not mistakenly combined into one long word. > > > >Fixes: 639f2f24895f ("drm/i915: Introduce new macros for tracing") > >Signed-off-by: Chris Wilson > >Cc: Venkata Sandeep Dhanalakota > >--- > > drivers/gpu/drm/i915/gt/intel_context.h | 2 +- > > drivers/gpu/drm/i915/i915_request.h | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > >diff --git a/drivers/gpu/drm/i915/gt/intel_context.h b/drivers/gpu/drm/i915/gt/intel_context.h > >index 1d4a1b1357cf..0f5ae4ff3b10 100644 > >--- a/drivers/gpu/drm/i915/gt/intel_context.h > >+++ b/drivers/gpu/drm/i915/gt/intel_context.h > >@@ -19,7 +19,7 @@ > > > > #define CE_TRACE(ce, fmt, ...) do { \ > > const struct intel_context *ce__ = (ce); \ > >- ENGINE_TRACE(ce__->engine, "context:%llx" fmt, \ > >+ ENGINE_TRACE(ce__->engine, "context:%llx " fmt, \ > > ce__->timeline->fence_context, \ > > ##__VA_ARGS__); \ > > } while (0) > >diff --git a/drivers/gpu/drm/i915/i915_request.h b/drivers/gpu/drm/i915/i915_request.h > >index 565322640378..9784421a3b4d 100644 > >--- a/drivers/gpu/drm/i915/i915_request.h > >+++ b/drivers/gpu/drm/i915/i915_request.h > >@@ -51,7 +51,7 @@ struct i915_capture_list { > > > > #define RQ_TRACE(rq, fmt, ...) do { \ > > const struct i915_request *rq__ = (rq); \ > >- ENGINE_TRACE(rq__->engine, "fence %llx:%lld, current %d" fmt, \ > >+ ENGINE_TRACE(rq__->engine, "fence %llx:%lld, current %d " fmt, \ > > do we care about the trailing space if fmt is "\n"? No. An extra space in a debug log, which you only see when something blows up and only compiled in for CI, is the last of your worries. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx