All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Wahren <stefan.wahren@i2se.com>
To: Phil Elwell <phil@raspberrypi.org>
Cc: Aishwarya Pant <aishpant@gmail.com>,
	Eric Anholt <eric@anholt.net>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-rpi-kernel@lists.infradead.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v2] staging: bcm2835-audio: Fix memory corruption
Date: Sun, 24 Sep 2017 00:44:41 +0200 (CEST)	[thread overview]
Message-ID: <1577139582.379288.1506206681123@email.1und1.de> (raw)
In-Reply-To: <20170923161554.GA13023@kroah.com>

Hi Phil,

> Greg Kroah-Hartman <gregkh@linuxfoundation.org> hat am 23. September 2017 um 18:15 geschrieben:
> 
> 
> On Sat, Sep 23, 2017 at 12:57:33PM +0200, Stefan Wahren wrote:
> > Hi Greg,
> > 
> > > Phil Elwell <phil@raspberrypi.org> hat am 11. August 2017 um 12:20 geschrieben:
> > > 
> > > 
> > > The previous commit (0adbfd46) fixed a memory leak but also freed a
> > > block in the success case, causing a stale pointer to be used with
> > > potentially fatal results. Only free the vchi_instance block in the
> > > case that vchi_connect fails; once connected, the instance is
> > > retained for subsequent connections.
> > > 
> > > Simplifying the code by removing a bunch of gotos and returning errors
> > > directly.
> > > 
> > > Signed-off-by: Phil Elwell <phil@raspberrypi.org>
> > > Fixes: 0adbfd4694c2 ("staging: bcm2835-audio: fix memory leak in bcm2835_audio_open_connection()")
> > 
> > can you still apply this patch or do you need a resend?
> 
> Hm, I don't see this anywhere in my tree, or in my todo mbox, so yes,
> please resend it, thanks.

could you please resend this patch?

Thanks
Stefan

> 
> greg k-h

      reply	other threads:[~2017-09-23 22:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-11 10:20 [PATCH v2] staging: bcm2835-audio: Fix memory corruption Phil Elwell
2017-08-11 13:46 ` Dan Carpenter
2017-09-23 10:57 ` Stefan Wahren
2017-09-23 16:15   ` Greg Kroah-Hartman
2017-09-23 22:44     ` Stefan Wahren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1577139582.379288.1506206681123@email.1und1.de \
    --to=stefan.wahren@i2se.com \
    --cc=aishpant@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=eric@anholt.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=phil@raspberrypi.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.