From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mimi Zohar Date: Fri, 03 Jan 2020 14:15:37 +0000 Subject: Re: [PATCH v6 1/3] IMA: Define workqueue for early boot key measurements Message-Id: <1578060937.5874.140.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="ibm852" Content-Transfer-Encoding: base64 List-Id: References: <20200103055608.22491-1-nramas@linux.microsoft.com> <20200103055608.22491-2-nramas@linux.microsoft.com> In-Reply-To: <20200103055608.22491-2-nramas@linux.microsoft.com> To: Lakshmi Ramasubramanian , James.Bottomley@HansenPartnership.com, linux-integrity@vger.kernel.org Cc: eric.snowberg@oracle.com, dhowells@redhat.com, mathew.j.martineau@linux.intel.com, matthewgarrett@google.com, sashal@kernel.org, jamorris@linux.microsoft.com, linux-kernel@vger.kernel.org, keyrings@vger.kernel.org SGkgTGFrc2htaSwKCk9uIFRodSwgMjAyMC0wMS0wMiBhdCAyMTo1NiAtMDgwMCwgTGFrc2htaSBS YW1hc3VicmFtYW5pYW4gd3JvdGU6Cj4gTWVhc3VyaW5nIGtleXMgcmVxdWlyZXMgYSBjdXN0b20g SU1BIHBvbGljeSB0byBiZSBsb2FkZWQuCj4gS2V5cyBjcmVhdGVkIG9yIHVwZGF0ZWQgYmVmb3Jl IGEgY3VzdG9tIElNQSBwb2xpY3kgaXMgbG9hZGVkIHNob3VsZAo+IGJlIHF1ZXVlZCBhbmQgdGhl IGtleXMgc2hvdWxkIGJlIHByb2Nlc3NlZCBhZnRlciBhIGN1c3RvbSBwb2xpY3kKPiBpcyBsb2Fk ZWQuCj4gCj4gVGhpcyBwYXRjaCBkZWZpbmVzIHdvcmtxdWV1ZSBmb3IgcXVldWluZyBrZXlzIHdo ZW4gYSBjdXN0b20gSU1BIHBvbGljeQo+IGhhcyBub3QgeWV0IGJlZW4gbG9hZGVkLgo+IAo+IEEg ZmxhZyBuYW1lbHkgaW1hX3Byb2Nlc3Nfa2V5cyBpcyB1c2VkIHRvIGNoZWNrIGlmIHRoZSBrZXkg c2hvdWxkIGJlCj4gcXVldWVkIG9yIHNob3VsZCBiZSBwcm9jZXNzZWQgaW1tZWRpYXRlbHkuCj4g Cj4gU2lnbmVkLW9mZi1ieTogTGFrc2htaSBSYW1hc3VicmFtYW5pYW4gPG5yYW1hc0BsaW51eC5t aWNyb3NvZnQuY29tPgo+IFJlcG9ydGVkLWJ5OiBrZXJuZWwgdGVzdCByb2JvdCA8cm9uZy5hLmNo ZW5AaW50ZWwuY29tPgo+IFJlcG9ydGVkLWJ5OiBrYnVpbGQgdGVzdCByb2JvdCA8bGtwQGludGVs LmNvbT4KClRoZSBjaGFuZ2VzIGJhc2VkIG9uICJrZXJuZWwgdGVzdCByb2JvdCIgcmVwb3J0cyBh cmUgcHJvcGVybHkgZm9sZGVkCmludG8gdGhpcyBwYXRjaCwgYnV0IHVubGVzcyB0aGUgdGFnIC0g IkFja2VkLWJ5IiwgIlJlcG9ydGVkLWJ5IiAtIGlzCnF1YWxpZmllZCwgaXQgcmVmZXJzIHRvIHRo ZSBlbnRpcmUgcGF0Y2guIMKgTGV0J3MgbGltaXQgaXQgYXM6CgpSZXBvcnRlZC1ieToga2VybmVs IHRlc3Qgcm9ib3QgPHJvbmcuYS5jaGVuQGludGVsLmNvbT4gIyBzbGVlcGluZwpmdW5jdGlvbiBj YWxsZWQgZnJvbSBpbnZhbGlkIGNvbnRleHQKUmVwb3J0ZWQtYnk6IGtidWlsZCB0ZXN0IHJvYm90 IDxsa3BAaW50ZWwuY29tPiAjIHNwYXJzZSBzeW1ib2wKaW1hX3F1ZXVlZF9rZXkoKSBzaG91bGQg YmUgc3RhdGljCgpNaW1pCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C8FBC2D0CE for ; Fri, 3 Jan 2020 14:15:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D2282064B for ; Fri, 3 Jan 2020 14:15:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727835AbgACOPr (ORCPT ); Fri, 3 Jan 2020 09:15:47 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:60250 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727523AbgACOPr (ORCPT ); Fri, 3 Jan 2020 09:15:47 -0500 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 003ECJHI110425 for ; Fri, 3 Jan 2020 09:15:45 -0500 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0b-001b2d01.pphosted.com with ESMTP id 2x9wwve6rk-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 03 Jan 2020 09:15:44 -0500 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 3 Jan 2020 14:15:43 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 3 Jan 2020 14:15:40 -0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 003EFd7031523070 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 3 Jan 2020 14:15:39 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8976EA4040; Fri, 3 Jan 2020 14:15:39 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E7FB3A404D; Fri, 3 Jan 2020 14:15:37 +0000 (GMT) Received: from localhost.localdomain (unknown [9.80.213.69]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 3 Jan 2020 14:15:37 +0000 (GMT) Subject: Re: [PATCH v6 1/3] IMA: Define workqueue for early boot key measurements From: Mimi Zohar To: Lakshmi Ramasubramanian , James.Bottomley@HansenPartnership.com, linux-integrity@vger.kernel.org Cc: eric.snowberg@oracle.com, dhowells@redhat.com, mathew.j.martineau@linux.intel.com, matthewgarrett@google.com, sashal@kernel.org, jamorris@linux.microsoft.com, linux-kernel@vger.kernel.org, keyrings@vger.kernel.org Date: Fri, 03 Jan 2020 09:15:37 -0500 In-Reply-To: <20200103055608.22491-2-nramas@linux.microsoft.com> References: <20200103055608.22491-1-nramas@linux.microsoft.com> <20200103055608.22491-2-nramas@linux.microsoft.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 20010314-0008-0000-0000-000003463B2B X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20010314-0009-0000-0000-00004A6674CA Message-Id: <1578060937.5874.140.camel@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2020-01-03_04:2020-01-02,2020-01-03 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 mlxlogscore=800 malwarescore=0 impostorscore=0 adultscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 spamscore=0 phishscore=0 bulkscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-2001030133 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lakshmi, On Thu, 2020-01-02 at 21:56 -0800, Lakshmi Ramasubramanian wrote: > Measuring keys requires a custom IMA policy to be loaded. > Keys created or updated before a custom IMA policy is loaded should > be queued and the keys should be processed after a custom policy > is loaded. > > This patch defines workqueue for queuing keys when a custom IMA policy > has not yet been loaded. > > A flag namely ima_process_keys is used to check if the key should be > queued or should be processed immediately. > > Signed-off-by: Lakshmi Ramasubramanian > Reported-by: kernel test robot > Reported-by: kbuild test robot The changes based on "kernel test robot" reports are properly folded into this patch, but unless the tag - "Acked-by", "Reported-by" - is qualified, it refers to the entire patch.  Let's limit it as: Reported-by: kernel test robot # sleeping function called from invalid context Reported-by: kbuild test robot # sparse symbol ima_queued_key() should be static Mimi