From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14CB0C33CAD for ; Mon, 13 Jan 2020 11:18:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E11E4207FF for ; Mon, 13 Jan 2020 11:18:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727331AbgAMLSB convert rfc822-to-8bit (ORCPT ); Mon, 13 Jan 2020 06:18:01 -0500 Received: from mail.fireflyinternet.com ([109.228.58.192]:52061 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725992AbgAMLSB (ORCPT ); Mon, 13 Jan 2020 06:18:01 -0500 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 19860154-1500050 for multiple; Mon, 13 Jan 2020 11:17:55 +0000 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Wambui Karuga , airlied@linux.ie, daniel@ffwll.ch, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com From: Chris Wilson In-Reply-To: <20200113111025.2048-1-wambui.karugax@gmail.com> Cc: sean@poorly.run, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20200113111025.2048-1-wambui.karugax@gmail.com> Message-ID: <157891427231.27314.12398974277241668021@skylake-alporthouse-com> User-Agent: alot/0.6 Subject: Re: [PATCH] drm/i915: convert to new logging macros based on struct intel_engine_cs. Date: Mon, 13 Jan 2020 11:17:52 +0000 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Wambui Karuga (2020-01-13 11:10:25) > fn(...) { > ... > struct intel_engine_cs *E = ...; > +struct drm_i915_private *dev_priv = E->i915; No new dev_priv. There should be no reason for drm_dbg here, as the rest of the debug is behind ENGINE_TRACE and so the vestigial debug should be moved over, or deleted as not being useful. The error messages look unhelpful. > if ((batch_end - cmd) < length) { > - DRM_DEBUG("CMD: Command length exceeds batch length: 0x%08X length=%u batchlen=%td\n", > - *cmd, > - length, > - batch_end - cmd); > + drm_dbg(&dev_priv->drm, > + "CMD: Command length exceeds batch length: 0x%08X length=%u batchlen=%td\n", No. This is not driver debug. If anything this should be pr_debug, or some over user centric channel. -Chris From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 076A6C33CAD for ; Mon, 13 Jan 2020 11:18:06 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DBD59207FF for ; Mon, 13 Jan 2020 11:18:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBD59207FF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5A95E89BC0; Mon, 13 Jan 2020 11:18:05 +0000 (UTC) Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 29F0589BC0; Mon, 13 Jan 2020 11:18:04 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 19860154-1500050 for multiple; Mon, 13 Jan 2020 11:17:55 +0000 MIME-Version: 1.0 To: Wambui Karuga , airlied@linux.ie, daniel@ffwll.ch, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com From: Chris Wilson In-Reply-To: <20200113111025.2048-1-wambui.karugax@gmail.com> References: <20200113111025.2048-1-wambui.karugax@gmail.com> Message-ID: <157891427231.27314.12398974277241668021@skylake-alporthouse-com> User-Agent: alot/0.6 Subject: Re: [PATCH] drm/i915: convert to new logging macros based on struct intel_engine_cs. Date: Mon, 13 Jan 2020 11:17:52 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, sean@poorly.run, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Wambui Karuga (2020-01-13 11:10:25) > fn(...) { > ... > struct intel_engine_cs *E = ...; > +struct drm_i915_private *dev_priv = E->i915; No new dev_priv. There should be no reason for drm_dbg here, as the rest of the debug is behind ENGINE_TRACE and so the vestigial debug should be moved over, or deleted as not being useful. The error messages look unhelpful. > if ((batch_end - cmd) < length) { > - DRM_DEBUG("CMD: Command length exceeds batch length: 0x%08X length=%u batchlen=%td\n", > - *cmd, > - length, > - batch_end - cmd); > + drm_dbg(&dev_priv->drm, > + "CMD: Command length exceeds batch length: 0x%08X length=%u batchlen=%td\n", No. This is not driver debug. If anything this should be pr_debug, or some over user centric channel. -Chris _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54A35C33CAD for ; Mon, 13 Jan 2020 11:18:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32B27207FF for ; Mon, 13 Jan 2020 11:18:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32B27207FF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E11756E059; Mon, 13 Jan 2020 11:18:05 +0000 (UTC) Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 29F0589BC0; Mon, 13 Jan 2020 11:18:04 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 19860154-1500050 for multiple; Mon, 13 Jan 2020 11:17:55 +0000 MIME-Version: 1.0 To: Wambui Karuga , airlied@linux.ie, daniel@ffwll.ch, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com From: Chris Wilson In-Reply-To: <20200113111025.2048-1-wambui.karugax@gmail.com> References: <20200113111025.2048-1-wambui.karugax@gmail.com> Message-ID: <157891427231.27314.12398974277241668021@skylake-alporthouse-com> User-Agent: alot/0.6 Date: Mon, 13 Jan 2020 11:17:52 +0000 Subject: Re: [Intel-gfx] [PATCH] drm/i915: convert to new logging macros based on struct intel_engine_cs. X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Wambui Karuga (2020-01-13 11:10:25) > fn(...) { > ... > struct intel_engine_cs *E = ...; > +struct drm_i915_private *dev_priv = E->i915; No new dev_priv. There should be no reason for drm_dbg here, as the rest of the debug is behind ENGINE_TRACE and so the vestigial debug should be moved over, or deleted as not being useful. The error messages look unhelpful. > if ((batch_end - cmd) < length) { > - DRM_DEBUG("CMD: Command length exceeds batch length: 0x%08X length=%u batchlen=%td\n", > - *cmd, > - length, > - batch_end - cmd); > + drm_dbg(&dev_priv->drm, > + "CMD: Command length exceeds batch length: 0x%08X length=%u batchlen=%td\n", No. This is not driver debug. If anything this should be pr_debug, or some over user centric channel. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx