From: Chris Wilson <chris@chris-wilson.co.uk>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 2/4] drm/i915: Use common priotree lists for virtual engine
Date: Tue, 14 Jan 2020 11:38:07 +0000 [thread overview]
Message-ID: <157900188699.27314.1253220724434401947@skylake-alporthouse-com> (raw)
In-Reply-To: <9b90921d-be2b-0c17-c1e6-32cdfec3ab19@linux.intel.com>
Quoting Tvrtko Ursulin (2020-01-14 11:13:06)
>
>
> On 13/01/2020 10:44, Chris Wilson wrote:
> > @@ -2473,6 +2475,7 @@ static void execlists_submit_request(struct i915_request *request)
> > spin_lock_irqsave(&engine->active.lock, flags);
> >
> > queue_request(engine, &request->sched, rq_prio(request));
> > + set_bit(I915_FENCE_FLAG_PQUEUE, &request->fence.flags);
>
> Move into queue_request so it is closer to priolist management, just like at other call sites?
Sure. When going through them, it felt natural to treat this as the list
operation. (That's what I was thinking :)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-14 11:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 10:44 [Intel-gfx] [PATCH 1/4] drm/i915/gt: Always reset the timeslice after a context switch Chris Wilson
2020-01-13 10:44 ` [Intel-gfx] [PATCH 2/4] drm/i915: Use common priotree lists for virtual engine Chris Wilson
2020-01-14 11:13 ` Tvrtko Ursulin
2020-01-14 11:20 ` Chris Wilson
2020-01-14 13:48 ` Tvrtko Ursulin
2020-01-14 13:53 ` Chris Wilson
2020-01-14 11:38 ` Chris Wilson [this message]
2020-01-14 11:55 ` [Intel-gfx] [PATCH v2] " Chris Wilson
2020-01-13 10:44 ` [Intel-gfx] [PATCH 3/4] drm/i915/gt: Allow temporary suspension of inflight requests Chris Wilson
2020-01-14 18:33 ` Tvrtko Ursulin
2020-01-14 18:57 ` Chris Wilson
2020-01-13 10:44 ` [Intel-gfx] [PATCH 4/4] drm/i915/execlists: Offline error capture Chris Wilson
2020-01-13 11:32 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/gt: Always reset the timeslice after a context switch Patchwork
2020-01-13 12:59 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-01-13 13:00 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
2020-01-13 17:26 ` [Intel-gfx] [PATCH 1/4] " Tvrtko Ursulin
2020-01-14 12:51 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/4] drm/i915/gt: Always reset the timeslice after a context switch (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157900188699.27314.1253220724434401947@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.