From: Chris Wilson <chris@chris-wilson.co.uk>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 2/3] drm/i915/gt: Allow temporary suspension of inflight requests
Date: Wed, 15 Jan 2020 11:01:35 +0000 [thread overview]
Message-ID: <157908609527.12549.10044345164172735540@skylake-alporthouse-com> (raw)
In-Reply-To: <c01c5bb7-2d57-43b2-5497-bb737890a935@linux.intel.com>
Quoting Tvrtko Ursulin (2020-01-15 10:58:39)
>
> On 15/01/2020 08:33, Chris Wilson wrote:
> > +static bool hold_request(const struct i915_request *rq)
> > +{
> > + struct i915_dependency *p;
> > +
> > + /*
> > + * If one of our ancestors is still on hold, we must also still be on
> > + * hold, otherwise we will bypass it and execute before it.
> > + */
> > + list_for_each_entry(p, &rq->sched.signalers_list, signal_link) {
> > + const struct i915_request *s =
> > + container_of(p->signaler, typeof(*s), sched);
> > +
> > + if (s->engine != rq->engine)
> > + continue;
> > +
> > + return i915_request_has_hold(s);
>
> It shouldn't be:
>
> if (i915_request_has_hold(s))
> return true;
>
> ?
Yes, it should be.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-15 11:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 8:33 [Intel-gfx] [PATCH 1/3] drm/i915: Use common priotree lists for virtual engine Chris Wilson
2020-01-15 8:33 ` [Intel-gfx] [PATCH 2/3] drm/i915/gt: Allow temporary suspension of inflight requests Chris Wilson
2020-01-15 10:58 ` Tvrtko Ursulin
2020-01-15 11:01 ` Chris Wilson [this message]
2020-01-15 11:10 ` [Intel-gfx] [PATCH v3] " Chris Wilson
2020-01-15 11:37 ` Tvrtko Ursulin
2020-01-15 11:46 ` Chris Wilson
2020-01-16 17:12 ` Tvrtko Ursulin
2020-01-15 8:33 ` [Intel-gfx] [PATCH 3/3] drm/i915/execlists: Offline error capture Chris Wilson
2020-01-16 17:22 ` Tvrtko Ursulin
2020-01-16 17:48 ` Chris Wilson
2020-01-16 18:14 ` Tvrtko Ursulin
2020-01-16 18:32 ` Chris Wilson
2020-01-15 9:02 ` [Intel-gfx] [PATCH v2] drm/i915: Keep track of request among the scheduling lists Chris Wilson
2020-01-16 17:23 ` Tvrtko Ursulin
2020-01-15 9:44 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2] drm/i915: Keep track of request among the scheduling lists (rev2) Patchwork
2020-01-15 10:06 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-01-15 10:06 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
2020-01-15 14:37 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2] drm/i915: Keep track of request among the scheduling lists (rev3) Patchwork
2020-01-15 14:37 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
2020-01-17 20:47 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157908609527.12549.10044345164172735540@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.