From: David Howells <dhowells@redhat.com> To: torvalds@linux-foundation.org Cc: dhowells@redhat.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Casey Schaufler <casey@schaufler-ca.com>, Stephen Smalley <sds@tycho.nsa.gov>, nicolas.dichtel@6wind.com, raven@themaw.net, Christian Brauner <christian@brauner.io>, dhowells@redhat.com, keyrings@vger.kernel.org, linux-usb@vger.kernel.org, linux-block@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH 04/14] pipe: Add O_NOTIFICATION_PIPE [ver #3] Date: Wed, 15 Jan 2020 13:31:11 +0000 [thread overview] Message-ID: <157909507195.20155.11337528682255354415.stgit@warthog.procyon.org.uk> (raw) In-Reply-To: <157909503552.20155.3030058841911628518.stgit@warthog.procyon.org.uk> Add an O_NOTIFICATION_PIPE flag that can be passed to pipe2() to indicate that the pipe being created is going to be used for notifications. This suppresses the use of splice(), vmsplice(), tee() and sendfile() on the pipe as calling iov_iter_revert() on a pipe when a kernel notification message has been inserted into the middle of a multi-buffer splice will be messy. The flag is given the same value as O_EXCL as it seems unlikely that this flag will ever be applicable to pipes and I don't want to use up another O_* bit unnecessarily. An alternative could be to add a pipe3() system call. Signed-off-by: David Howells <dhowells@redhat.com> --- include/uapi/linux/watch_queue.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/uapi/linux/watch_queue.h b/include/uapi/linux/watch_queue.h index 5f3d21e8a34b..9df72227f515 100644 --- a/include/uapi/linux/watch_queue.h +++ b/include/uapi/linux/watch_queue.h @@ -3,6 +3,9 @@ #define _UAPI_LINUX_WATCH_QUEUE_H #include <linux/types.h> +#include <linux/fcntl.h> + +#define O_NOTIFICATION_PIPE O_EXCL /* Parameter to pipe2() selecting notification pipe */ enum watch_notification_type { WATCH_TYPE_META = 0, /* Special record */
WARNING: multiple messages have this Message-ID
From: David Howells <dhowells@redhat.com> To: torvalds@linux-foundation.org Cc: dhowells@redhat.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Casey Schaufler <casey@schaufler-ca.com>, Stephen Smalley <sds@tycho.nsa.gov>, nicolas.dichtel@6wind.com, raven@themaw.net, Christian Brauner <christian@brauner.io>dhowells@redhat.com, keyrings@vger.kernel.org, linux-usb@vger.kernel.org, linux-block@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH 04/14] pipe: Add O_NOTIFICATION_PIPE [ver #3] Date: Wed, 15 Jan 2020 13:31:11 +0000 [thread overview] Message-ID: <157909507195.20155.11337528682255354415.stgit@warthog.procyon.org.uk> (raw) In-Reply-To: <157909503552.20155.3030058841911628518.stgit@warthog.procyon.org.uk> Add an O_NOTIFICATION_PIPE flag that can be passed to pipe2() to indicate that the pipe being created is going to be used for notifications. This suppresses the use of splice(), vmsplice(), tee() and sendfile() on the pipe as calling iov_iter_revert() on a pipe when a kernel notification message has been inserted into the middle of a multi-buffer splice will be messy. The flag is given the same value as O_EXCL as it seems unlikely that this flag will ever be applicable to pipes and I don't want to use up another O_* bit unnecessarily. An alternative could be to add a pipe3() system call. Signed-off-by: David Howells <dhowells@redhat.com> --- include/uapi/linux/watch_queue.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/uapi/linux/watch_queue.h b/include/uapi/linux/watch_queue.h index 5f3d21e8a34b..9df72227f515 100644 --- a/include/uapi/linux/watch_queue.h +++ b/include/uapi/linux/watch_queue.h @@ -3,6 +3,9 @@ #define _UAPI_LINUX_WATCH_QUEUE_H #include <linux/types.h> +#include <linux/fcntl.h> + +#define O_NOTIFICATION_PIPE O_EXCL /* Parameter to pipe2() selecting notification pipe */ enum watch_notification_type { WATCH_TYPE_META = 0, /* Special record */
WARNING: multiple messages have this Message-ID
From: David Howells <dhowells@redhat.com> To: torvalds@linux-foundation.org Cc: dhowells@redhat.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Casey Schaufler <casey@schaufler-ca.com>, Stephen Smalley <sds@tycho.nsa.gov>, nicolas.dichtel@6wind.com, raven@themaw.net, Christian Brauner <christian@brauner.io>dhowells@redhat.com, keyrings@vger.kernel.org, linux-usb@vger.kernel.org, linux-block@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.orglinux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH 04/14] pipe: Add O_NOTIFICATION_PIPE [ver #3] Date: Wed, 15 Jan 2020 13:31:11 +0000 [thread overview] Message-ID: <157909507195.20155.11337528682255354415.stgit@warthog.procyon.org.uk> (raw) In-Reply-To: <157909503552.20155.3030058841911628518.stgit@warthog.procyon.org.uk> Add an O_NOTIFICATION_PIPE flag that can be passed to pipe2() to indicate that the pipe being created is going to be used for notifications. This suppresses the use of splice(), vmsplice(), tee() and sendfile() on the pipe as calling iov_iter_revert() on a pipe when a kernel notification message has been inserted into the middle of a multi-buffer splice will be messy. The flag is given the same value as O_EXCL as it seems unlikely that this flag will ever be applicable to pipes and I don't want to use up another O_* bit unnecessarily. An alternative could be to add a pipe3() system call. Signed-off-by: David Howells <dhowells@redhat.com> --- include/uapi/linux/watch_queue.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/uapi/linux/watch_queue.h b/include/uapi/linux/watch_queue.h index 5f3d21e8a34b..9df72227f515 100644 --- a/include/uapi/linux/watch_queue.h +++ b/include/uapi/linux/watch_queue.h @@ -3,6 +3,9 @@ #define _UAPI_LINUX_WATCH_QUEUE_H #include <linux/types.h> +#include <linux/fcntl.h> + +#define O_NOTIFICATION_PIPE O_EXCL /* Parameter to pipe2() selecting notification pipe */ enum watch_notification_type { WATCH_TYPE_META = 0, /* Special record */
next prev parent reply other threads:[~2020-01-15 13:31 UTC|newest] Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-15 13:30 [RFC PATCH 00/14] pipe: Keyrings, Block and USB notifications " David Howells 2020-01-15 13:30 ` David Howells 2020-01-15 13:30 ` David Howells 2020-01-15 13:30 ` [RFC PATCH 01/14] uapi: General notification queue definitions " David Howells 2020-01-15 13:30 ` David Howells 2020-01-15 13:30 ` David Howells 2020-01-15 13:30 ` [RFC PATCH 02/14] security: Add hooks to rule on setting a watch " David Howells 2020-01-15 13:30 ` David Howells 2020-01-15 13:30 ` David Howells 2020-01-15 13:31 ` [RFC PATCH 03/14] security: Add a hook for the point of notification insertion " David Howells 2020-01-15 13:31 ` David Howells 2020-01-15 13:31 ` David Howells 2020-01-15 13:31 ` David Howells [this message] 2020-01-15 13:31 ` [RFC PATCH 04/14] pipe: Add O_NOTIFICATION_PIPE " David Howells 2020-01-15 13:31 ` David Howells 2020-01-15 13:31 ` [RFC PATCH 05/14] pipe: Add general notification queue support " David Howells 2020-01-15 13:31 ` David Howells 2020-01-15 13:31 ` David Howells 2020-01-15 13:31 ` [RFC PATCH 06/14] keys: Add a notification facility " David Howells 2020-01-15 13:31 ` David Howells 2020-01-15 13:31 ` David Howells 2020-01-15 13:31 ` [RFC PATCH 07/14] Add sample notification program " David Howells 2020-01-15 13:31 ` David Howells 2020-01-15 13:31 ` David Howells 2020-01-26 15:47 ` Guenter Roeck 2020-01-26 15:47 ` Guenter Roeck 2020-01-26 15:47 ` Guenter Roeck 2020-01-15 13:31 ` [RFC PATCH 08/14] pipe: Allow buffers to be marked read-whole-or-error for notifications " David Howells 2020-01-15 13:31 ` David Howells 2020-01-15 13:31 ` David Howells 2020-01-15 13:31 ` [RFC PATCH 09/14] pipe: Add notification lossage handling " David Howells 2020-01-15 13:31 ` David Howells 2020-01-15 13:31 ` David Howells 2020-01-15 13:32 ` [RFC PATCH 10/14] Add a general, global device notification watch list " David Howells 2020-01-15 13:32 ` David Howells 2020-01-15 13:32 ` David Howells 2020-01-15 13:32 ` [RFC PATCH 11/14] block: Add block layer notifications " David Howells 2020-01-15 13:32 ` David Howells 2020-01-15 13:32 ` David Howells 2020-01-15 13:32 ` [RFC PATCH 12/14] usb: Add USB subsystem " David Howells 2020-01-15 13:32 ` David Howells 2020-01-15 13:32 ` David Howells 2020-01-15 13:32 ` [RFC PATCH 13/14] selinux: Implement the watch_key security hook " David Howells 2020-01-15 13:32 ` David Howells 2020-01-15 13:32 ` David Howells 2020-01-15 13:32 ` [RFC PATCH 14/14] smack: Implement the watch_key and post_notification hooks " David Howells 2020-01-15 13:32 ` David Howells 2020-01-15 13:32 ` David Howells 2020-01-15 20:10 ` [RFC PATCH 00/14] pipe: Keyrings, Block and USB notifications " Linus Torvalds 2020-01-15 20:10 ` Linus Torvalds 2020-02-11 0:56 ` Andres Freund 2020-02-11 0:56 ` Andres Freund 2020-01-15 21:07 ` David Howells 2020-01-15 21:07 ` David Howells -- strict thread matches above, loose matches on Subject: below -- 2019-11-07 13:35 [RFC PATCH 00/14] pipe: Keyrings, Block and USB notifications [ver #2] David Howells 2019-11-07 13:35 ` David Howells 2019-11-07 13:35 ` David Howells 2019-11-07 13:35 ` [RFC PATCH 01/14] uapi: General notification queue definitions " David Howells 2019-11-07 13:35 ` David Howells 2019-11-07 13:35 ` David Howells 2019-11-07 13:35 ` [RFC PATCH 02/14] security: Add hooks to rule on setting a watch " David Howells 2019-11-07 13:35 ` David Howells 2019-11-07 13:35 ` David Howells 2019-11-07 13:35 ` [RFC PATCH 03/14] security: Add a hook for the point of notification insertion " David Howells 2019-11-07 13:35 ` David Howells 2019-11-07 13:35 ` David Howells 2019-11-07 13:35 ` [RFC PATCH 04/14] pipe: Add O_NOTIFICATION_PIPE " David Howells 2019-11-07 13:35 ` David Howells 2019-11-07 13:35 ` David Howells 2019-11-07 18:16 ` Andy Lutomirski 2019-11-07 18:16 ` Andy Lutomirski 2019-11-07 18:48 ` David Howells 2019-11-08 5:06 ` Andy Lutomirski 2019-11-08 5:06 ` Andy Lutomirski 2019-11-08 6:42 ` David Howells 2019-11-07 13:36 ` [RFC PATCH 05/14] pipe: Add general notification queue support " David Howells 2019-11-07 13:36 ` David Howells 2019-11-07 13:36 ` David Howells 2019-11-07 13:36 ` [RFC PATCH 06/14] keys: Add a notification facility " David Howells 2019-11-07 13:36 ` David Howells 2019-11-07 13:36 ` David Howells 2019-11-07 13:36 ` [RFC PATCH 07/14] Add sample notification program " David Howells 2019-11-07 13:36 ` David Howells 2019-11-07 13:36 ` David Howells 2019-11-07 13:36 ` [RFC PATCH 08/14] pipe: Allow buffers to be marked read-whole-or-error for notifications " David Howells 2019-11-07 13:36 ` David Howells 2019-11-07 13:36 ` David Howells 2019-11-07 18:15 ` Andy Lutomirski 2019-11-07 18:15 ` [RFC PATCH 08/14] pipe: Allow buffers to be marked read-whole-or-error for notifications [ver #2 Andy Lutomirski 2019-11-07 18:23 ` [RFC PATCH 08/14] pipe: Allow buffers to be marked read-whole-or-error for notifications [ver #2] David Howells 2019-11-07 18:23 ` [RFC PATCH 08/14] pipe: Allow buffers to be marked read-whole-or-error for notifications [ver #2 David Howells 2019-11-07 13:36 ` [RFC PATCH 09/14] pipe: Add notification lossage handling [ver #2] David Howells 2019-11-07 13:36 ` David Howells 2019-11-07 13:36 ` David Howells 2019-11-07 13:36 ` [RFC PATCH 10/14] Add a general, global device notification watch list " David Howells 2019-11-07 13:36 ` David Howells 2019-11-07 13:36 ` David Howells 2019-11-07 13:37 ` [RFC PATCH 11/14] block: Add block layer notifications " David Howells 2019-11-07 13:37 ` David Howells 2019-11-07 13:37 ` David Howells 2019-11-07 13:37 ` [RFC PATCH 12/14] usb: Add USB subsystem " David Howells 2019-11-07 13:37 ` David Howells 2019-11-07 13:37 ` David Howells 2019-11-07 13:37 ` [RFC PATCH 13/14] selinux: Implement the watch_key security hook " David Howells 2019-11-07 13:37 ` David Howells 2019-11-07 13:37 ` David Howells 2019-11-07 13:37 ` [RFC PATCH 14/14] smack: Implement the watch_key and post_notification hooks " David Howells 2019-11-07 13:37 ` David Howells 2019-11-07 13:37 ` David Howells 2019-11-07 17:16 ` [RFC PATCH 05/14] pipe: Add general notification queue support " David Howells
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=157909507195.20155.11337528682255354415.stgit@warthog.procyon.org.uk \ --to=dhowells@redhat.com \ --cc=casey@schaufler-ca.com \ --cc=christian@brauner.io \ --cc=gregkh@linuxfoundation.org \ --cc=keyrings@vger.kernel.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=nicolas.dichtel@6wind.com \ --cc=raven@themaw.net \ --cc=sds@tycho.nsa.gov \ --cc=torvalds@linux-foundation.org \ --subject='Re: [RFC PATCH 04/14] pipe: Add O_NOTIFICATION_PIPE [ver #3]' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.