From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1925BC433B4 for ; Wed, 21 Apr 2021 09:09:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D8F2E61425 for ; Wed, 21 Apr 2021 09:09:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237625AbhDUJJf (ORCPT ); Wed, 21 Apr 2021 05:09:35 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:16610 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233975AbhDUJJc (ORCPT ); Wed, 21 Apr 2021 05:09:32 -0400 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FQF6K6TBWz17RWx; Wed, 21 Apr 2021 17:06:33 +0800 (CST) Received: from [10.136.110.154] (10.136.110.154) by smtp.huawei.com (10.3.19.212) with Microsoft SMTP Server (TLS) id 14.3.498.0; Wed, 21 Apr 2021 17:08:50 +0800 Subject: Re: [f2fs-dev] [PATCH v4] f2fs: compress: add compress_inode to cache compressed blockst To: Jaegeuk Kim CC: , References: <20210202080056.51658-1-yuchao0@huawei.com> <46e9924c-0086-cd2a-2e93-7149b92ba27e@huawei.com> <01a0ff76-6fa7-3196-8760-e7f6f163ef64@huawei.com> From: Chao Yu Message-ID: <157988c7-079f-0c9f-5cf9-e83bc2f835d1@huawei.com> Date: Wed, 21 Apr 2021 17:08:50 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.110.154] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/3/11 4:52, Jaegeuk Kim wrote: > On 03/09, Chao Yu wrote: >> On 2021/3/9 8:01, Jaegeuk Kim wrote: >>> On 03/05, Chao Yu wrote: >>>> On 2021/3/5 4:20, Jaegeuk Kim wrote: >>>>> On 02/27, Jaegeuk Kim wrote: >>>>>> On 02/04, Chao Yu wrote: >>>>>>> Jaegeuk, >>>>>>> >>>>>>> On 2021/2/2 16:00, Chao Yu wrote: >>>>>>>> - for (i = 0; i < dic->nr_cpages; i++) { >>>>>>>> + for (i = 0; i < cc->nr_cpages; i++) { >>>>>>>> struct page *page = dic->cpages[i]; >>>>>>> >>>>>>> por_fsstress still hang in this line? >>>>>> >>>>>> I'm stuck on testing the patches, since the latest kernel is panicking somehow. >>>>>> Let me update later, once I can test a bit. :( >>>>> >>>>> It seems this works without error. >>>>> https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=4e6e1364dccba80ed44925870b97fbcf989b96c9 >>>> >>>> Ah, good news. >>>> >>>> Thanks for helping to test the patch. :) >>> >>> Hmm, I hit this again. Let me check w/o compress_cache back. :( >> >> Oops :( > > Ok, apprantely that panic is caused by compress_cache. The test is running over > 24hours w/o it. Jaegeuk, I'm still struggling troubleshooting this issue. However, I failed again to reproduce this bug, I doubt the reason may be my test script and environment(device type/size) is different from yours. (btw, I used pmem as back-end device, and test w/ all fault injection points and w/o write_io/checkpoint fault injection points) Could you please share me your run.sh script? and test command? And I'd like to ask what's your device type and size? Thanks, > . > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B8DAC43461 for ; Wed, 21 Apr 2021 09:09:15 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1943561444; Wed, 21 Apr 2021 09:09:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1943561444 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.92.3) (envelope-from ) id 1lZ8rC-0006K1-8r; Wed, 21 Apr 2021 09:09:14 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) (envelope-from ) id 1lZ8r9-0006Jr-Vi for linux-f2fs-devel@lists.sourceforge.net; Wed, 21 Apr 2021 09:09:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ur5tjmtS7qRaHF+vUWX8XAkiI01TTz+vNP9g7b4mHTk=; b=UhJX1XZnpX0IazaoDS3iYRvtoV McuT5lOPz8XG10y1O7K/ncrl5SNa7s15ZbV4rUApFraDNt2+9OL+zUrTvtBNK3EWPcEYf56ynNk1F S6rnNsmAXjID4MwQPKCxDpWXMXbOW6ZCVSK3MYKdDpGJyw+9o10KyeabEmnt+NerMBCc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ur5tjmtS7qRaHF+vUWX8XAkiI01TTz+vNP9g7b4mHTk=; b=E6uDlYQpk+EjnWDfFWyYGVkWG7 FUkcWn0qsX5M3yXb9G0lqxjvQNvnVvQicJibGHfd1zGbUZb+goZ3MU8anWxmMcVPcF8u1qj12TaLg HoUq2oYsfT2+m5cXlOYXFDQx8/Lf5Q82RPS2MbVVqMlCOlh6+N7JAq8awbUJ5ESmNI4w=; Received: from szxga04-in.huawei.com ([45.249.212.190]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1lZ8r3-0074CP-Vz for linux-f2fs-devel@lists.sourceforge.net; Wed, 21 Apr 2021 09:09:12 +0000 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FQF6K6TBWz17RWx; Wed, 21 Apr 2021 17:06:33 +0800 (CST) Received: from [10.136.110.154] (10.136.110.154) by smtp.huawei.com (10.3.19.212) with Microsoft SMTP Server (TLS) id 14.3.498.0; Wed, 21 Apr 2021 17:08:50 +0800 To: Jaegeuk Kim References: <20210202080056.51658-1-yuchao0@huawei.com> <46e9924c-0086-cd2a-2e93-7149b92ba27e@huawei.com> <01a0ff76-6fa7-3196-8760-e7f6f163ef64@huawei.com> From: Chao Yu Message-ID: <157988c7-079f-0c9f-5cf9-e83bc2f835d1@huawei.com> Date: Wed, 21 Apr 2021 17:08:50 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.136.110.154] X-CFilter-Loop: Reflected X-Headers-End: 1lZ8r3-0074CP-Vz Subject: Re: [f2fs-dev] [PATCH v4] f2fs: compress: add compress_inode to cache compressed blockst X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2021/3/11 4:52, Jaegeuk Kim wrote: > On 03/09, Chao Yu wrote: >> On 2021/3/9 8:01, Jaegeuk Kim wrote: >>> On 03/05, Chao Yu wrote: >>>> On 2021/3/5 4:20, Jaegeuk Kim wrote: >>>>> On 02/27, Jaegeuk Kim wrote: >>>>>> On 02/04, Chao Yu wrote: >>>>>>> Jaegeuk, >>>>>>> >>>>>>> On 2021/2/2 16:00, Chao Yu wrote: >>>>>>>> - for (i = 0; i < dic->nr_cpages; i++) { >>>>>>>> + for (i = 0; i < cc->nr_cpages; i++) { >>>>>>>> struct page *page = dic->cpages[i]; >>>>>>> >>>>>>> por_fsstress still hang in this line? >>>>>> >>>>>> I'm stuck on testing the patches, since the latest kernel is panicking somehow. >>>>>> Let me update later, once I can test a bit. :( >>>>> >>>>> It seems this works without error. >>>>> https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=4e6e1364dccba80ed44925870b97fbcf989b96c9 >>>> >>>> Ah, good news. >>>> >>>> Thanks for helping to test the patch. :) >>> >>> Hmm, I hit this again. Let me check w/o compress_cache back. :( >> >> Oops :( > > Ok, apprantely that panic is caused by compress_cache. The test is running over > 24hours w/o it. Jaegeuk, I'm still struggling troubleshooting this issue. However, I failed again to reproduce this bug, I doubt the reason may be my test script and environment(device type/size) is different from yours. (btw, I used pmem as back-end device, and test w/ all fault injection points and w/o write_io/checkpoint fault injection points) Could you please share me your run.sh script? and test command? And I'd like to ask what's your device type and size? Thanks, > . > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel