From mboxrd@z Thu Jan 1 00:00:00 1970 From: Icenowy Zheng Subject: Re: [PATCH v3 4/4] arm64: dts: allwinner: a64: add SRAM controller device tree node Date: Tue, 19 Jun 2018 22:27:09 +0800 Message-ID: <15798B96-01B4-4D48-8695-64D4DC80E7D3@aosc.io> References: <20180614153548.9644-1-wens@csie.org> <20180614153548.9644-5-wens@csie.org> <2687631.x8iGEoiUx5@jernej-laptop> <5C14D945-0795-4100-86E2-6FBF04350715@aosc.io> Reply-To: icenowy-h8G6r0blFSE@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.orgJagan Teki Cc: linux-arm-kernel , =?UTF-8?Q?Jernej_=C5=A0krabec?= , linux-sunxi , Mark Rutland , devicetree , Maxime Ripard , Chen-Yu Tsai , Rob Herring List-Id: devicetree@vger.kernel.org =E4=BA=8E 2018=E5=B9=B46=E6=9C=8819=E6=97=A5 GMT+08:00 =E4=B8=8B=E5=8D=883:= 36:19, Jagan Teki =E5=86=99=E5=88=B0: >On Fri, Jun 15, 2018 at 4:39 AM, Icenowy Zheng wrote: >> >> >> =E4=BA=8E 2018=E5=B9=B46=E6=9C=8815=E6=97=A5 GMT+08:00 =E4=B8=8A=E5=8D= =881:27:21, "Jernej =C5=A0krabec" > =E5=86=99=E5=88=B0: >>>Dne =C4=8Detrtek, 14. junij 2018 ob 19:09:56 CEST je Jagan Teki >napisal(a): >>>> On Thu, Jun 14, 2018 at 9:05 PM, Chen-Yu Tsai >wrote: >>>> > From: Icenowy Zheng >>>> > >>>> > Allwinner A64 has a SRAM controller, and in the device tree >>>currently >>>> > we have a syscon node to enable EMAC driver to access the EMAC >>>clock >>>> > register. As SRAM controller driver can now export regmap for >this >>>> > register, replace the syscon node to the SRAM controller device >>>node, >>>> > and let EMAC driver to acquire its EMAC clock regmap. >>>> > >>>> > Signed-off-by: Icenowy Zheng >>>> > [wens-jdAy2FN1RRM@public.gmane.org: Updated compatible string] >>>> > Signed-off-by: Chen-Yu Tsai >>>> > --- >>>> > >>>> > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 19 >>>+++++++++++++++++-- >>>> > 1 file changed, 17 insertions(+), 2 deletions(-) >>>> > >>>> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >>>> > b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index >>>> > 1b2ef28c42bd..87968dafe1dc 100644 >>>> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >>>> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >>>> > @@ -169,9 +169,24 @@ >>>> > >>>> > ranges; >>>> > >>>> > syscon: syscon@1c00000 { >>>> > >>>> > - compatible =3D >>>> > "allwinner,sun50i-a64-system-controller", - >>> >>>> > "syscon"; >>>> > + compatible =3D >>>> > "allwinner,sun50i-a64-system-control"; >>>> > >>>> > reg =3D <0x01c00000 0x1000>; >>>> > >>>> > + #address-cells =3D <1>; >>>> > + #size-cells =3D <1>; >>>> > + ranges; >>>> > + >>>> > + sram_c: sram@18000 { >>>> > + compatible =3D "mmio-sram"; >>>> > + reg =3D <0x00018000 0x28000>; >>>> > + #address-cells =3D <1>; >>>> > + #size-cells =3D <1>; >>>> > + ranges =3D <0 0x00018000 0x28000>; >>>> > + >>>> > + de2_sram: sram-section@0 { >>>> >>>> So, this can attach to display-engine node through allwinner,sram >and >>>> add support to claim the sram on sun4i/sun4i_drv.c, correct? >>> >>>Actually, it has to be added to display_clocks node and claimed in >>>drivers/ >>>clk/sunxi-ng/ccu-sun8i-de2.c >> >> Sorry it's old practice. >> >> My new way is to add a bus driver which claims the SRAM. > >Are you pointing this driver[1] ? if yes do we have recent version >patches for these changes so-that I can import. I'll resend it when this patchset is ready. > >[1] https://patchwork.kernel.org/patch/10290399/ --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: icenowy@aosc.io (Icenowy Zheng) Date: Tue, 19 Jun 2018 22:27:09 +0800 Subject: [linux-sunxi] [PATCH v3 4/4] arm64: dts: allwinner: a64: add SRAM controller device tree node In-Reply-To: References: <20180614153548.9644-1-wens@csie.org> <20180614153548.9644-5-wens@csie.org> <2687631.x8iGEoiUx5@jernej-laptop> <5C14D945-0795-4100-86E2-6FBF04350715@aosc.io> Message-ID: <15798B96-01B4-4D48-8695-64D4DC80E7D3@aosc.io> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org ? 2018?6?19? GMT+08:00 ??3:36:19, Jagan Teki ??: >On Fri, Jun 15, 2018 at 4:39 AM, Icenowy Zheng wrote: >> >> >> ? 2018?6?15? GMT+08:00 ??1:27:21, "Jernej ?krabec" > ??: >>>Dne ?etrtek, 14. junij 2018 ob 19:09:56 CEST je Jagan Teki >napisal(a): >>>> On Thu, Jun 14, 2018 at 9:05 PM, Chen-Yu Tsai >wrote: >>>> > From: Icenowy Zheng >>>> > >>>> > Allwinner A64 has a SRAM controller, and in the device tree >>>currently >>>> > we have a syscon node to enable EMAC driver to access the EMAC >>>clock >>>> > register. As SRAM controller driver can now export regmap for >this >>>> > register, replace the syscon node to the SRAM controller device >>>node, >>>> > and let EMAC driver to acquire its EMAC clock regmap. >>>> > >>>> > Signed-off-by: Icenowy Zheng >>>> > [wens at csie.org: Updated compatible string] >>>> > Signed-off-by: Chen-Yu Tsai >>>> > --- >>>> > >>>> > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 19 >>>+++++++++++++++++-- >>>> > 1 file changed, 17 insertions(+), 2 deletions(-) >>>> > >>>> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >>>> > b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index >>>> > 1b2ef28c42bd..87968dafe1dc 100644 >>>> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >>>> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >>>> > @@ -169,9 +169,24 @@ >>>> > >>>> > ranges; >>>> > >>>> > syscon: syscon at 1c00000 { >>>> > >>>> > - compatible = >>>> > "allwinner,sun50i-a64-system-controller", - >>> >>>> > "syscon"; >>>> > + compatible = >>>> > "allwinner,sun50i-a64-system-control"; >>>> > >>>> > reg = <0x01c00000 0x1000>; >>>> > >>>> > + #address-cells = <1>; >>>> > + #size-cells = <1>; >>>> > + ranges; >>>> > + >>>> > + sram_c: sram at 18000 { >>>> > + compatible = "mmio-sram"; >>>> > + reg = <0x00018000 0x28000>; >>>> > + #address-cells = <1>; >>>> > + #size-cells = <1>; >>>> > + ranges = <0 0x00018000 0x28000>; >>>> > + >>>> > + de2_sram: sram-section at 0 { >>>> >>>> So, this can attach to display-engine node through allwinner,sram >and >>>> add support to claim the sram on sun4i/sun4i_drv.c, correct? >>> >>>Actually, it has to be added to display_clocks node and claimed in >>>drivers/ >>>clk/sunxi-ng/ccu-sun8i-de2.c >> >> Sorry it's old practice. >> >> My new way is to add a bus driver which claims the SRAM. > >Are you pointing this driver[1] ? if yes do we have recent version >patches for these changes so-that I can import. I'll resend it when this patchset is ready. > >[1] https://patchwork.kernel.org/patch/10290399/