From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 260E3C35247 for ; Mon, 3 Feb 2020 17:37:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 084962080C for ; Mon, 3 Feb 2020 17:37:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 084962080C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 789FC6E3FE; Mon, 3 Feb 2020 17:37:29 +0000 (UTC) Received: from fireflyinternet.com (unknown [77.68.26.236]) by gabe.freedesktop.org (Postfix) with ESMTPS id 390986E3FE for ; Mon, 3 Feb 2020 17:37:27 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 20103417-1500050 for multiple; Mon, 03 Feb 2020 17:37:14 +0000 MIME-Version: 1.0 To: Matthew Auld , intel-gfx@lists.freedesktop.org From: Chris Wilson In-Reply-To: <8a3d1405-c6c0-4190-7085-7c697326e6d1@intel.com> References: <20200203094152.4150550-1-chris@chris-wilson.co.uk> <20200203094152.4150550-4-chris@chris-wilson.co.uk> <8a3d1405-c6c0-4190-7085-7c697326e6d1@intel.com> Message-ID: <158075143184.27392.7841098289893052329@skylake-alporthouse-com> User-Agent: alot/0.6 Date: Mon, 03 Feb 2020 17:37:11 +0000 Subject: Re: [Intel-gfx] [PATCH 4/6] drm/i915/selftests: Add a simple rollover for the kernel context X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Matthew Auld (2020-02-03 17:32:29) > On 03/02/2020 09:41, Chris Wilson wrote: > > + for (i = 0; i < ARRAY_SIZE(rq); i++) { > > + rq[i] = i915_request_create(ce); > > + if (IS_ERR(rq[i])) { > > + err = PTR_ERR(rq[i]); > > + goto out; > > + } > > + ... > > +out: > > + for (i = 0; i < ARRAY_SIZE(rq); i++) > > + i915_request_put(rq[i]); > > !IS_ERR_OR_NULL()? Oh drat, I let err into rq[]. I'll rework the assignment to avoid putting the ERR_PTR here. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx