From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98FE2C2D0B1 for ; Tue, 4 Feb 2020 09:09:54 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 439CA2084E for ; Tue, 4 Feb 2020 09:09:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 439CA2084E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DC1A06EDFC; Tue, 4 Feb 2020 09:09:53 +0000 (UTC) Received: from fireflyinternet.com (unknown [77.68.26.236]) by gabe.freedesktop.org (Postfix) with ESMTPS id E85FC6EDFC for ; Tue, 4 Feb 2020 09:09:52 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 20108687-1500050 for multiple; Tue, 04 Feb 2020 09:09:50 +0000 MIME-Version: 1.0 To: Andi Shyti From: Chris Wilson In-Reply-To: <20200204090636.GA1670@intel.intel> References: <20200203202110.670209-1-chris@chris-wilson.co.uk> <20200204090636.GA1670@intel.intel> Message-ID: <158080738803.27392.10698748710924477408@skylake-alporthouse-com> User-Agent: alot/0.6 Date: Tue, 04 Feb 2020 09:09:48 +0000 Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Fix rc6 on Ivybridge X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Andi Shyti (2020-02-04 09:06:36) > Hi Chris, > > > The current rc6 threshold is larger than the evaluation interval on > > Ivybridge; it never enters rc6. Remove the special casing so it behaves > > like the other gen6/gen7, and we see rc6 residencies before we manually > > park the system. > > > > Closes: https://gitlab.freedesktop.org/drm/intel/issues/1114 > > Testcase: igt/i915_pm_rc6_residency/rc6-idle #ivb > > Signed-off-by: Chris Wilson > > Cc: Andi Shyti > > --- > > drivers/gpu/drm/i915/gt/intel_rc6.c | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.c b/drivers/gpu/drm/i915/gt/intel_rc6.c > > index 01a99fdbb3c4..682f598f7042 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_rc6.c > > +++ b/drivers/gpu/drm/i915/gt/intel_rc6.c > > @@ -226,10 +226,7 @@ static void gen6_rc6_enable(struct intel_rc6 *rc6) > > > > set(uncore, GEN6_RC_SLEEP, 0); > > set(uncore, GEN6_RC1e_THRESHOLD, 1000); > > - if (IS_IVYBRIDGE(i915)) > > - set(uncore, GEN6_RC6_THRESHOLD, 125000); > > - else > > - set(uncore, GEN6_RC6_THRESHOLD, 50000); > > + set(uncore, GEN6_RC6_THRESHOLD, 50000); > > why was is set like this in a first place? No one knows. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx