From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A22A5C2D0B1 for ; Fri, 7 Feb 2020 06:29:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 64C4320838 for ; Fri, 7 Feb 2020 06:29:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="HdO234FF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726816AbgBGG3J (ORCPT ); Fri, 7 Feb 2020 01:29:09 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:61291 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726417AbgBGG3J (ORCPT ); Fri, 7 Feb 2020 01:29:09 -0500 X-UUID: 8bbd85f1ab1647128adf2e7a48c741a2-20200207 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=R/+a0fdrCDE55+6NHJbY91tgYCmhdw3+sIz81IyvB4g=; b=HdO234FFanK4JzHsBHdy4uzl3Z8p1rFOlSX1F+VDNMRB1dSz1IocidIrm3rh5jb2VoyL2xumRm4MUL6mkuGZ813LHDa6QE2Q7YzHG3UGKQCHDTTfsUWa+ywO3VxCKyJqW8EkwDjKbj76EWU3SwA8xUq2AguMLnvtixKRv4B9ecY=; X-UUID: 8bbd85f1ab1647128adf2e7a48c741a2-20200207 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1799503453; Fri, 07 Feb 2020 14:29:01 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 7 Feb 2020 14:28:19 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 7 Feb 2020 14:28:24 +0800 Message-ID: <1581056939.22229.55.camel@mtkswgap22> Subject: Re: [PATCH v1 1/1] binder: transaction latency tracking for user build From: Frankie Chang To: Joel Fernandes CC: Greg Kroah-Hartman , Todd Kjos , Martijn Coenen , "Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?=" , Christian Brauner , , , , Date: Fri, 7 Feb 2020 14:28:59 +0800 In-Reply-To: <20200207031759.GA121785@google.com> References: <1580885572-14272-1-git-send-email-Frankie.Chang@mediatek.com> <20200205093612.GA1167956@kroah.com> <20200205154943.GE142103@google.com> <1581045023.22229.46.camel@mtkswgap22> <20200207031759.GA121785@google.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gVGh1LCAyMDIwLTAyLTA2IGF0IDIyOjE3IC0wNTAwLCBKb2VsIEZlcm5hbmRlcyB3cm90ZToN Cj4gT24gRnJpLCBGZWIgMDcsIDIwMjAgYXQgMTE6MTA6MjNBTSArMDgwMCwgRnJhbmtpZSBDaGFu ZyB3cm90ZToNCj4gPiBPbiBXZWQsIDIwMjAtMDItMDUgYXQgMTA6NDkgLTA1MDAsIEpvZWwgRmVy bmFuZGVzIHdyb3RlOg0KPiA+ID4gT24gV2VkLCBGZWIgMDUsIDIwMjAgYXQgMDk6MzY6MTJBTSAr MDAwMCwgR3JlZyBLcm9haC1IYXJ0bWFuIHdyb3RlOg0KPiA+ID4gPiBPbiBXZWQsIEZlYiAwNSwg MjAyMCBhdCAwMjo1Mjo1MlBNICswODAwLCBGcmFua2llIENoYW5nIHdyb3RlOg0KPiA+ID4gPiA+ IFJlY29yZCBzdGFydC9lbmQgdGltZXN0YW1wIHRvIGJpbmRlciB0cmFuc2FjdGlvbi4NCj4gPiA+ ID4gPiBXaGVuIHRyYW5zYWN0aW9uIGlzIGNvbXBsZXRlZCBvciB0cmFuc2FjdGlvbiBpcyBmcmVl LA0KPiA+ID4gPiA+IGl0IHdvdWxkIGJlIGNoZWNrZWQgaWYgdHJhbnNhY3Rpb24gbGF0ZW5jeSBv dmVyIHRocmVzaG9sZCAoMiBzZWMpLA0KPiA+ID4gPiA+IGlmIHllcywgcHJpbnRpbmcgcmVsYXRl ZCBpbmZvcm1hdGlvbiBmb3IgdHJhY2luZy4NCj4gPiA+ID4gPiANCj4gPiA+ID4gPiBTaWduZWQt b2ZmLWJ5OiBGcmFua2llIENoYW5nIDxGcmFua2llLkNoYW5nQG1lZGlhdGVrLmNvbT4NCj4gPiA+ ID4gPiAtLS0NCj4gPiA+ID4gPiAgZHJpdmVycy9hbmRyb2lkL0tjb25maWcgICAgICAgICAgIHwg ICAgOCArKysNCj4gPiA+ID4gPiAgZHJpdmVycy9hbmRyb2lkL2JpbmRlci5jICAgICAgICAgIHwg IDEwNyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrDQo+ID4gPiA+ID4gIGRy aXZlcnMvYW5kcm9pZC9iaW5kZXJfaW50ZXJuYWwuaCB8ICAgIDQgKysNCj4gPiA+ID4gPiAgMyBm aWxlcyBjaGFuZ2VkLCAxMTkgaW5zZXJ0aW9ucygrKQ0KPiA+ID4gPiA+IA0KPiA+ID4gPiA+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2FuZHJvaWQvS2NvbmZpZyBiL2RyaXZlcnMvYW5kcm9pZC9LY29u ZmlnDQo+ID4gPiA+ID4gaW5kZXggNmZkZjJhYi4uN2JhODBlYiAxMDA2NDQNCj4gPiA+ID4gPiAt LS0gYS9kcml2ZXJzL2FuZHJvaWQvS2NvbmZpZw0KPiA+ID4gPiA+ICsrKyBiL2RyaXZlcnMvYW5k cm9pZC9LY29uZmlnDQo+ID4gPiA+ID4gQEAgLTU0LDYgKzU0LDE0IEBAIGNvbmZpZyBBTkRST0lE X0JJTkRFUl9JUENfU0VMRlRFU1QNCj4gPiA+ID4gPiAgCSAgZXhoYXVzdGl2ZWx5IHdpdGggY29t YmluYXRpb25zIG9mIHZhcmlvdXMgYnVmZmVyIHNpemVzIGFuZA0KPiA+ID4gPiA+ICAJICBhbGln bm1lbnRzLg0KPiA+ID4gPiA+ICANCj4gPiA+ID4gPiArY29uZmlnIEJJTkRFUl9VU0VSX1RSQUNL SU5HDQo+ID4gPiA+ID4gKwlib29sICJBbmRyb2lkIEJpbmRlciB0cmFuc2FjdGlvbiB0cmFja2lu ZyINCj4gPiA+ID4gPiArCWhlbHANCj4gPiA+ID4gPiArCSAgVXNlZCBmb3IgdHJhY2sgYWJub3Jt YWwgYmluZGVyIHRyYW5zYWN0aW9uIHdoaWNoIGlzIG92ZXIgMiBzZWNvbmRzLA0KPiA+ID4gPiA+ ICsJICB3aGVuIHRoZSB0cmFuc2FjdGlvbiBpcyBkb25lIG9yIGJlIGZyZWUsIHRoaXMgdHJhbnNh Y3Rpb24gd291bGQgYmUNCj4gPiA+ID4gPiArCSAgY2hlY2tlZCB3aGV0aGVyIGl0IGV4ZWN1dGVk IG92ZXJ0aW1lLg0KPiA+ID4gPiA+ICsJICBJZiB5ZXMsIHByaW50aW5nIG91dCB0aGUgZGV0YWls IGluZm8gYWJvdXQgaXQuDQo+ID4gPiA+ID4gKw0KPiA+ID4gPiA+ICBlbmRpZiAjIGlmIEFORFJP SUQNCj4gPiA+ID4gPiAgDQo+ID4gPiA+ID4gIGVuZG1lbnUNCj4gPiA+ID4gPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9hbmRyb2lkL2JpbmRlci5jIGIvZHJpdmVycy9hbmRyb2lkL2JpbmRlci5jDQo+ ID4gPiA+ID4gaW5kZXggZTliYzlmYy4uNWEzNTJlZSAxMDA2NDQNCj4gPiA+ID4gPiAtLS0gYS9k cml2ZXJzL2FuZHJvaWQvYmluZGVyLmMNCj4gPiA+ID4gPiArKysgYi9kcml2ZXJzL2FuZHJvaWQv YmluZGVyLmMNCj4gPiA+ID4gPiBAQCAtNzYsNiArNzYsMTEgQEANCj4gPiA+ID4gPiAgI2luY2x1 ZGUgImJpbmRlcl9pbnRlcm5hbC5oIg0KPiA+ID4gPiA+ICAjaW5jbHVkZSAiYmluZGVyX3RyYWNl LmgiDQo+ID4gPiA+ID4gIA0KPiA+ID4gPiA+ICsjaWZkZWYgQ09ORklHX0JJTkRFUl9VU0VSX1RS QUNLSU5HDQo+ID4gPiA+ID4gKyNpbmNsdWRlIDxsaW51eC9ydGMuaD4NCj4gPiA+ID4gPiArI2lu Y2x1ZGUgPGxpbnV4L3RpbWUuaD4NCj4gPiA+ID4gPiArI2VuZGlmDQo+ID4gPiA+ID4gKw0KPiA+ ID4gPiA+ICBzdGF0aWMgSExJU1RfSEVBRChiaW5kZXJfZGVmZXJyZWRfbGlzdCk7DQo+ID4gPiA+ ID4gIHN0YXRpYyBERUZJTkVfTVVURVgoYmluZGVyX2RlZmVycmVkX2xvY2spOw0KPiA+ID4gPiA+ ICANCj4gPiA+ID4gPiBAQCAtNTkxLDggKzU5NiwxMDQgQEAgc3RydWN0IGJpbmRlcl90cmFuc2Fj dGlvbiB7DQo+ID4gPiA+ID4gIAkgKiBkdXJpbmcgdGhyZWFkIHRlYXJkb3duDQo+ID4gPiA+ID4g IAkgKi8NCj4gPiA+ID4gPiAgCXNwaW5sb2NrX3QgbG9jazsNCj4gPiA+ID4gPiArI2lmZGVmIENP TkZJR19CSU5ERVJfVVNFUl9UUkFDS0lORw0KPiA+ID4gPiA+ICsJc3RydWN0IHRpbWVzcGVjIHRp bWVzdGFtcDsNCj4gPiA+ID4gPiArCXN0cnVjdCB0aW1ldmFsIHR2Ow0KPiA+ID4gPiA+ICsjZW5k aWYNCj4gPiA+ID4gPiAgfTsNCj4gPiA+ID4gPiAgDQo+ID4gPiA+ID4gKyNpZmRlZiBDT05GSUdf QklOREVSX1VTRVJfVFJBQ0tJTkcNCj4gPiA+ID4gPiArDQo+ID4gPiA+ID4gKy8qDQo+ID4gPiA+ ID4gKyAqIGJpbmRlcl9wcmludF9kZWxheSAtIE91dHB1dCBpbmZvIG9mIGEgZGVsYXkgdHJhbnNh Y3Rpb24NCj4gPiA+ID4gPiArICogQHQ6ICAgICAgICAgIHBvaW50ZXIgdG8gdGhlIG92ZXItdGlt ZSB0cmFuc2FjdGlvbg0KPiA+ID4gPiA+ICsgKi8NCj4gPiA+ID4gPiArc3RhdGljIHZvaWQgYmlu ZGVyX3ByaW50X2RlbGF5KHN0cnVjdCBiaW5kZXJfdHJhbnNhY3Rpb24gKnQpDQo+ID4gPiA+ID4g K3sNCj4gPiA+ID4gPiArCXN0cnVjdCBydGNfdGltZSB0bTsNCj4gPiA+ID4gPiArCXN0cnVjdCB0 aW1lc3BlYyAqc3RhcnRpbWU7DQo+ID4gPiA+ID4gKwlzdHJ1Y3QgdGltZXNwZWMgY3VyLCBzdWJf dDsNCj4gPiA+ID4gPiArDQo+ID4gPiA+ID4gKwlrdGltZV9nZXRfdHMoJmN1cik7DQo+ID4gPiA+ ID4gKwlzdGFydGltZSA9ICZ0LT50aW1lc3RhbXA7DQo+ID4gPiA+ID4gKwlzdWJfdCA9IHRpbWVz cGVjX3N1YihjdXIsICpzdGFydGltZSk7DQo+ID4gPiA+ID4gKw0KPiA+ID4gPiA+ICsJLyogaWYg dHJhbnNhY3Rpb24gdGltZSBpcyBvdmVyIHRoYW4gMiBzZWMsDQo+ID4gPiA+ID4gKwkgKiBzaG93 IHRpbWVvdXQgd2FybmluZyBsb2cuDQo+ID4gPiA+ID4gKwkgKi8NCj4gPiA+ID4gPiArCWlmIChz dWJfdC50dl9zZWMgPCAyKQ0KPiA+ID4gPiA+ICsJCXJldHVybjsNCj4gPiA+ID4gPiArDQo+ID4g PiA+ID4gKwlydGNfdGltZV90b190bSh0LT50di50dl9zZWMsICZ0bSk7DQo+ID4gPiA+ID4gKw0K PiA+ID4gPiA+ICsJc3Bpbl9sb2NrKCZ0LT5sb2NrKTsNCj4gPiA+ID4gPiArCXByX2luZm9fcmF0 ZWxpbWl0ZWQoIiVkOiBmcm9tICVkOiVkIHRvICVkOiVkIiwNCj4gPiA+ID4gPiArCQkJICAgIHQt PmRlYnVnX2lkLA0KPiA+ID4gPiA+ICsJCQkgICAgdC0+ZnJvbSA/IHQtPmZyb20tPnByb2MtPnBp ZCA6IDAsDQo+ID4gPiA+ID4gKwkJCSAgICB0LT5mcm9tID8gdC0+ZnJvbS0+cGlkIDogMCwNCj4g PiA+ID4gPiArCQkJICAgIHQtPnRvX3Byb2MgPyB0LT50b19wcm9jLT5waWQgOiAwLA0KPiA+ID4g PiA+ICsJCQkgICAgdC0+dG9fdGhyZWFkID8gdC0+dG9fdGhyZWFkLT5waWQgOiAwKTsNCj4gPiA+ ID4gPiArCXNwaW5fdW5sb2NrKCZ0LT5sb2NrKTsNCj4gPiA+ID4gPiArDQo+ID4gPiA+ID4gKwlw cl9pbmZvX3JhdGVsaW1pdGVkKCIgdG90YWwgJXUuJTAzbGQgcyBjb2RlICV1IHN0YXJ0ICVsdS4l MDNsZCBhbmRyb2lkICVkLSUwMmQtJTAyZCAlMDJkOiUwMmQ6JTAyZC4lMDNsdVxuIiwNCj4gPiA+ ID4gPiArCQkJICAgICh1bnNpZ25lZCBpbnQpc3ViX3QudHZfc2VjLA0KPiA+ID4gPiA+ICsJCQkg ICAgKHN1Yl90LnR2X25zZWMgLyBOU0VDX1BFUl9NU0VDKSwNCj4gPiA+ID4gPiArCQkJICAgIHQt PmNvZGUsDQo+ID4gPiA+ID4gKwkJCSAgICAodW5zaWduZWQgbG9uZylzdGFydGltZS0+dHZfc2Vj LA0KPiA+ID4gPiA+ICsJCQkgICAgKHN0YXJ0aW1lLT50dl9uc2VjIC8gTlNFQ19QRVJfTVNFQyks DQo+ID4gPiA+ID4gKwkJCSAgICAodG0udG1feWVhciArIDE5MDApLCAodG0udG1fbW9uICsgMSks IHRtLnRtX21kYXksDQo+ID4gPiA+ID4gKwkJCSAgICB0bS50bV9ob3VyLCB0bS50bV9taW4sIHRt LnRtX3NlYywNCj4gPiA+ID4gPiArCQkJICAgICh1bnNpZ25lZCBsb25nKSh0LT50di50dl91c2Vj IC8gVVNFQ19QRVJfTVNFQykpOw0KPiA+ID4gPiA+ICt9DQo+ID4gPiA+IA0KPiA+ID4gPiBJY2ss IHdoeSBub3QgdXNlIGEgdHJhY2Vwb2ludCBmb3IgdGhpcyBpbnN0ZWFkPw0KPiA+ID4gPiANCj4g PiA+ID4gQW5kIHdoYXQgaXMgdXNlcnNwYWNlIHN1cHBvc2VkIHRvIGRvIHdpdGggdGhpcyBpZiB0 aGV5IHNlZSBpdD8NCj4gPiA+IA0KPiA+ID4gT3IgYW5vdGhlciBvcHRpb24gaXMgdG8gaW1wbGVt ZW50IHRoaXMgc2VwYXJhdGVseSBvdXRzaWRlIG9mIGJpbmRlci5jIHVzaW5nDQo+ID4gPiByZWdp c3Rlcl90cmFjZV8qIG9uIHRoZSBleGlzdGluZyBiaW5kZXIgdHJhY2Vwb2ludHMsIHNpbWlsYXIg dG8gd2hhdCBzYXkgdGhlDQo+ID4gPiBibG9jayB0cmFjZXIgb3IgcHJlZW1wdC1vZmYgdHJhY2Vy cyBkby4gQ2FsbCBpdCwgc2F5LCAiYmluZGVyLWxhdGVuY3kgdHJhY2VyIi4NCj4gPiA+IA0KPiA+ ID4gVGhhdCB3YXkgYWxsIG9mIHRoaXMgdHJhY2luZyBjb2RlIGlzIGluLWtlcm5lbCBidXQgb3V0 c2lkZSBvZiBiaW5kZXIuYy4NCj4gPiA+IA0KPiA+ID4gdGhhbmtzLA0KPiA+ID4gDQo+ID4gPiAg LSBKb2VsDQo+ID4gPiANCj4gPiBUaW1lIGxpbWl0YXRpb24gb2YgcmVjb3JkaW5nIGlzIHRoZSBy ZWFzb24gd2h5IHdlIGRvbid0IHVzZSB0cmFjZXBvaW50Lg0KPiA+IEluIHNvbWUgc2l0dWF0aW9u cywgdGhlIGV4Y2VwdGlvbiBpcyBjYXVzZWQgYnkgYSBzZXJpZXMgb2YgdHJhbnNhY3Rpb25zDQo+ ID4gaW50ZXJhY3Rpb24uDQo+ID4gU29tZSBhYm5vcm1hbCB0cmFuc2FjdGlvbnMgbWF5IGJlIHBl bmRpbmcgZm9yIGEgbG9uZyB0aW1lIGFnbywgdGhleQ0KPiA+IGNvdWxkIG5vdCBiZSByZWNvcmRl ZCBkdWUgdG8gYnVmZmVyIGxpbWl0ZWQuDQo+IA0KPiByZWdpc3Rlcl90cmFjZV8qIGRvZXMgbm90 IHVzZSB0aGUgdHJhY2UgYnVmZmVyIHNvIEkgYW0gbm90IHN1cmUgd2hhdCB5b3UNCj4gbWVhbi4g SSBhbSBhc2tpbmcgeW91IHRvIHVzZSB0cmFjZXBvaW50cywgbm90IGZ0cmFjZSBldmVudHMuDQo+ IA0KPiB0aGFua3MsDQo+IA0KPiAgLSBKb2VsDQo+IA0KVGhlIGV4aXN0aW5nIGJpbmRlciB0cmFj ZXBvaW50IG1heSBub3QgYmUgcHJlY2lzZSBlbm91Z2ggYmVjYXVzZSB0aGVyZQ0KaXMgbm8gcHJv cGVyIHRyYWNlcG9pbnQgd2hpY2ggY2FuIHJlcHJlc2VudCB0aGUgcmVhbCBmaW5pc2hlZCB0aW1l IG9mDQp0cmFuc2FjdGlvbi4NCg0KVGhlIHJlYXNvbiB3aHkgd2UgZG9uJ3QgcHV0IHRoZSBjb2Rl IG91dHNpZGUgYmluZGVyLmMgaXMgdGhhdCBzdHJ1Y3R1cmUNCm9mIGJpbmRlcl90cmFuc2FjdGlv biBkaWRuJ3QgcHV0IGluIGhlYWRlciBmaWxlLg0KSWYgaXQgY291bGQgYmUgbW92ZWQgdG8gYmlu ZGVyX2ludGVybmFsLmgsIHRoZW4gd2UgY2FuIGFkZA0KImJpbmRlci1sYXRlbmN5IHRyYWNlciIg YXMgeW91IG1lbnRpb25lZCBlYXJsaWVyLg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3A5BC2D0B1 for ; Fri, 7 Feb 2020 06:39:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8CB012082E for ; Fri, 7 Feb 2020 06:39:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OugaPyi9"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="PjOlN03d" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8CB012082E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VDzcQGENtuNwZb/wc4ROrv0XH6BPOItIUOfhT7YDFAQ=; b=OugaPyi9x5N3/t enC8ugbIh6jFcOmZObAoPJqQXcAzk5W4QD/u/Rii7m2YUrexvaiuruoVQ/xtcu62/EeOQM56pZ1dT HMaciAhLwN0vN6WA+9P3k9S9zYgs2qKivrA/gJxg5fIALmO4f+9GnaSefca4viTjzx6tCorJmLeEC cifcSjltOv2qUW5gaJ3cjFa375YZnMwArLG0fFPLlxQAcU9kNxUyoQWgW4169ufWhLhuaZDjqxznv GfpdyvPyKPMS5fTIcrVbhokORfHKZuwt7e8K2hwvFD0YFKaBwz5anj14XiloHIu4+WyxzsyZ5K52X akj8VH4ntNH8y34ChODw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1izxIJ-0006LM-A0; Fri, 07 Feb 2020 06:39:15 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1izxIG-0006Ks-T1 for linux-mediatek@lists.infradead.org; Fri, 07 Feb 2020 06:39:14 +0000 X-UUID: d26faf6d420849ecb5a4c7c9f18a5c36-20200206 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=R/+a0fdrCDE55+6NHJbY91tgYCmhdw3+sIz81IyvB4g=; b=PjOlN03d0bw3D4X0MX6BBqa30I19p0SQe+jz4E9zwctWkk1CG4I3Vx18Px53VJ+ygcLOjFHlAK5Mf7iefLvzzBPjCNhxTTfE/GT4sD9Ha3DpW0dRn5D272kjIXNox6ZfgUwXGWyEjeWjSEMcXLPdZTu8pMepJTM7K0nQ065Pd5Q=; X-UUID: d26faf6d420849ecb5a4c7c9f18a5c36-20200206 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 557963574; Thu, 06 Feb 2020 22:39:03 -0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 6 Feb 2020 22:29:43 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 7 Feb 2020 14:28:19 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 7 Feb 2020 14:28:24 +0800 Message-ID: <1581056939.22229.55.camel@mtkswgap22> Subject: Re: [PATCH v1 1/1] binder: transaction latency tracking for user build From: Frankie Chang To: Joel Fernandes Date: Fri, 7 Feb 2020 14:28:59 +0800 In-Reply-To: <20200207031759.GA121785@google.com> References: <1580885572-14272-1-git-send-email-Frankie.Chang@mediatek.com> <20200205093612.GA1167956@kroah.com> <20200205154943.GE142103@google.com> <1581045023.22229.46.camel@mtkswgap22> <20200207031759.GA121785@google.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200206_223912_949428_C694C181 X-CRM114-Status: GOOD ( 27.65 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Todd Kjos , wsd_upstream@mediatek.com, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= , Jian-Min.Liu@mediatek.com, linux-mediatek@lists.infradead.org, Martijn Coenen , Christian Brauner Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, 2020-02-06 at 22:17 -0500, Joel Fernandes wrote: > On Fri, Feb 07, 2020 at 11:10:23AM +0800, Frankie Chang wrote: > > On Wed, 2020-02-05 at 10:49 -0500, Joel Fernandes wrote: > > > On Wed, Feb 05, 2020 at 09:36:12AM +0000, Greg Kroah-Hartman wrote: > > > > On Wed, Feb 05, 2020 at 02:52:52PM +0800, Frankie Chang wrote: > > > > > Record start/end timestamp to binder transaction. > > > > > When transaction is completed or transaction is free, > > > > > it would be checked if transaction latency over threshold (2 sec), > > > > > if yes, printing related information for tracing. > > > > > > > > > > Signed-off-by: Frankie Chang > > > > > --- > > > > > drivers/android/Kconfig | 8 +++ > > > > > drivers/android/binder.c | 107 +++++++++++++++++++++++++++++++++++++ > > > > > drivers/android/binder_internal.h | 4 ++ > > > > > 3 files changed, 119 insertions(+) > > > > > > > > > > diff --git a/drivers/android/Kconfig b/drivers/android/Kconfig > > > > > index 6fdf2ab..7ba80eb 100644 > > > > > --- a/drivers/android/Kconfig > > > > > +++ b/drivers/android/Kconfig > > > > > @@ -54,6 +54,14 @@ config ANDROID_BINDER_IPC_SELFTEST > > > > > exhaustively with combinations of various buffer sizes and > > > > > alignments. > > > > > > > > > > +config BINDER_USER_TRACKING > > > > > + bool "Android Binder transaction tracking" > > > > > + help > > > > > + Used for track abnormal binder transaction which is over 2 seconds, > > > > > + when the transaction is done or be free, this transaction would be > > > > > + checked whether it executed overtime. > > > > > + If yes, printing out the detail info about it. > > > > > + > > > > > endif # if ANDROID > > > > > > > > > > endmenu > > > > > diff --git a/drivers/android/binder.c b/drivers/android/binder.c > > > > > index e9bc9fc..5a352ee 100644 > > > > > --- a/drivers/android/binder.c > > > > > +++ b/drivers/android/binder.c > > > > > @@ -76,6 +76,11 @@ > > > > > #include "binder_internal.h" > > > > > #include "binder_trace.h" > > > > > > > > > > +#ifdef CONFIG_BINDER_USER_TRACKING > > > > > +#include > > > > > +#include > > > > > +#endif > > > > > + > > > > > static HLIST_HEAD(binder_deferred_list); > > > > > static DEFINE_MUTEX(binder_deferred_lock); > > > > > > > > > > @@ -591,8 +596,104 @@ struct binder_transaction { > > > > > * during thread teardown > > > > > */ > > > > > spinlock_t lock; > > > > > +#ifdef CONFIG_BINDER_USER_TRACKING > > > > > + struct timespec timestamp; > > > > > + struct timeval tv; > > > > > +#endif > > > > > }; > > > > > > > > > > +#ifdef CONFIG_BINDER_USER_TRACKING > > > > > + > > > > > +/* > > > > > + * binder_print_delay - Output info of a delay transaction > > > > > + * @t: pointer to the over-time transaction > > > > > + */ > > > > > +static void binder_print_delay(struct binder_transaction *t) > > > > > +{ > > > > > + struct rtc_time tm; > > > > > + struct timespec *startime; > > > > > + struct timespec cur, sub_t; > > > > > + > > > > > + ktime_get_ts(&cur); > > > > > + startime = &t->timestamp; > > > > > + sub_t = timespec_sub(cur, *startime); > > > > > + > > > > > + /* if transaction time is over than 2 sec, > > > > > + * show timeout warning log. > > > > > + */ > > > > > + if (sub_t.tv_sec < 2) > > > > > + return; > > > > > + > > > > > + rtc_time_to_tm(t->tv.tv_sec, &tm); > > > > > + > > > > > + spin_lock(&t->lock); > > > > > + pr_info_ratelimited("%d: from %d:%d to %d:%d", > > > > > + t->debug_id, > > > > > + t->from ? t->from->proc->pid : 0, > > > > > + t->from ? t->from->pid : 0, > > > > > + t->to_proc ? t->to_proc->pid : 0, > > > > > + t->to_thread ? t->to_thread->pid : 0); > > > > > + spin_unlock(&t->lock); > > > > > + > > > > > + pr_info_ratelimited(" total %u.%03ld s code %u start %lu.%03ld android %d-%02d-%02d %02d:%02d:%02d.%03lu\n", > > > > > + (unsigned int)sub_t.tv_sec, > > > > > + (sub_t.tv_nsec / NSEC_PER_MSEC), > > > > > + t->code, > > > > > + (unsigned long)startime->tv_sec, > > > > > + (startime->tv_nsec / NSEC_PER_MSEC), > > > > > + (tm.tm_year + 1900), (tm.tm_mon + 1), tm.tm_mday, > > > > > + tm.tm_hour, tm.tm_min, tm.tm_sec, > > > > > + (unsigned long)(t->tv.tv_usec / USEC_PER_MSEC)); > > > > > +} > > > > > > > > Ick, why not use a tracepoint for this instead? > > > > > > > > And what is userspace supposed to do with this if they see it? > > > > > > Or another option is to implement this separately outside of binder.c using > > > register_trace_* on the existing binder tracepoints, similar to what say the > > > block tracer or preempt-off tracers do. Call it, say, "binder-latency tracer". > > > > > > That way all of this tracing code is in-kernel but outside of binder.c. > > > > > > thanks, > > > > > > - Joel > > > > > Time limitation of recording is the reason why we don't use tracepoint. > > In some situations, the exception is caused by a series of transactions > > interaction. > > Some abnormal transactions may be pending for a long time ago, they > > could not be recorded due to buffer limited. > > register_trace_* does not use the trace buffer so I am not sure what you > mean. I am asking you to use tracepoints, not ftrace events. > > thanks, > > - Joel > The existing binder tracepoint may not be precise enough because there is no proper tracepoint which can represent the real finished time of transaction. The reason why we don't put the code outside binder.c is that structure of binder_transaction didn't put in header file. If it could be moved to binder_internal.h, then we can add "binder-latency tracer" as you mentioned earlier. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek