From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48C71C2BA83 for ; Fri, 7 Feb 2020 16:33:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 267AF22314 for ; Fri, 7 Feb 2020 16:33:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 267AF22314 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C2FC56EB02; Fri, 7 Feb 2020 16:33:55 +0000 (UTC) Received: from fireflyinternet.com (unknown [77.68.26.236]) by gabe.freedesktop.org (Postfix) with ESMTPS id 96A026EB02 for ; Fri, 7 Feb 2020 16:33:54 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 20151048-1500050 for multiple; Fri, 07 Feb 2020 16:33:36 +0000 MIME-Version: 1.0 From: Chris Wilson User-Agent: alot/0.6 To: Intel-gfx@lists.freedesktop.org, Tvrtko Ursulin References: <20200207161331.23447-1-tvrtko.ursulin@linux.intel.com> <20200207161331.23447-6-tvrtko.ursulin@linux.intel.com> In-Reply-To: <20200207161331.23447-6-tvrtko.ursulin@linux.intel.com> Message-ID: <158109321467.16098.12817907526709789256@skylake-alporthouse-com> Date: Fri, 07 Feb 2020 16:33:34 +0000 Subject: Re: [Intel-gfx] [PATCH 5/6] drm/i915: Track per drm client engine class busyness X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Tvrtko Ursulin (2020-02-07 16:13:30) > static inline void > -__intel_context_stats_start(struct intel_context *ce, ktime_t now) > +__intel_context_stats_start(struct intel_context *ce, > + struct intel_engine_cs *engine, > + ktime_t now) > { > struct intel_context_stats *stats = &ce->stats; > - > - if (!stats->active) { > - stats->start = now; > - stats->active = true; > + struct i915_gem_context *ctx; > + > + if (stats->active) > + return; > + > + stats->start = now; > + stats->active = true; > + > + rcu_read_lock(); > + ctx = rcu_dereference(ce->gem_context); > + if (ctx && ctx->client) { I'd rather avoid having to dig into the GEM context down here next to the HW. First thought would be to keep the stats local on the intel_context and for the client to chase collate them when the user reads the fd. Hmm, didn't you structure it like so earlier? What made you change your mind? -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx